{"id":11927,"url":"https://patchwork.libcamera.org/api/patches/11927/?format=json","web_url":"https://patchwork.libcamera.org/patch/11927/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210414102955.9503-2-david.plowman@raspberrypi.com>","date":"2021-04-14T10:29:53","name":"[libcamera-devel,v3,1/3] ipa: raspberrypi: Make CamHelper exposure methods virtual","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7fa0a8cb40fac1ec7942491ae2dbd76623b110c3","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11927/mbox/","series":[{"id":1927,"url":"https://patchwork.libcamera.org/api/series/1927/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1927","date":"2021-04-14T10:29:52","name":"Raspberry Pi: handle sensors more flexibly","version":3,"mbox":"https://patchwork.libcamera.org/series/1927/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11927/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11927/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E5D8DBD22F\n\tfor ;\n\tWed, 14 Apr 2021 10:30:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9AB3668818;\n\tWed, 14 Apr 2021 12:30:02 +0200 (CEST)","from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com\n\t[IPv6:2a00:1450:4864:20::62d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C2EF468803\n\tfor ;\n\tWed, 14 Apr 2021 12:30:00 +0200 (CEST)","by mail-ej1-x62d.google.com with SMTP id w3so30658162ejc.4\n\tfor ;\n\tWed, 14 Apr 2021 03:30:00 -0700 (PDT)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\th8sm11369137ede.25.2021.04.14.03.29.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 14 Apr 2021 03:29:59 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Eh3Obv55\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Y7RBLkfsx9Q0XA5VMAG5UTmLaj1/rjfPHufTqSsjJXs=;\n\tb=Eh3Obv5549rmgXEGVthxv9ucPUsCnA4R+elqq8ohkvIH1IklA0A71QZUkgUy+rFQDZ\n\tpW9eiMnSzsV/JjR89dLfNpjiFxM8dTTg74yeb6cfqQicuzOjbMmP9H7TXTIt3P+MGe7z\n\tUOzK0zoHzxl+DjR5uuP4FxEkl+MibAMMjYjuyvSRIN7W0j0Nw8I+n1E42boN70rrRlG+\n\t0DfMt7/fk6QO3fkKPjZocs/HnUnSU/0TSkMWOkDtI1AtK4bu+sh3R6nLFikMRREMkhR3\n\tZTcyRBnm0h8NCtiJT98sqaaN/otY7oB2Pphyj5M28ZTDh8DEP9l00SsCihJ/24vxED8Y\n\tei2Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Y7RBLkfsx9Q0XA5VMAG5UTmLaj1/rjfPHufTqSsjJXs=;\n\tb=a1KN8v3k6cE7QE9q2VPCaijbPWVDKhX6K5Kbw2BXkSPm0RKOMsJ66owYxORB5mMVN1\n\t0TWcfflxe22nWh5uM1+RlZPWV4gek6uDs+QWTp/40jez0DjjRM3WiXhSGHmkko7MK+rp\n\t+rx496x4NfAl2WYT2wbQghX6G55tiLlyEDeTRVxsvTa4369Qv3PPsJt3ROP/suBPDPcx\n\tFtYmH9kwN/dQnKQsuAgv393+B6Rsc48NMbkeDCoG4tyfHsCGbcNzN4zQ1BNL2U+WfY/m\n\t3DpuyptVGK8b9nA4udGpCfu0/9GaBmwl4vsQIB3Czku5duEr8tAgDfo0KQz5SRehWMRH\n\t3/Ow==","X-Gm-Message-State":"AOAM530B3oBOiApK6x2WC6PQEFQoWyvUsYIWEQ6NBaRPrzhqeVHsXv2S\n\tmqtIPN+AzJ8dyZ/kKndUpGf0lCLFSt6Z8w==","X-Google-Smtp-Source":"ABdhPJyhta5LVEj6ZJk8ENLF3cfRberSlIERniNrg0KnP22vqyyUEAnurUjVJzX7lLWQn8n3a7trMA==","X-Received":"by 2002:a17:907:2bcb:: with SMTP id\n\tgv11mr2863941ejc.353.1618396200300; \n\tWed, 14 Apr 2021 03:30:00 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 14 Apr 2021 11:29:53 +0100","Message-Id":"<20210414102955.9503-2-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20210414102955.9503-1-david.plowman@raspberrypi.com>","References":"<20210414102955.9503-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 1/3] ipa: raspberrypi: Make CamHelper\n\texposure methods virtual","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This allows derived classes to override them if they have any special\nbehaviours to implement. For instance if a particular camera mode\nproduces a different signal level to other modes, you might choose to\naddress that in the gain or exposure methods.\n\nSigned-off-by: David Plowman \nReviewed-by: Naushir Patuck \n---\n src/ipa/raspberrypi/cam_helper.hpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp\nindex 1b2d6eec..4053a870 100644\n--- a/src/ipa/raspberrypi/cam_helper.hpp\n+++ b/src/ipa/raspberrypi/cam_helper.hpp\n@@ -66,8 +66,8 @@ public:\n \tvirtual ~CamHelper();\n \tvoid SetCameraMode(const CameraMode &mode);\n \tMdParser &Parser() const { return *parser_; }\n-\tuint32_t ExposureLines(double exposure_us) const;\n-\tdouble Exposure(uint32_t exposure_lines) const; // in us\n+\tvirtual uint32_t ExposureLines(double exposure_us) const;\n+\tvirtual double Exposure(uint32_t exposure_lines) const; // in us\n \tvirtual uint32_t GetVBlanking(double &exposure_us, double minFrameDuration,\n \t\t\t\t double maxFrameDuration) const;\n \tvirtual uint32_t GainCode(double gain) const = 0;\n","prefixes":["libcamera-devel","v3","1/3"]}