[{"id":16251,"web_url":"https://patchwork.libcamera.org/comment/16251/","msgid":"","date":"2021-04-13T21:55:16","subject":"Re: [libcamera-devel] [PATCH] lc-compliance: Initialize the event\n\tloop pointer","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Apr 13, 2021 at 11:52:56PM +0200, Niklas Söderlund wrote:\n> The event loop pointer loop_ was not initialized. This have no effect on\n\ns/have/has/\n\n> the current code flow but could in the future lead to hard debug\n> problems.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/lc-compliance/simple_capture.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/lc-compliance/simple_capture.cpp b/src/lc-compliance/simple_capture.cpp\n> index 0ff720bfd0052e45..8f714d3b5e73e28e 100644\n> --- a/src/lc-compliance/simple_capture.cpp\n> +++ b/src/lc-compliance/simple_capture.cpp\n> @@ -10,7 +10,8 @@\n> using namespace libcamera;\n> \n> SimpleCapture::SimpleCapture(std::shared_ptr camera)\n> -\t: camera_(camera), allocator_(std::make_unique(camera))\n> +\t: loop_(nullptr), camera_(camera),\n> +\t allocator_(std::make_unique(camera))\n> {\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9AA71BD1F6\n\tfor ;\n\tTue, 13 Apr 2021 21:56:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B12B602D1;\n\tTue, 13 Apr 2021 23:56:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED924602D1\n\tfor ;\n\tTue, 13 Apr 2021 23:56:07 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 773B39F0;\n\tTue, 13 Apr 2021 23:56:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KtZCRHhl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618350967;\n\tbh=c18MkDkn3DjE70wLqyzQgPMNJ4rVsaLPrKvYO/yL/Ks=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KtZCRHhlll8JZuKtgB/5Z98bqBbRCC4U2FET43zyzjmNiDF3PjF3kDzUwN6DGbeYC\n\tmxCkF9Sho0FzzbfPTTyBWDqWNYerRhN5Jd3x8gJxUfNFXwXUbQtzTqYb1s06/2NboY\n\t/JbE3W1ppqSxBtaRgYw3qlHevmMSC5j2voageOSw=","Date":"Wed, 14 Apr 2021 00:55:16 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"","References":"<20210413215256.2734772-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210413215256.2734772-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH] lc-compliance: Initialize the event\n\tloop pointer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]