[{"id":16261,"web_url":"https://patchwork.libcamera.org/comment/16261/","msgid":"<20210414035119.qqm34peyg7uunvi3@basti-TUXEDO-Book-XA1510>","date":"2021-04-14T03:51:19","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: log: Use compiler\n\tbuiltins to retrieve file and line number","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"Hey Laurent,\n\nThank you for the patch.\n\nOn 14.04.2021 00:51, Laurent Pinchart wrote:\n>Replace the __FILE__ and __LINE__ values passed to the _log() function\n>with default parameters, taking their values from the __builtin_FILE()\n>and __builtin_LINE() functions. This moves handling of the file and line\n>from the preprocessor to the compiler, which is generally preferred as\n>it increases type safety.\n\nSounds good, I have tested the patch on my machine and I can confirm\nthat there is no visible change.\n\n>\n>Signed-off-by: Laurent Pinchart \nTested-by: Sebastian Fricke \n\n>---\n> include/libcamera/internal/log.h | 15 ++++++++-------\n> src/libcamera/log.cpp | 17 ++++++++---------\n> 2 files changed, 16 insertions(+), 16 deletions(-)\n>\n>diff --git a/include/libcamera/internal/log.h b/include/libcamera/internal/log.h\n>index 0fdacc4733fe..be0bab3c1272 100644\n>--- a/include/libcamera/internal/log.h\n>+++ b/include/libcamera/internal/log.h\n>@@ -89,21 +89,22 @@ public:\n> protected:\n> \tvirtual std::string logPrefix() const = 0;\n>\n>-\tLogMessage _log(const char *file, unsigned int line,\n>-\t\t\tconst LogCategory *category,\n>-\t\t\tLogSeverity severity) const;\n>+\tLogMessage _log(const LogCategory *category, LogSeverity severity,\n>+\t\t\tconst char *fileName = __builtin_FILE(),\n>+\t\t\tunsigned int line = __builtin_LINE()) const;\n> };\n>\n>-LogMessage _log(const char *file, unsigned int line,\n>-\t\tconst LogCategory *category, LogSeverity severity);\n>+LogMessage _log(const LogCategory *category, LogSeverity severity,\n>+\t\tconst char *fileName = __builtin_FILE(),\n>+\t\tunsigned int line = __builtin_LINE());\n>\n> #ifndef __DOXYGEN__\n> #define _LOG_CATEGORY(name) logCategory##name\n>\n> #define _LOG1(severity) \\\n>-\t_log(__FILE__, __LINE__, nullptr, Log##severity).stream()\n>+\t_log(nullptr, Log##severity).stream()\n> #define _LOG2(category, severity) \\\n>-\t_log(__FILE__, __LINE__, &_LOG_CATEGORY(category)(), Log##severity).stream()\n>+\t_log(&_LOG_CATEGORY(category)(), Log##severity).stream()\n>\n> /*\n> * Expand the LOG() macro to _LOG1() or _LOG2() based on the number of\n>diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n>index 9f86e645ac58..94175ab34535 100644\n>--- a/src/libcamera/log.cpp\n>+++ b/src/libcamera/log.cpp\n>@@ -897,19 +897,18 @@ Loggable::~Loggable()\n>\n> /**\n> * \\brief Create a temporary LogMessage object to log a message\n>- * \\param[in] fileName The file name where the message is logged from\n>- * \\param[in] line The line number where the message is logged from\n> * \\param[in] category The log message category\n> * \\param[in] severity The log message severity\n>+ * \\param[in] fileName The file name where the message is logged from\n>+ * \\param[in] line The line number where the message is logged from\n> *\n> * This method is used as a backeng by the LOG() macro to create a log message\n> * for locations inheriting from the Loggable class.\n> *\n> * \\return A log message\n> */\n>-LogMessage Loggable::_log(const char *fileName, unsigned int line,\n>-\t\t\t const LogCategory *category,\n>-\t\t\t LogSeverity severity) const\n>+LogMessage Loggable::_log(const LogCategory *category, LogSeverity severity,\n>+\t\t\t const char *fileName, unsigned int line) const\n> {\n> \tLogMessage msg(fileName, line,\n> \t\t category ? *category : LogCategory::defaultCategory(),\n>@@ -921,18 +920,18 @@ LogMessage Loggable::_log(const char *fileName, unsigned int line,\n>\n> /**\n> * \\brief Create a temporary LogMessage object to log a message\n>- * \\param[in] fileName The file name where the message is logged from\n>- * \\param[in] line The line number where the message is logged from\n> * \\param[in] category The log message category\n> * \\param[in] severity The log message severity\n>+ * \\param[in] fileName The file name where the message is logged from\n>+ * \\param[in] line The line number where the message is logged from\n> *\n> * This function is used as a backeng by the LOG() macro to create a log\n> * message for locations not inheriting from the Loggable class.\n> *\n> * \\return A log message\n> */\n>-LogMessage _log(const char *fileName, unsigned int line,\n>-\t\tconst LogCategory *category, LogSeverity severity)\n>+LogMessage _log(const LogCategory *category, LogSeverity severity,\n>+\t\tconst char *fileName, unsigned int line)\n> {\n> \treturn LogMessage(fileName, line,\n> \t\t\t category ? *category : LogCategory::defaultCategory(),\n>-- \n>Regards,\n>\n>Laurent Pinchart\n>\n>_______________________________________________\n>libcamera-devel mailing list\n>libcamera-devel@lists.libcamera.org\n>https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8015ABD1F6\n\tfor ;\n\tWed, 14 Apr 2021 03:51:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EFD13602D1;\n\tWed, 14 Apr 2021 05:51:21 +0200 (CEST)","from mout01.posteo.de (mout01.posteo.de [185.67.36.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1D92602CD\n\tfor ;\n\tWed, 14 Apr 2021 05:51:20 +0200 (CEST)","from submission (posteo.de [89.146.220.130]) \n\tby mout01.posteo.de (Postfix) with ESMTPS id 6C5EF1A022B\n\tfor ;\n\tWed, 14 Apr 2021 05:51:20 +0200 (CEST)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4FKpRq5KvWz6tmG;\n\tWed, 14 Apr 2021 05:51:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"g8PUtPRd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1618372280; bh=RkB2kC04s59kh5zaqXU4Pl+MDaHt0Es6esKydP61C2c=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=g8PUtPRdqnw+b8J/SdOSsDsuM5S04C/UKxaFmfrLnahPiHqAcTmG72/WYvE8XKuCd\n\tkvouOls1zphmmRGNP/q8zJ26BhdRX1Yvbm122Dy8JxXUw3hhdfdfB6OXb8nHhewp2v\n\ttQAQb5ZG2KF716zJBuoRh3mO5lT5vCfJwVdOLD05c9lRljUIZURyJ+pPPtJ09rUlzP\n\tUQitFJiXmoDGSFDOGfCIyr56tlcP5IcIEsn8bJ563bXbjrZ+4Uztd05gnnUDsD3Rfv\n\tVYvr4Q5l4TLY1tNFJwpZg+xsM4yGUzJLlRVy3lgGl89BbJmdVDSg/95J6c2mQqIrdN\n\tybjmwtbrkKAPA==","Date":"Wed, 14 Apr 2021 05:51:19 +0200","From":"Sebastian Fricke ","To":"Laurent Pinchart ","Message-ID":"<20210414035119.qqm34peyg7uunvi3@basti-TUXEDO-Book-XA1510>","References":"<20210413215121.15538-1-laurent.pinchart@ideasonboard.com>\n\t<20210413215121.15538-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210413215121.15538-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: log: Use compiler\n\tbuiltins to retrieve file and line number","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16269,"web_url":"https://patchwork.libcamera.org/comment/16269/","msgid":"<5bb0b6a1-9472-31d9-ba5d-dc470c9007bd@ideasonboard.com>","date":"2021-04-14T08:49:09","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: log: Use compiler\n\tbuiltins to retrieve file and line number","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 13/04/2021 22:51, Laurent Pinchart wrote:\n> Replace the __FILE__ and __LINE__ values passed to the _log() function\n> with default parameters, taking their values from the __builtin_FILE()\n> and __builtin_LINE() functions. This moves handling of the file and line\n> from the preprocessor to the compiler, which is generally preferred as\n> it increases type safety.\n> \n\nSounds good to me.\n\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/internal/log.h | 15 ++++++++-------\n> src/libcamera/log.cpp | 17 ++++++++---------\n> 2 files changed, 16 insertions(+), 16 deletions(-)\n> \n> diff --git a/include/libcamera/internal/log.h b/include/libcamera/internal/log.h\n> index 0fdacc4733fe..be0bab3c1272 100644\n> --- a/include/libcamera/internal/log.h\n> +++ b/include/libcamera/internal/log.h\n> @@ -89,21 +89,22 @@ public:\n> protected:\n> \tvirtual std::string logPrefix() const = 0;\n> \n> -\tLogMessage _log(const char *file, unsigned int line,\n> -\t\t\tconst LogCategory *category,\n> -\t\t\tLogSeverity severity) const;\n> +\tLogMessage _log(const LogCategory *category, LogSeverity severity,\n> +\t\t\tconst char *fileName = __builtin_FILE(),\n> +\t\t\tunsigned int line = __builtin_LINE()) const;\n> };\n> \n> -LogMessage _log(const char *file, unsigned int line,\n> -\t\tconst LogCategory *category, LogSeverity severity);\n> +LogMessage _log(const LogCategory *category, LogSeverity severity,\n> +\t\tconst char *fileName = __builtin_FILE(),\n> +\t\tunsigned int line = __builtin_LINE());\n> \n> #ifndef __DOXYGEN__\n> #define _LOG_CATEGORY(name) logCategory##name\n> \n> #define _LOG1(severity) \\\n> -\t_log(__FILE__, __LINE__, nullptr, Log##severity).stream()\n> +\t_log(nullptr, Log##severity).stream()\n> #define _LOG2(category, severity) \\\n> -\t_log(__FILE__, __LINE__, &_LOG_CATEGORY(category)(), Log##severity).stream()\n> +\t_log(&_LOG_CATEGORY(category)(), Log##severity).stream()\n\nDo we actually need these macros any more at all?\n\nFrom what I can see they serve the following now:\n\n - Make LOG all caps in the code\n I think this is actually helpful to make log lines clear\n\n - Adds the .stream() call after the construction\n Maybe this is helpful. Can it be done with a direct call by\n overriding the << operator or something directly though to make the\n object itself look like a stream?\n\n\nOtherwise,\n\nReviewed-by: Kieran Bingham \n\n\n> \n> /*\n> * Expand the LOG() macro to _LOG1() or _LOG2() based on the number of\n> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n> index 9f86e645ac58..94175ab34535 100644\n> --- a/src/libcamera/log.cpp\n> +++ b/src/libcamera/log.cpp\n> @@ -897,19 +897,18 @@ Loggable::~Loggable()\n> \n> /**\n> * \\brief Create a temporary LogMessage object to log a message\n> - * \\param[in] fileName The file name where the message is logged from\n> - * \\param[in] line The line number where the message is logged from\n> * \\param[in] category The log message category\n> * \\param[in] severity The log message severity\n> + * \\param[in] fileName The file name where the message is logged from\n> + * \\param[in] line The line number where the message is logged from\n> *\n> * This method is used as a backeng by the LOG() macro to create a log message\n> * for locations inheriting from the Loggable class.\n> *\n> * \\return A log message\n> */\n> -LogMessage Loggable::_log(const char *fileName, unsigned int line,\n> -\t\t\t const LogCategory *category,\n> -\t\t\t LogSeverity severity) const\n> +LogMessage Loggable::_log(const LogCategory *category, LogSeverity severity,\n> +\t\t\t const char *fileName, unsigned int line) const\n> {\n> \tLogMessage msg(fileName, line,\n> \t\t category ? *category : LogCategory::defaultCategory(),\n> @@ -921,18 +920,18 @@ LogMessage Loggable::_log(const char *fileName, unsigned int line,\n> \n> /**\n> * \\brief Create a temporary LogMessage object to log a message\n> - * \\param[in] fileName The file name where the message is logged from\n> - * \\param[in] line The line number where the message is logged from\n> * \\param[in] category The log message category\n> * \\param[in] severity The log message severity\n> + * \\param[in] fileName The file name where the message is logged from\n> + * \\param[in] line The line number where the message is logged from\n> *\n> * This function is used as a backeng by the LOG() macro to create a log\n> * message for locations not inheriting from the Loggable class.\n> *\n> * \\return A log message\n> */\n> -LogMessage _log(const char *fileName, unsigned int line,\n> -\t\tconst LogCategory *category, LogSeverity severity)\n> +LogMessage _log(const LogCategory *category, LogSeverity severity,\n> +\t\tconst char *fileName, unsigned int line)\n> {\n> \treturn LogMessage(fileName, line,\n> \t\t\t category ? *category : LogCategory::defaultCategory(),\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01377BD224\n\tfor ;\n\tWed, 14 Apr 2021 08:49:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 41CD76880B;\n\tWed, 14 Apr 2021 10:49:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 28F4C687EF\n\tfor ;\n\tWed, 14 Apr 2021 10:49:13 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 370DC6F2;\n\tWed, 14 Apr 2021 10:49:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Webl8C7W\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618390152;\n\tbh=NNw+f6hvLQ91drabNcwwOX0WcTft6OdZikuU4jI9YeI=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Webl8C7WiGxJXRqWORur0mClpEVp7eis5E8OLdsUt7q8o7HWzOW/tRbulePOL8+KN\n\tIbYYROgQFVSsY7YTWzlt9mncWDcXg642UIze+0CWpi+y2pbaKkHpmWYHzka4i4dhaU\n\t/M/HMnXYewhxFXvOT23lmWyy456EFNNFsdte/TD8=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210413215121.15538-1-laurent.pinchart@ideasonboard.com>\n\t<20210413215121.15538-3-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<5bb0b6a1-9472-31d9-ba5d-dc470c9007bd@ideasonboard.com>","Date":"Wed, 14 Apr 2021 09:49:09 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210413215121.15538-3-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: log: Use compiler\n\tbuiltins to retrieve file and line number","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16271,"web_url":"https://patchwork.libcamera.org/comment/16271/","msgid":"","date":"2021-04-14T09:40:08","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: log: Use compiler\n\tbuiltins to retrieve file and line number","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Wed, Apr 14, 2021 at 09:49:09AM +0100, Kieran Bingham wrote:\n> On 13/04/2021 22:51, Laurent Pinchart wrote:\n> > Replace the __FILE__ and __LINE__ values passed to the _log() function\n> > with default parameters, taking their values from the __builtin_FILE()\n> > and __builtin_LINE() functions. This moves handling of the file and line\n> > from the preprocessor to the compiler, which is generally preferred as\n> > it increases type safety.\n> \n> Sounds good to me.\n> \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > include/libcamera/internal/log.h | 15 ++++++++-------\n> > src/libcamera/log.cpp | 17 ++++++++---------\n> > 2 files changed, 16 insertions(+), 16 deletions(-)\n> > \n> > diff --git a/include/libcamera/internal/log.h b/include/libcamera/internal/log.h\n> > index 0fdacc4733fe..be0bab3c1272 100644\n> > --- a/include/libcamera/internal/log.h\n> > +++ b/include/libcamera/internal/log.h\n> > @@ -89,21 +89,22 @@ public:\n> > protected:\n> > \tvirtual std::string logPrefix() const = 0;\n> > \n> > -\tLogMessage _log(const char *file, unsigned int line,\n> > -\t\t\tconst LogCategory *category,\n> > -\t\t\tLogSeverity severity) const;\n> > +\tLogMessage _log(const LogCategory *category, LogSeverity severity,\n> > +\t\t\tconst char *fileName = __builtin_FILE(),\n> > +\t\t\tunsigned int line = __builtin_LINE()) const;\n> > };\n> > \n> > -LogMessage _log(const char *file, unsigned int line,\n> > -\t\tconst LogCategory *category, LogSeverity severity);\n> > +LogMessage _log(const LogCategory *category, LogSeverity severity,\n> > +\t\tconst char *fileName = __builtin_FILE(),\n> > +\t\tunsigned int line = __builtin_LINE());\n> > \n> > #ifndef __DOXYGEN__\n> > #define _LOG_CATEGORY(name) logCategory##name\n> > \n> > #define _LOG1(severity) \\\n> > -\t_log(__FILE__, __LINE__, nullptr, Log##severity).stream()\n> > +\t_log(nullptr, Log##severity).stream()\n> > #define _LOG2(category, severity) \\\n> > -\t_log(__FILE__, __LINE__, &_LOG_CATEGORY(category)(), Log##severity).stream()\n> > +\t_log(&_LOG_CATEGORY(category)(), Log##severity).stream()\n> \n> Do we actually need these macros any more at all?\n> \n> From what I can see they serve the following now:\n> \n> - Make LOG all caps in the code\n> I think this is actually helpful to make log lines clear\n> \n> - Adds the .stream() call after the construction\n> Maybe this is helpful. Can it be done with a direct call by\n> overriding the << operator or something directly though to make the\n> object itself look like a stream?\n\nThey're also used to construct the category, and the severity. Otherwise\nwe'd have to write LogInfo instead of Info, but also\nlogCategoryV4L2Device() instead of V4L2Device.\n\nIf we wanted to simplify this, we could drop _LOG1 and _LOG2, and keep\nLOG. That would make the category mandatory, we wouldn't be able to\nwrite LOG(Info) << ... for quick debugging.\n\n> Otherwise,\n> \n> Reviewed-by: Kieran Bingham \n> \n> > /*\n> > * Expand the LOG() macro to _LOG1() or _LOG2() based on the number of\n> > diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n> > index 9f86e645ac58..94175ab34535 100644\n> > --- a/src/libcamera/log.cpp\n> > +++ b/src/libcamera/log.cpp\n> > @@ -897,19 +897,18 @@ Loggable::~Loggable()\n> > \n> > /**\n> > * \\brief Create a temporary LogMessage object to log a message\n> > - * \\param[in] fileName The file name where the message is logged from\n> > - * \\param[in] line The line number where the message is logged from\n> > * \\param[in] category The log message category\n> > * \\param[in] severity The log message severity\n> > + * \\param[in] fileName The file name where the message is logged from\n> > + * \\param[in] line The line number where the message is logged from\n> > *\n> > * This method is used as a backeng by the LOG() macro to create a log message\n> > * for locations inheriting from the Loggable class.\n> > *\n> > * \\return A log message\n> > */\n> > -LogMessage Loggable::_log(const char *fileName, unsigned int line,\n> > -\t\t\t const LogCategory *category,\n> > -\t\t\t LogSeverity severity) const\n> > +LogMessage Loggable::_log(const LogCategory *category, LogSeverity severity,\n> > +\t\t\t const char *fileName, unsigned int line) const\n> > {\n> > \tLogMessage msg(fileName, line,\n> > \t\t category ? *category : LogCategory::defaultCategory(),\n> > @@ -921,18 +920,18 @@ LogMessage Loggable::_log(const char *fileName, unsigned int line,\n> > \n> > /**\n> > * \\brief Create a temporary LogMessage object to log a message\n> > - * \\param[in] fileName The file name where the message is logged from\n> > - * \\param[in] line The line number where the message is logged from\n> > * \\param[in] category The log message category\n> > * \\param[in] severity The log message severity\n> > + * \\param[in] fileName The file name where the message is logged from\n> > + * \\param[in] line The line number where the message is logged from\n> > *\n> > * This function is used as a backeng by the LOG() macro to create a log\n> > * message for locations not inheriting from the Loggable class.\n> > *\n> > * \\return A log message\n> > */\n> > -LogMessage _log(const char *fileName, unsigned int line,\n> > -\t\tconst LogCategory *category, LogSeverity severity)\n> > +LogMessage _log(const LogCategory *category, LogSeverity severity,\n> > +\t\tconst char *fileName, unsigned int line)\n> > {\n> > \treturn LogMessage(fileName, line,\n> > \t\t\t category ? *category : LogCategory::defaultCategory(),","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E82BBD1F6\n\tfor ;\n\tWed, 14 Apr 2021 09:40:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C863687EF;\n\tWed, 14 Apr 2021 11:40:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45955602CA\n\tfor ;\n\tWed, 14 Apr 2021 11:40:10 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A64C86F2;\n\tWed, 14 Apr 2021 11:40:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cSsdtdPm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618393209;\n\tbh=hb59tPO+A2OMdcaLoARNVQnQizsjtW+hWsg/jtEYfGk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cSsdtdPm968abNFSjjEnmHWdr4PjDmEvIS5FbVtXCtvnbTle+z+M61SMURX/weOMg\n\tnmNQWyb+byrH6qzlEXJnpz+c8BfwQLmMOJr69UcDIUrL1SHEYAZAt/77RevgWl9JBh\n\tobkesWKiEeVQhCowW4mLiVrqiTzBcXzH+83WqmlA=","Date":"Wed, 14 Apr 2021 12:40:08 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210413215121.15538-1-laurent.pinchart@ideasonboard.com>\n\t<20210413215121.15538-3-laurent.pinchart@ideasonboard.com>\n\t<5bb0b6a1-9472-31d9-ba5d-dc470c9007bd@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<5bb0b6a1-9472-31d9-ba5d-dc470c9007bd@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: log: Use compiler\n\tbuiltins to retrieve file and line number","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16275,"web_url":"https://patchwork.libcamera.org/comment/16275/","msgid":"","date":"2021-04-14T10:53:02","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: log: Use compiler\n\tbuiltins to retrieve file and line number","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 14/04/2021 10:40, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Wed, Apr 14, 2021 at 09:49:09AM +0100, Kieran Bingham wrote:\n>> On 13/04/2021 22:51, Laurent Pinchart wrote:\n>>> Replace the __FILE__ and __LINE__ values passed to the _log() function\n>>> with default parameters, taking their values from the __builtin_FILE()\n>>> and __builtin_LINE() functions. This moves handling of the file and line\n>>> from the preprocessor to the compiler, which is generally preferred as\n>>> it increases type safety.\n>>\n>> Sounds good to me.\n>>\n>>> Signed-off-by: Laurent Pinchart \n>>> ---\n>>> include/libcamera/internal/log.h | 15 ++++++++-------\n>>> src/libcamera/log.cpp | 17 ++++++++---------\n>>> 2 files changed, 16 insertions(+), 16 deletions(-)\n>>>\n>>> diff --git a/include/libcamera/internal/log.h b/include/libcamera/internal/log.h\n>>> index 0fdacc4733fe..be0bab3c1272 100644\n>>> --- a/include/libcamera/internal/log.h\n>>> +++ b/include/libcamera/internal/log.h\n>>> @@ -89,21 +89,22 @@ public:\n>>> protected:\n>>> \tvirtual std::string logPrefix() const = 0;\n>>> \n>>> -\tLogMessage _log(const char *file, unsigned int line,\n>>> -\t\t\tconst LogCategory *category,\n>>> -\t\t\tLogSeverity severity) const;\n>>> +\tLogMessage _log(const LogCategory *category, LogSeverity severity,\n>>> +\t\t\tconst char *fileName = __builtin_FILE(),\n>>> +\t\t\tunsigned int line = __builtin_LINE()) const;\n>>> };\n>>> \n>>> -LogMessage _log(const char *file, unsigned int line,\n>>> -\t\tconst LogCategory *category, LogSeverity severity);\n>>> +LogMessage _log(const LogCategory *category, LogSeverity severity,\n>>> +\t\tconst char *fileName = __builtin_FILE(),\n>>> +\t\tunsigned int line = __builtin_LINE());\n>>> \n>>> #ifndef __DOXYGEN__\n>>> #define _LOG_CATEGORY(name) logCategory##name\n>>> \n>>> #define _LOG1(severity) \\\n>>> -\t_log(__FILE__, __LINE__, nullptr, Log##severity).stream()\n>>> +\t_log(nullptr, Log##severity).stream()\n>>> #define _LOG2(category, severity) \\\n>>> -\t_log(__FILE__, __LINE__, &_LOG_CATEGORY(category)(), Log##severity).stream()\n>>> +\t_log(&_LOG_CATEGORY(category)(), Log##severity).stream()\n>>\n>> Do we actually need these macros any more at all?\n>>\n>> From what I can see they serve the following now:\n>>\n>> - Make LOG all caps in the code\n>> I think this is actually helpful to make log lines clear\n>>\n>> - Adds the .stream() call after the construction\n>> Maybe this is helpful. Can it be done with a direct call by\n>> overriding the << operator or something directly though to make the\n>> object itself look like a stream?\n> \n> They're also used to construct the category, and the severity. Otherwise\n> we'd have to write LogInfo instead of Info, but also\n> logCategoryV4L2Device() instead of V4L2Device.\n\nAh yes, I missed that, and I think that's a valuable feature too.\n\n> If we wanted to simplify this, we could drop _LOG1 and _LOG2, and keep\n> LOG. That would make the category mandatory, we wouldn't be able to\n> write LOG(Info) << ... for quick debugging.\n\nIn thinking the macros weren't needed, I thought that would be handled\nby a separate function overload that would call through with a null\ncategory.\n\nBut the Category shortening alone is a churn I wouldn't want to lose so\nI don't think there's much to change here.\n\n> \n>> Otherwise,\n>>\n>> Reviewed-by: Kieran Bingham \n>>\n\nStill stands ... ;-)\n\n\n>>> /*\n>>> * Expand the LOG() macro to _LOG1() or _LOG2() based on the number of\n>>> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n>>> index 9f86e645ac58..94175ab34535 100644\n>>> --- a/src/libcamera/log.cpp\n>>> +++ b/src/libcamera/log.cpp\n>>> @@ -897,19 +897,18 @@ Loggable::~Loggable()\n>>> \n>>> /**\n>>> * \\brief Create a temporary LogMessage object to log a message\n>>> - * \\param[in] fileName The file name where the message is logged from\n>>> - * \\param[in] line The line number where the message is logged from\n>>> * \\param[in] category The log message category\n>>> * \\param[in] severity The log message severity\n>>> + * \\param[in] fileName The file name where the message is logged from\n>>> + * \\param[in] line The line number where the message is logged from\n>>> *\n>>> * This method is used as a backeng by the LOG() macro to create a log message\n>>> * for locations inheriting from the Loggable class.\n>>> *\n>>> * \\return A log message\n>>> */\n>>> -LogMessage Loggable::_log(const char *fileName, unsigned int line,\n>>> -\t\t\t const LogCategory *category,\n>>> -\t\t\t LogSeverity severity) const\n>>> +LogMessage Loggable::_log(const LogCategory *category, LogSeverity severity,\n>>> +\t\t\t const char *fileName, unsigned int line) const\n>>> {\n>>> \tLogMessage msg(fileName, line,\n>>> \t\t category ? *category : LogCategory::defaultCategory(),\n>>> @@ -921,18 +920,18 @@ LogMessage Loggable::_log(const char *fileName, unsigned int line,\n>>> \n>>> /**\n>>> * \\brief Create a temporary LogMessage object to log a message\n>>> - * \\param[in] fileName The file name where the message is logged from\n>>> - * \\param[in] line The line number where the message is logged from\n>>> * \\param[in] category The log message category\n>>> * \\param[in] severity The log message severity\n>>> + * \\param[in] fileName The file name where the message is logged from\n>>> + * \\param[in] line The line number where the message is logged from\n>>> *\n>>> * This function is used as a backeng by the LOG() macro to create a log\n>>> * message for locations not inheriting from the Loggable class.\n>>> *\n>>> * \\return A log message\n>>> */\n>>> -LogMessage _log(const char *fileName, unsigned int line,\n>>> -\t\tconst LogCategory *category, LogSeverity severity)\n>>> +LogMessage _log(const LogCategory *category, LogSeverity severity,\n>>> +\t\tconst char *fileName, unsigned int line)\n>>> {\n>>> \treturn LogMessage(fileName, line,\n>>> \t\t\t category ? *category : LogCategory::defaultCategory(),\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B0EE6BD1F6\n\tfor ;\n\tWed, 14 Apr 2021 10:53:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2895668819;\n\tWed, 14 Apr 2021 12:53:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 06FB768803\n\tfor ;\n\tWed, 14 Apr 2021 12:53:05 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5764A6F2;\n\tWed, 14 Apr 2021 12:53:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lGvu/GnJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618397584;\n\tbh=9Y5o5wqTeFGO6POehlr3aSQBhlhd1nnaupLSkpUbIds=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=lGvu/GnJAQYWy8SX/vi6QG9CQfoNBMgCdsLRMCtyQXcf7qGJTCfZt2hCqpc5rx45H\n\tQDtGkbSvJVkF2DvUV6EBJJcV+ubwiJe2ZwWAYVEieUKehLe18KakGmeePz4NN7dOzm\n\tWepBsEnW8uJL7kjcVNIefR70DVXsCHeoZsQ4e6cw=","To":"Laurent Pinchart ","References":"<20210413215121.15538-1-laurent.pinchart@ideasonboard.com>\n\t<20210413215121.15538-3-laurent.pinchart@ideasonboard.com>\n\t<5bb0b6a1-9472-31d9-ba5d-dc470c9007bd@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Wed, 14 Apr 2021 11:53:02 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: log: Use compiler\n\tbuiltins to retrieve file and line number","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]