[{"id":16262,"web_url":"https://patchwork.libcamera.org/comment/16262/","msgid":"<20210414040644.5ltx3a74ka2em557@basti-TUXEDO-Book-XA1510>","date":"2021-04-14T04:06:44","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: log: De-duplicate\n\t_log() functions and LogMessage constructor","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"Hey Laurent,\n\nThank you for the patch.\n\nOn 14.04.2021 00:51, Laurent Pinchart wrote:\n>The _log() functions, as well as the LogMessage constructor, exist in\n>two versions, one that takes a log category, and one that doesn't. The\n>latter uses the default log category. This can be simplied by passing a\n>LogCategory pointer to _log(), which can then be null for the default\n>category, and moving the retrieval of the default log category from the\n>LogMessage constructor to the _log() function.\n\nNice this patch is able to remove a lot of lines from the code.\nI have tested this patch with `LIBCAMERA_LOG_LEVELS=0` (default category)\nand with `LIBCAMERA_LOG_LEVELS=Camera:0` (with specified category).\nAnd compared the output with the output before applying the patch.\n\nIn both cases the result looks exactly the same and there are no\nproblems.\n\n>\n>Signed-off-by: Laurent Pinchart \nTested-by: Sebastian Fricke \n\n>---\n> include/libcamera/internal/log.h | 13 ++-----\n> src/libcamera/log.cpp | 66 ++++----------------------------\n> 2 files changed, 12 insertions(+), 67 deletions(-)\n>\n>diff --git a/include/libcamera/internal/log.h b/include/libcamera/internal/log.h\n>index e76ae913c857..0fdacc4733fe 100644\n>--- a/include/libcamera/internal/log.h\n>+++ b/include/libcamera/internal/log.h\n>@@ -55,8 +55,6 @@ const LogCategory &_LOG_CATEGORY(name)()\t\t\t\t\\\n> class LogMessage\n> {\n> public:\n>-\tLogMessage(const char *fileName, unsigned int line,\n>-\t\t LogSeverity severity);\n> \tLogMessage(const char *fileName, unsigned int line,\n> \t\t const LogCategory &category, LogSeverity severity);\n>\n>@@ -92,23 +90,20 @@ protected:\n> \tvirtual std::string logPrefix() const = 0;\n>\n> \tLogMessage _log(const char *file, unsigned int line,\n>-\t\t\tLogSeverity severity) const;\n>-\tLogMessage _log(const char *file, unsigned int line,\n>-\t\t\tconst LogCategory &category,\n>+\t\t\tconst LogCategory *category,\n> \t\t\tLogSeverity severity) const;\n> };\n>\n>-LogMessage _log(const char *file, unsigned int line, LogSeverity severity);\n> LogMessage _log(const char *file, unsigned int line,\n>-\t\tconst LogCategory &category, LogSeverity severity);\n>+\t\tconst LogCategory *category, LogSeverity severity);\n>\n> #ifndef __DOXYGEN__\n> #define _LOG_CATEGORY(name) logCategory##name\n>\n> #define _LOG1(severity) \\\n>-\t_log(__FILE__, __LINE__, Log##severity).stream()\n>+\t_log(__FILE__, __LINE__, nullptr, Log##severity).stream()\n> #define _LOG2(category, severity) \\\n>-\t_log(__FILE__, __LINE__, _LOG_CATEGORY(category)(), Log##severity).stream()\n>+\t_log(__FILE__, __LINE__, &_LOG_CATEGORY(category)(), Log##severity).stream()\n>\n> /*\n> * Expand the LOG() macro to _LOG1() or _LOG2() based on the number of\n>diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n>index 45c7c2d24652..9f86e645ac58 100644\n>--- a/src/libcamera/log.cpp\n>+++ b/src/libcamera/log.cpp\n>@@ -763,24 +763,6 @@ const LogCategory &LogCategory::defaultCategory()\n> * directly. Use the LOG() macro instead access the log infrastructure.\n> */\n>\n>-/**\n>- * \\brief Construct a log message for the default category\n>- * \\param[in] fileName The file name where the message is logged from\n>- * \\param[in] line The line number where the message is logged from\n>- * \\param[in] severity The log message severity, controlling how the message\n>- * will be displayed\n>- *\n>- * Create a log message pertaining to line \\a line of file \\a fileName. The\n>- * \\a severity argument sets the message severity to control whether it will be\n>- * output or dropped.\n>- */\n>-LogMessage::LogMessage(const char *fileName, unsigned int line,\n>-\t\t LogSeverity severity)\n>-\t: category_(LogCategory::defaultCategory()), severity_(severity)\n>-{\n>-\tinit(fileName, line);\n>-}\n>-\n> /**\n> * \\brief Construct a log message for a given category\n> * \\param[in] fileName The file name where the message is logged from\n>@@ -913,26 +895,6 @@ Loggable::~Loggable()\n> * \\return A string to be prefixed to the log message\n> */\n>\n>-/**\n>- * \\brief Create a temporary LogMessage object to log a message\n>- * \\param[in] fileName The file name where the message is logged from\n>- * \\param[in] line The line number where the message is logged from\n>- * \\param[in] severity The log message severity\n>- *\n>- * This method is used as a backeng by the LOG() macro to create a log message\n>- * for locations inheriting from the Loggable class.\n>- *\n>- * \\return A log message\n>- */\n>-LogMessage Loggable::_log(const char *fileName, unsigned int line,\n>-\t\t\t LogSeverity severity) const\n>-{\n>-\tLogMessage msg(fileName, line, severity);\n>-\n>-\tmsg.stream() << logPrefix() << \": \";\n>-\treturn msg;\n>-}\n>-\n> /**\n> * \\brief Create a temporary LogMessage object to log a message\n> * \\param[in] fileName The file name where the message is logged from\n>@@ -946,31 +908,17 @@ LogMessage Loggable::_log(const char *fileName, unsigned int line,\n> * \\return A log message\n> */\n> LogMessage Loggable::_log(const char *fileName, unsigned int line,\n>-\t\t\t const LogCategory &category,\n>+\t\t\t const LogCategory *category,\n> \t\t\t LogSeverity severity) const\n> {\n>-\tLogMessage msg(fileName, line, category, severity);\n>+\tLogMessage msg(fileName, line,\n>+\t\t category ? *category : LogCategory::defaultCategory(),\n>+\t\t severity);\n>\n> \tmsg.stream() << logPrefix() << \": \";\n> \treturn msg;\n> }\n>\n>-/**\n>- * \\brief Create a temporary LogMessage object to log a message\n>- * \\param[in] fileName The file name where the message is logged from\n>- * \\param[in] line The line number where the message is logged from\n>- * \\param[in] severity The log message severity\n>- *\n>- * This function is used as a backeng by the LOG() macro to create a log\n>- * message for locations not inheriting from the Loggable class.\n>- *\n>- * \\return A log message\n>- */\n>-LogMessage _log(const char *fileName, unsigned int line, LogSeverity severity)\n>-{\n>-\treturn LogMessage(fileName, line, severity);\n>-}\n>-\n> /**\n> * \\brief Create a temporary LogMessage object to log a message\n> * \\param[in] fileName The file name where the message is logged from\n>@@ -984,9 +932,11 @@ LogMessage _log(const char *fileName, unsigned int line, LogSeverity severity)\n> * \\return A log message\n> */\n> LogMessage _log(const char *fileName, unsigned int line,\n>-\t\tconst LogCategory &category, LogSeverity severity)\n>+\t\tconst LogCategory *category, LogSeverity severity)\n> {\n>-\treturn LogMessage(fileName, line, category, severity);\n>+\treturn LogMessage(fileName, line,\n>+\t\t\t category ? *category : LogCategory::defaultCategory(),\n>+\t\t\t severity);\n> }\n>\n> /**\n>-- \n>Regards,\n>\n>Laurent Pinchart\n>\n>_______________________________________________\n>libcamera-devel mailing list\n>libcamera-devel@lists.libcamera.org\n>https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1414BD224\n\tfor ;\n\tWed, 14 Apr 2021 04:06:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6DB64602D1;\n\tWed, 14 Apr 2021 06:06:48 +0200 (CEST)","from mout02.posteo.de (mout02.posteo.de [185.67.36.66])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9733F602CD\n\tfor ;\n\tWed, 14 Apr 2021 06:06:46 +0200 (CEST)","from submission (posteo.de [89.146.220.130]) \n\tby mout02.posteo.de (Postfix) with ESMTPS id 264A72400E5\n\tfor ;\n\tWed, 14 Apr 2021 06:06:46 +0200 (CEST)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4FKpnd3rMDz9rxK;\n\tWed, 14 Apr 2021 06:06:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"eexwc0U6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1618373206; bh=sujPvTqXUF9j7TFKL+y7rbb/OfNus/O5jfUmUQJFDa4=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=eexwc0U6QEHwaNdQss6T3hguWYU7uAcXrA14K8+HfsND5RljdgR0w4HgGGPzOlqGS\n\tYSW4zIIpqbE+M7KN4xNIAWpDvAcUxCUm0udlca3f57dBiCD0jSkPIyONZUSKl1i0V/\n\tmr8B6Yo6TtwMDmsQnXSn8IUnkHbvR+P+xq3Hhy/PTK+Rh6A9r7/ctPuCar0NTr5BDX\n\tkji/VOUljVXFugxRt3LHqDYf2sx/dSkI3CPfqg1jctjO4jt/DBI89bq1Fq7d1XLVbe\n\t0W7l3D9o/LIdNAX6tXGnxSGrpH+66GAQBQi4AQ74oNhoQ6aefplXG0C1klJWmA7y03\n\tysKRqQotRo4Xg==","Date":"Wed, 14 Apr 2021 06:06:44 +0200","From":"Sebastian Fricke ","To":"Laurent Pinchart ","Message-ID":"<20210414040644.5ltx3a74ka2em557@basti-TUXEDO-Book-XA1510>","References":"<20210413215121.15538-1-laurent.pinchart@ideasonboard.com>\n\t<20210413215121.15538-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210413215121.15538-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: log: De-duplicate\n\t_log() functions and LogMessage constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16276,"web_url":"https://patchwork.libcamera.org/comment/16276/","msgid":"<8dcbc1c2-6dc1-6f96-54ef-b889cb84075d@ideasonboard.com>","date":"2021-04-14T10:54:54","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: log: De-duplicate\n\t_log() functions and LogMessage constructor","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 13/04/2021 22:51, Laurent Pinchart wrote:\n> The _log() functions, as well as the LogMessage constructor, exist in\n> two versions, one that takes a log category, and one that doesn't. The\n> latter uses the default log category. This can be simplied by passing a\n\ns/simplied/simplified/\n\n> LogCategory pointer to _log(), which can then be null for the default\n> category, and moving the retrieval of the default log category from the\n> LogMessage constructor to the _log() function.\n> \n> Signed-off-by: Laurent Pinchart \n\nLooks good to me.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/internal/log.h | 13 ++-----\n> src/libcamera/log.cpp | 66 ++++----------------------------\n> 2 files changed, 12 insertions(+), 67 deletions(-)\n> \n> diff --git a/include/libcamera/internal/log.h b/include/libcamera/internal/log.h\n> index e76ae913c857..0fdacc4733fe 100644\n> --- a/include/libcamera/internal/log.h\n> +++ b/include/libcamera/internal/log.h\n> @@ -55,8 +55,6 @@ const LogCategory &_LOG_CATEGORY(name)()\t\t\t\t\\\n> class LogMessage\n> {\n> public:\n> -\tLogMessage(const char *fileName, unsigned int line,\n> -\t\t LogSeverity severity);\n> \tLogMessage(const char *fileName, unsigned int line,\n> \t\t const LogCategory &category, LogSeverity severity);\n> \n> @@ -92,23 +90,20 @@ protected:\n> \tvirtual std::string logPrefix() const = 0;\n> \n> \tLogMessage _log(const char *file, unsigned int line,\n> -\t\t\tLogSeverity severity) const;\n> -\tLogMessage _log(const char *file, unsigned int line,\n> -\t\t\tconst LogCategory &category,\n> +\t\t\tconst LogCategory *category,\n> \t\t\tLogSeverity severity) const;\n> };\n> \n> -LogMessage _log(const char *file, unsigned int line, LogSeverity severity);\n> LogMessage _log(const char *file, unsigned int line,\n> -\t\tconst LogCategory &category, LogSeverity severity);\n> +\t\tconst LogCategory *category, LogSeverity severity);\n> \n> #ifndef __DOXYGEN__\n> #define _LOG_CATEGORY(name) logCategory##name\n> \n> #define _LOG1(severity) \\\n> -\t_log(__FILE__, __LINE__, Log##severity).stream()\n> +\t_log(__FILE__, __LINE__, nullptr, Log##severity).stream()\n> #define _LOG2(category, severity) \\\n> -\t_log(__FILE__, __LINE__, _LOG_CATEGORY(category)(), Log##severity).stream()\n> +\t_log(__FILE__, __LINE__, &_LOG_CATEGORY(category)(), Log##severity).stream()\n> \n> /*\n> * Expand the LOG() macro to _LOG1() or _LOG2() based on the number of\n> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n> index 45c7c2d24652..9f86e645ac58 100644\n> --- a/src/libcamera/log.cpp\n> +++ b/src/libcamera/log.cpp\n> @@ -763,24 +763,6 @@ const LogCategory &LogCategory::defaultCategory()\n> * directly. Use the LOG() macro instead access the log infrastructure.\n> */\n> \n> -/**\n> - * \\brief Construct a log message for the default category\n> - * \\param[in] fileName The file name where the message is logged from\n> - * \\param[in] line The line number where the message is logged from\n> - * \\param[in] severity The log message severity, controlling how the message\n> - * will be displayed\n> - *\n> - * Create a log message pertaining to line \\a line of file \\a fileName. The\n> - * \\a severity argument sets the message severity to control whether it will be\n> - * output or dropped.\n> - */\n> -LogMessage::LogMessage(const char *fileName, unsigned int line,\n> -\t\t LogSeverity severity)\n> -\t: category_(LogCategory::defaultCategory()), severity_(severity)\n> -{\n> -\tinit(fileName, line);\n> -}\n> -\n> /**\n> * \\brief Construct a log message for a given category\n> * \\param[in] fileName The file name where the message is logged from\n> @@ -913,26 +895,6 @@ Loggable::~Loggable()\n> * \\return A string to be prefixed to the log message\n> */\n> \n> -/**\n> - * \\brief Create a temporary LogMessage object to log a message\n> - * \\param[in] fileName The file name where the message is logged from\n> - * \\param[in] line The line number where the message is logged from\n> - * \\param[in] severity The log message severity\n> - *\n> - * This method is used as a backeng by the LOG() macro to create a log message\n> - * for locations inheriting from the Loggable class.\n> - *\n> - * \\return A log message\n> - */\n> -LogMessage Loggable::_log(const char *fileName, unsigned int line,\n> -\t\t\t LogSeverity severity) const\n> -{\n> -\tLogMessage msg(fileName, line, severity);\n> -\n> -\tmsg.stream() << logPrefix() << \": \";\n> -\treturn msg;\n> -}\n> -\n> /**\n> * \\brief Create a temporary LogMessage object to log a message\n> * \\param[in] fileName The file name where the message is logged from\n> @@ -946,31 +908,17 @@ LogMessage Loggable::_log(const char *fileName, unsigned int line,\n> * \\return A log message\n> */\n> LogMessage Loggable::_log(const char *fileName, unsigned int line,\n> -\t\t\t const LogCategory &category,\n> +\t\t\t const LogCategory *category,\n> \t\t\t LogSeverity severity) const\n> {\n> -\tLogMessage msg(fileName, line, category, severity);\n> +\tLogMessage msg(fileName, line,\n> +\t\t category ? *category : LogCategory::defaultCategory(),\n> +\t\t severity);\n> \n> \tmsg.stream() << logPrefix() << \": \";\n> \treturn msg;\n> }\n> \n> -/**\n> - * \\brief Create a temporary LogMessage object to log a message\n> - * \\param[in] fileName The file name where the message is logged from\n> - * \\param[in] line The line number where the message is logged from\n> - * \\param[in] severity The log message severity\n> - *\n> - * This function is used as a backeng by the LOG() macro to create a log\n> - * message for locations not inheriting from the Loggable class.\n> - *\n> - * \\return A log message\n> - */\n> -LogMessage _log(const char *fileName, unsigned int line, LogSeverity severity)\n> -{\n> -\treturn LogMessage(fileName, line, severity);\n> -}\n> -\n> /**\n> * \\brief Create a temporary LogMessage object to log a message\n> * \\param[in] fileName The file name where the message is logged from\n> @@ -984,9 +932,11 @@ LogMessage _log(const char *fileName, unsigned int line, LogSeverity severity)\n> * \\return A log message\n> */\n> LogMessage _log(const char *fileName, unsigned int line,\n> -\t\tconst LogCategory &category, LogSeverity severity)\n> +\t\tconst LogCategory *category, LogSeverity severity)\n> {\n> -\treturn LogMessage(fileName, line, category, severity);\n> +\treturn LogMessage(fileName, line,\n> +\t\t\t category ? *category : LogCategory::defaultCategory(),\n> +\t\t\t severity);\n> }\n> \n> /**\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7469BBD224\n\tfor ;\n\tWed, 14 Apr 2021 10:55:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DEAD06880A;\n\tWed, 14 Apr 2021 12:54:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0909868803\n\tfor ;\n\tWed, 14 Apr 2021 12:54:58 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 57BC26F2;\n\tWed, 14 Apr 2021 12:54:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"f9wYZXKv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618397697;\n\tbh=OFbyWSwbBJaRdBD+u0+gruR4/ZZnzuFJVRJQ1UoicGw=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=f9wYZXKv8D8niDtfttpBc2ZpXBtTkSyiTDRWLLUg3/YXWrZCn4DfhoWcqaJriZnV4\n\t+Dp1+LHZNFwbwERRPklddCh18yF49DvdfDXrZj7qJrFOcoZ9qywgRndvXNY682XqJ3\n\t5PbHal9rEDvfHOm7T5WgQ02UD+Ib07JQYHJGFsyY=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210413215121.15538-1-laurent.pinchart@ideasonboard.com>\n\t<20210413215121.15538-2-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<8dcbc1c2-6dc1-6f96-54ef-b889cb84075d@ideasonboard.com>","Date":"Wed, 14 Apr 2021 11:54:54 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210413215121.15538-2-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: log: De-duplicate\n\t_log() functions and LogMessage constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]