[{"id":16250,"web_url":"https://patchwork.libcamera.org/comment/16250/","msgid":"","date":"2021-04-13T21:52:32","subject":"Re: [libcamera-devel] [PATCH] lc-compliance: Drop return value from\n\tSimpleCapture::stop()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Apr 13, 2021 at 11:51:44PM +0200, Niklas Söderlund wrote:\n> The return value is never checked and serves to real usage, drop it.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/lc-compliance/simple_capture.cpp | 4 +---\n> src/lc-compliance/simple_capture.h | 2 +-\n> 2 files changed, 2 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/lc-compliance/simple_capture.cpp b/src/lc-compliance/simple_capture.cpp\n> index 8f714d3b5e73e28e..811a6220009654be 100644\n> --- a/src/lc-compliance/simple_capture.cpp\n> +++ b/src/lc-compliance/simple_capture.cpp\n> @@ -50,7 +50,7 @@ Results::Result SimpleCapture::start()\n> \treturn { Results::Pass, \"Started camera\" };\n> }\n> \n> -Results::Result SimpleCapture::stop()\n> +void SimpleCapture::stop()\n> {\n> \tStream *stream = config_->at(0).stream();\n> \n> @@ -59,8 +59,6 @@ Results::Result SimpleCapture::stop()\n> \tcamera_->requestCompleted.disconnect(this, &SimpleCapture::requestComplete);\n> \n> \tallocator_->free(stream);\n> -\n> -\treturn { Results::Pass, \"Stopped camera\" };\n> }\n> \n> /* SimpleCaptureBalanced */\n> diff --git a/src/lc-compliance/simple_capture.h b/src/lc-compliance/simple_capture.h\n> index 4693c13404cee7d2..d9de53fb63a3ea3f 100644\n> --- a/src/lc-compliance/simple_capture.h\n> +++ b/src/lc-compliance/simple_capture.h\n> @@ -24,7 +24,7 @@ protected:\n> \tvirtual ~SimpleCapture();\n> \n> \tResults::Result start();\n> -\tResults::Result stop();\n> +\tvoid stop();\n> \n> \tvirtual void requestComplete(libcamera::Request *request) = 0;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8AE7FBD224\n\tfor ;\n\tTue, 13 Apr 2021 21:53:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 44C5C687EC;\n\tTue, 13 Apr 2021 23:53:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8218B602D1\n\tfor ;\n\tTue, 13 Apr 2021 23:53:23 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D4309F0;\n\tTue, 13 Apr 2021 23:53:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bXRwROQ7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618350803;\n\tbh=06kiakB0s0av6DjlBHSc5yoUiNE8yQHRLb2XkVG6RAQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bXRwROQ7lRSU5V4iv0bD1ls+LFJDqYclsvoqKO17OpLvv30SWJDXa4HFbZQwfu2DR\n\tczV7xxa9QUCM1LVs9M+lekxqXah4aMV2u70uZRQahGUIpijHa9cPE8B/za6lmeXy1/\n\tHLYgojCSXpEoEzE7dyr56/2/aazS5vLoIBwrICVM=","Date":"Wed, 14 Apr 2021 00:52:32 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"","References":"<20210413215144.2733876-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210413215144.2733876-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH] lc-compliance: Drop return value from\n\tSimpleCapture::stop()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]