[{"id":16241,"web_url":"https://patchwork.libcamera.org/comment/16241/","msgid":"","date":"2021-04-13T20:40:59","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Demote\n\terror message","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Apr 13, 2021 at 05:49:07PM +0200, Jacopo Mondi wrote:\n> The CameraSensor class is noisy enough in reporting the missing\n> sensor driver features.\n> \n> Demote an error message about defaulting the active sensor area when\n> retrieving the camera sensor info to a warning.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/camera_sensor.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index f7ed91d990f7..2887bb69ca02 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -774,7 +774,7 @@ int CameraSensor::sensorInfo(CameraSensorInfo *info) const\n> \tint ret = subdev_->getSelection(pad_, V4L2_SEL_TGT_CROP, &info->analogCrop);\n> \tif (ret) {\n> \t\tinfo->analogCrop = activeArea_;\n> -\t\tLOG(CameraSensor, Error)\n> +\t\tLOG(CameraSensor, Warning)\n> \t\t\t<< \"The analogue crop rectangle has been defaulted to the active area size\";\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54299BD224\n\tfor ;\n\tTue, 13 Apr 2021 20:41:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14F92687FE;\n\tTue, 13 Apr 2021 22:41:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71877602D1\n\tfor ;\n\tTue, 13 Apr 2021 22:41:50 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 02FC89F0;\n\tTue, 13 Apr 2021 22:41:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lVoUlEpe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618346510;\n\tbh=q3oBT2WEkcN+1Fwr/3kE+xtmIV8voNGIYCpjbZgnQsA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lVoUlEpeqb2SnJimDUyB6H4RqwwTs+qonzeWQzKT4G+X002DiaUOurL9z7cDnpBP0\n\thBQtHgAOhuy4B//8BrOuaEvRZl8ZbLsH2lmsbQAlSHfLmZGiGuG4ifeB1CQKRN31KI\n\t6Y8X6j3IkqTlHKPkUiGl1l6ndxTrq7YrEZcGixYo=","Date":"Tue, 13 Apr 2021 23:40:59 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210413154907.50449-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210413154907.50449-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Demote\n\terror message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]