[{"id":16235,"web_url":"https://patchwork.libcamera.org/comment/16235/","msgid":"","date":"2021-04-13T17:48:07","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline_handler:\n\tDocument requestSequence_","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Apr 13, 2021 at 01:25:34PM +0100, Kieran Bingham wrote:\n> The documentation for requestSequence_ was not added when the sequence\n> number was implemented.\n> \n> Provide it.\n> \n> Fixes: d874b3e34173 (\"libcamera: request: Provide a sequence number\")\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline_handler.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 433c05f60db0..43395b57d818 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -97,6 +97,17 @@ LOG_DEFINE_CATEGORY(Pipeline)\n> * when creating the camera, and shall not be modified afterwards.\n> */\n> \n> +/**\n> + * \\var CameraData::requestSequence_\n> + * \\brief The queuing sequence of the request\n> + *\n> + * When requests are queued, they are given a per-camera sequence number to\n> + * facilitate debugging of internal request usage.\n> + *\n> + * The requestSequence_ tracks the number of requests queued to a camera\n> + * over its lifetime.\n> + */\n> +\n> /**\n> * \\class PipelineHandler\n> * \\brief Create and manage cameras based on a set of media devices","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF15ABD224\n\tfor ;\n\tTue, 13 Apr 2021 17:49:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49BC6687FE;\n\tTue, 13 Apr 2021 19:49:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 004DF602D1\n\tfor ;\n\tTue, 13 Apr 2021 19:49:03 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 35C399F0;\n\tTue, 13 Apr 2021 19:49:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YvtEp9U1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618336143;\n\tbh=8k9fO5+YvWGBllca5aWNiCeDP9scWSOPuCFyjQ0vmLg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YvtEp9U1M/gbHEZSvuPyevpOoCTyTD0dlqtRVzlCw0ux9g0rmIt7SxS8bARhuMzjy\n\t5QfOxQwS5BOPddqFiJexc1T50/9Fe79qsHJtirlmfQMX4RSUJfi1oQzumB0m4kaZKG\n\th21siiNiL54H1/rm/Pm9T5x7vnjFkRaWTqfgPhvM=","Date":"Tue, 13 Apr 2021 20:48:07 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210413122534.342138-1-kieran.bingham@ideasonboard.com>\n\t<20210413122534.342138-4-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210413122534.342138-4-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline_handler:\n\tDocument requestSequence_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]