[{"id":1585,"web_url":"https://patchwork.libcamera.org/comment/1585/","msgid":"<20190511125533.GD4946@pendragon.ideasonboard.com>","date":"2019-05-11T12:55:33","subject":"Re: [libcamera-devel] [PATCH v3 06/11] test: media_device: Add test\n\tfor acquire() and release()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sat, May 11, 2019 at 11:19:02AM +0200, Niklas Söderlund wrote:\n> The interfaces MediaDevice::{open,close}() are about to be made private,\n> replace them with a test of MediaDevice::{acquire,release}() instead.\n> The new test will implicitly tests the open() and close() methods as\n> they are about to be move inside acquire() and release() which will\n> remain public.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> test/media_device/media_device_basic.cpp | 41 +++++++++++++++++++\n> test/media_device/media_device_print_test.cpp | 11 -----\n> test/media_device/meson.build | 1 +\n> 3 files changed, 42 insertions(+), 11 deletions(-)\n> create mode 100644 test/media_device/media_device_basic.cpp\n> \n> diff --git a/test/media_device/media_device_basic.cpp b/test/media_device/media_device_basic.cpp\n> new file mode 100644\n> index 0000000000000000..ba95dd0578fce22d\n> --- /dev/null\n> +++ b/test/media_device/media_device_basic.cpp\n> @@ -0,0 +1,41 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2019, Google Inc.\n> + *\n> + * media_device_basic.cpp - Test basic functions of MediaDevice\n\nHow about renaming this file to media_device_acquire.cpp and updating\nthe description accordingly ? We can rename it to something else later\nif we add more test.\n\n> + */\n> +\n> +#include \"media_device_test.h\"\n> +\n> +using namespace libcamera;\n> +\n> +class MediaDeviceBasic : public MediaDeviceTest\n> +{\n> +\tint testAcquire()\n> +\t{\n> +\t\tif (!media_->acquire())\n> +\t\t\treturn TestFail;\n> +\n> +\t\tif (media_->acquire())\n> +\t\t\treturn TestFail;\n> +\n> +\t\tmedia_->release();\n> +\n> +\t\tif (!media_->acquire())\n> +\t\t\treturn TestFail;\n> +\n> +\t\tmedia_->release();\n> +\n> +\t\treturn TestPass;\n> +\t}\n> +\n> +\tint run()\n> +\t{\n> +\t\tif (testAcquire() != TestPass)\n> +\t\t\treturn TestFail;\n> +\n> +\t\treturn TestPass;\n> +\t}\n> +};\n> +\n> +TEST_REGISTER(MediaDeviceBasic);\n> diff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp\n> index ceffd538e13fca73..30d929b8c76387a7 100644\n> --- a/test/media_device/media_device_print_test.cpp\n> +++ b/test/media_device/media_device_print_test.cpp\n> @@ -113,17 +113,6 @@ int MediaDevicePrintTest::testMediaDevice(const string deviceNode)\n> \tMediaDevice dev(deviceNode);\n> \tint ret;\n> \n> -\t/* Fuzzy open/close sequence. */\n> -\tret = dev.open();\n> -\tif (ret)\n> -\t\treturn ret;\n> -\n> -\tret = dev.open();\n> -\tif (!ret)\n> -\t\treturn ret;\n> -\n> -\tdev.close();\n> -\n> \tret = dev.populate();\n> \tif (ret)\n> \t\treturn ret;\n> diff --git a/test/media_device/meson.build b/test/media_device/meson.build\n> index 1005685409d99aa7..7a3266187abd806f 100644\n> --- a/test/media_device/meson.build\n> +++ b/test/media_device/meson.build\n> @@ -1,4 +1,5 @@\n> media_device_tests = [\n> + ['media_device_basic', 'media_device_basic.cpp'],\n> ['media_device_print_test', 'media_device_print_test.cpp'],\n> ['media_device_link_test', 'media_device_link_test.cpp'],\n> ]","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A11E60E4F\n\tfor ;\n\tSat, 11 May 2019 14:55:49 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 079FCD5;\n\tSat, 11 May 2019 14:55:48 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1557579349;\n\tbh=Yba1E+MX7wkRkerBldEPsnWqRdLpNlVnIfHVqFlSROM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hauET0sa+R2DjeBFlg7e0qZP6clZX9b0yVZIh87A79cG1kUBIrXIfY8f+HtL4QC2V\n\t50B4weLI6RqQ4g6i3y/DZ5CL6CWztJ+Y997M41CzuweNSFwa9GP/2CPd6xOiOj7EfP\n\t7WgM7Qk8SAo4NAiq+P8VXxl6GzlhAg8H5/QtJWDk=","Date":"Sat, 11 May 2019 15:55:33 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190511125533.GD4946@pendragon.ideasonboard.com>","References":"<20190511091907.10050-1-niklas.soderlund@ragnatech.se>\n\t<20190511091907.10050-7-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190511091907.10050-7-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 06/11] test: media_device: Add test\n\tfor acquire() and release()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 11 May 2019 12:55:49 -0000"}},{"id":1586,"web_url":"https://patchwork.libcamera.org/comment/1586/","msgid":"<20190511125606.GE4946@pendragon.ideasonboard.com>","date":"2019-05-11T12:56:06","subject":"Re: [libcamera-devel] [PATCH v3 06/11] test: media_device: Add test\n\tfor acquire() and release()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Sat, May 11, 2019 at 03:55:33PM +0300, Laurent Pinchart wrote:\n> On Sat, May 11, 2019 at 11:19:02AM +0200, Niklas Söderlund wrote:\n> > The interfaces MediaDevice::{open,close}() are about to be made private,\n> > replace them with a test of MediaDevice::{acquire,release}() instead.\n> > The new test will implicitly tests the open() and close() methods as\n> > they are about to be move inside acquire() and release() which will\n> > remain public.\n> > \n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > test/media_device/media_device_basic.cpp | 41 +++++++++++++++++++\n> > test/media_device/media_device_print_test.cpp | 11 -----\n> > test/media_device/meson.build | 1 +\n> > 3 files changed, 42 insertions(+), 11 deletions(-)\n> > create mode 100644 test/media_device/media_device_basic.cpp\n> > \n> > diff --git a/test/media_device/media_device_basic.cpp b/test/media_device/media_device_basic.cpp\n> > new file mode 100644\n> > index 0000000000000000..ba95dd0578fce22d\n> > --- /dev/null\n> > +++ b/test/media_device/media_device_basic.cpp\n> > @@ -0,0 +1,41 @@\n> > +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> > +/*\n> > + * Copyright (C) 2019, Google Inc.\n> > + *\n> > + * media_device_basic.cpp - Test basic functions of MediaDevice\n> \n> How about renaming this file to media_device_acquire.cpp and updating\n> the description accordingly ? We can rename it to something else later\n> if we add more test.\n\nI forgot to mention that, apart from that,\n\nReviewed-by: Laurent Pinchart \n\n> > + */\n> > +\n> > +#include \"media_device_test.h\"\n> > +\n> > +using namespace libcamera;\n> > +\n> > +class MediaDeviceBasic : public MediaDeviceTest\n> > +{\n> > +\tint testAcquire()\n> > +\t{\n> > +\t\tif (!media_->acquire())\n> > +\t\t\treturn TestFail;\n> > +\n> > +\t\tif (media_->acquire())\n> > +\t\t\treturn TestFail;\n> > +\n> > +\t\tmedia_->release();\n> > +\n> > +\t\tif (!media_->acquire())\n> > +\t\t\treturn TestFail;\n> > +\n> > +\t\tmedia_->release();\n> > +\n> > +\t\treturn TestPass;\n> > +\t}\n> > +\n> > +\tint run()\n> > +\t{\n> > +\t\tif (testAcquire() != TestPass)\n> > +\t\t\treturn TestFail;\n> > +\n> > +\t\treturn TestPass;\n> > +\t}\n> > +};\n> > +\n> > +TEST_REGISTER(MediaDeviceBasic);\n> > diff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp\n> > index ceffd538e13fca73..30d929b8c76387a7 100644\n> > --- a/test/media_device/media_device_print_test.cpp\n> > +++ b/test/media_device/media_device_print_test.cpp\n> > @@ -113,17 +113,6 @@ int MediaDevicePrintTest::testMediaDevice(const string deviceNode)\n> > \tMediaDevice dev(deviceNode);\n> > \tint ret;\n> > \n> > -\t/* Fuzzy open/close sequence. */\n> > -\tret = dev.open();\n> > -\tif (ret)\n> > -\t\treturn ret;\n> > -\n> > -\tret = dev.open();\n> > -\tif (!ret)\n> > -\t\treturn ret;\n> > -\n> > -\tdev.close();\n> > -\n> > \tret = dev.populate();\n> > \tif (ret)\n> > \t\treturn ret;\n> > diff --git a/test/media_device/meson.build b/test/media_device/meson.build\n> > index 1005685409d99aa7..7a3266187abd806f 100644\n> > --- a/test/media_device/meson.build\n> > +++ b/test/media_device/meson.build\n> > @@ -1,4 +1,5 @@\n> > media_device_tests = [\n> > + ['media_device_basic', 'media_device_basic.cpp'],\n> > ['media_device_print_test', 'media_device_print_test.cpp'],\n> > ['media_device_link_test', 'media_device_link_test.cpp'],\n> > ]","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66CAF60E4F\n\tfor ;\n\tSat, 11 May 2019 14:56:22 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F3D36D5;\n\tSat, 11 May 2019 14:56:21 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1557579382;\n\tbh=rNnHCuKJvp4Kt1moIutoCpcc6crIh/BtxkK+AK/h40A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fxk4UwMHU0PcLIU4CpSJLctp0dTzWkNySMLSsCMdweaH4Hfj5WnB8Lls3WMRMZxge\n\t8WtUMi7hsfI/MbS74SJNbl68a01a3YM3EVsFGbEKIITiBpsbuG42Tkzwxx+sLLedlZ\n\tKBkUz/mYLrburAuwQqIdN6TnIwQc1aKTIPkOBSSI=","Date":"Sat, 11 May 2019 15:56:06 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190511125606.GE4946@pendragon.ideasonboard.com>","References":"<20190511091907.10050-1-niklas.soderlund@ragnatech.se>\n\t<20190511091907.10050-7-niklas.soderlund@ragnatech.se>\n\t<20190511125533.GD4946@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190511125533.GD4946@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 06/11] test: media_device: Add test\n\tfor acquire() and release()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 11 May 2019 12:56:22 -0000"}},{"id":1605,"web_url":"https://patchwork.libcamera.org/comment/1605/","msgid":"<20190516235758.GB22849@bigcity.dyn.berto.se>","date":"2019-05-16T23:57:58","subject":"Re: [libcamera-devel] [PATCH v3 06/11] test: media_device: Add test\n\tfor acquire() and release()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your feedback.\n\nOn 2019-05-11 15:55:33 +0300, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patch.\n> \n> On Sat, May 11, 2019 at 11:19:02AM +0200, Niklas Söderlund wrote:\n> > The interfaces MediaDevice::{open,close}() are about to be made private,\n> > replace them with a test of MediaDevice::{acquire,release}() instead.\n> > The new test will implicitly tests the open() and close() methods as\n> > they are about to be move inside acquire() and release() which will\n> > remain public.\n> > \n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > test/media_device/media_device_basic.cpp | 41 +++++++++++++++++++\n> > test/media_device/media_device_print_test.cpp | 11 -----\n> > test/media_device/meson.build | 1 +\n> > 3 files changed, 42 insertions(+), 11 deletions(-)\n> > create mode 100644 test/media_device/media_device_basic.cpp\n> > \n> > diff --git a/test/media_device/media_device_basic.cpp b/test/media_device/media_device_basic.cpp\n> > new file mode 100644\n> > index 0000000000000000..ba95dd0578fce22d\n> > --- /dev/null\n> > +++ b/test/media_device/media_device_basic.cpp\n> > @@ -0,0 +1,41 @@\n> > +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> > +/*\n> > + * Copyright (C) 2019, Google Inc.\n> > + *\n> > + * media_device_basic.cpp - Test basic functions of MediaDevice\n> \n> How about renaming this file to media_device_acquire.cpp and updating\n> the description accordingly ? We can rename it to something else later\n> if we add more test.\n\nGood point, will do so for v4.\n\n> \n> > + */\n> > +\n> > +#include \"media_device_test.h\"\n> > +\n> > +using namespace libcamera;\n> > +\n> > +class MediaDeviceBasic : public MediaDeviceTest\n> > +{\n> > +\tint testAcquire()\n> > +\t{\n> > +\t\tif (!media_->acquire())\n> > +\t\t\treturn TestFail;\n> > +\n> > +\t\tif (media_->acquire())\n> > +\t\t\treturn TestFail;\n> > +\n> > +\t\tmedia_->release();\n> > +\n> > +\t\tif (!media_->acquire())\n> > +\t\t\treturn TestFail;\n> > +\n> > +\t\tmedia_->release();\n> > +\n> > +\t\treturn TestPass;\n> > +\t}\n> > +\n> > +\tint run()\n> > +\t{\n> > +\t\tif (testAcquire() != TestPass)\n> > +\t\t\treturn TestFail;\n> > +\n> > +\t\treturn TestPass;\n> > +\t}\n> > +};\n> > +\n> > +TEST_REGISTER(MediaDeviceBasic);\n> > diff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp\n> > index ceffd538e13fca73..30d929b8c76387a7 100644\n> > --- a/test/media_device/media_device_print_test.cpp\n> > +++ b/test/media_device/media_device_print_test.cpp\n> > @@ -113,17 +113,6 @@ int MediaDevicePrintTest::testMediaDevice(const string deviceNode)\n> > \tMediaDevice dev(deviceNode);\n> > \tint ret;\n> > \n> > -\t/* Fuzzy open/close sequence. */\n> > -\tret = dev.open();\n> > -\tif (ret)\n> > -\t\treturn ret;\n> > -\n> > -\tret = dev.open();\n> > -\tif (!ret)\n> > -\t\treturn ret;\n> > -\n> > -\tdev.close();\n> > -\n> > \tret = dev.populate();\n> > \tif (ret)\n> > \t\treturn ret;\n> > diff --git a/test/media_device/meson.build b/test/media_device/meson.build\n> > index 1005685409d99aa7..7a3266187abd806f 100644\n> > --- a/test/media_device/meson.build\n> > +++ b/test/media_device/meson.build\n> > @@ -1,4 +1,5 @@\n> > media_device_tests = [\n> > + ['media_device_basic', 'media_device_basic.cpp'],\n> > ['media_device_print_test', 'media_device_print_test.cpp'],\n> > ['media_device_link_test', 'media_device_link_test.cpp'],\n> > ]\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A30E760103\n\tfor ;\n\tFri, 17 May 2019 01:58:00 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id 14so4670661ljj.5\n\tfor ;\n\tThu, 16 May 2019 16:58:00 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\ty19sm1223352lfl.40.2019.05.16.16.57.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 16 May 2019 16:57:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=+FxoMoC1t1xEXgOiMHehr/1hHzeW8uf3H4ZfAW5K9JQ=;\n\tb=zfNmWziOQpwBZAYw4tcGCKUVdrlkJ5fZxUP5dj7NIZ8xNaczMMo4oV0YAf0mFhZU/g\n\tpYW/GCcgpePtIXcERmdUFBwbRDSurh7IOVIPcR8WfLzfBijomjNiA6FEcMXG9/H/PC85\n\t5/H4XA+W8UrwEgKAiMtFmlh9+nPMZMst8pWx4VZfW7BqeS8GMCmZ46L/hWOeUlu1ZErJ\n\tnlzymZN4mqJNlxvEc/9PGVELgd9SNQlJ/XC9Lts7xrNjRQevbtYxLc32dE5xRZnRhYCS\n\tJmKzQp2qLWJXuujf5oeUI4Sp3df0hDkgcpZ38pw9VGIVXRoKIl37aWYMBryLnvXI4EWG\n\t4qOQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=+FxoMoC1t1xEXgOiMHehr/1hHzeW8uf3H4ZfAW5K9JQ=;\n\tb=RioIat4zCzx5R6O/Q5xakvUNLYUiklCJ487thYSh0wb+aqUyFF5fNGTPUPwekbmZ04\n\tPGH7vuzag6Qxy4yFvmL5gjA+w91R0U75ONPKdn975dRQl2bTse0s4y0CUP3xN87ay+WE\n\tAFaqqFhwIyMMCksVtLqdH/6smCTD0Y7omzLUsuHV7NJcG1AphgQqn4ZX775voU4aP4ut\n\t06aZDwzQm5IwGaGUbYnubZFFj7/fIL4nqeDsrb+Uxr0JUd9u/Gm35THVMGmzsozgBFww\n\tDVQ9Aulp2uL33IWRbtVi1xmYV6VNwq6ZvrYwyvT4oUpbM+FBvF5KipLq87qT69VdisIx\n\tu5vQ==","X-Gm-Message-State":"APjAAAWTE3TAz4wcOMxYKGFH1Wmp629v9Q5ljurJntW2L9mxnlcXm5f+\n\tcrGDRjdwk/cdNF8fRaYJtiFZqA==","X-Google-Smtp-Source":"APXvYqxJ058lJHNpb3JkLLSSNU5doC7CDo6vHtGL+IWtmc7AlwYFappeihP/FHHvaFWFBlaTglf+Qg==","X-Received":"by 2002:a2e:3818:: with SMTP id f24mr310274lja.13.1558051079908; \n\tThu, 16 May 2019 16:57:59 -0700 (PDT)","Date":"Fri, 17 May 2019 01:57:58 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190516235758.GB22849@bigcity.dyn.berto.se>","References":"<20190511091907.10050-1-niklas.soderlund@ragnatech.se>\n\t<20190511091907.10050-7-niklas.soderlund@ragnatech.se>\n\t<20190511125533.GD4946@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190511125533.GD4946@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH v3 06/11] test: media_device: Add test\n\tfor acquire() and release()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 16 May 2019 23:58:00 -0000"}}]