[{"id":16246,"web_url":"https://patchwork.libcamera.org/comment/16246/","msgid":"","date":"2021-04-13T21:19:52","subject":"Re: [libcamera-devel] [RFC PATCH v2 4/5] libcamera: CameraSensor:\n\tAttach available test pattern modes","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Hiro\n\nOn 13/04/2021 08:50, Hirokazu Honda wrote:\n> This add available test pattern modes to libcamera to\n> CameraSensorInfo.\n> \n> Signed-off-by: Hirokazu Honda \n> ---\n> include/libcamera/internal/camera_sensor.h | 2 ++\n> src/libcamera/camera_sensor.cpp | 38 ++++++++++++++++++++++\n> 2 files changed, 40 insertions(+)\n> \n> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> index 3fa3a419..75b884db 100644\n> --- a/include/libcamera/internal/camera_sensor.h\n> +++ b/include/libcamera/internal/camera_sensor.h\n> @@ -38,6 +38,8 @@ struct CameraSensorInfo {\n> \n> \tuint32_t minFrameLength;\n> \tuint32_t maxFrameLength;\n> +\n> +\tstd::vector availableTestPatternModes;\n> };\n> \n> class CameraSensor : protected Loggable\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index c012385f..81d6af44 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -840,6 +840,44 @@ int CameraSensor::sensorInfo(CameraSensorInfo *info) const\n> \tinfo->minFrameLength = info->outputSize.height + vblank.min().get();\n> \tinfo->maxFrameLength = info->outputSize.height + vblank.max().get();\n> \n> +\tconst SensorInfo *staticInfo = SensorDatabase::get(model_);\n> +\tif (!staticInfo) {\n> +\t\tLOG(CameraSensor, Warning)\n> +\t\t\t<< \"No static properties available for '\" << model_ << \"'\";\n> +\t\tLOG(CameraSensor, Warning)\n> +\t\t\t<< \"Please consider updating the sensor database\";\n> +\t\treturn -EINVAL;\n> +\t}\n> +\n> +\tconst auto &v4l2TestPattern = controls().find(V4L2_CID_TEST_PATTERN);\n> +\tif (v4l2TestPattern == controls().end()) {\n> +\t\tLOG(CameraSensor, Error) << \"No static test pattern map for \\'\"\n> +\t\t\t\t\t << model() << \"\\'\";\n\nIs this an error? Do all sensors have to provide a test pattern?\n(Maybe they do provide them, but is it a requirement?)\n\n> +\t\treturn 0;\n> +\t}\n> +\n> +\tfor (const ControlValue &value : v4l2TestPattern->second.values()) {\n> +\t\tconst ControlMenu &menu = value.get();\n> +\t\tASSERT(menu.isName);\n> +\n> +\t\tint32_t matchedTestPattern = -1;\n> +\t\tfor (const auto &[name, testPattern] : staticInfo->testPatternModeMap) {\n> +\t\t\tif (strcmp(menu.name, name) == 0) {\n> +\t\t\t\tmatchedTestPattern = testPattern;\n> +\t\t\t\tbreak;\n> +\t\t\t}\n> +\t\t}\n> +\n> +\t\tif (matchedTestPattern != -1) {\n> +\t\t\tLOG(CameraSensor, Debug) << \"Test pattern mode named \\'\"\n> +\t\t\t\t\t\t << menu.name << \"\\' added\";\n> +\t\t\tinfo->availableTestPatternModes.push_back(matchedTestPattern);\n> +\t\t} else {\n> +\t\t\tLOG(CameraSensor, Debug) << \"Test pattern mode named \\'\"\n> +\t\t\t\t\t\t << menu.name << \"\\' ignored\";\n> +\t\t}\n> +\t}\n> +\n> \treturn 0;\n> }\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D996BBD1F6\n\tfor ;\n\tTue, 13 Apr 2021 21:19:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C0B8687FE;\n\tTue, 13 Apr 2021 23:19:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8045B602D1\n\tfor ;\n\tTue, 13 Apr 2021 23:19:55 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E6B279F0;\n\tTue, 13 Apr 2021 23:19:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TCFoJJuv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618348795;\n\tbh=WIMik9Sx66zlBfEexI5uVH+/Bx2IC0H40qE0DMd2tJM=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=TCFoJJuvLU61/H6FpLlg8idbfK93qzyzKJzQDPic46Q4d3hV9YNZ/vRMmDfPjCSqi\n\t8d3vAtNN/cONLya0EOCu+pey9npWCx67JGRcsIVWCRIaGqOTyQf4R2yXG/ejIn431d\n\tbdZNs7SlglD00A+hDp8pW/JMjhD+1TSLaJH122PI=","To":"Hirokazu Honda , libcamera-devel@lists.libcamera.org","References":"<20210413075013.3069213-1-hiroh@chromium.org>\n\t<20210413075013.3069213-5-hiroh@chromium.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 13 Apr 2021 22:19:52 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210413075013.3069213-5-hiroh@chromium.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [RFC PATCH v2 4/5] libcamera: CameraSensor:\n\tAttach available test pattern modes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"jmondi@jacopo.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16258,"web_url":"https://patchwork.libcamera.org/comment/16258/","msgid":"","date":"2021-04-14T01:49:43","subject":"Re: [libcamera-devel] [RFC PATCH v2 4/5] libcamera: CameraSensor:\n\tAttach available test pattern modes","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Kieran,\n\nOn Wed, Apr 14, 2021 at 6:19 AM Kieran Bingham\n wrote:\n>\n> Hi Hiro\n>\n> On 13/04/2021 08:50, Hirokazu Honda wrote:\n> > This add available test pattern modes to libcamera to\n> > CameraSensorInfo.\n> >\n> > Signed-off-by: Hirokazu Honda \n> > ---\n> > include/libcamera/internal/camera_sensor.h | 2 ++\n> > src/libcamera/camera_sensor.cpp | 38 ++++++++++++++++++++++\n> > 2 files changed, 40 insertions(+)\n> >\n> > diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> > index 3fa3a419..75b884db 100644\n> > --- a/include/libcamera/internal/camera_sensor.h\n> > +++ b/include/libcamera/internal/camera_sensor.h\n> > @@ -38,6 +38,8 @@ struct CameraSensorInfo {\n> >\n> > uint32_t minFrameLength;\n> > uint32_t maxFrameLength;\n> > +\n> > + std::vector availableTestPatternModes;\n> > };\n> >\n> > class CameraSensor : protected Loggable\n> > diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> > index c012385f..81d6af44 100644\n> > --- a/src/libcamera/camera_sensor.cpp\n> > +++ b/src/libcamera/camera_sensor.cpp\n> > @@ -840,6 +840,44 @@ int CameraSensor::sensorInfo(CameraSensorInfo *info) const\n> > info->minFrameLength = info->outputSize.height + vblank.min().get();\n> > info->maxFrameLength = info->outputSize.height + vblank.max().get();\n> >\n> > + const SensorInfo *staticInfo = SensorDatabase::get(model_);\n> > + if (!staticInfo) {\n> > + LOG(CameraSensor, Warning)\n> > + << \"No static properties available for '\" << model_ << \"'\";\n> > + LOG(CameraSensor, Warning)\n> > + << \"Please consider updating the sensor database\";\n> > + return -EINVAL;\n> > + }\n> > +\n> > + const auto &v4l2TestPattern = controls().find(V4L2_CID_TEST_PATTERN);\n> > + if (v4l2TestPattern == controls().end()) {\n> > + LOG(CameraSensor, Error) << \"No static test pattern map for \\'\"\n> > + << model() << \"\\'\";\n>\n> Is this an error? Do all sensors have to provide a test pattern?\n> (Maybe they do provide them, but is it a requirement?)\n>\n\nRight, since V4L2_CID_TEST_PATTERN is an optional call, this\nshould be Debug.\n\n\n> > + return 0;\n> > + }\n> > +\n> > + for (const ControlValue &value : v4l2TestPattern->second.values()) {\n> > + const ControlMenu &menu = value.get();\n> > + ASSERT(menu.isName);\n> > +\n> > + int32_t matchedTestPattern = -1;\n> > + for (const auto &[name, testPattern] : staticInfo->testPatternModeMap) {\n> > + if (strcmp(menu.name, name) == 0) {\n> > + matchedTestPattern = testPattern;\n> > + break;\n> > + }\n> > + }\n> > +\n> > + if (matchedTestPattern != -1) {\n> > + LOG(CameraSensor, Debug) << \"Test pattern mode named \\'\"\n> > + << menu.name << \"\\' added\";\n> > + info->availableTestPatternModes.push_back(matchedTestPattern);\n> > + } else {\n> > + LOG(CameraSensor, Debug) << \"Test pattern mode named \\'\"\n> > + << menu.name << \"\\' ignored\";\n> > + }\n> > + }\n> > +\n> > return 0;\n> > }\n> >\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0777CBD1F6\n\tfor ;\n\tWed, 14 Apr 2021 01:49:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 794D1602D1;\n\tWed, 14 Apr 2021 03:49:55 +0200 (CEST)","from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com\n\t[IPv6:2a00:1450:4864:20::62b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 250A6602CD\n\tfor ;\n\tWed, 14 Apr 2021 03:49:54 +0200 (CEST)","by mail-ej1-x62b.google.com with SMTP id x12so8122742ejc.1\n\tfor ;\n\tTue, 13 Apr 2021 18:49:54 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"DtuRob26\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=/fo7fQS7Nt8kynFN+Gu/HqUJ7ED433127bHL/8lmuAQ=;\n\tb=DtuRob26TB/0knlR3y9n4BrBkbhsffp4rAPT/rjn5uzyMcnJFreIiAumdhsyVD12yr\n\tKgyEO++9Iksv8nsMnEBYnlUqC2HTx25B9KRTaeYM/4VKWINj+jxvkvgCrSLzo2fLadhk\n\tAH70YvL/dvim+Er43fp+8f436pGzNdMszPN/c=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=/fo7fQS7Nt8kynFN+Gu/HqUJ7ED433127bHL/8lmuAQ=;\n\tb=tkNwMi78cxXbbMvalBU5MiaKakOdbgp69pZpcpzVZpJWW4xhlRgkYdZZsUUf1qvUO6\n\tgDjCW+Pv4GuKtrH2Zv6FCIPKoGOV09Oykp2ZYwuZLjRT3kyhowPgMj3VjHhc2+BuBD4J\n\teR1D0S47MeAAPHXv+Sq8mzSU1p4SljQCxkJE90CQIsTkf7Zw81uwE5aFdRrSw4r2yj3m\n\tTvXFer3BaCx83z7iQoOa3f8etnYpl75VyEaVwLtuLrVXkHbQ3+oxGosdbgL2tqSdwcfH\n\tAJFfOXHERCnfGzoE0Be9Zgfp2HmmeRyvpvUr3DWd1Vk/0GPob9Z61TRYj8mnvO5VN77M\n\tDfPQ==","X-Gm-Message-State":"AOAM530xGzoKQkMysCsYZuIZsYLkKRo6eHQqfxo1f8qpGTdNIHXAifUu\n\t3LDYgqhJyOM4T9zFEXjXCxP4Opk8OdI57HYlPjCTCw==","X-Google-Smtp-Source":"ABdhPJy8FyQcGOiv8NEd7/JlDzrwTXfOqiXEVnYFQQH3YV2VOnyPAPtKZvJ2yXqQ6MF93DME+Ee5we0jIZPvK/neznM=","X-Received":"by 2002:a17:906:4801:: with SMTP id\n\tw1mr35237067ejq.475.1618364993813; \n\tTue, 13 Apr 2021 18:49:53 -0700 (PDT)","MIME-Version":"1.0","References":"<20210413075013.3069213-1-hiroh@chromium.org>\n\t<20210413075013.3069213-5-hiroh@chromium.org>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Wed, 14 Apr 2021 10:49:43 +0900","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [RFC PATCH v2 4/5] libcamera: CameraSensor:\n\tAttach available test pattern modes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"jmondi@jacopo.org, libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]