[{"id":163,"web_url":"https://patchwork.libcamera.org/comment/163/","msgid":"<781c3cb7-0389-3272-a41a-8388bbb1860f@ideasonboard.com>","date":"2019-01-01T22:07:40","subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: mediadevice: Reorder\n\tfunctions in declaration order","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 01/01/2019 21:23, Laurent Pinchart wrote:\n> In order to simplify navigation in the .cpp file, order functions in the\n> declaration order in the .h file.\n> \n\nI'll not look this over as I would expect it to be a zero-code-change.\n\nAs long as that assumption is correct,\n\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  src/libcamera/media_device.cpp | 356 ++++++++++++++++-----------------\n>  1 file changed, 178 insertions(+), 178 deletions(-)\n> \n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index fd5a31746075..4c77d3787391 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -70,38 +70,6 @@ MediaDevice::~MediaDevice()\n>  \tclear();\n>  }\n>  \n> -/**\n> - * \\fn MediaDevice::driver()\n> - * \\brief Retrieve the media device driver name\n> - * \\return The name of the kernel driver that handles the MediaDevice\n> - */\n> -\n> -/**\n> - * \\fn MediaDevice::devnode()\n> - * \\brief Retrieve the media device device node path\n> - * \\return The MediaDevice devnode path\n> - */\n> -\n> -/**\n> - * \\brief Delete all media objects in the MediaDevice.\n> - *\n> - * Delete all MediaEntities; entities will then delete their pads,\n> - * and each source pad will delete links.\n> - *\n> - * After this function has been called, the media graph will be unpopulated\n> - * and its media objects deleted. The media device has to be populated\n> - * before it could be used again.\n> - */\n> -void MediaDevice::clear()\n> -{\n> -\tfor (auto const &o : objects_)\n> -\t\tdelete o.second;\n> -\n> -\tobjects_.clear();\n> -\tentities_.clear();\n> -\tvalid_ = false;\n> -}\n> -\n>  /**\n>   * \\brief Open a media device and retrieve informations from it\n>   *\n> @@ -154,152 +122,6 @@ void MediaDevice::close()\n>  \tfd_ = -1;\n>  }\n>  \n> -/**\n> - * \\fn MediaDevice::entities()\n> - * \\brief Retrieve the list of entities in the media graph\n> - * \\return The list of MediaEntities registered in the MediaDevice\n> - */\n> -\n> -/*\n> - * Add a new object to the global objects pool and fail if the object\n> - * has already been registered.\n> - */\n> -bool MediaDevice::addObject(MediaObject *obj)\n> -{\n> -\n> -\tif (objects_.find(obj->id()) != objects_.end()) {\n> -\t\tLOG(Error) << \"Element with id \" << obj->id()\n> -\t\t\t   << \" already enumerated.\";\n> -\t\treturn false;\n> -\t}\n> -\n> -\tobjects_[obj->id()] = obj;\n> -\n> -\treturn true;\n> -}\n> -\n> -/*\n> - * MediaObject pool lookup by id.\n> - */\n> -MediaObject *MediaDevice::object(unsigned int id)\n> -{\n> -\tauto it = objects_.find(id);\n> -\treturn (it == objects_.end()) ? nullptr : it->second;\n> -}\n> -\n> -/**\n> - * \\brief Return the MediaEntity with name \\a name\n> - * \\param name The entity name\n> - * \\return The entity with \\a name\n> - * \\return nullptr if no entity with \\a name is found\n> - */\n> -MediaEntity *MediaDevice::getEntityByName(const std::string &name)\n> -{\n> -\tfor (MediaEntity *e : entities_)\n> -\t\tif (e->name() == name)\n> -\t\t\treturn e;\n> -\n> -\treturn nullptr;\n> -}\n> -\n> -bool MediaDevice::populateLinks(const struct media_v2_topology &topology)\n> -{\n> -\tmedia_v2_link *mediaLinks = reinterpret_cast<media_v2_link *>\n> -\t\t\t\t    (topology.ptr_links);\n> -\n> -\tfor (unsigned int i = 0; i < topology.num_links; ++i) {\n> -\t\t/*\n> -\t\t * Skip links between entities and interfaces: we only care\n> -\t\t * about pad-2-pad links here.\n> -\t\t */\n> -\t\tif ((mediaLinks[i].flags & MEDIA_LNK_FL_LINK_TYPE) ==\n> -\t\t    MEDIA_LNK_FL_INTERFACE_LINK)\n> -\t\t\tcontinue;\n> -\n> -\t\t/* Store references to source and sink pads in the link. */\n> -\t\tunsigned int source_id = mediaLinks[i].source_id;\n> -\t\tMediaPad *source = dynamic_cast<MediaPad *>\n> -\t\t\t\t   (object(source_id));\n> -\t\tif (!source) {\n> -\t\t\tLOG(Error) << \"Failed to find pad with id: \"\n> -\t\t\t\t   << source_id;\n> -\t\t\treturn false;\n> -\t\t}\n> -\n> -\t\tunsigned int sink_id = mediaLinks[i].sink_id;\n> -\t\tMediaPad *sink = dynamic_cast<MediaPad *>\n> -\t\t\t\t (object(sink_id));\n> -\t\tif (!sink) {\n> -\t\t\tLOG(Error) << \"Failed to find pad with id: \"\n> -\t\t\t\t   << sink_id;\n> -\t\t\treturn false;\n> -\t\t}\n> -\n> -\t\tMediaLink *link = new MediaLink(&mediaLinks[i], source, sink);\n> -\t\tif (!addObject(link)) {\n> -\t\t\tdelete link;\n> -\t\t\treturn false;\n> -\t\t}\n> -\n> -\t\tsource->addLink(link);\n> -\t\tsink->addLink(link);\n> -\t}\n> -\n> -\treturn true;\n> -}\n> -\n> -bool MediaDevice::populatePads(const struct media_v2_topology &topology)\n> -{\n> -\tmedia_v2_pad *mediaPads = reinterpret_cast<media_v2_pad *>\n> -\t\t\t\t  (topology.ptr_pads);\n> -\n> -\tfor (unsigned int i = 0; i < topology.num_pads; ++i) {\n> -\t\tunsigned int entity_id = mediaPads[i].entity_id;\n> -\n> -\t\t/* Store a reference to this MediaPad in entity. */\n> -\t\tMediaEntity *mediaEntity = dynamic_cast<MediaEntity *>\n> -\t\t\t\t\t   (object(entity_id));\n> -\t\tif (!mediaEntity) {\n> -\t\t\tLOG(Error) << \"Failed to find entity with id: \"\n> -\t\t\t\t   << entity_id;\n> -\t\t\treturn false;\n> -\t\t}\n> -\n> -\t\tMediaPad *pad = new MediaPad(&mediaPads[i], mediaEntity);\n> -\t\tif (!addObject(pad)) {\n> -\t\t\tdelete pad;\n> -\t\t\treturn false;\n> -\t\t}\n> -\n> -\t\tmediaEntity->addPad(pad);\n> -\t}\n> -\n> -\treturn true;\n> -}\n> -\n> -/*\n> - * For each entity in the media graph create a MediaEntity and store a\n> - * reference in the MediaObject global pool and in the global vector of\n> - * entities.\n> - */\n> -bool MediaDevice::populateEntities(const struct media_v2_topology &topology)\n> -{\n> -\tmedia_v2_entity *mediaEntities = reinterpret_cast<media_v2_entity *>\n> -\t\t\t\t\t (topology.ptr_entities);\n> -\n> -\tfor (unsigned int i = 0; i < topology.num_entities; ++i) {\n> -\t\tMediaEntity *entity = new MediaEntity(&mediaEntities[i]);\n> -\t\tif (!addObject(entity)) {\n> -\t\t\tdelete entity;\n> -\t\t\treturn false;\n> -\t\t}\n> -\n> -\t\tentities_.push_back(entity);\n> -\t}\n> -\n> -\treturn true;\n> -}\n> -\n>  /**\n>   * \\brief Populate the media graph with media objects\n>   *\n> @@ -380,15 +202,193 @@ int MediaDevice::populate()\n>   * \\return true if the media graph is valid, false otherwise\n>   */\n>  \n> +/**\n> + * \\fn MediaDevice::driver()\n> + * \\brief Retrieve the media device driver name\n> + * \\return The name of the kernel driver that handles the MediaDevice\n> + */\n> +\n> +/**\n> + * \\fn MediaDevice::devnode()\n> + * \\brief Retrieve the media device device node path\n> + * \\return The MediaDevice devnode path\n> + */\n> +\n> +/**\n> + * \\fn MediaDevice::entities()\n> + * \\brief Retrieve the list of entities in the media graph\n> + * \\return The list of MediaEntities registered in the MediaDevice\n> + */\n> +\n> +/**\n> + * \\brief Return the MediaEntity with name \\a name\n> + * \\param name The entity name\n> + * \\return The entity with \\a name\n> + * \\return nullptr if no entity with \\a name is found\n> + */\n> +MediaEntity *MediaDevice::getEntityByName(const std::string &name)\n> +{\n> +\tfor (MediaEntity *e : entities_)\n> +\t\tif (e->name() == name)\n> +\t\t\treturn e;\n> +\n> +\treturn nullptr;\n> +}\n> +\n>  /**\n>   * \\var MediaDevice::objects_\n>   * \\brief Global map of media objects (entities, pads, links) keyed by their\n>   * object id.\n>   */\n>  \n> +/*\n> + * MediaObject pool lookup by id.\n> + */\n> +MediaObject *MediaDevice::object(unsigned int id)\n> +{\n> +\tauto it = objects_.find(id);\n> +\treturn (it == objects_.end()) ? nullptr : it->second;\n> +}\n> +\n> +/*\n> + * Add a new object to the global objects pool and fail if the object\n> + * has already been registered.\n> + */\n> +bool MediaDevice::addObject(MediaObject *obj)\n> +{\n> +\n> +\tif (objects_.find(obj->id()) != objects_.end()) {\n> +\t\tLOG(Error) << \"Element with id \" << obj->id()\n> +\t\t\t   << \" already enumerated.\";\n> +\t\treturn false;\n> +\t}\n> +\n> +\tobjects_[obj->id()] = obj;\n> +\n> +\treturn true;\n> +}\n> +\n> +/**\n> + * \\brief Delete all media objects in the MediaDevice.\n> + *\n> + * Delete all MediaEntities; entities will then delete their pads,\n> + * and each source pad will delete links.\n> + *\n> + * After this function has been called, the media graph will be unpopulated\n> + * and its media objects deleted. The media device has to be populated\n> + * before it could be used again.\n> + */\n> +void MediaDevice::clear()\n> +{\n> +\tfor (auto const &o : objects_)\n> +\t\tdelete o.second;\n> +\n> +\tobjects_.clear();\n> +\tentities_.clear();\n> +\tvalid_ = false;\n> +}\n> +\n>  /**\n>   * \\var MediaDevice::entities_\n>   * \\brief Global list of media entities in the media graph\n>   */\n>  \n> +/*\n> + * For each entity in the media graph create a MediaEntity and store a\n> + * reference in the MediaObject global pool and in the global vector of\n> + * entities.\n> + */\n> +bool MediaDevice::populateEntities(const struct media_v2_topology &topology)\n> +{\n> +\tmedia_v2_entity *mediaEntities = reinterpret_cast<media_v2_entity *>\n> +\t\t\t\t\t (topology.ptr_entities);\n> +\n> +\tfor (unsigned int i = 0; i < topology.num_entities; ++i) {\n> +\t\tMediaEntity *entity = new MediaEntity(&mediaEntities[i]);\n> +\t\tif (!addObject(entity)) {\n> +\t\t\tdelete entity;\n> +\t\t\treturn false;\n> +\t\t}\n> +\n> +\t\tentities_.push_back(entity);\n> +\t}\n> +\n> +\treturn true;\n> +}\n> +\n> +bool MediaDevice::populatePads(const struct media_v2_topology &topology)\n> +{\n> +\tmedia_v2_pad *mediaPads = reinterpret_cast<media_v2_pad *>\n> +\t\t\t\t  (topology.ptr_pads);\n> +\n> +\tfor (unsigned int i = 0; i < topology.num_pads; ++i) {\n> +\t\tunsigned int entity_id = mediaPads[i].entity_id;\n> +\n> +\t\t/* Store a reference to this MediaPad in entity. */\n> +\t\tMediaEntity *mediaEntity = dynamic_cast<MediaEntity *>\n> +\t\t\t\t\t   (object(entity_id));\n> +\t\tif (!mediaEntity) {\n> +\t\t\tLOG(Error) << \"Failed to find entity with id: \"\n> +\t\t\t\t   << entity_id;\n> +\t\t\treturn false;\n> +\t\t}\n> +\n> +\t\tMediaPad *pad = new MediaPad(&mediaPads[i], mediaEntity);\n> +\t\tif (!addObject(pad)) {\n> +\t\t\tdelete pad;\n> +\t\t\treturn false;\n> +\t\t}\n> +\n> +\t\tmediaEntity->addPad(pad);\n> +\t}\n> +\n> +\treturn true;\n> +}\n> +\n> +bool MediaDevice::populateLinks(const struct media_v2_topology &topology)\n> +{\n> +\tmedia_v2_link *mediaLinks = reinterpret_cast<media_v2_link *>\n> +\t\t\t\t    (topology.ptr_links);\n> +\n> +\tfor (unsigned int i = 0; i < topology.num_links; ++i) {\n> +\t\t/*\n> +\t\t * Skip links between entities and interfaces: we only care\n> +\t\t * about pad-2-pad links here.\n> +\t\t */\n> +\t\tif ((mediaLinks[i].flags & MEDIA_LNK_FL_LINK_TYPE) ==\n> +\t\t    MEDIA_LNK_FL_INTERFACE_LINK)\n> +\t\t\tcontinue;\n> +\n> +\t\t/* Store references to source and sink pads in the link. */\n> +\t\tunsigned int source_id = mediaLinks[i].source_id;\n> +\t\tMediaPad *source = dynamic_cast<MediaPad *>\n> +\t\t\t\t   (object(source_id));\n> +\t\tif (!source) {\n> +\t\t\tLOG(Error) << \"Failed to find pad with id: \"\n> +\t\t\t\t   << source_id;\n> +\t\t\treturn false;\n> +\t\t}\n> +\n> +\t\tunsigned int sink_id = mediaLinks[i].sink_id;\n> +\t\tMediaPad *sink = dynamic_cast<MediaPad *>\n> +\t\t\t\t (object(sink_id));\n> +\t\tif (!sink) {\n> +\t\t\tLOG(Error) << \"Failed to find pad with id: \"\n> +\t\t\t\t   << sink_id;\n> +\t\t\treturn false;\n> +\t\t}\n> +\n> +\t\tMediaLink *link = new MediaLink(&mediaLinks[i], source, sink);\n> +\t\tif (!addObject(link)) {\n> +\t\t\tdelete link;\n> +\t\t\treturn false;\n> +\t\t}\n> +\n> +\t\tsource->addLink(link);\n> +\t\tsink->addLink(link);\n> +\t}\n> +\n> +\treturn true;\n> +}\n> +\n>  } /* namespace libcamera */\n>","headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B18F560B31\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  1 Jan 2019 23:07:43 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BC746505;\n\tTue,  1 Jan 2019 23:07:42 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546380463;\n\tbh=ampr7qlLaQLFaY5nC7wizTWgxRpRQJS3QcFa3Weseu8=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=diKkfivm6FCQWJRDnDMaqowmfTRM62FJIPPM8kaezCYfssM1o8w1m2xe3BBkRQ3Dg\n\tWNLlC4sroSwJrH5KmGcm0pSBc2X1rkWhSFSlBfD8U7N74F8PEPW1fq1LzkDwcKfPms\n\tw7qhQDU7iOeplcIHqO/No9g+76lGB6p+2qrm6KUI=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190101212328.18361-1-laurent.pinchart@ideasonboard.com>\n\t<20190101212328.18361-3-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<781c3cb7-0389-3272-a41a-8388bbb1860f@ideasonboard.com>","Date":"Tue, 1 Jan 2019 22:07:40 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1","MIME-Version":"1.0","In-Reply-To":"<20190101212328.18361-3-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: mediadevice: Reorder\n\tfunctions in declaration order","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 01 Jan 2019 22:07:43 -0000"}}]