[{"id":16255,"web_url":"https://patchwork.libcamera.org/comment/16255/","msgid":"<38955e09-06c4-8775-6894-aea67eaa9d9a@ideasonboard.com>","date":"2021-04-13T22:32:39","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: V4L2Device: Use\n\tstd::vector in updateControls()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Hiro,\n\nOn 13/04/2021 07:19, Hirokazu Honda wrote:\n> V4L2Device::updateControls() takes two arguments, raw array and\n> its size, for the v4l2_ext_control values. This replaces it with\n> std::vector.\n\nThis patch does more than just replace the raw array for the vector\nlike-for-like.\n\nIt also changes the processing of how the controls are searched and\niterated.\n\nThat should be documented here, if it's still appropriate - though to\nease things - it might be clearer/easier to have the change to a vector\ndirectly, and then fix up the parsing if that's a specific improvement.\n\n\n> \n> Signed-off-by: Hirokazu Honda \n> ---\n> include/libcamera/internal/v4l2_device.h | 3 +-\n> src/libcamera/v4l2_device.cpp | 36 +++++++++++++-----------\n> 2 files changed, 20 insertions(+), 19 deletions(-)\n> \n> diff --git a/include/libcamera/internal/v4l2_device.h b/include/libcamera/internal/v4l2_device.h\n> index d006bf68..4cce3840 100644\n> --- a/include/libcamera/internal/v4l2_device.h\n> +++ b/include/libcamera/internal/v4l2_device.h\n> @@ -55,8 +55,7 @@ protected:\n> private:\n> \tvoid listControls();\n> \tvoid updateControls(ControlList *ctrls,\n> -\t\t\t const struct v4l2_ext_control *v4l2Ctrls,\n> -\t\t\t unsigned int count);\n> +\t\t\t const std::vector &v4l2Ctrls);\n> \n> \tvoid eventAvailable(EventNotifier *notifier);\n> \n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index 8625dde8..8f29cd7f 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -251,7 +251,7 @@ ControlList V4L2Device::getControls(const std::vector &ids)\n> \t\tv4l2Ctrls.resize(errorIdx);\n> \t}\n> \n> -\tupdateControls(&ctrls, v4l2Ctrls.data(), v4l2Ctrls.size());\n> +\tupdateControls(&ctrls, v4l2Ctrls);\n> \n> \treturn ctrls;\n> }\n> @@ -353,7 +353,7 @@ int V4L2Device::setControls(ControlList *ctrls)\n> \t\tret = errorIdx;\n> \t}\n> \n> -\tupdateControls(ctrls, v4l2Ctrls.data(), v4l2Ctrls.size());\n> +\tupdateControls(ctrls, v4l2Ctrls);\n> \n> \treturn ret;\n> }\n> @@ -517,25 +517,27 @@ void V4L2Device::listControls()\n> * values in \\a v4l2Ctrls\n> * \\param[inout] ctrls List of V4L2 controls to update\n> * \\param[in] v4l2Ctrls List of V4L2 extended controls as returned by the driver\n> - * \\param[in] count The number of controls to update\n> */\n> void V4L2Device::updateControls(ControlList *ctrls,\n> -\t\t\t\tconst struct v4l2_ext_control *v4l2Ctrls,\n> -\t\t\t\tunsigned int count)\n> +\t\t\t\tconst std::vector &v4l2Ctrls)\n> {\n> -\tunsigned int i = 0;\n> -\tfor (auto &ctrl : *ctrls) {\n> -\t\tif (i == count)\n> -\t\t\tbreak;\n> +\tfor (const v4l2_ext_control &v4l2Ctrl : v4l2Ctrls) {\n> +\t\tif (!ctrls->contains(v4l2Ctrl.id)) {\n> +\t\t\tLOG(V4L2, Error) << \"Unknown id: \" << v4l2Ctrl.id;\n> +\t\t\tcontinue;\n> +\t\t}\n\nHrm, are these extra validation checks?\nor is it because we've inverted the search now?\n\n> -\t\tconst struct v4l2_ext_control *v4l2Ctrl = &v4l2Ctrls[i];\n> -\t\tunsigned int id = ctrl.first;\n> -\t\tControlValue &value = ctrl.second;\n> +\t\tconst auto it = controls_.find(v4l2Ctrl.id);\n> +\t\tif (it == controls_.end()) {\n> +\t\t\tLOG(V4L2, Error) << \"Unknown id: \" << v4l2Ctrl.id;\n> +\t\t\tcontinue;\n> +\t\t}\n> \n> -\t\tconst auto iter = controls_.find(id);\n> -\t\tswitch (iter->first->type()) {\n> +\t\tconst ControlValue &value = ctrls->get(v4l2Ctrl.id);\n> +\t\tControlValue newValue = value;\n> +\t\tswitch (it->first->type()) {\n> \t\tcase ControlTypeInteger64:\n> -\t\t\tvalue.set(v4l2Ctrl->value64);\n> +\t\t\tnewValue.set(v4l2Ctrl.value64);\n> \t\t\tbreak;\n> \n> \t\tcase ControlTypeByte:\n> @@ -550,11 +552,11 @@ void V4L2Device::updateControls(ControlList *ctrls,\n> \t\t\t * \\todo To be changed when support for string controls\n> \t\t\t * will be added.\n> \t\t\t */\n> -\t\t\tvalue.set(v4l2Ctrl->value);\n> +\t\t\tnewValue.set(v4l2Ctrl.value);\n> \t\t\tbreak;\n> \t\t}\n> \n> -\t\ti++;\n> +\t\tctrls->set(v4l2Ctrl.id, newValue);\n\nIt's quite hard to distinguish what's going on in there.\nDoes this do more than just use a vector instead of an array ?\n\nFor instance, was ctrls.set() called previously in some other way which\nisn't jumping out at me in the diff above?\n\nAh, I suspect previously, the 'value' was the ControlValue and it was\nalready obtained because the search was through the ctrls list...\n\n\n\n> \t}\n> }\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 06F81BD224\n\tfor ;\n\tTue, 13 Apr 2021 22:32:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7AAAE687FE;\n\tWed, 14 Apr 2021 00:32:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5EB57602CD\n\tfor ;\n\tWed, 14 Apr 2021 00:32:43 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BBBB86F2;\n\tWed, 14 Apr 2021 00:32:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FzfVtpjs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618353163;\n\tbh=rrZRC9VApdKLlBynpBmaEfDFVSusfmfjWm9lsglKIHM=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=FzfVtpjsWq50oqk0TsDwrQfc4wVJhdH+J+75HVyKiyqITIzJdRVWngQW46icjQAVW\n\tB+gS6NwV8W8mUzqofJ5Uzd7e0kUXqZq6DJRJSLUC0lXG2v7wQGc+erxjGgrDN183gQ\n\tw9k6kYIIXGz4UETBtHFcqXFEdynzqZEwvrQGkalI=","To":"Hirokazu Honda , libcamera-devel@lists.libcamera.org","References":"<20210413061925.3054927-1-hiroh@chromium.org>\n\t<20210413061925.3054927-3-hiroh@chromium.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<38955e09-06c4-8775-6894-aea67eaa9d9a@ideasonboard.com>","Date":"Tue, 13 Apr 2021 23:32:39 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210413061925.3054927-3-hiroh@chromium.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: V4L2Device: Use\n\tstd::vector in updateControls()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16292,"web_url":"https://patchwork.libcamera.org/comment/16292/","msgid":"","date":"2021-04-15T04:48:05","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: V4L2Device: Use\n\tstd::vector in updateControls()","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Kieran,\n\nOn Wed, Apr 14, 2021 at 7:32 AM Kieran Bingham\n wrote:\n>\n> Hi Hiro,\n>\n> On 13/04/2021 07:19, Hirokazu Honda wrote:\n> > V4L2Device::updateControls() takes two arguments, raw array and\n> > its size, for the v4l2_ext_control values. This replaces it with\n> > std::vector.\n>\n> This patch does more than just replace the raw array for the vector\n> like-for-like.\n>\n> It also changes the processing of how the controls are searched and\n> iterated.\n>\n> That should be documented here, if it's still appropriate - though to\n> ease things - it might be clearer/easier to have the change to a vector\n> directly, and then fix up the parsing if that's a specific improvement.\n>\n>\n> >\n> > Signed-off-by: Hirokazu Honda \n> > ---\n> > include/libcamera/internal/v4l2_device.h | 3 +-\n> > src/libcamera/v4l2_device.cpp | 36 +++++++++++++-----------\n> > 2 files changed, 20 insertions(+), 19 deletions(-)\n> >\n> > diff --git a/include/libcamera/internal/v4l2_device.h b/include/libcamera/internal/v4l2_device.h\n> > index d006bf68..4cce3840 100644\n> > --- a/include/libcamera/internal/v4l2_device.h\n> > +++ b/include/libcamera/internal/v4l2_device.h\n> > @@ -55,8 +55,7 @@ protected:\n> > private:\n> > void listControls();\n> > void updateControls(ControlList *ctrls,\n> > - const struct v4l2_ext_control *v4l2Ctrls,\n> > - unsigned int count);\n> > + const std::vector &v4l2Ctrls);\n> >\n> > void eventAvailable(EventNotifier *notifier);\n> >\n> > diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> > index 8625dde8..8f29cd7f 100644\n> > --- a/src/libcamera/v4l2_device.cpp\n> > +++ b/src/libcamera/v4l2_device.cpp\n> > @@ -251,7 +251,7 @@ ControlList V4L2Device::getControls(const std::vector &ids)\n> > v4l2Ctrls.resize(errorIdx);\n> > }\n> >\n> > - updateControls(&ctrls, v4l2Ctrls.data(), v4l2Ctrls.size());\n> > + updateControls(&ctrls, v4l2Ctrls);\n> >\n> > return ctrls;\n> > }\n> > @@ -353,7 +353,7 @@ int V4L2Device::setControls(ControlList *ctrls)\n> > ret = errorIdx;\n> > }\n> >\n> > - updateControls(ctrls, v4l2Ctrls.data(), v4l2Ctrls.size());\n> > + updateControls(ctrls, v4l2Ctrls);\n> >\n> > return ret;\n> > }\n> > @@ -517,25 +517,27 @@ void V4L2Device::listControls()\n> > * values in \\a v4l2Ctrls\n> > * \\param[inout] ctrls List of V4L2 controls to update\n> > * \\param[in] v4l2Ctrls List of V4L2 extended controls as returned by the driver\n> > - * \\param[in] count The number of controls to update\n> > */\n> > void V4L2Device::updateControls(ControlList *ctrls,\n> > - const struct v4l2_ext_control *v4l2Ctrls,\n> > - unsigned int count)\n> > + const std::vector &v4l2Ctrls)\n> > {\n> > - unsigned int i = 0;\n> > - for (auto &ctrl : *ctrls) {\n> > - if (i == count)\n> > - break;\n> > + for (const v4l2_ext_control &v4l2Ctrl : v4l2Ctrls) {\n> > + if (!ctrls->contains(v4l2Ctrl.id)) {\n> > + LOG(V4L2, Error) << \"Unknown id: \" << v4l2Ctrl.id;\n> > + continue;\n> > + }\n>\n> Hrm, are these extra validation checks?\n> or is it because we've inverted the search now?\n>\n> > - const struct v4l2_ext_control *v4l2Ctrl = &v4l2Ctrls[i];\n> > - unsigned int id = ctrl.first;\n> > - ControlValue &value = ctrl.second;\n> > + const auto it = controls_.find(v4l2Ctrl.id);\n> > + if (it == controls_.end()) {\n> > + LOG(V4L2, Error) << \"Unknown id: \" << v4l2Ctrl.id;\n> > + continue;\n> > + }\n> >\n> > - const auto iter = controls_.find(id);\n> > - switch (iter->first->type()) {\n> > + const ControlValue &value = ctrls->get(v4l2Ctrl.id);\n> > + ControlValue newValue = value;\n> > + switch (it->first->type()) {\n> > case ControlTypeInteger64:\n> > - value.set(v4l2Ctrl->value64);\n> > + newValue.set(v4l2Ctrl.value64);\n> > break;\n> >\n> > case ControlTypeByte:\n> > @@ -550,11 +552,11 @@ void V4L2Device::updateControls(ControlList *ctrls,\n> > * \\todo To be changed when support for string controls\n> > * will be added.\n> > */\n> > - value.set(v4l2Ctrl->value);\n> > + newValue.set(v4l2Ctrl.value);\n> > break;\n> > }\n> >\n> > - i++;\n> > + ctrls->set(v4l2Ctrl.id, newValue);\n>\n> It's quite hard to distinguish what's going on in there.\n> Does this do more than just use a vector instead of an array ?\n>\n> For instance, was ctrls.set() called previously in some other way which\n> isn't jumping out at me in the diff above?\n>\n> Ah, I suspect previously, the 'value' was the ControlValue and it was\n> already obtained because the search was through the ctrls list...\n>\n\nThe problem is ControlList() somehow allows to return a reference or\npointer via begin-end, but somehow doesn't via find or get.\nIt is very strange that I can only change it by get & set if without begin-end.\nI separate the patch for the change except vector-array change.\nPTAL https://patchwork.libcamera.org/patch/11934/\n\nBest Regards,\n-Hiro\n\n>\n>\n> > }\n> > }\n> >\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2FF97BD1F6\n\tfor ;\n\tThu, 15 Apr 2021 04:48:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8549568812;\n\tThu, 15 Apr 2021 06:48:17 +0200 (CEST)","from mail-ed1-x536.google.com (mail-ed1-x536.google.com\n\t[IPv6:2a00:1450:4864:20::536])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54D11602C7\n\tfor ;\n\tThu, 15 Apr 2021 06:48:16 +0200 (CEST)","by mail-ed1-x536.google.com with SMTP id d21so6260365edv.9\n\tfor ;\n\tWed, 14 Apr 2021 21:48:16 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"aGu82d0T\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=qkIW6spH9z7d32RfIG6HVUUCVoNY61Uflfz6zEQbY6w=;\n\tb=aGu82d0TbOz7GqUgUrumBwtwUTOQOE+P61muQQdhHSUwSFkrMaox9d7iumMC5rIkuZ\n\tLURNlXa2P7iXElYUZbP/aVjMs2ExSQs0n1y7oElogk9Sv88IapZx/k0re1meeKRRKsHK\n\tDxCDOXwJN+NGGAZpwuAeas6lR1B8RqHJmrgoI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=qkIW6spH9z7d32RfIG6HVUUCVoNY61Uflfz6zEQbY6w=;\n\tb=BnZR7qHmIRgO/B7snZhyP6I1tar2pVQ8S8jDQ4miBy8BY8JqFmBhQ8feeRry2jq6gl\n\t3SiUXeS/qAl8+YVMjGOl/ThcArIF1SlO/scufeMAu2FNemrsKI7fcntD42M0TsMgamKv\n\taj3sfvuPU+nqbuGucpjik5hgyAvASMaato7tcee019mfLOzx4G6SUmvPwuTiYp+nIbrG\n\tT2GHw2NVLZ4TBUnLM3dtiI50G7uGGE4bTlhrBVD+EKS8k/gehKOYlKQwiYKnlnW7/ppJ\n\twE8LmiizlX8OCLHQZ4QGwfUulV5AleBGhbUmsoKt7KGENJheIjKGO7ED8Y++V9ZCPOAw\n\tNzUg==","X-Gm-Message-State":"AOAM532ePffkCmKneQ9cYCUNE9KyD8+dkgey3keiBiTtKKyYyxnyZw47\n\tcnkhpx/nZzxAE7csBVuQIyGHlQOlv0bvLzFGZf8fIhyYXzc+Aw==","X-Google-Smtp-Source":"ABdhPJwadUOVohy0d946Yjg8rFqvGu3BKjJOdEUEWw3OV8jEeA0go18/0zOkKrFosygM5+PB6IiYAKP5NKY2SLLa4uQ=","X-Received":"by 2002:a05:6402:51cd:: with SMTP id\n\tr13mr1841363edd.116.1618462095959; \n\tWed, 14 Apr 2021 21:48:15 -0700 (PDT)","MIME-Version":"1.0","References":"<20210413061925.3054927-1-hiroh@chromium.org>\n\t<20210413061925.3054927-3-hiroh@chromium.org>\n\t<38955e09-06c4-8775-6894-aea67eaa9d9a@ideasonboard.com>","In-Reply-To":"<38955e09-06c4-8775-6894-aea67eaa9d9a@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Thu, 15 Apr 2021 13:48:05 +0900","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: V4L2Device: Use\n\tstd::vector in updateControls()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]