[{"id":16253,"web_url":"https://patchwork.libcamera.org/comment/16253/","msgid":"","date":"2021-04-13T22:14:09","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: V4L2Device: Use\n\tstd::vector for v4l2_ext_control in setControls()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Hiro,\n\nOn 13/04/2021 07:19, Hirokazu Honda wrote:\n> The original code uses Variable-Length-Array, which is not\n> officially supported in C++. This replaces the array with\n> std::vector.\n> ---\n> src/libcamera/v4l2_device.cpp | 18 +++++++++---------\n> 1 file changed, 9 insertions(+), 9 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index 78c289c2..8625dde8 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -280,12 +280,11 @@ ControlList V4L2Device::getControls(const std::vector &ids)\n> */\n> int V4L2Device::setControls(ControlList *ctrls)\n> {\n> -\tunsigned int count = ctrls->size();\n> -\tif (count == 0)\n> +\tif (ctrls->empty())\n> \t\treturn 0;\n> \n> -\tstruct v4l2_ext_control v4l2Ctrls[count];\n> -\tmemset(v4l2Ctrls, 0, sizeof(v4l2Ctrls));\n> +\tstd::vector v4l2Ctrls(ctrls->size());\n> +\tmemset(v4l2Ctrls.data(), 0, v4l2Ctrls.size());\n\nDoes the vector not initialise in anyway ?\n\nLooking at https://www.cplusplus.com/reference/vector/vector/vector/\nthis must be using the fill(2) constructor.\n\nI suspect if nothing is provided, it won't fill, so perhaps it's not\ninitialised, but if that's the case, I wonder if the right way to\nconstruct this is more like:\n\n\tstd::vector v4l2Ctrls(ctrls->size(), {});\n\nBut I'm not particular certain.\n\nOtherwise, this looks Ok to me...\n\nReviewed-by: Kieran Bingham \n\n> \n> \tunsigned int i = 0;\n> \tfor (auto &ctrl : *ctrls) {\n> @@ -332,15 +331,15 @@ int V4L2Device::setControls(ControlList *ctrls)\n> \n> \tstruct v4l2_ext_controls v4l2ExtCtrls = {};\n> \tv4l2ExtCtrls.which = V4L2_CTRL_WHICH_CUR_VAL;\n> -\tv4l2ExtCtrls.controls = v4l2Ctrls;\n> -\tv4l2ExtCtrls.count = count;\n> +\tv4l2ExtCtrls.controls = v4l2Ctrls.data();\n> +\tv4l2ExtCtrls.count = v4l2Ctrls.size();\n> \n> \tint ret = ioctl(VIDIOC_S_EXT_CTRLS, &v4l2ExtCtrls);\n> \tif (ret) {\n> \t\tunsigned int errorIdx = v4l2ExtCtrls.error_idx;\n> \n> \t\t/* Generic validation error. */\n> -\t\tif (errorIdx == 0 || errorIdx >= count) {\n> +\t\tif (errorIdx == 0 || errorIdx >= v4l2Ctrls.size()) {\n> \t\t\tLOG(V4L2, Error) << \"Unable to set controls: \"\n> \t\t\t\t\t << strerror(-ret);\n> \t\t\treturn -EINVAL;\n> @@ -349,11 +348,12 @@ int V4L2Device::setControls(ControlList *ctrls)\n> \t\t/* A specific control failed. */\n> \t\tLOG(V4L2, Error) << \"Unable to set control \" << errorIdx\n> \t\t\t\t << \": \" << strerror(-ret);\n> -\t\tcount = errorIdx - 1;\n> +\n> +\t\tv4l2Ctrls.resize(errorIdx);\n> \t\tret = errorIdx;\n> \t}\n> \n> -\tupdateControls(ctrls, v4l2Ctrls, count);\n> +\tupdateControls(ctrls, v4l2Ctrls.data(), v4l2Ctrls.size());\n> \n> \treturn ret;\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97A91BD224\n\tfor ;\n\tTue, 13 Apr 2021 22:14:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0346E687FE;\n\tWed, 14 Apr 2021 00:14:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99664602CD\n\tfor ;\n\tWed, 14 Apr 2021 00:14:12 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EA95E6F2;\n\tWed, 14 Apr 2021 00:14:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dGw+S6No\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618352052;\n\tbh=BZUJuNITDbybrXU/iAQ0s9RPBpHPTs2it8Qp0TTwVN4=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=dGw+S6NoUJN6QPO09g0YZltirWYXG4t6Nosel5SLkPBHLFv2u8Ka1up7G/Ei6bO6k\n\tmgIgrzT1ma5fHcGG1a+JfhqTm84SAOM/wSR3wvte9fOP2uOl4RVwLxEqCkaBv36yg5\n\t06y+4r+0YWMNG1C8YKYuShkFpvYSIPITAxk7w/R4=","To":"Hirokazu Honda , libcamera-devel@lists.libcamera.org","References":"<20210413061925.3054927-1-hiroh@chromium.org>\n\t<20210413061925.3054927-2-hiroh@chromium.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 13 Apr 2021 23:14:09 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210413061925.3054927-2-hiroh@chromium.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: V4L2Device: Use\n\tstd::vector for v4l2_ext_control in setControls()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16291,"web_url":"https://patchwork.libcamera.org/comment/16291/","msgid":"","date":"2021-04-15T03:58:42","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: V4L2Device: Use\n\tstd::vector for v4l2_ext_control in setControls()","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"On Wed, Apr 14, 2021 at 7:14 AM Kieran Bingham\n wrote:\n>\n> Hi Hiro,\n>\n> On 13/04/2021 07:19, Hirokazu Honda wrote:\n> > The original code uses Variable-Length-Array, which is not\n> > officially supported in C++. This replaces the array with\n> > std::vector.\n> > ---\n> > src/libcamera/v4l2_device.cpp | 18 +++++++++---------\n> > 1 file changed, 9 insertions(+), 9 deletions(-)\n> >\n> > diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> > index 78c289c2..8625dde8 100644\n> > --- a/src/libcamera/v4l2_device.cpp\n> > +++ b/src/libcamera/v4l2_device.cpp\n> > @@ -280,12 +280,11 @@ ControlList V4L2Device::getControls(const std::vector &ids)\n> > */\n> > int V4L2Device::setControls(ControlList *ctrls)\n> > {\n> > - unsigned int count = ctrls->size();\n> > - if (count == 0)\n> > + if (ctrls->empty())\n> > return 0;\n> >\n> > - struct v4l2_ext_control v4l2Ctrls[count];\n> > - memset(v4l2Ctrls, 0, sizeof(v4l2Ctrls));\n> > + std::vector v4l2Ctrls(ctrls->size());\n> > + memset(v4l2Ctrls.data(), 0, v4l2Ctrls.size());\n>\n> Does the vector not initialise in anyway ?\n>\n> Looking at https://www.cplusplus.com/reference/vector/vector/vector/\n> this must be using the fill(2) constructor.\n>\n> I suspect if nothing is provided, it won't fill, so perhaps it's not\n> initialised, but if that's the case, I wonder if the right way to\n> construct this is more like:\n>\n> std::vector v4l2Ctrls(ctrls->size(), {});\n\nAs replied to 1/3, I don't trust the zero initialization by {}.\nSo I would rather use std::memset.\n\nBest Regards,\n-Hiro\n>\n> But I'm not particular certain.\n>\n> Otherwise, this looks Ok to me...\n>\n> Reviewed-by: Kieran Bingham \n>\n> >\n> > unsigned int i = 0;\n> > for (auto &ctrl : *ctrls) {\n> > @@ -332,15 +331,15 @@ int V4L2Device::setControls(ControlList *ctrls)\n> >\n> > struct v4l2_ext_controls v4l2ExtCtrls = {};\n> > v4l2ExtCtrls.which = V4L2_CTRL_WHICH_CUR_VAL;\n> > - v4l2ExtCtrls.controls = v4l2Ctrls;\n> > - v4l2ExtCtrls.count = count;\n> > + v4l2ExtCtrls.controls = v4l2Ctrls.data();\n> > + v4l2ExtCtrls.count = v4l2Ctrls.size();\n> >\n> > int ret = ioctl(VIDIOC_S_EXT_CTRLS, &v4l2ExtCtrls);\n> > if (ret) {\n> > unsigned int errorIdx = v4l2ExtCtrls.error_idx;\n> >\n> > /* Generic validation error. */\n> > - if (errorIdx == 0 || errorIdx >= count) {\n> > + if (errorIdx == 0 || errorIdx >= v4l2Ctrls.size()) {\n> > LOG(V4L2, Error) << \"Unable to set controls: \"\n> > << strerror(-ret);\n> > return -EINVAL;\n> > @@ -349,11 +348,12 @@ int V4L2Device::setControls(ControlList *ctrls)\n> > /* A specific control failed. */\n> > LOG(V4L2, Error) << \"Unable to set control \" << errorIdx\n> > << \": \" << strerror(-ret);\n> > - count = errorIdx - 1;\n> > +\n> > + v4l2Ctrls.resize(errorIdx);\n> > ret = errorIdx;\n> > }\n> >\n> > - updateControls(ctrls, v4l2Ctrls, count);\n> > + updateControls(ctrls, v4l2Ctrls.data(), v4l2Ctrls.size());\n> >\n> > return ret;\n> > }\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5115BD1F6\n\tfor ;\n\tThu, 15 Apr 2021 03:58:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E18068812;\n\tThu, 15 Apr 2021 05:58:55 +0200 (CEST)","from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n\t[IPv6:2a00:1450:4864:20::632])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 534BD602C7\n\tfor ;\n\tThu, 15 Apr 2021 05:58:54 +0200 (CEST)","by mail-ej1-x632.google.com with SMTP id u21so34679276ejo.13\n\tfor ;\n\tWed, 14 Apr 2021 20:58:54 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Onw1xrTn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=B/4V2f5kOjcMzBZTl4EyRYkCOJHJJNIy1+CdQewQnrk=;\n\tb=Onw1xrTnIEEJs297PpmhJFwqVXGE+k1GTNwY0cQK98G3+Doov0INwyFaNh0oY/Rsew\n\t9XTvRplEsejcrfCT+jd2rJzqJ/t4e/NxrOYUbc5KNiIurD3lsWtyGRP4ZEomIMEoNUG/\n\tbIcPo8RlUiVTP9rHdF1/WT6qhYzRFRPsAsEwc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=B/4V2f5kOjcMzBZTl4EyRYkCOJHJJNIy1+CdQewQnrk=;\n\tb=hrIAQWozn8Q3nO0NJ0ynNe4wXo8E+vfa4XO5DpfBPodrB+Rh1ESXjJunjFgadDzOuw\n\tgruoFduS0Nnm22Y6yM++fiqBgENWclWkbGE36Hnz568pmZ0HAEXgle2RcRCqa9Dq8bUg\n\tcVIIhaJ2ivDylw4TBAxLms9Dc1ZYJkBQtzI3kzzU5sFNqgB6J/2km3HZ3omlAqMSNskE\n\twArczWvh11bABDe5wUph45TLGV9Y4zPApjwpWjuv5a6FYtjLaaRkINW1AbOALV0w6owV\n\tQ226iGYnYDu8yzoIdfoFRmaST3/Hvy5WaLa7ANGbrOpg4VXGtrDGY/Wx5uADQPwdJtK7\n\tUcOA==","X-Gm-Message-State":"AOAM533AqgZlGpabgWce3A6gUTH6yi6jo0QyBdZB2/D694ho9x1IKJoM\n\tauxjsOj/UrdU0HBxxEOfVWxPy9VajR4KR81b/Vc7ddR+AzA=","X-Google-Smtp-Source":"ABdhPJy2wQiPAAmdkCQNUcc4gxnJGFlErCFmFoOXKmt9TR5lxLETKsr5WnIoFIvn6tu70GQQw6L1Ukh4wiAuaBRIJLo=","X-Received":"by 2002:a17:906:80d1:: with SMTP id\n\ta17mr1305522ejx.55.1618459133974; \n\tWed, 14 Apr 2021 20:58:53 -0700 (PDT)","MIME-Version":"1.0","References":"<20210413061925.3054927-1-hiroh@chromium.org>\n\t<20210413061925.3054927-2-hiroh@chromium.org>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Thu, 15 Apr 2021 12:58:42 +0900","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: V4L2Device: Use\n\tstd::vector for v4l2_ext_control in setControls()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]