{"id":11894,"url":"https://patchwork.libcamera.org/api/patches/11894/?format=json","web_url":"https://patchwork.libcamera.org/patch/11894/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210413002731.25653-2-laurent.pinchart@ideasonboard.com>","date":"2021-04-13T00:27:30","name":"[libcamera-devel,1/2] test: span: Add tests for begin() and rend()","commit_ref":"c244d07286e4010ee884eeea6f8e67fa5d1ff3cb","pull_url":null,"state":"accepted","archived":false,"hash":"f49f6f29bbe21a55c253ebfe909654ca631d2cbc","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11894/mbox/","series":[{"id":1914,"url":"https://patchwork.libcamera.org/api/series/1914/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1914","date":"2021-04-13T00:27:29","name":"libcamera: Fix Span reverse iterators","version":1,"mbox":"https://patchwork.libcamera.org/series/1914/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11894/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11894/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F7DEBD1F6\n\tfor ;\n\tTue, 13 Apr 2021 00:28:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4456F68801;\n\tTue, 13 Apr 2021 02:28:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0591A605AE\n\tfor ;\n\tTue, 13 Apr 2021 02:28:25 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9AC0E89A\n\tfor ;\n\tTue, 13 Apr 2021 02:28:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"N2yg3PJw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618273704;\n\tbh=qu3oIzQMbwzG76RUg2C67O0n2Jy4ndzX3o2fefY6PAQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=N2yg3PJwuLyHbMbFy7P6Tn82zl2nkPWbW/ogXA28g+t/IL5aSPSMgIIOU+iXgtVCN\n\tvqVHq9BuTuFSvOzQPL6Gui1bqiyt62Vuau3DSmRMqTHuE5eeeZVi7pCiaU3GiojH0s\n\trjD2o+OZVbVj4PsKm22rNR+uW6AkbzKXOXtWhhcE=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 13 Apr 2021 03:27:30 +0300","Message-Id":"<20210413002731.25653-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.28.1","In-Reply-To":"<20210413002731.25653-1-laurent.pinchart@ideasonboard.com>","References":"<20210413002731.25653-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 1/2] test: span: Add tests for begin() and\n\trend()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Verify that the begin() and rend() iterators (and their const version)\nreference the correct values. The end() and rbegin() iterators can't be\ntested the same way as they're not dereferenceable.\n\nSigned-off-by: Laurent Pinchart \n---\n test/span.cpp | 40 ++++++++++++++++++++++++++++++++--------\n 1 file changed, 32 insertions(+), 8 deletions(-)","diff":"diff --git a/test/span.cpp b/test/span.cpp\nindex d60b769c9877..ca037c8f02fa 100644\n--- a/test/span.cpp\n+++ b/test/span.cpp\n@@ -72,12 +72,24 @@ protected:\n \n \t\tstaticSpan = Span{ v };\n \n-\t\tstaticSpan.begin();\n-\t\tstaticSpan.cbegin();\n+\t\tif (*staticSpan.begin() != 1) {\n+\t\t\tstd::cout << \"Span::begin() failed\" << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\t\tif (*staticSpan.cbegin() != 1) {\n+\t\t\tstd::cout << \"Span::cbegin() failed\" << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n \t\tstaticSpan.end();\n \t\tstaticSpan.cend();\n-\t\tstaticSpan.rbegin();\n-\t\tstaticSpan.crbegin();\n+\t\tif (*staticSpan.rbegin() != 4) {\n+\t\t\tstd::cout << \"Span::rbegin() failed\" << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\t\tif (*staticSpan.crbegin() != 4) {\n+\t\t\tstd::cout << \"Span::crbegin() failed\" << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n \t\tstaticSpan.rend();\n \t\tstaticSpan.crend();\n \n@@ -141,12 +153,24 @@ protected:\n \n \t\tdynamicSpan = Span{ a };\n \n-\t\tdynamicSpan.begin();\n-\t\tdynamicSpan.cbegin();\n+\t\tif (*dynamicSpan.begin() != 1) {\n+\t\t\tstd::cout << \"Span::begin() failed\" << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\t\tif (*dynamicSpan.cbegin() != 1) {\n+\t\t\tstd::cout << \"Span::cbegin() failed\" << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n \t\tdynamicSpan.end();\n \t\tdynamicSpan.cend();\n-\t\tdynamicSpan.rbegin();\n-\t\tdynamicSpan.crbegin();\n+\t\tif (*dynamicSpan.rbegin() != 4) {\n+\t\t\tstd::cout << \"Span::rbegin() failed\" << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\t\tif (*dynamicSpan.crbegin() != 4) {\n+\t\t\tstd::cout << \"Span::crbegin() failed\" << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n \t\tdynamicSpan.rend();\n \t\tdynamicSpan.crend();\n \n","prefixes":["libcamera-devel","1/2"]}