[{"id":16190,"web_url":"https://patchwork.libcamera.org/comment/16190/","msgid":"<c2df179f-1e9c-203d-6f1a-396afb8a53f0@ideasonboard.com>","date":"2021-04-12T20:03:43","subject":"Re: [libcamera-devel] [PATCH] pipeline: rkisp1: Add check for\n\tnon-existent frame info","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Sebastian,\n\nOn 11/04/2021 17:48, Sebastian Fricke wrote:\n> Add a check, that makes sure that the given FrameBuffer is associated\n> to a RkISP1FrameInfo instance. The current code tries to access the\n> frame info without checking if it actually exists.\n> \n> Fixes: 0eb65e14e libcamera: pipeline: rkisp1: Attach to an IPA\n> \n> Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net>\n> ---\n>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 ++\n>  1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 03757327..eca7d608 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1079,6 +1079,8 @@ void PipelineHandlerRkISP1::paramReady(FrameBuffer *buffer)\n>  \tRkISP1CameraData *data = cameraData(activeCamera_);\n>  \n>  \tRkISP1FrameInfo *info = data->frameInfo_.find(buffer);\n> +\tif (!info)\n> +\t\treturn;\n\nIf the frameInfo can't find what it's looking for, then that should be a\nfatal error (if it's not already) ... but even if it's Fatal, I think\nit's best to make sure the return paths on FATAL's are handled as we may\nchoose to cause FATAL to not assert in non-debug builds.\n\nAlong with that, other code paths do check this and return accordingly,\nso this improves consistency.\n\n\nSo\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n>  \n>  \tinfo->paramDequeued = true;\n>  \ttryCompleteRequest(info->request);\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB2F6BD224\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 12 Apr 2021 20:03:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 13DF1687F6;\n\tMon, 12 Apr 2021 22:03:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AFE41602CD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 12 Apr 2021 22:03:46 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1C1113F0;\n\tMon, 12 Apr 2021 22:03:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IkAnYMfi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618257826;\n\tbh=qvVe5vIi4qPvGQ16zICvyHzzUkJ/+ytmulNDehotevE=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=IkAnYMfiW9fwQJ+uZk3VkXC+To5CBPxTGGz9+8EB7cO9bvZBffrqJPIc4+Fcc69TD\n\tR34kw8dT8VPIM2Oj7TAA52c51OshhBwDsoqrzLGz0CEuntJ2SUouVJMD75tIUJe0xo\n\tM2QCCOuHUjRojEpbjj63Jjb8KvtEQl25ARtrivkQ=","To":"Sebastian Fricke <sebastian.fricke@posteo.net>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210411164858.29961-1-sebastian.fricke@posteo.net>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<c2df179f-1e9c-203d-6f1a-396afb8a53f0@ideasonboard.com>","Date":"Mon, 12 Apr 2021 21:03:43 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210411164858.29961-1-sebastian.fricke@posteo.net>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] pipeline: rkisp1: Add check for\n\tnon-existent frame info","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":16742,"web_url":"https://patchwork.libcamera.org/comment/16742/","msgid":"<20210503115121.ar5s7r2xpw7yiw4c@basti-TUXEDO-Book-XA1510>","date":"2021-05-03T11:51:21","subject":"Re: [libcamera-devel] [PATCH] pipeline: rkisp1: Add check for\n\tnon-existent frame info","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"Hey,\n\nslight push .. :)\n\nOn 11.04.2021 18:48, Sebastian Fricke wrote:\n>Add a check, that makes sure that the given FrameBuffer is associated\n>to a RkISP1FrameInfo instance. The current code tries to access the\n>frame info without checking if it actually exists.\n>\n>Fixes: 0eb65e14e libcamera: pipeline: rkisp1: Attach to an IPA\n>\n>Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n>diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>index 03757327..eca7d608 100644\n>--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>@@ -1079,6 +1079,8 @@ void PipelineHandlerRkISP1::paramReady(FrameBuffer *buffer)\n> \tRkISP1CameraData *data = cameraData(activeCamera_);\n>\n> \tRkISP1FrameInfo *info = data->frameInfo_.find(buffer);\n>+\tif (!info)\n>+\t\treturn;\n>\n> \tinfo->paramDequeued = true;\n> \ttryCompleteRequest(info->request);\n>-- \n>2.25.1\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D343BDE77\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  3 May 2021 11:51:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AAE176890C;\n\tMon,  3 May 2021 13:51:25 +0200 (CEST)","from mout01.posteo.de (mout01.posteo.de [185.67.36.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E09BD60511\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  3 May 2021 13:51:23 +0200 (CEST)","from submission (posteo.de [89.146.220.130]) \n\tby mout01.posteo.de (Postfix) with ESMTPS id 774AA24002F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  3 May 2021 13:51:23 +0200 (CEST)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4FYhBy3kk2z9rxY;\n\tMon,  3 May 2021 13:51:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"n8NJTQtk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1620042683; bh=ya5UehNtyi2dg7NEpjGXl3BwSNMQSFZ2nfooA1oIbgA=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=n8NJTQtkZ7vd/un27sGWzR46b0qSwBNgeCWGL/YSXLVAdHdq9jLrp0VzNWxhHAkVP\n\tsYZwrBZIE9JhebxwIkCJh7Gx2h2cNCudP5lQ1csnJunO96+vF1ONLwYrzyOuvYZIGi\n\tr1++5WQypCwta/dA6SJYOCEcqMGuXt6lJyLYM0soUjwoxNalH38fZLs+VGlvVeo69r\n\t32sziPvWF7r3afI2k84GZ1AxECYZ6/WclYdaIIbGVERfY34Y8tQH6ffH6B4YFGLjlP\n\tID3uz1V9YIPZFPIxrFFFq0FJpmVQX/Pj778DWw2jJTi65ib6mlm58HrufxaV2DQtH4\n\t9wh6glyXZuI8A==","Date":"Mon,  3 May 2021 11:51:21 +0000","From":"Sebastian Fricke <sebastian.fricke@posteo.net>","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20210503115121.ar5s7r2xpw7yiw4c@basti-TUXEDO-Book-XA1510>","References":"<20210411164858.29961-1-sebastian.fricke@posteo.net>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210411164858.29961-1-sebastian.fricke@posteo.net>","Subject":"Re: [libcamera-devel] [PATCH] pipeline: rkisp1: Add check for\n\tnon-existent frame info","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":16744,"web_url":"https://patchwork.libcamera.org/comment/16744/","msgid":"<e02b7549-ae0e-0c13-c514-60ddbd4b7c00@ideasonboard.com>","date":"2021-05-03T12:34:17","subject":"Re: [libcamera-devel] [PATCH] pipeline: rkisp1: Add check for\n\tnon-existent frame info","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Sebastian,\n\nOn 03/05/2021 12:51, Sebastian Fricke wrote:\n> Hey,\n> \n> slight push .. :)\n\nI'll push this in now.\n--\nKieran\n\n\n> \n> On 11.04.2021 18:48, Sebastian Fricke wrote:\n>> Add a check, that makes sure that the given FrameBuffer is associated\n>> to a RkISP1FrameInfo instance. The current code tries to access the\n>> frame info without checking if it actually exists.\n>>\n>> Fixes: 0eb65e14e libcamera: pipeline: rkisp1: Attach to an IPA\n>>\n>> Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net>\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>> ---\n>> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 ++\n>> 1 file changed, 2 insertions(+)\n>>\n>> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> index 03757327..eca7d608 100644\n>> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> @@ -1079,6 +1079,8 @@ void\n>> PipelineHandlerRkISP1::paramReady(FrameBuffer *buffer)\n>>     RkISP1CameraData *data = cameraData(activeCamera_);\n>>\n>>     RkISP1FrameInfo *info = data->frameInfo_.find(buffer);\n>> +    if (!info)\n>> +        return;\n>>\n>>     info->paramDequeued = true;\n>>     tryCompleteRequest(info->request);\n>> -- \n>> 2.25.1\n>>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E906BDE77\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  3 May 2021 12:34:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 146D5688AE;\n\tMon,  3 May 2021 14:34:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EFA4B60511\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  3 May 2021 14:34:20 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 530766EE;\n\tMon,  3 May 2021 14:34:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jXsMK2m8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1620045260;\n\tbh=g360IPxocleotJP7B9Ora6QHZMG7yZBNeEK8dgpJnM4=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=jXsMK2m8qarQEY6DioWySnqE5lDWs6Jd/yrUI3YyMVYd3Q3xLCb60V/d6wyUJhq67\n\tCCaL0pu5rk/QABPqk2rE2PmxR+47+kdyRu1hgpE2MqXWVC2AlByN224vzxgqh4TPk0\n\thPd+g5olYNjpig/CfSaka+DffG3ZaBA/uuK5Cq/Y=","To":"Sebastian Fricke <sebastian.fricke@posteo.net>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210411164858.29961-1-sebastian.fricke@posteo.net>\n\t<20210503115121.ar5s7r2xpw7yiw4c@basti-TUXEDO-Book-XA1510>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Organization":"Ideas on Board","Message-ID":"<e02b7549-ae0e-0c13-c514-60ddbd4b7c00@ideasonboard.com>","Date":"Mon, 3 May 2021 13:34:17 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"<20210503115121.ar5s7r2xpw7yiw4c@basti-TUXEDO-Book-XA1510>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] pipeline: rkisp1: Add check for\n\tnon-existent frame info","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]