[{"id":16263,"web_url":"https://patchwork.libcamera.org/comment/16263/","msgid":"","date":"2021-04-14T08:07:13","subject":"Re: [libcamera-devel] [PATCH v2 1/3] ipa: raspberrypi: Make\n\tCamHelper exposure methods virtual","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"I forgot to add Naush's \"Reviewed-by\" tag:\n\nOn Thu, 8 Apr 2021 at 14:36, David Plowman\n wrote:\n>\n> This allows derived classes to override them if they have any special\n> behaviours to implement. For instance if a particular camera mode\n> produces a different signal level to other modes, you might choose to\n> address that in the gain or exposure methods.\n>\n> Signed-off-by: David Plowman \n\nReviewed-by: Naushir Patuck \n\n>\n> ---\n> src/ipa/raspberrypi/cam_helper.hpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp\n> index 1b2d6eec..4053a870 100644\n> --- a/src/ipa/raspberrypi/cam_helper.hpp\n> +++ b/src/ipa/raspberrypi/cam_helper.hpp\n> @@ -66,8 +66,8 @@ public:\n> virtual ~CamHelper();\n> void SetCameraMode(const CameraMode &mode);\n> MdParser &Parser() const { return *parser_; }\n> - uint32_t ExposureLines(double exposure_us) const;\n> - double Exposure(uint32_t exposure_lines) const; // in us\n> + virtual uint32_t ExposureLines(double exposure_us) const;\n> + virtual double Exposure(uint32_t exposure_lines) const; // in us\n> virtual uint32_t GetVBlanking(double &exposure_us, double minFrameDuration,\n> double maxFrameDuration) const;\n> virtual uint32_t GainCode(double gain) const = 0;\n> --\n> 2.20.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13576BD224\n\tfor ;\n\tWed, 14 Apr 2021 08:07:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3707768805;\n\tWed, 14 Apr 2021 10:07:28 +0200 (CEST)","from mail-ot1-x332.google.com (mail-ot1-x332.google.com\n\t[IPv6:2607:f8b0:4864:20::332])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59C85687EF\n\tfor ;\n\tWed, 14 Apr 2021 10:07:26 +0200 (CEST)","by mail-ot1-x332.google.com with SMTP id\n\t101-20020a9d0d6e0000b02902816815ff62so12712249oti.9\n\tfor ;\n\tWed, 14 Apr 2021 01:07:26 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"cLaPHjfL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=0aI3p9nI4o0J9iUFMLfvycyT/Ea9h45O97ed3ZJ0Muo=;\n\tb=cLaPHjfLbImvcQsugYX3bXapBmkvQwjUPZRoqTFd7TFjJbgdVSS3kj2mBdrgcmzOpl\n\tmgFLIZwpJ87zI9T/2sIwPiSBUq++hI46YMkk4hOs7hTDwPNEiVaaHsiBC7+BGMw+wHqt\n\tasWg3+Jgg0mmHj1gn/ZNIIJpsCbos5wj8QpavdLHSGRabgXGq49cnjLK+7EPgl9Gx3Th\n\tY38Wz0yCwLT0SjyCI3jWyjTP59dbxrRYsSkCR0oEGW0KWQ7CmNdldejEqTdpG1n5qAew\n\tcvV/L2XYH1eH2+C/oJ+HaX0LFR6GWkpCtN2IYVSsp2EN1gSsuY1MFG0ob8uRWc9YVlyQ\n\t9i/Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=0aI3p9nI4o0J9iUFMLfvycyT/Ea9h45O97ed3ZJ0Muo=;\n\tb=DX05t0Up2fBGexDGiWXvmC4IWaY/eW4N4m2vXjcdluLjb2vqL9RpSyQJnOmtaSIxN2\n\thkXqygSzgC5BNiQwZ7Ab0XqIOoAGTtkWnp1aMPnRhdG6CyVkfAFcIzL57s3LAKvL9btV\n\tozhZySQ7AUJKFI+Hxba8H34OzcFgwaJ8wWeqmfKitJmuf6DNu29yNoP8WghPbbta+Zc4\n\tTvokl7DPENb0SP+/31u8x+/owPQv2CjvWQaQXNP6QWGBvLzGqI6qjKNlNWNk4qWJcj1w\n\tpeG/2V2TUm62gxPnfqGej9J/OXnNWArsAD6dzmApZX7iGGhUQ6FAoNYOADPucHvE/Hrw\n\tye/g==","X-Gm-Message-State":"AOAM531lvMBBeTBwguqQ8bbQc2wBx2F7nmQvd2HzDi84UTJRX3O44t2D\n\t05+ySLbg/INzZANjABIFnenXftoytVvU8AUHwHnoHSNvWA8=","X-Google-Smtp-Source":"ABdhPJxPBpfzCYdMa2nQuSWknpLMVr3GWaPHv/I5q2MIKb6a8Cz6RnhLbrOekJti3hCmpnuKFiC93GCw+F9zZ+Ntx34=","X-Received":"by 2002:a9d:730b:: with SMTP id\n\te11mr7636936otk.166.1618387644792; \n\tWed, 14 Apr 2021 01:07:24 -0700 (PDT)","MIME-Version":"1.0","References":"<20210408133634.16815-1-david.plowman@raspberrypi.com>\n\t<20210408133634.16815-2-david.plowman@raspberrypi.com>","In-Reply-To":"<20210408133634.16815-2-david.plowman@raspberrypi.com>","From":"David Plowman ","Date":"Wed, 14 Apr 2021 09:07:13 +0100","Message-ID":"","To":"libcamera devel ","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] ipa: raspberrypi: Make\n\tCamHelper exposure methods virtual","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]