{"id":11865,"url":"https://patchwork.libcamera.org/api/patches/11865/?format=json","web_url":"https://patchwork.libcamera.org/patch/11865/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210408031040.1388568-2-hiroh@chromium.org>","date":"2021-04-08T03:10:40","name":"[libcamera-devel,v3,2/2] android: CameraDevice: Validate buffer_handle by CameraBuffer::isValidBuffer()","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"75ee0031da9414b2da3f235e94afc7879d713b00","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11865/mbox/","series":[{"id":1903,"url":"https://patchwork.libcamera.org/api/series/1903/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1903","date":"2021-04-08T03:10:39","name":"[libcamera-devel,v3,1/2] android: CameraBuffer: Add a static function to check a buffer validness","version":3,"mbox":"https://patchwork.libcamera.org/series/1903/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11865/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11865/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 411EFBD227\n\tfor ;\n\tThu, 8 Apr 2021 03:11:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 34900687F3;\n\tThu, 8 Apr 2021 05:10:59 +0200 (CEST)","from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com\n\t[IPv6:2607:f8b0:4864:20::102c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C84CB687A2\n\tfor ;\n\tThu, 8 Apr 2021 05:10:57 +0200 (CEST)","by mail-pj1-x102c.google.com with SMTP id\n\tot17-20020a17090b3b51b0290109c9ac3c34so2350054pjb.4\n\tfor ;\n\tWed, 07 Apr 2021 20:10:57 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:8822:ec6c:14d8:eea9])\n\tby smtp.gmail.com with ESMTPSA id\n\tq14sm23685397pgt.54.2021.04.07.20.10.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 Apr 2021 20:10:55 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"XWtcvKpy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=0kB3NhEX2dg7aQOxQ6JiJnUKmNOQIHWM9FgWV5zRdkQ=;\n\tb=XWtcvKpyfjyfKigk6YKy/04mweWp8n/G/HkbI5owD3P43jxuJ9cYYcCN46sQKp/v+H\n\tcP3ccXcrylxfOsQIRBaXyumO/64kBFm2XqBoL5DcPr6E+0IEBrVHzfUOUBatod7bknf7\n\te4ZXGWUCc2owP9r53H83OyU65Zpan90GOB5AI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=0kB3NhEX2dg7aQOxQ6JiJnUKmNOQIHWM9FgWV5zRdkQ=;\n\tb=Cn/SjsWAbUKgatIOL8pKS/yXfQiX9IVHAv8qW+QVlEQVLk0kOemHzXtiEO4v3LKdc8\n\tYvhEqj9xDBQyDZoEyc2ypLCneouNpdNj8MfRO7YI3/BKlkAvDEBRs3pYW78UmkRX9plZ\n\tLpUQDd36lIQiUGU2PM01yLPYmLgGthZuvp+4t0SEj0dgYFrpOI2dDWnFLxbwpc3rWTrQ\n\tyFEYHWZvX4kDbQsLgDlEeKK4/Z+K16ZJ6iErqo/BWKtjaQmvZBC5leI3u13U5iXW9NzI\n\toUFN1v1rRSORk6ksh2ageXWo1tcCsqVBmcc4rdmYsLJUAjDJ+rlZ+G/bdN3A26rs+0d4\n\tkiYw==","X-Gm-Message-State":"AOAM531+2aCDCczfs+CYX9TJe8CksGcGceBNjuPCKbZQoGlR718ha3LG\n\tyCIMtuRKKMggVkGK6NJjIpK5CuNbbNuc/Q==","X-Google-Smtp-Source":"ABdhPJxFzh9BUPRNc4b8yJlBYw8rY5df99u0d5msick98Usszz6zRpAMMbjvt5U1kr+kaceY2TqKUg==","X-Received":"by 2002:a17:90a:b392:: with SMTP id\n\te18mr6207040pjr.66.1617851456246; \n\tWed, 07 Apr 2021 20:10:56 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 8 Apr 2021 12:10:40 +0900","Message-Id":"<20210408031040.1388568-2-hiroh@chromium.org>","X-Mailer":"git-send-email 2.31.0.208.g409f899ff0-goog","In-Reply-To":"<20210408031040.1388568-1-hiroh@chromium.org>","References":"<20210408031040.1388568-1-hiroh@chromium.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 2/2] android: CameraDevice: Validate\n\tbuffer_handle by CameraBuffer::isValidBuffer()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This adds a validation to buffer_handle provided in\nCameraDevice::processCaptureRequest() by using\nCameraBuffer::isValidBuffer().\n\nSigned-off-by: Hirokazu Honda \n---\n src/android/camera_device.cpp | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 89044efa..7247c12c 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -293,6 +293,11 @@ bool isValidRequest(camera3_capture_request_t *camera3Request)\n \t\t\t\t<< \") in buffer \" << i;\n \t\t\treturn false;\n \t\t}\n+\n+\t\tif (!CameraBuffer::isValidBuffer(handle)) {\n+\t\t\tLOG(HAL, Error) << \"Buffer \" << i << \" is invalid\";\n+\t\t\treturn false;\n+\t\t}\n \t}\n \n \treturn true;\n","prefixes":["libcamera-devel","v3","2/2"]}