[{"id":16136,"web_url":"https://patchwork.libcamera.org/comment/16136/","msgid":"<20210407080925.ijzxozwealobmnnd@uno.localdomain>","date":"2021-04-07T08:09:25","subject":"Re: [libcamera-devel] [PATCH] libcamera: thread: Fix typo in comment","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Sebastian\n\nOn Wed, Apr 07, 2021 at 07:31:40AM +0200, Sebastian Fricke wrote:\n> s/This method enter/This method enters/\n\nThanks\nReviewed-by: Jacopo Mondi \n\n\n>\n> Signed-off-by: Sebastian Fricke \n> ---\n> src/libcamera/thread.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> index f339dab1..f14c433f 100644\n> --- a/src/libcamera/thread.cpp\n> +++ b/src/libcamera/thread.cpp\n> @@ -290,7 +290,7 @@ void Thread::startThread()\n> /**\n> * \\brief Enter the event loop\n> *\n> - * This method enter an event loop based on the event dispatcher instance for\n> + * This method enters an event loop based on the event dispatcher instance for\n> * the thread, and blocks until the exit() method is called. It is meant to be\n> * called within the thread from the run() method and shall not be called\n> * outside of the thread.\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A858BD1F6\n\tfor ;\n\tWed, 7 Apr 2021 08:08:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 61E43687D5;\n\tWed, 7 Apr 2021 10:08:50 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE38268795\n\tfor ;\n\tWed, 7 Apr 2021 10:08:48 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 6262560005;\n\tWed, 7 Apr 2021 08:08:48 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 7 Apr 2021 10:09:25 +0200","From":"Jacopo Mondi ","To":"Sebastian Fricke ","Message-ID":"<20210407080925.ijzxozwealobmnnd@uno.localdomain>","References":"<20210407053139.8686-1-sebastian.fricke@posteo.net>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210407053139.8686-1-sebastian.fricke@posteo.net>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: thread: Fix typo in comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16137,"web_url":"https://patchwork.libcamera.org/comment/16137/","msgid":"","date":"2021-04-07T08:56:11","subject":"Re: [libcamera-devel] [PATCH] libcamera: thread: Fix typo in comment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Sebastian,\n\nThank you for the patch.\n\nOn Wed, Apr 07, 2021 at 07:31:40AM +0200, Sebastian Fricke wrote:\n> s/This method enter/This method enters/\n\nThis duplicates the content of the patch itself, but there's really not\nmuch else that needs to be said. In my opinion this is a valid case\nwhere a commit message could be left empty. It doesn't matter much.\n\n> Signed-off-by: Sebastian Fricke \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/thread.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> index f339dab1..f14c433f 100644\n> --- a/src/libcamera/thread.cpp\n> +++ b/src/libcamera/thread.cpp\n> @@ -290,7 +290,7 @@ void Thread::startThread()\n> /**\n> * \\brief Enter the event loop\n> *\n> - * This method enter an event loop based on the event dispatcher instance for\n> + * This method enters an event loop based on the event dispatcher instance for\n> * the thread, and blocks until the exit() method is called. It is meant to be\n> * called within the thread from the run() method and shall not be called\n> * outside of the thread.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D8B9BD224\n\tfor ;\n\tWed, 7 Apr 2021 08:56:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3389E687D5;\n\tWed, 7 Apr 2021 10:56:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A95368795\n\tfor ;\n\tWed, 7 Apr 2021 10:56:56 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 085D188F;\n\tWed, 7 Apr 2021 10:56:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Q99y9Elz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1617785816;\n\tbh=XCQHZVQYpww21ZVyJszZUxC/JJ9sTizr+z/t4UmDbQs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Q99y9Elzu8oK3Df6LcwxQEbyCp+6mSz8Fdw5r7buaXy+QSdTmNS/S232zE/pkkgs+\n\tpY/nUXG9uHED6yLMpHVzg3XboCC58T6p0YqFuow48f9upwAFIPrgWEos3yW2egz5bd\n\taMUfCeKAlTtre68LGxLP7XZAXM47VNlH5USbpHnw=","Date":"Wed, 7 Apr 2021 11:56:11 +0300","From":"Laurent Pinchart ","To":"Sebastian Fricke ","Message-ID":"","References":"<20210407053139.8686-1-sebastian.fricke@posteo.net>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210407053139.8686-1-sebastian.fricke@posteo.net>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: thread: Fix typo in comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16138,"web_url":"https://patchwork.libcamera.org/comment/16138/","msgid":"<20210407090152.3a6ti53mn3mm57nj@basti-TUXEDO-Book-XA1510>","date":"2021-04-07T09:01:52","subject":"Re: [libcamera-devel] [PATCH] libcamera: thread: Fix typo in comment","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"Hey Laurent,\n\nOn 07.04.2021 11:56, Laurent Pinchart wrote:\n>Hi Sebastian,\n>\n>Thank you for the patch.\n>\n>On Wed, Apr 07, 2021 at 07:31:40AM +0200, Sebastian Fricke wrote:\n>> s/This method enter/This method enters/\n>\n>This duplicates the content of the patch itself, but there's really not\n>much else that needs to be said. In my opinion this is a valid case\n>where a commit message could be left empty. It doesn't matter much.\n\nThank you for that advice, my intention behind this line is to make clear,\nwhich part of the text was changed. I found this often useful when the\ncommit diff contains a lot of text and the change is very very small\n(like adding a missing letter 's'), because in that case the reviewer\nwould have to read the whole line again to find that error.\nDo you think it is beneficial when the reviewer has to spot the error on his own?\n\n>\n>> Signed-off-by: Sebastian Fricke \n>\n>Reviewed-by: Laurent Pinchart \n\nGreetings,\n\nSebastian\n>\n>> ---\n>> src/libcamera/thread.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n>> index f339dab1..f14c433f 100644\n>> --- a/src/libcamera/thread.cpp\n>> +++ b/src/libcamera/thread.cpp\n>> @@ -290,7 +290,7 @@ void Thread::startThread()\n>> /**\n>> * \\brief Enter the event loop\n>> *\n>> - * This method enter an event loop based on the event dispatcher instance for\n>> + * This method enters an event loop based on the event dispatcher instance for\n>> * the thread, and blocks until the exit() method is called. It is meant to be\n>> * called within the thread from the run() method and shall not be called\n>> * outside of the thread.\n>\n>-- \n>Regards,\n>\n>Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ABA41BD1F6\n\tfor ;\n\tWed, 7 Apr 2021 09:01:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22C7D687A2;\n\tWed, 7 Apr 2021 11:01:56 +0200 (CEST)","from mout02.posteo.de (mout02.posteo.de [185.67.36.66])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EEF5568795\n\tfor ;\n\tWed, 7 Apr 2021 11:01:54 +0200 (CEST)","from submission (posteo.de [89.146.220.130]) \n\tby mout02.posteo.de (Postfix) with ESMTPS id 20F32240104\n\tfor ;\n\tWed, 7 Apr 2021 11:01:54 +0200 (CEST)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4FFdgP1hqRz9rxd;\n\tWed, 7 Apr 2021 11:01:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"pelSSQxl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1617786114; bh=h+3Qec/QI0qkpvA8ZukxW7BEsc4iTj3+u/KRqkCVvmQ=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=pelSSQxlc4ZAAUirXeJ8/9X03hDuXq1C7zfuPWndKasY7U10nKINRgACATjY2zip5\n\tLKsjIYXBwLPG03q5L4XT1lYJ67KSeWHY3NpTs2x1MQHGtoDutr+TBaT5bIR2eRT7st\n\tUj1eMxJ02m3ZcvbA+I1fTTknH+OL3bXtAYGw1FXmoybSyo7RbezC2j8o8xS+6yhhh8\n\tduZggIfRX5J8wKUgByXYBCdWKJZgRShuejqVFDIY4djxL0TwTdQRurtcjLKow8IuJy\n\tUX5IrC0OVDlaZemCVaUYsF8AL3YX0sBoSkLhz9OSPiao7AaBwvhV3k347jkJ3V3Apf\n\tLaW4HGG3h1yEA==","Date":"Wed, 7 Apr 2021 11:01:52 +0200","From":"Sebastian Fricke ","To":"Laurent Pinchart ","Message-ID":"<20210407090152.3a6ti53mn3mm57nj@basti-TUXEDO-Book-XA1510>","References":"<20210407053139.8686-1-sebastian.fricke@posteo.net>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: thread: Fix typo in comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16139,"web_url":"https://patchwork.libcamera.org/comment/16139/","msgid":"","date":"2021-04-07T09:03:48","subject":"Re: [libcamera-devel] [PATCH] libcamera: thread: Fix typo in comment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Sebastian,\n\nOn Wed, Apr 07, 2021 at 11:01:52AM +0200, Sebastian Fricke wrote:\n> On 07.04.2021 11:56, Laurent Pinchart wrote:\n> > On Wed, Apr 07, 2021 at 07:31:40AM +0200, Sebastian Fricke wrote:\n> >> s/This method enter/This method enters/\n> >\n> > This duplicates the content of the patch itself, but there's really not\n> > much else that needs to be said. In my opinion this is a valid case\n> > where a commit message could be left empty. It doesn't matter much.\n> \n> Thank you for that advice, my intention behind this line is to make clear,\n> which part of the text was changed. I found this often useful when the\n> commit diff contains a lot of text and the change is very very small\n> (like adding a missing letter 's'), because in that case the reviewer\n> would have to read the whole line again to find that error.\n> Do you think it is beneficial when the reviewer has to spot the error on his own?\n\nFor a single line change, I think it's not too hard to spot :-) But\nagain, it doesn't matter much.\n\n> >> Signed-off-by: Sebastian Fricke \n> >\n> > Reviewed-by: Laurent Pinchart \n> >\n> >> ---\n> >> src/libcamera/thread.cpp | 2 +-\n> >> 1 file changed, 1 insertion(+), 1 deletion(-)\n> >>\n> >> diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> >> index f339dab1..f14c433f 100644\n> >> --- a/src/libcamera/thread.cpp\n> >> +++ b/src/libcamera/thread.cpp\n> >> @@ -290,7 +290,7 @@ void Thread::startThread()\n> >> /**\n> >> * \\brief Enter the event loop\n> >> *\n> >> - * This method enter an event loop based on the event dispatcher instance for\n> >> + * This method enters an event loop based on the event dispatcher instance for\n> >> * the thread, and blocks until the exit() method is called. It is meant to be\n> >> * called within the thread from the run() method and shall not be called\n> >> * outside of the thread.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B6CFBD1F6\n\tfor ;\n\tWed, 7 Apr 2021 09:04:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B51B0687A2;\n\tWed, 7 Apr 2021 11:04:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37A0C68795\n\tfor ;\n\tWed, 7 Apr 2021 11:04:33 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B4E7588F;\n\tWed, 7 Apr 2021 11:04:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XKQ+YOOu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1617786272;\n\tbh=z/LGYcxWOqg17V80bi7I2TirWx0zz3d7PQmote7niEY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XKQ+YOOupR3bGNJrgYwTvEA0u+PKD0zPT+xu+dWZ8oOivpIclMovwNojwqDEeznui\n\tKOdVx8dyJjuQfP3gZfthbM4g70GruGOEzPEkbat8Lb07XZZYjh3AinI9g3eRXzFP0Z\n\tILyvBwWezR8BPlQ0hFXXUjF9wEewAKwEig2euGk4=","Date":"Wed, 7 Apr 2021 12:03:48 +0300","From":"Laurent Pinchart ","To":"Sebastian Fricke ","Message-ID":"","References":"<20210407053139.8686-1-sebastian.fricke@posteo.net>\n\t\n\t<20210407090152.3a6ti53mn3mm57nj@basti-TUXEDO-Book-XA1510>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210407090152.3a6ti53mn3mm57nj@basti-TUXEDO-Book-XA1510>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: thread: Fix typo in comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]