[{"id":16135,"web_url":"https://patchwork.libcamera.org/comment/16135/","msgid":"<20210407080854.vzeogummpr5muakz@uno.localdomain>","date":"2021-04-07T08:08:54","subject":"Re: [libcamera-devel] [PATCH v2 2/2] android: CameraDevice:\n\tValidate buffer_handle by CameraBuffer::isValidBuffer()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Hiro,\n\nOn Wed, Apr 07, 2021 at 01:36:20PM +0900, Hirokazu Honda wrote:\n> This adds a validation to buffer_handle provided in\n> CameraDevice::processCaptureRequest() by using\n> CameraBuffer::isValidBuffer().\n>\n> Signed-off-by: Hirokazu Honda \n> ---\n> src/android/camera_device.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 89044efa..8a742812 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -293,6 +293,11 @@ bool isValidRequest(camera3_capture_request_t *camera3Request)\n> \t\t\t\t<< \") in buffer \" << i;\n> \t\t\treturn false;\n> \t\t}\n> +\n> +\t\tif (!CameraBuffer::isValidBuffer(handle)) {\n> +\t\t\tLOG(HAL, Error) << \"buffer \" << i << \"is invalid\";\n\ns/buffer/Buffer\n\" is invalid\" with a space at the beginning of the string\n\nI would consider moving the error printout to the memory backend\nimplementation as it could add more details on the failure reason.\nHowever, this is good\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n\n> +\t\t\treturn false;\n> +\t\t}\n> \t}\n>\n> \treturn true;\n> --\n> 2.31.0.208.g409f899ff0-goog\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7FC61BD1F6\n\tfor ;\n\tWed, 7 Apr 2021 08:08:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EF67C687D5;\n\tWed, 7 Apr 2021 10:08:19 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C0B8168795\n\tfor ;\n\tWed, 7 Apr 2021 10:08:17 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 50E81240003;\n\tWed, 7 Apr 2021 08:08:16 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 7 Apr 2021 10:08:54 +0200","From":"Jacopo Mondi ","To":"Hirokazu Honda ","Message-ID":"<20210407080854.vzeogummpr5muakz@uno.localdomain>","References":"<20210407043620.1756347-1-hiroh@chromium.org>\n\t<20210407043620.1756347-2-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210407043620.1756347-2-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] android: CameraDevice:\n\tValidate buffer_handle by CameraBuffer::isValidBuffer()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]