[{"id":16278,"web_url":"https://patchwork.libcamera.org/comment/16278/","msgid":"","date":"2021-04-14T14:07:36","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: pipeline: rkisp1:\n\tAssert empty queuedRequests before clearing frameInfo","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Nícolas,\n\nThanks for your patch.\n\nOn 2021-04-06 15:23:34 -0300, Nícolas F. R. A. Prado wrote:\n> Assert that there are no queued requests before clearing the frameInfo,\n> otherwise a SEGFAULT can occur.\n> \n> This issue happened while running lc-compliance.\n> \n> Suggested-by: Kieran Bingham \n> Signed-off-by: Nícolas F. R. A. Prado \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index c122c9be2afd..3c8d9dfe6f87 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -842,6 +842,7 @@ void PipelineHandlerRkISP1::stop(Camera *camera)\n> \t\tLOG(RkISP1, Warning)\n> \t\t\t<< \"Failed to stop parameters for \" << camera->id();\n> \n> +\tASSERT(data->queuedRequests_.empty());\n> \tdata->frameInfo_.clear();\n> \n> \tfreeBuffers(camera);\n> -- \n> 2.31.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E955BD1F6\n\tfor ;\n\tWed, 14 Apr 2021 14:07:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0CF266880C;\n\tWed, 14 Apr 2021 16:07:39 +0200 (CEST)","from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com\n\t[IPv6:2a00:1450:4864:20::12f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 709A568803\n\tfor ;\n\tWed, 14 Apr 2021 16:07:38 +0200 (CEST)","by mail-lf1-x12f.google.com with SMTP id j18so33470094lfg.5\n\tfor ;\n\tWed, 14 Apr 2021 07:07:38 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\to17sm3868074lfg.203.2021.04.14.07.07.37\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 14 Apr 2021 07:07:37 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"jdJvON7i\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=D/1M90JDEQB2fevDfeDFEdHYAZ3Vm0+lNn6UmOejgO8=;\n\tb=jdJvON7ieWNSBzP/0Nlme9voR+zOk4LmAa6ooWz3nR3IjhKUz7whdmXwgra6WBgenv\n\tqm1ZDEUMalksiKQdN2sZd/lU0eCv+aHD4ZMV8fnstSqmL96G2Y+fZd9kwRo8oJPQZvdg\n\tzM1muy2g8yrqmdIP9sCSq19zdRLxtNpPLyTdMiiCDdOJ/wef4nJRhQAfID8Bo991Mo8q\n\twCQJJvhgcM9DoHkyjBnrK6fpqc17wUwoKIg9BSBUKI/8ciKexH/OTEjhdHON9gIK7Pc9\n\tWt+r6SOXi42kVFkv53YuNJ3D3zbr99onjk6H1vUc6u09SHBnizu/fL7jZoyDrvxsRCKx\n\t/C5A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=D/1M90JDEQB2fevDfeDFEdHYAZ3Vm0+lNn6UmOejgO8=;\n\tb=Xpmqpu2g5ACfu4mSFzl4aYREdYqEc8oA0f6AqxddNS0AtZsa/MxboaDfwAgLPSYAgS\n\tyvRV5e3mpIt07sHSS++xcQJaNlIj11sG2m154ukHkE9OMpr1W4mNn9C4tTxtocKJ1HCA\n\t7VBbCtE0EdrUEUZphiw//uXmZ5/WRWxat2OxHWyQcYHKEoHCGOI68e965K3T7YYiUH5k\n\tYlYWufK/LPspYubcndGl+pU9jqN7ssv2qjvI0J3KvBMQHFVmKXT3DjyyaJmrDVmdvtJW\n\tEaABG167hHpqnsEpkWjMRErHR6U9WtGjQ7GGH/cEtZuHIwCTCkcb5qjVwYpMAKTNDXpp\n\t4fxg==","X-Gm-Message-State":"AOAM5339tth09H56YTm+wFGmfu2+16QhCEadpL0SXeOnnOq43ugw0Hgp\n\tlcYMEpNocMd22PmNo/G4iif0Og==","X-Google-Smtp-Source":"ABdhPJy69Lfuu5ahrnZ5ny5wFFRDlno61Vga5dyFuisiQ/OWptx2CYjCqV/wOnbh7pSkmVOA2jJL8w==","X-Received":"by 2002:ac2:593c:: with SMTP id\n\tv28mr27254685lfi.581.1618409257811; \n\tWed, 14 Apr 2021 07:07:37 -0700 (PDT)","Date":"Wed, 14 Apr 2021 16:07:36 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"=?iso-8859-1?q?N=EDcolas_F=2E_R=2E_A=2E?= Prado ","Message-ID":"","References":"<20210406182335.85847-1-nfraprado@collabora.com>\n\t<20210406182335.85847-3-nfraprado@collabora.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210406182335.85847-3-nfraprado@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: pipeline: rkisp1:\n\tAssert empty queuedRequests before clearing frameInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org,\n\tCollabora Kernel ML ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16281,"web_url":"https://patchwork.libcamera.org/comment/16281/","msgid":"<4544107a-dced-bbdf-09ff-51af48d0ca40@ideasonboard.com>","date":"2021-04-14T14:11:53","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: pipeline: rkisp1:\n\tAssert empty queuedRequests before clearing frameInfo","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 06/04/2021 19:23, Nícolas F. R. A. Prado wrote:\n> Assert that there are no queued requests before clearing the frameInfo,\n> otherwise a SEGFAULT can occur.\n> \n> This issue happened while running lc-compliance.\n> \n> Suggested-by: Kieran Bingham \n> Signed-off-by: Nícolas F. R. A. Prado \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index c122c9be2afd..3c8d9dfe6f87 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -842,6 +842,7 @@ void PipelineHandlerRkISP1::stop(Camera *camera)\n> \t\tLOG(RkISP1, Warning)\n> \t\t\t<< \"Failed to stop parameters for \" << camera->id();\n> \n> +\tASSERT(data->queuedRequests_.empty());\n> \tdata->frameInfo_.clear();\n> \n> \tfreeBuffers(camera);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63B75BD224\n\tfor ;\n\tWed, 14 Apr 2021 14:11:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 261D76880C;\n\tWed, 14 Apr 2021 16:11:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A3E9F68803\n\tfor ;\n\tWed, 14 Apr 2021 16:11:56 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF8146F2;\n\tWed, 14 Apr 2021 16:11:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lN8HtceC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618409516;\n\tbh=BkNg3HHkT/RPHJS7sKquraz949tCc8tkhe5FknzMW9k=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=lN8HtceC0rdlkgakmy/tF+eWqwsF9WARsiFX0yrAcROB+17RH7fZbecrjxeZntZNw\n\t4A8mf60lqGD0SsPPGj4/LuDk7AURBLNAdIPaej+pN8iKXTTvSzyhKDjuNmkV32kQCP\n\tNhK9jPIVEmbMtbQDfIu5DhziG5/HTDNEqq/ILFWA=","To":"=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210406182335.85847-1-nfraprado@collabora.com>\n\t<20210406182335.85847-3-nfraprado@collabora.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<4544107a-dced-bbdf-09ff-51af48d0ca40@ideasonboard.com>","Date":"Wed, 14 Apr 2021 15:11:53 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210406182335.85847-3-nfraprado@collabora.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: pipeline: rkisp1:\n\tAssert empty queuedRequests before clearing frameInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"Collabora Kernel ML ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]