[{"id":16249,"web_url":"https://patchwork.libcamera.org/comment/16249/","msgid":"<f8f781fa-462f-bed3-22c9-020010e48ae7@ideasonboard.com>","date":"2021-04-13T21:36:17","subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: pipeline:\n\traspberrypi: Update ControlInfos after sensor format change","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi David,\n\nOn 06/04/2021 11:40, David Plowman wrote:\n> The Raspberry Pi pipeline handler does not update the sensor format\n> using CameraSensor::setFormat, so it must manually force the update of\n> the associated ControlInfos.\n> \n> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n> ---\n>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 ++++++\n>  1 file changed, 6 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index f22e286e..bbcc15ec 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -608,6 +608,12 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n>  \tif (ret)\n>  \t\treturn ret;\n>  \n> +\t/*\n> +\t * The control ranges associated with the sensor may need updating\n> +\t * after a format change.\n> +\t */\n> +\tdata->sensor_->updateControlInfos();\n> +\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n>  \tLOG(RPI, Info) << \"Sensor: \" << camera->id()\n>  \t\t       << \" - Selected mode: \" << sensorFormat.toString();\n>  \n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A358EBD1F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Apr 2021 21:36:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1DBED687FE;\n\tTue, 13 Apr 2021 23:36:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF9C2602D1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Apr 2021 23:36:19 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 09B1B9F0;\n\tTue, 13 Apr 2021 23:36:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wVvkZ51y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618349779;\n\tbh=9E7le9e5ONVeYlR8fFA2ex/JyWkDzalRMOVWaxLilt0=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=wVvkZ51yt7s8Dh7NED+6oExyKKRM948K9juJMyN8UjeSMMvlZpMU4CAdgPHLDxmHX\n\t7T6YjXOFPT0YNXpJa6Ubx+6dT/ZCJmgeltNQwewAs8PdczDifuda087fg+q3palNxM\n\tN9ZQBClVWgWXoSHkRx+FYRBGsf/6rnjis7GSj4lg=","To":"David Plowman <david.plowman@raspberrypi.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210406104050.23814-1-david.plowman@raspberrypi.com>\n\t<20210406104050.23814-3-david.plowman@raspberrypi.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<f8f781fa-462f-bed3-22c9-020010e48ae7@ideasonboard.com>","Date":"Tue, 13 Apr 2021 22:36:17 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210406104050.23814-3-david.plowman@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: pipeline:\n\traspberrypi: Update ControlInfos after sensor format change","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":16270,"web_url":"https://patchwork.libcamera.org/comment/16270/","msgid":"<CAEmqJPosuo9AOgKmAruF6y+9bAa05mm0K7usceR7KRKOJKSVvA@mail.gmail.com>","date":"2021-04-14T08:51:24","subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: pipeline:\n\traspberrypi: Update ControlInfos after sensor format change","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for your work.\n\nOn Tue, 6 Apr 2021 at 11:41, David Plowman <david.plowman@raspberrypi.com>\nwrote:\n\n> The Raspberry Pi pipeline handler does not update the sensor format\n> using CameraSensor::setFormat, so it must manually force the update of\n> the associated ControlInfos.\n>\n> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n>\n\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\n\n---\n>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 ++++++\n>  1 file changed, 6 insertions(+)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index f22e286e..bbcc15ec 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -608,6 +608,12 @@ int PipelineHandlerRPi::configure(Camera *camera,\n> CameraConfiguration *config)\n>         if (ret)\n>                 return ret;\n>\n> +       /*\n> +        * The control ranges associated with the sensor may need updating\n> +        * after a format change.\n> +        */\n> +       data->sensor_->updateControlInfos();\n> +\n>         LOG(RPI, Info) << \"Sensor: \" << camera->id()\n>                        << \" - Selected mode: \" << sensorFormat.toString();\n>\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D72E6BD224\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 14 Apr 2021 08:51:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E2056880E;\n\tWed, 14 Apr 2021 10:51:43 +0200 (CEST)","from mail-lf1-x136.google.com (mail-lf1-x136.google.com\n\t[IPv6:2a00:1450:4864:20::136])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C9DBC68805\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 14 Apr 2021 10:51:41 +0200 (CEST)","by mail-lf1-x136.google.com with SMTP id x20so1589014lfu.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 14 Apr 2021 01:51:41 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"JX0bYuf6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=4IN5uh1lZwtnPl2WPuJ23C48+B5z42HEfFqPSggLLII=;\n\tb=JX0bYuf6HcQU23mNI9+0+3rzDTmtJVPxWBQbfMAKgSRFbcPl3f+ktc5Sk42bu3ikyp\n\tNjKE+VfGisoQEc+7gPU9r2UJ3cYBz36HZbcrsMVLwzo4Us0cvC3jhEZ/xL4T++nPe67j\n\txmsEid357sK9WTwOgmKj5Qp9xJeQbHpeWYkrJO4xLvwhFFWIg1syR/RoTQOKfsozASoF\n\tO2DuYhQAD8zbLLPlw6ktiFnOYWWq/XXK2bfK0nABCvtoyl0XZahTV1l+hg8fme2cmvUl\n\tJtPwC/hUiCN38sKct+7Em6ZZ9z2VkeqhNABO6T2SOher1lJ9IVBolHdv+Cq2iGhV3DJT\n\ttRBA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=4IN5uh1lZwtnPl2WPuJ23C48+B5z42HEfFqPSggLLII=;\n\tb=i0RSA6kXyhpf8usUL/8rYl+nMuig5/dwXpR8ZlE23u1+2Nek9CtPfblh78T6ylIKRp\n\t54ZLPZEtOJZIsBq0qKh9fWt0lGyIpen9Hcm/vbqKFIPwUNXNVN2WMND2CF0O882qZuNN\n\t4sXuDIGYL6Dffu1eOfY1OGX8d4bnWtZ1KA2t1QUw4fzcrj40el1rHwUhg6pLTJzQYn1B\n\tIEOHvy/viQTj1/4TE7Y04x3VmE8yVBBxuYo1CKBL2pDgNp6nr3kXsLGkfRhv+kE7tpF7\n\tsIgI6OmssfN7GyIFtexaLzSQxDDE/5v54F6k077h7BsRRsBVdaLLpqgY7fkMjAozSErS\n\tVACQ==","X-Gm-Message-State":"AOAM532DGEH/Ed2KzbtNbsT5rnHoVjQFj3okiMh7E3rt+pz1+DVFD38J\n\tR4Rdj58nMoaJadvO1WEX4XtotIvszK8QSFUWXANLeg==","X-Google-Smtp-Source":"ABdhPJzaJ7ETWAzHGi6ADZ6Ghj36R11jZdcHa7OgPgwqqraO4DnJf4cXBS2upR/fHVLXwjEZnLTYPMLg3qhbNpPKQ1Q=","X-Received":"by 2002:a05:6512:b25:: with SMTP id\n\tw37mr26129540lfu.272.1618390301110; \n\tWed, 14 Apr 2021 01:51:41 -0700 (PDT)","MIME-Version":"1.0","References":"<20210406104050.23814-1-david.plowman@raspberrypi.com>\n\t<20210406104050.23814-3-david.plowman@raspberrypi.com>","In-Reply-To":"<20210406104050.23814-3-david.plowman@raspberrypi.com>","From":"Naushir Patuck <naush@raspberrypi.com>","Date":"Wed, 14 Apr 2021 09:51:24 +0100","Message-ID":"<CAEmqJPosuo9AOgKmAruF6y+9bAa05mm0K7usceR7KRKOJKSVvA@mail.gmail.com>","To":"David Plowman <david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: pipeline:\n\traspberrypi: Update ControlInfos after sensor format change","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Content-Type":"multipart/mixed;\n\tboundary=\"===============0670051325279960069==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":16757,"web_url":"https://patchwork.libcamera.org/comment/16757/","msgid":"<YJE7rkW+o4yKIthg@pendragon.ideasonboard.com>","date":"2021-05-04T12:18:54","subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: pipeline:\n\traspberrypi: Update ControlInfos after sensor format change","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Tue, Apr 06, 2021 at 11:40:50AM +0100, David Plowman wrote:\n> The Raspberry Pi pipeline handler does not update the sensor format\n> using CameraSensor::setFormat, so it must manually force the update of\n> the associated ControlInfos.\n> \n> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n> ---\n>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 ++++++\n>  1 file changed, 6 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index f22e286e..bbcc15ec 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -608,6 +608,12 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n>  \tif (ret)\n>  \t\treturn ret;\n>  \n> +\t/*\n> +\t * The control ranges associated with the sensor may need updating\n> +\t * after a format change.\n\nWith a\n\n\t * \\todo Use the CameraSensor::setFormat() API\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> +\t */\n> +\tdata->sensor_->updateControlInfos();\n> +\n>  \tLOG(RPI, Info) << \"Sensor: \" << camera->id()\n>  \t\t       << \" - Selected mode: \" << sensorFormat.toString();\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DCFEDBDE79\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  4 May 2021 12:18:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D6AA60511;\n\tTue,  4 May 2021 14:18:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5ED68602BF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  4 May 2021 14:18:58 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D4E0758E;\n\tTue,  4 May 2021 14:18:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JYSGZcZC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1620130738;\n\tbh=yskxwuNHYB5Kf5kx4vkKD9tiUzhe6gq9+q+UcpdumDw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JYSGZcZCWlf0QBhnh/J3SaSuTxKcm4a3rWhMbBWGVgM72r3LpnRmz4YFQPrSZweeN\n\tCCMYBxnDSu+85BMJBvoL8qn4QDMdd0PtA9lynSg9GwSpsIKfiC3DHilunow1nwuAUu\n\tfwemmFjXexbJMPksXyCSgFgq+Sg7hs33UdaGYvWc=","Date":"Tue, 4 May 2021 15:18:54 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"David Plowman <david.plowman@raspberrypi.com>","Message-ID":"<YJE7rkW+o4yKIthg@pendragon.ideasonboard.com>","References":"<20210406104050.23814-1-david.plowman@raspberrypi.com>\n\t<20210406104050.23814-3-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210406104050.23814-3-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: pipeline:\n\traspberrypi: Update ControlInfos after sensor format change","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]