[{"id":16124,"web_url":"https://patchwork.libcamera.org/comment/16124/","msgid":"<20210406125122.jtxxag32yoewlsdo@uno.localdomain>","date":"2021-04-06T12:51:22","subject":"Re: [libcamera-devel] [PATCH 2/2] android: CameraDevice: Validate\n\tbuffer_handle by CameraBuffer::isValid()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Hiro,\n\nOn Mon, Apr 05, 2021 at 01:04:24PM +0900, Hirokazu Honda wrote:\n> This adds a validation to buffer_handle provided in\n> CameraDevice::processCaptureRequest() by using\n> CameraBuffer::isValid().\n>\n> Signed-off-by: Hirokazu Honda \n> ---\n> src/android/camera_device.cpp | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 89044efa..0fff5927 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -257,6 +257,7 @@ void sortCamera3StreamConfigs(std::vector &unsortedConfigs,\n> }\n>\n> bool isValidRequest(camera3_capture_request_t *camera3Request)\n> +\n\nUps\n\n> {\n> \tif (!camera3Request) {\n> \t\tLOG(HAL, Error) << \"No capture request provided\";\n> @@ -293,6 +294,13 @@ bool isValidRequest(camera3_capture_request_t *camera3Request)\n> \t\t\t\t<< \") in buffer \" << i;\n> \t\t\treturn false;\n> \t\t}\n> +\n> +\t\tCameraBuffer cameraBuffer(*outputBuffer.buffer,\n> +\t\t\t\t\t PROT_READ | PROT_WRITE, /*map=*/false);\n> +\t\tif (!cameraBuffer.isValid()) {\n> +\t\t\tLOG(HAL, Error) << \"cameraBuffer is invalid\";\n> +\t\t\treturn false;\n> +\t\t}\n\nSee comment in 1/2. I think a static function would be better. Does a\nstatic function works well with d-pointer ?\n\n> \t}\n>\n> \treturn true;\n> --\n> 2.31.0.208.g409f899ff0-goog\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E25D8C0DA3\n\tfor ;\n\tTue, 6 Apr 2021 12:50:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 460BF68786;\n\tTue, 6 Apr 2021 14:50:47 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D47460518\n\tfor ;\n\tTue, 6 Apr 2021 14:50:46 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id CBBA21BF20C;\n\tTue, 6 Apr 2021 12:50:45 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Tue, 6 Apr 2021 14:51:22 +0200","From":"Jacopo Mondi ","To":"Hirokazu Honda ","Message-ID":"<20210406125122.jtxxag32yoewlsdo@uno.localdomain>","References":"<20210405040424.1929737-1-hiroh@chromium.org>\n\t<20210405040424.1929737-3-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210405040424.1929737-3-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: CameraDevice: Validate\n\tbuffer_handle by CameraBuffer::isValid()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]