[{"id":16120,"web_url":"https://patchwork.libcamera.org/comment/16120/","msgid":"","date":"2021-04-04T13:06:08","subject":"Re: [libcamera-devel] [PATCH] android: mm: cros: Fix compilation","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Thanks Laurent for this fix.\n\nOn Sun, Apr 4, 2021 at 8:59 AM Laurent Pinchart\n wrote:\n>\n> Commit 7d7879833812 (\"android: mm: cros: Handle buffer registration\n> failure\") mistakenly tried to initialize the CameraBuffer::Private\n> registered member variable instead of registered_. This reults in a\n> compilation failure. Fix it.\n>\n> Fixes: 7d7879833812 (\"android: mm: cros: Handle buffer registration failure\")\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/android/mm/cros_camera_buffer.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> I failed to catch this before pushing :-( Sorry. I'll push the fix right\n> away to fix the compilation breakage.\n>\n\nReviewed-by: Hirokazu Honda \n\n> diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp\n> index 2a82d4b7c470..1a4fd5d1dfe3 100644\n> --- a/src/android/mm/cros_camera_buffer.cpp\n> +++ b/src/android/mm/cros_camera_buffer.cpp\n> @@ -50,7 +50,7 @@ private:\n> CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,\n> buffer_handle_t camera3Buffer, int flags)\n> : Extensible::Private(cameraBuffer), handle_(camera3Buffer),\n> - numPlanes_(0), valid_(false), registered(false)\n> + numPlanes_(0), valid_(false), registered_(false)\n> {\n> bufferManager_ = cros::CameraBufferManager::GetInstance();\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 44048BD695\n\tfor ;\n\tSun, 4 Apr 2021 13:06:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 72BB768786;\n\tSun, 4 Apr 2021 15:06:21 +0200 (CEST)","from mail-ej1-x630.google.com (mail-ej1-x630.google.com\n\t[IPv6:2a00:1450:4864:20::630])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F4B66084F\n\tfor ;\n\tSun, 4 Apr 2021 15:06:20 +0200 (CEST)","by mail-ej1-x630.google.com with SMTP id u5so13444194ejn.8\n\tfor ;\n\tSun, 04 Apr 2021 06:06:20 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"is3YgS5r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=THZikmrw/8KD2LmWxY0TIiO/1RoBbdaqefDKtEPkdKE=;\n\tb=is3YgS5r0zS9ZpkT3n6aSm/FL/+HgTR6q2S+IW5IGP7NJfaJfwY0/FlmlnIy8o9PB0\n\tVvZqehp7gt095/zJ6DezInhNbSMD1+zVs3Ao1qOguV2FFYi9PQbGD1Y7WwahMzWnAKh0\n\thJLZUKT4zKA3uNVcOlqHlqZPfoYiWa1cMDVXE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=THZikmrw/8KD2LmWxY0TIiO/1RoBbdaqefDKtEPkdKE=;\n\tb=tSf/qRbL2O/dnuI+20ICbJox+0jfHgBxpN6jg9i2okwgAO5p63oh/3dv+jcXmAybDN\n\tkl2F8WMOd7g0sNYqdS1TyP8gVFMi4fcGhnqTYsvvlLpugISnTzeqcUi7/nkXYN5PXxWA\n\t7MPMEXDyAL4tD2TVvsUOoZbfi8vYX5u4T9yyhSFIFQm1gK2iG+o25u8+XChThb5I5hGG\n\tqgQmaHCszwTNTCuB2oNo2ABNEK1tDs/deaTrFHTfkpmQxcLY7zxDSg/NRVLUgHxJmMr6\n\tYQRBxsBm1r2ZY63Kuqfe6r3VZ45ABmR0JRIoeMqcFcELeBCVFXTWdXTRURPC8ttVAkup\n\t6Gxw==","X-Gm-Message-State":"AOAM531JmjeTY78ccfdG3URGDGWSTL9S7+45viKF4M0CvadVnwM9vALf\n\t432Z+pVBGng52tfMhoNBn8DNWcg1uDXGAUX2YMfYy1p+S68=","X-Google-Smtp-Source":"ABdhPJyClpJOpZQuVwuA9mULscYUqu7Bkeo7+XdW3OcwNDRuyxvp2IoPxkah1zlPQxWi0gTP+dwzxpj33pbHVAEFYkU=","X-Received":"by 2002:a17:906:729d:: with SMTP id\n\tb29mr1158072ejl.243.1617541579763; \n\tSun, 04 Apr 2021 06:06:19 -0700 (PDT)","MIME-Version":"1.0","References":"<20210403235838.21594-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20210403235838.21594-1-laurent.pinchart@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Sun, 4 Apr 2021 22:06:08 +0900","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH] android: mm: cros: Fix compilation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]