[{"id":16118,"web_url":"https://patchwork.libcamera.org/comment/16118/","msgid":"","date":"2021-04-03T22:47:02","subject":"Re: [libcamera-devel] [PATCH v4 1/2] android: cameraDevice:\n\tFactorize the code of validating camera3_capture_request","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nOn Sat, Apr 03, 2021 at 10:37:40PM +0900, Hirokazu Honda wrote:\n> CameraDevice::processCaptureRequest() checks the validness of a\n\nJust a small comment, it's \"validity\", not \"validness\". I'll fix when\napplying.\n\n> provided camera3_capture_request. This factorizes the code in\n> order to add more validation to the request later.\n> \n> Signed-off-by: Hirokazu Honda \n> Reviewed-by: Jacopo Mondi \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/android/camera_device.cpp | 24 ++++++++++++++++--------\n> 1 file changed, 16 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index eb327978..d8ce43be 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -256,6 +256,21 @@ void sortCamera3StreamConfigs(std::vector &unsortedConfigs,\n> \tunsortedConfigs = sortedConfigs;\n> }\n> \n> +bool isValidRequest(camera3_capture_request_t *camera3Request)\n> +{\n> +\tif (!camera3Request) {\n> +\t\tLOG(HAL, Error) << \"No capture request provided\";\n> +\t\treturn false;\n> +\t}\n> +\n> +\tif (!camera3Request->num_output_buffers) {\n> +\t\tLOG(HAL, Error) << \"No output buffers provided\";\n> +\t\treturn false;\n> +\t}\n> +\n> +\treturn true;\n> +}\n> +\n> } /* namespace */\n> \n> /*\n> @@ -1785,15 +1800,8 @@ int CameraDevice::processControls(Camera3RequestDescriptor *descriptor)\n> \n> int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)\n> {\n> -\tif (!camera3Request) {\n> -\t\tLOG(HAL, Error) << \"No capture request provided\";\n> +\tif (!isValidRequest(camera3Request))\n> \t\treturn -EINVAL;\n> -\t}\n> -\n> -\tif (!camera3Request->num_output_buffers) {\n> -\t\tLOG(HAL, Error) << \"No output buffers provided\";\n> -\t\treturn -EINVAL;\n> -\t}\n> \n> \t/* Start the camera if that's the first request we handle. */\n> \tif (!running_) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27F23BD695\n\tfor ;\n\tSat, 3 Apr 2021 22:47:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 976E2602E5;\n\tSun, 4 Apr 2021 00:47:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B5217602E5\n\tfor ;\n\tSun, 4 Apr 2021 00:47:48 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1CF893D7;\n\tSun, 4 Apr 2021 00:47:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ADiQpCLD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1617490068;\n\tbh=cUdYwi/pkyN4GBKhUUsLd8BOEdtKq1jGaaIxqVHvxBg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ADiQpCLD7K1hHJtS1GHEzAdVbgsWx0o8jv+7JYHmLNcAQpk+vLBGsCGzBKhql6Msm\n\tot/N03bEOxgborHpnvKeZlK2Lzv2uYHtRB41IA50xvzKgZd9lI2FY54rSB036mqXh1\n\trupANROoLvyWjF1keiygNRjIqg3n/85310tLoLUw=","Date":"Sun, 4 Apr 2021 01:47:02 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210403133741.1595440-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210403133741.1595440-1-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v4 1/2] android: cameraDevice:\n\tFactorize the code of validating camera3_capture_request","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]