[{"id":1573,"web_url":"https://patchwork.libcamera.org/comment/1573/","msgid":"<20190511024927.GF12768@pendragon.ideasonboard.com>","date":"2019-05-11T02:49:27","subject":"Re: [libcamera-devel] [PATCH 5/5] test: v4l2_device: Switch most\n\ttests to vimc","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Wed, May 08, 2019 at 06:58:14PM +0200, Niklas Söderlund wrote:\n> The vimc driver delivers frames much faster then the vivid driver hence\n> most v4l2 device tests complete much quicker if vimc is used. The only\n> v4l2 device test which can't be switched is buffer_sharing as it needs\n> to import buffers somewhere, something vimc do not support.\n> \n> With this change I manage to shave of almost 7 seconds for each run of\n> all v4l2 device tests.\n> \n> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nNice improvement!\n\nHow does this work after you reset all the links without enabling new\nones ?\n\n> ---\n>  test/v4l2_device/capture_async.cpp   | 2 +-\n>  test/v4l2_device/double_open.cpp     | 2 +-\n>  test/v4l2_device/formats.cpp         | 2 +-\n>  test/v4l2_device/request_buffers.cpp | 2 +-\n>  test/v4l2_device/stream_on_off.cpp   | 2 +-\n>  5 files changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/test/v4l2_device/capture_async.cpp b/test/v4l2_device/capture_async.cpp\n> index fd428ff909f32999..69b1d5a13ed8675a 100644\n> --- a/test/v4l2_device/capture_async.cpp\n> +++ b/test/v4l2_device/capture_async.cpp\n> @@ -18,7 +18,7 @@ class CaptureAsyncTest : public V4L2DeviceTest\n>  {\n>  public:\n>  \tCaptureAsyncTest()\n> -\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\"), frames(0) {}\n> +\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\"), frames(0) {}\n>  \n>  \tvoid receiveBuffer(Buffer *buffer)\n>  \t{\n> diff --git a/test/v4l2_device/double_open.cpp b/test/v4l2_device/double_open.cpp\n> index b402de04fca5ddbb..53850620889b0972 100644\n> --- a/test/v4l2_device/double_open.cpp\n> +++ b/test/v4l2_device/double_open.cpp\n> @@ -15,7 +15,7 @@ class DoubleOpen : public V4L2DeviceTest\n>  {\n>  public:\n>  \tDoubleOpen()\n> -\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\") {}\n> +\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\") {}\n>  protected:\n>  \tint run()\n>  \t{\n> diff --git a/test/v4l2_device/formats.cpp b/test/v4l2_device/formats.cpp\n> index 3ac47f5cc665b62b..6be045ff754c4258 100644\n> --- a/test/v4l2_device/formats.cpp\n> +++ b/test/v4l2_device/formats.cpp\n> @@ -19,7 +19,7 @@ class Format : public V4L2DeviceTest\n>  {\n>  public:\n>  \tFormat()\n> -\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\") {}\n> +\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\") {}\n>  protected:\n>  \tint run()\n>  \t{\n> diff --git a/test/v4l2_device/request_buffers.cpp b/test/v4l2_device/request_buffers.cpp\n> index 794b083eb84d8d2e..7b7b06b2b409bd23 100644\n> --- a/test/v4l2_device/request_buffers.cpp\n> +++ b/test/v4l2_device/request_buffers.cpp\n> @@ -11,7 +11,7 @@ class RequestBuffersTest : public V4L2DeviceTest\n>  {\n>  public:\n>  \tRequestBuffersTest()\n> -\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\") {}\n> +\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\") {}\n>  \n>  protected:\n>  \tint run()\n> diff --git a/test/v4l2_device/stream_on_off.cpp b/test/v4l2_device/stream_on_off.cpp\n> index 4902d5fd6d58a73d..b158b8e402c83156 100644\n> --- a/test/v4l2_device/stream_on_off.cpp\n> +++ b/test/v4l2_device/stream_on_off.cpp\n> @@ -11,7 +11,7 @@ class StreamOnStreamOffTest : public V4L2DeviceTest\n>  {\n>  public:\n>  \tStreamOnStreamOffTest()\n> -\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\") {}\n> +\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\") {}\n>  protected:\n>  \tint run()\n>  \t{","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCB3660E4D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 11 May 2019 04:49:43 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3D6492DF;\n\tSat, 11 May 2019 04:49:43 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1557542983;\n\tbh=HieiMiHNyBjT5D+oH+zLYBPWpov7fjh/iNQ68/AhAsw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RbzGU6QIYPUZAO7zgf16TgfKKlNH5GVJT83mZjpzZkxoe0AWk1RsMXLTE5/Kjlnbo\n\t3DxEuS1d8FgHJmm+xUEHCEQDavBnur1+iYN3KlNBrG0cBWjoTJYe42bbBrGQjqGTha\n\txKbt/vRXcSNDBjtyxe1C4BETBp5NiJXHE+OlFZxc=","Date":"Sat, 11 May 2019 05:49:27 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190511024927.GF12768@pendragon.ideasonboard.com>","References":"<20190508165814.26201-1-niklas.soderlund@ragnatech.se>\n\t<20190508165814.26201-6-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190508165814.26201-6-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 5/5] test: v4l2_device: Switch most\n\ttests to vimc","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sat, 11 May 2019 02:49:44 -0000"}},{"id":1581,"web_url":"https://patchwork.libcamera.org/comment/1581/","msgid":"<20190511110726.GK28561@bigcity.dyn.berto.se>","date":"2019-05-11T11:07:26","subject":"Re: [libcamera-devel] [PATCH 5/5] test: v4l2_device: Switch most\n\ttests to vimc","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your feedback.\n\nOn 2019-05-11 05:49:27 +0300, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patch.\n> \n> On Wed, May 08, 2019 at 06:58:14PM +0200, Niklas Söderlund wrote:\n> > The vimc driver delivers frames much faster then the vivid driver hence\n> > most v4l2 device tests complete much quicker if vimc is used. The only\n> > v4l2 device test which can't be switched is buffer_sharing as it needs\n> > to import buffers somewhere, something vimc do not support.\n> > \n> > With this change I manage to shave of almost 7 seconds for each run of\n> > all v4l2 device tests.\n> > \n> > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n> \n> Nice improvement!\n> \n> How does this work after you reset all the links without enabling new\n> ones ?\n\nAll tests based on vimc uses the \"Raw Capture 0\" node which is enabled \nwith an immutable link so there is no need (yet) to explicit enable \nlinks for vimc based tests.\n\nI'm hoping we can get vimc multistreaming support upstream somehow and a \ntest based on that would need to enable links in it's run() before \nexecuting its tests.\n\n> \n> > ---\n> >  test/v4l2_device/capture_async.cpp   | 2 +-\n> >  test/v4l2_device/double_open.cpp     | 2 +-\n> >  test/v4l2_device/formats.cpp         | 2 +-\n> >  test/v4l2_device/request_buffers.cpp | 2 +-\n> >  test/v4l2_device/stream_on_off.cpp   | 2 +-\n> >  5 files changed, 5 insertions(+), 5 deletions(-)\n> > \n> > diff --git a/test/v4l2_device/capture_async.cpp b/test/v4l2_device/capture_async.cpp\n> > index fd428ff909f32999..69b1d5a13ed8675a 100644\n> > --- a/test/v4l2_device/capture_async.cpp\n> > +++ b/test/v4l2_device/capture_async.cpp\n> > @@ -18,7 +18,7 @@ class CaptureAsyncTest : public V4L2DeviceTest\n> >  {\n> >  public:\n> >  \tCaptureAsyncTest()\n> > -\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\"), frames(0) {}\n> > +\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\"), frames(0) {}\n> >  \n> >  \tvoid receiveBuffer(Buffer *buffer)\n> >  \t{\n> > diff --git a/test/v4l2_device/double_open.cpp b/test/v4l2_device/double_open.cpp\n> > index b402de04fca5ddbb..53850620889b0972 100644\n> > --- a/test/v4l2_device/double_open.cpp\n> > +++ b/test/v4l2_device/double_open.cpp\n> > @@ -15,7 +15,7 @@ class DoubleOpen : public V4L2DeviceTest\n> >  {\n> >  public:\n> >  \tDoubleOpen()\n> > -\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\") {}\n> > +\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\") {}\n> >  protected:\n> >  \tint run()\n> >  \t{\n> > diff --git a/test/v4l2_device/formats.cpp b/test/v4l2_device/formats.cpp\n> > index 3ac47f5cc665b62b..6be045ff754c4258 100644\n> > --- a/test/v4l2_device/formats.cpp\n> > +++ b/test/v4l2_device/formats.cpp\n> > @@ -19,7 +19,7 @@ class Format : public V4L2DeviceTest\n> >  {\n> >  public:\n> >  \tFormat()\n> > -\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\") {}\n> > +\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\") {}\n> >  protected:\n> >  \tint run()\n> >  \t{\n> > diff --git a/test/v4l2_device/request_buffers.cpp b/test/v4l2_device/request_buffers.cpp\n> > index 794b083eb84d8d2e..7b7b06b2b409bd23 100644\n> > --- a/test/v4l2_device/request_buffers.cpp\n> > +++ b/test/v4l2_device/request_buffers.cpp\n> > @@ -11,7 +11,7 @@ class RequestBuffersTest : public V4L2DeviceTest\n> >  {\n> >  public:\n> >  \tRequestBuffersTest()\n> > -\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\") {}\n> > +\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\") {}\n> >  \n> >  protected:\n> >  \tint run()\n> > diff --git a/test/v4l2_device/stream_on_off.cpp b/test/v4l2_device/stream_on_off.cpp\n> > index 4902d5fd6d58a73d..b158b8e402c83156 100644\n> > --- a/test/v4l2_device/stream_on_off.cpp\n> > +++ b/test/v4l2_device/stream_on_off.cpp\n> > @@ -11,7 +11,7 @@ class StreamOnStreamOffTest : public V4L2DeviceTest\n> >  {\n> >  public:\n> >  \tStreamOnStreamOffTest()\n> > -\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\") {}\n> > +\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\") {}\n> >  protected:\n> >  \tint run()\n> >  \t{\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lj1-x235.google.com (mail-lj1-x235.google.com\n\t[IPv6:2a00:1450:4864:20::235])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C5E460E4F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 11 May 2019 13:07:28 +0200 (CEST)","by mail-lj1-x235.google.com with SMTP id h21so5400462ljk.13\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 11 May 2019 04:07:28 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tx184sm83723lfa.27.2019.05.11.04.07.26\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSat, 11 May 2019 04:07:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=Pq1JDHV87mF/KNZaueLx+K3vOAD4bYnO2godNyNImRw=;\n\tb=jrDO4LNhuB1sbNImOHd0mduvqJPjz3h5rtrKbihK7iQJAI5Wyp68AYJGvJVrGCJnAe\n\t0Lyw7Wg+U9hWO/Qk2q+p/xcJNsfRFdHqLeUWTpNi4Fa8D/1yRRD8bpd7kNeVtFMhFwf4\n\toYIOuj0rtB30XNy0pkYjPP0BlcCKSGNNe02Xj1G41pqsKUKbU+ZItwX6omjnMp23anXd\n\tfyOb+KOBawbuPZIRD/2HQb1kesVC1wZ7+KI4U6dQ7eA9TknSezkHdqjFucwTBeBKocxF\n\tluG8pk7pxcqfNI/1m5scJTUl+oGCIV4lrGJycr1PFOF93CShM7/f9M18VeZeIHRx6xQ2\n\tamuQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=Pq1JDHV87mF/KNZaueLx+K3vOAD4bYnO2godNyNImRw=;\n\tb=jGZ+kvWlbT2FpSck8r+Cs8/ExK9djqsCFisuImWOy0neYoL60pCK9OwMeXnsJCj8qf\n\tufww/nvpfSvkh4FteoeHWC07c2f15DkcvQCAUEmaFPl0yHAtNRZb/ihlputD7TVp3Y5+\n\tXlxisHHgRrnXd/3pzQ8pcuL0vf2zNsRZ13AC2Kpi0IyykkL+KEda/IHdtOhGPA0bqRy/\n\tcJB9Fy0uOB2tfijnPtYG4OYKc1zvlYOWFk0V6EJUKlQaIwo7MTHKEpitzU5ocCujtytH\n\tLO749oI+2XtmYoOdeXRGHrJQQ6WHarxsPeheITXgXRBCYc5ilYq3m3o49ZjGMWwppm93\n\t+HDA==","X-Gm-Message-State":"APjAAAU6EllYBuT4pnCxJ62UL3leMV3eOEfAKtAK4qoLNFW7iKj0nO1h\n\tQUTWx5rzu1ITdtbryu1uviOudXn44SY=","X-Google-Smtp-Source":"APXvYqzbCDohycv3J/o85+zWPbWzQiQur7BmRygKuVdMLZRRwLRm7IU5EzrRzwTFrSVGs8oqFz61tQ==","X-Received":"by 2002:a2e:90da:: with SMTP id\n\to26mr3973763ljg.182.1557572847779; \n\tSat, 11 May 2019 04:07:27 -0700 (PDT)","Date":"Sat, 11 May 2019 13:07:26 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190511110726.GK28561@bigcity.dyn.berto.se>","References":"<20190508165814.26201-1-niklas.soderlund@ragnatech.se>\n\t<20190508165814.26201-6-niklas.soderlund@ragnatech.se>\n\t<20190511024927.GF12768@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190511024927.GF12768@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH 5/5] test: v4l2_device: Switch most\n\ttests to vimc","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sat, 11 May 2019 11:07:28 -0000"}},{"id":1594,"web_url":"https://patchwork.libcamera.org/comment/1594/","msgid":"<20190511133918.GL4946@pendragon.ideasonboard.com>","date":"2019-05-11T13:39:18","subject":"Re: [libcamera-devel] [PATCH 5/5] test: v4l2_device: Switch most\n\ttests to vimc","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nOn Sat, May 11, 2019 at 01:07:26PM +0200, Niklas Söderlund wrote:\n> On 2019-05-11 05:49:27 +0300, Laurent Pinchart wrote:\n> > On Wed, May 08, 2019 at 06:58:14PM +0200, Niklas Söderlund wrote:\n> >> The vimc driver delivers frames much faster then the vivid driver hence\n> >> most v4l2 device tests complete much quicker if vimc is used. The only\n> >> v4l2 device test which can't be switched is buffer_sharing as it needs\n> >> to import buffers somewhere, something vimc do not support.\n> >> \n> >> With this change I manage to shave of almost 7 seconds for each run of\n> >> all v4l2 device tests.\n> >> \n> >> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n> > \n> > Nice improvement!\n> > \n> > How does this work after you reset all the links without enabling new\n> > ones ?\n> \n> All tests based on vimc uses the \"Raw Capture 0\" node which is enabled \n> with an immutable link so there is no need (yet) to explicit enable \n> links for vimc based tests.\n> \n> I'm hoping we can get vimc multistreaming support upstream somehow and a \n> test based on that would need to enable links in it's run() before \n> executing its tests.\n\nOK.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> >> ---\n> >>  test/v4l2_device/capture_async.cpp   | 2 +-\n> >>  test/v4l2_device/double_open.cpp     | 2 +-\n> >>  test/v4l2_device/formats.cpp         | 2 +-\n> >>  test/v4l2_device/request_buffers.cpp | 2 +-\n> >>  test/v4l2_device/stream_on_off.cpp   | 2 +-\n> >>  5 files changed, 5 insertions(+), 5 deletions(-)\n> >> \n> >> diff --git a/test/v4l2_device/capture_async.cpp b/test/v4l2_device/capture_async.cpp\n> >> index fd428ff909f32999..69b1d5a13ed8675a 100644\n> >> --- a/test/v4l2_device/capture_async.cpp\n> >> +++ b/test/v4l2_device/capture_async.cpp\n> >> @@ -18,7 +18,7 @@ class CaptureAsyncTest : public V4L2DeviceTest\n> >>  {\n> >>  public:\n> >>  \tCaptureAsyncTest()\n> >> -\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\"), frames(0) {}\n> >> +\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\"), frames(0) {}\n> >>  \n> >>  \tvoid receiveBuffer(Buffer *buffer)\n> >>  \t{\n> >> diff --git a/test/v4l2_device/double_open.cpp b/test/v4l2_device/double_open.cpp\n> >> index b402de04fca5ddbb..53850620889b0972 100644\n> >> --- a/test/v4l2_device/double_open.cpp\n> >> +++ b/test/v4l2_device/double_open.cpp\n> >> @@ -15,7 +15,7 @@ class DoubleOpen : public V4L2DeviceTest\n> >>  {\n> >>  public:\n> >>  \tDoubleOpen()\n> >> -\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\") {}\n> >> +\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\") {}\n> >>  protected:\n> >>  \tint run()\n> >>  \t{\n> >> diff --git a/test/v4l2_device/formats.cpp b/test/v4l2_device/formats.cpp\n> >> index 3ac47f5cc665b62b..6be045ff754c4258 100644\n> >> --- a/test/v4l2_device/formats.cpp\n> >> +++ b/test/v4l2_device/formats.cpp\n> >> @@ -19,7 +19,7 @@ class Format : public V4L2DeviceTest\n> >>  {\n> >>  public:\n> >>  \tFormat()\n> >> -\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\") {}\n> >> +\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\") {}\n> >>  protected:\n> >>  \tint run()\n> >>  \t{\n> >> diff --git a/test/v4l2_device/request_buffers.cpp b/test/v4l2_device/request_buffers.cpp\n> >> index 794b083eb84d8d2e..7b7b06b2b409bd23 100644\n> >> --- a/test/v4l2_device/request_buffers.cpp\n> >> +++ b/test/v4l2_device/request_buffers.cpp\n> >> @@ -11,7 +11,7 @@ class RequestBuffersTest : public V4L2DeviceTest\n> >>  {\n> >>  public:\n> >>  \tRequestBuffersTest()\n> >> -\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\") {}\n> >> +\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\") {}\n> >>  \n> >>  protected:\n> >>  \tint run()\n> >> diff --git a/test/v4l2_device/stream_on_off.cpp b/test/v4l2_device/stream_on_off.cpp\n> >> index 4902d5fd6d58a73d..b158b8e402c83156 100644\n> >> --- a/test/v4l2_device/stream_on_off.cpp\n> >> +++ b/test/v4l2_device/stream_on_off.cpp\n> >> @@ -11,7 +11,7 @@ class StreamOnStreamOffTest : public V4L2DeviceTest\n> >>  {\n> >>  public:\n> >>  \tStreamOnStreamOffTest()\n> >> -\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\") {}\n> >> +\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\") {}\n> >>  protected:\n> >>  \tint run()\n> >>  \t{","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A403D60E4F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 11 May 2019 15:39:34 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 266E6D5;\n\tSat, 11 May 2019 15:39:34 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1557581974;\n\tbh=yaFljV5KkslrMOsTbSke+3P4O09HL8tjIOWqTAEDrXo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YzrWnyebYDKUPhSWrAURKbLegXoeLpxf8s3yEqoqg9IbU2NzrPvPaZKTA/UG/QZ59\n\t0COTDmOBl8mVsagcyM9c35qYI5bSpu+m/DRL3SIIbkTA6Dd0Ft0YZ/tdILdLddlC7g\n\t/b7TYpWAWDQMzm+hKLSnZ56XHqqlf03G1V2RSVII=","Date":"Sat, 11 May 2019 16:39:18 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190511133918.GL4946@pendragon.ideasonboard.com>","References":"<20190508165814.26201-1-niklas.soderlund@ragnatech.se>\n\t<20190508165814.26201-6-niklas.soderlund@ragnatech.se>\n\t<20190511024927.GF12768@pendragon.ideasonboard.com>\n\t<20190511110726.GK28561@bigcity.dyn.berto.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190511110726.GK28561@bigcity.dyn.berto.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 5/5] test: v4l2_device: Switch most\n\ttests to vimc","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sat, 11 May 2019 13:39:34 -0000"}}]