[{"id":16087,"web_url":"https://patchwork.libcamera.org/comment/16087/","msgid":"<20210401161025.mp6fxghfkdjkwvmf@uno.localdomain>","date":"2021-04-01T16:10:25","subject":"Re: [libcamera-devel] [PATCH 2/2] android: CameraDevice: Add more\n\tcamera3_capture_request validation","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Hiro,\n\nOn Fri, Apr 02, 2021 at 12:31:23AM +0900, Hirokazu Honda wrote:\n> This adds more validation to camera3_capture_request mainly\n> about buffer_handle values.\n>\n> Signed-off-by: Hirokazu Honda \n> ---\n> src/android/camera_device.cpp | 27 ++++++++++++++++++++++++++-\n> 1 file changed, 26 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 48eb471d..4ed4d3ff 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -263,11 +263,36 @@ bool isValidRequest(camera3_capture_request_t *camera3Request)\n> \t\treturn false;\n> \t}\n>\n> -\tif (!camera3Request->num_output_buffers) {\n> +\tif (!camera3Request->num_output_buffers ||\n> +\t !camera3Request->output_buffers) {\n> \t\tLOG(HAL, Error) << \"No output buffers provided\";\n> \t\treturn -EINVAL;\n> \t}\n>\n> +\tfor (uint32_t i = 0; i < camera3Request->num_output_buffers; i++) {\n> +\t\tconst camera3_stream_buffer_t &outputBuffer =\n> +\t\t\tcamera3Request->output_buffers[i];\n> +\t\tif (!outputBuffer.buffer || !(*outputBuffer.buffer)) {\n> +\t\t\tLOG(HAL, Error) << \"Invalid native handle\";\n> +\t\t\treturn -EINVAL;\n\nreturn false ?\n\n> +\t\t}\n> +\n> +\t\tconst native_handle_t *handle = *outputBuffer.buffer;\n> +\t\tconstexpr int kNativeHandleMaxFds = 1024;\n\nWhere does the 1024 limit comes from ?\n\n> +\t\tif (handle->numFds < 0 || handle->numFds > kNativeHandleMaxFds) {\n> +\t\t\tLOG(HAL, Error) << \"Invalid number of fds: \"\n> +\t\t\t\t\t<< handle->numFds;\n> +\t\t\treturn -EINVAL;\n> +\t\t}\n> +\n> +\t\tconstexpr int kNativeHandleMaxInts = 1024;\n> +\t\tif (handle->numInts < 0 || handle->numInts > kNativeHandleMaxInts) {\n> +\t\t\tLOG(HAL, Error) << \"Invalid number of data\"\n\n\"of data:\" for consistency\n\nThanks\n j\n\n> +\t\t\t\t\t<< handle->numInts;\n> +\t\t\treturn -EINVAL;\n> +\t\t}\n> +\t}\n> +\n> \treturn true;\n> }\n>\n> --\n> 2.31.0.291.g576ba9dcdaf-goog\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 02265C0DA4\n\tfor ;\n\tThu, 1 Apr 2021 16:09:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6FB3068791;\n\tThu, 1 Apr 2021 18:09:52 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 05D9B602D7\n\tfor ;\n\tThu, 1 Apr 2021 18:09:51 +0200 (CEST)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 7C0FF60009;\n\tThu, 1 Apr 2021 16:09:50 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","Date":"Thu, 1 Apr 2021 18:10:25 +0200","From":"Jacopo Mondi ","To":"Hirokazu Honda ","Message-ID":"<20210401161025.mp6fxghfkdjkwvmf@uno.localdomain>","References":"<20210401153123.1217170-1-hiroh@chromium.org>\n\t<20210401153123.1217170-2-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210401153123.1217170-2-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: CameraDevice: Add more\n\tcamera3_capture_request validation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16089,"web_url":"https://patchwork.libcamera.org/comment/16089/","msgid":"","date":"2021-04-01T16:15:42","subject":"Re: [libcamera-devel] [PATCH 2/2] android: CameraDevice: Add more\n\tcamera3_capture_request validation","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"On Fri, Apr 2, 2021 at 1:09 AM Jacopo Mondi wrote:\n>\n> Hi Hiro,\n>\n> On Fri, Apr 02, 2021 at 12:31:23AM +0900, Hirokazu Honda wrote:\n> > This adds more validation to camera3_capture_request mainly\n> > about buffer_handle values.\n> >\n> > Signed-off-by: Hirokazu Honda \n> > ---\n> > src/android/camera_device.cpp | 27 ++++++++++++++++++++++++++-\n> > 1 file changed, 26 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 48eb471d..4ed4d3ff 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -263,11 +263,36 @@ bool isValidRequest(camera3_capture_request_t *camera3Request)\n> > return false;\n> > }\n> >\n> > - if (!camera3Request->num_output_buffers) {\n> > + if (!camera3Request->num_output_buffers ||\n> > + !camera3Request->output_buffers) {\n> > LOG(HAL, Error) << \"No output buffers provided\";\n> > return -EINVAL;\n> > }\n> >\n> > + for (uint32_t i = 0; i < camera3Request->num_output_buffers; i++) {\n> > + const camera3_stream_buffer_t &outputBuffer =\n> > + camera3Request->output_buffers[i];\n> > + if (!outputBuffer.buffer || !(*outputBuffer.buffer)) {\n> > + LOG(HAL, Error) << \"Invalid native handle\";\n> > + return -EINVAL;\n>\n> return false ?\n>\n> > + }\n> > +\n> > + const native_handle_t *handle = *outputBuffer.buffer;\n> > + constexpr int kNativeHandleMaxFds = 1024;\n>\n> Where does the 1024 limit comes from ?\n>\n\nIt comes from NATIVE_HANDLE_MAX_FDS and NATIVE_HANDLE_MAX_INTS in\nnative_handle.h.\nhttps://android.googlesource.com/platform/system/core/+/master/libcutils/include/cutils/native_handle.h#26\nSomehow native_handle.h in include/android doesn't have the values..\n\n-Hiro\n\n> > + if (handle->numFds < 0 || handle->numFds > kNativeHandleMaxFds) {\n> > + LOG(HAL, Error) << \"Invalid number of fds: \"\n> > + << handle->numFds;\n> > + return -EINVAL;\n> > + }\n> > +\n> > + constexpr int kNativeHandleMaxInts = 1024;\n> > + if (handle->numInts < 0 || handle->numInts > kNativeHandleMaxInts) {\n> > + LOG(HAL, Error) << \"Invalid number of data\"\n>\n> \"of data:\" for consistency\n>\n> Thanks\n> j\n>\n> > + << handle->numInts;\n> > + return -EINVAL;\n> > + }\n> > + }\n> > +\n> > return true;\n> > }\n> >\n> > --\n> > 2.31.0.291.g576ba9dcdaf-goog\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F6D3C0DA3\n\tfor ;\n\tThu, 1 Apr 2021 16:15:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B16B68787;\n\tThu, 1 Apr 2021 18:15:54 +0200 (CEST)","from mail-ej1-x634.google.com (mail-ej1-x634.google.com\n\t[IPv6:2a00:1450:4864:20::634])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F16F468784\n\tfor ;\n\tThu, 1 Apr 2021 18:15:52 +0200 (CEST)","by mail-ej1-x634.google.com with SMTP id hq27so3684741ejc.9\n\tfor ;\n\tThu, 01 Apr 2021 09:15:52 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"ASnPp2G1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=tc+dH9SGHzCfMzaTV40ttuadKNQ4iSKFC8x1X9yAq9c=;\n\tb=ASnPp2G1GJlIuSLm3ig3gKZ+uvlQn8BEilSXvsZ4fDhF8DuGZ/KGF0Pu+7Cc0WphQV\n\tT4v43rD28QSY9aCXXrkwwX19TO4+T2g2SUYVjHSQb13QGARFEfTDIZi4XZbbQo29eAru\n\t4qbm4OglQhcSHqhwxqnxsgizO8DnkW81k5E8E=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=tc+dH9SGHzCfMzaTV40ttuadKNQ4iSKFC8x1X9yAq9c=;\n\tb=qCg4CUW29rJMFD2zwj0gEckwcn9k1IGQ+z7uXl4+0zrJE3+vQY2ETr/mM616kf6jAT\n\tJywW7CUF8liNoOHbozP1CC5SRGTZfJchcwaTZHdO/b79QEFvaaxKjp+dEV5UTftOPXbM\n\tdepL9V9v7HOn4jal9eQ/6VjYrckL76tLeLeV6PVNvXLJSsiKOuLLfdtiRnspU0JThoDy\n\tclpwjSlzRyH/ILOLMHZDzuS154YyN2jr+z2Bex2b30yW/E9Ss9csN5UUMecgtv7DHNpE\n\tB6lF7rwJYQamSupacivycf4cfe+CjWhxQrlGosMK4uTankAMDDuNpbZUSBFeG0ia1RUR\n\tYRWw==","X-Gm-Message-State":"AOAM5300Qs/l1PP9oV5E/96NtgjSt4OAPMWWG73wpkdlYbxpVMZ8WDs6\n\t+QSl66xvRo6q2A69gLwzCu6yLLG43q61lOzDIbPX4g==","X-Google-Smtp-Source":"ABdhPJwQZPR9vKDktte/B96oQ55vxZLB3LUt3YfMqh8hAK01Lpb64RdglQnZOJQAj4rr2lJod4KQ99p1bEZmi5as9LA=","X-Received":"by 2002:a17:906:6a06:: with SMTP id\n\to6mr9726137ejr.306.1617293752644; \n\tThu, 01 Apr 2021 09:15:52 -0700 (PDT)","MIME-Version":"1.0","References":"<20210401153123.1217170-1-hiroh@chromium.org>\n\t<20210401153123.1217170-2-hiroh@chromium.org>\n\t<20210401161025.mp6fxghfkdjkwvmf@uno.localdomain>","In-Reply-To":"<20210401161025.mp6fxghfkdjkwvmf@uno.localdomain>","From":"Hirokazu Honda ","Date":"Fri, 2 Apr 2021 01:15:42 +0900","Message-ID":"","To":"Jacopo Mondi ","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: CameraDevice: Add more\n\tcamera3_capture_request validation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16091,"web_url":"https://patchwork.libcamera.org/comment/16091/","msgid":"","date":"2021-04-01T22:36:46","subject":"Re: [libcamera-devel] [PATCH 2/2] android: CameraDevice: Add more\n\tcamera3_capture_request validation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Hiro,\n\nOn 01/04/2021 17:15, Hirokazu Honda wrote:\n> On Fri, Apr 2, 2021 at 1:09 AM Jacopo Mondi wrote:\n>>\n>> Hi Hiro,\n>>\n>> On Fri, Apr 02, 2021 at 12:31:23AM +0900, Hirokazu Honda wrote:\n>>> This adds more validation to camera3_capture_request mainly\n>>> about buffer_handle values.\n>>>\n>>> Signed-off-by: Hirokazu Honda \n>>> ---\n>>> src/android/camera_device.cpp | 27 ++++++++++++++++++++++++++-\n>>> 1 file changed, 26 insertions(+), 1 deletion(-)\n>>>\n>>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n>>> index 48eb471d..4ed4d3ff 100644\n>>> --- a/src/android/camera_device.cpp\n>>> +++ b/src/android/camera_device.cpp\n>>> @@ -263,11 +263,36 @@ bool isValidRequest(camera3_capture_request_t *camera3Request)\n>>> return false;\n>>> }\n>>>\n>>> - if (!camera3Request->num_output_buffers) {\n>>> + if (!camera3Request->num_output_buffers ||\n>>> + !camera3Request->output_buffers) {\n>>> LOG(HAL, Error) << \"No output buffers provided\";\n>>> return -EINVAL;\n>>> }\n>>>\n>>> + for (uint32_t i = 0; i < camera3Request->num_output_buffers; i++) {\n>>> + const camera3_stream_buffer_t &outputBuffer =\n>>> + camera3Request->output_buffers[i];\n>>> + if (!outputBuffer.buffer || !(*outputBuffer.buffer)) {\n>>> + LOG(HAL, Error) << \"Invalid native handle\";\n>>> + return -EINVAL;\n>>\n>> return false ?\n>>\n>>> + }\n>>> +\n>>> + const native_handle_t *handle = *outputBuffer.buffer;\n>>> + constexpr int kNativeHandleMaxFds = 1024;\n>>\n>> Where does the 1024 limit comes from ?\n>>\n> \n> It comes from NATIVE_HANDLE_MAX_FDS and NATIVE_HANDLE_MAX_INTS in\n> native_handle.h.\n> https://android.googlesource.com/platform/system/core/+/master/libcutils/include/cutils/native_handle.h#26\n> Somehow native_handle.h in include/android doesn't have the values..\n> \n> -Hiro\n> \n>>> + if (handle->numFds < 0 || handle->numFds > kNativeHandleMaxFds) {\n>>> + LOG(HAL, Error) << \"Invalid number of fds: \"\n>>> + << handle->numFds;\n>>> + return -EINVAL;\n>>> + }\n>>> +\n>>> + constexpr int kNativeHandleMaxInts = 1024;\n>>> + if (handle->numInts < 0 || handle->numInts > kNativeHandleMaxInts) {\n>>> + LOG(HAL, Error) << \"Invalid number of data\"\n>>\n>> \"of data:\" for consistency\n\nDon't forget the space after the ':'\n\n\"Invalid number of data\" doesn't make much sense to me, but I'm not\nactually sure what handle->numInts is storing?\n\nHow about:\n\n\"Unsupported quantity of ints: \"\n\nBut I'm not even fond of that ;-) - Perhaps it doesn't matter so much as\nthe error will lead the reader here somehow anyway.\n\n>>\n>> Thanks\n>> j\n>>\n>>> + << handle->numInts;\n>>> + return -EINVAL;\n\nAnd of course all the return values need to be boolean.\n\n\n>>> + }\n>>> + }\n>>> +\n>>> return true;\n>>> }\n>>>\n>>> --\n>>> 2.31.0.291.g576ba9dcdaf-goog\n>>>\n>>> _______________________________________________\n>>> libcamera-devel mailing list\n>>> libcamera-devel@lists.libcamera.org\n>>> https://lists.libcamera.org/listinfo/libcamera-devel\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77983C0DA3\n\tfor ;\n\tThu, 1 Apr 2021 22:36:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F06CC68780;\n\tFri, 2 Apr 2021 00:36:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6DDBF6051B\n\tfor ;\n\tFri, 2 Apr 2021 00:36:50 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AC5A880E;\n\tFri, 2 Apr 2021 00:36:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WFMr1JVB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1617316609;\n\tbh=NyszUpZlA+SaXelEmqq+8W4C0mYShbqNsyqk4HakXVY=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=WFMr1JVBGCAG9jkHcJxgPniKu85W+KqJVdgLgzUSMG9OTGnWpitEoNQSUWAfurZub\n\tNuSaAcb8MIinC1VGhsP1E9qjqSObY/gLr2dnoXLOBluowny5ofNoDlARAbf8T6XGe7\n\tDsi46u70c4rFEulCjxTYgBxeW3Z3jdLTefkRHMl4=","To":"Hirokazu Honda , Jacopo Mondi ","References":"<20210401153123.1217170-1-hiroh@chromium.org>\n\t<20210401153123.1217170-2-hiroh@chromium.org>\n\t<20210401161025.mp6fxghfkdjkwvmf@uno.localdomain>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 1 Apr 2021 23:36:46 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: CameraDevice: Add more\n\tcamera3_capture_request validation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]