[{"id":16086,"web_url":"https://patchwork.libcamera.org/comment/16086/","msgid":"<20210401160530.an4mdgmalsn3dwig@uno.localdomain>","date":"2021-04-01T16:05:30","subject":"Re: [libcamera-devel] [PATCH 1/2] android: cameraDevice: Factorize\n\tthe code of validating camera3_capture_request","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Hiro,\nOn Fri, Apr 02, 2021 at 12:31:22AM +0900, Hirokazu Honda wrote:\n> CameraDevice::processCaptureRequest() checks the validness of a\n> provided camera3_capture_request. This factorizes the code in\n> order to add more validation to the request later.\n>\n> Signed-off-by: Hirokazu Honda \n> ---\n> src/android/camera_device.cpp | 24 ++++++++++++++++--------\n> 1 file changed, 16 insertions(+), 8 deletions(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index eb327978..48eb471d 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -256,6 +256,21 @@ void sortCamera3StreamConfigs(std::vector &unsortedConfigs,\n> \tunsortedConfigs = sortedConfigs;\n> }\n>\n> +bool isValidRequest(camera3_capture_request_t *camera3Request)\n> +{\n> +\tif (!camera3Request) {\n> +\t\tLOG(HAL, Error) << \"No capture request provided\";\n> +\t\treturn false;\n> +\t}\n> +\n> +\tif (!camera3Request->num_output_buffers) {\n> +\t\tLOG(HAL, Error) << \"No output buffers provided\";\n> +\t\treturn -EINVAL;\n\nreturn false ?\n\nWith this fixed\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> +\t}\n> +\n> +\treturn true;\n> +}\n> +\n> } /* namespace */\n>\n> /*\n> @@ -1785,15 +1800,8 @@ int CameraDevice::processControls(Camera3RequestDescriptor *descriptor)\n>\n> int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)\n> {\n> -\tif (!camera3Request) {\n> -\t\tLOG(HAL, Error) << \"No capture request provided\";\n> -\t\treturn -EINVAL;\n> -\t}\n> -\n> -\tif (!camera3Request->num_output_buffers) {\n> -\t\tLOG(HAL, Error) << \"No output buffers provided\";\n> +\tif (isValidRequest(camera3Request))\n> \t\treturn -EINVAL;\n> -\t}\n>\n> \t/* Start the camera if that's the first request we handle. */\n> \tif (!running_) {\n> --\n> 2.31.0.291.g576ba9dcdaf-goog\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6D2C7C0DA3\n\tfor ;\n\tThu, 1 Apr 2021 16:04:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DF77668791;\n\tThu, 1 Apr 2021 18:04:56 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86B3D602D7\n\tfor ;\n\tThu, 1 Apr 2021 18:04:56 +0200 (CEST)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id BD6F4240003;\n\tThu, 1 Apr 2021 16:04:55 +0000 (UTC)"],"Date":"Thu, 1 Apr 2021 18:05:30 +0200","From":"Jacopo Mondi ","To":"Hirokazu Honda ","Message-ID":"<20210401160530.an4mdgmalsn3dwig@uno.localdomain>","References":"<20210401153123.1217170-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210401153123.1217170-1-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH 1/2] android: cameraDevice: Factorize\n\tthe code of validating camera3_capture_request","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16088,"web_url":"https://patchwork.libcamera.org/comment/16088/","msgid":"","date":"2021-04-01T16:11:35","subject":"Re: [libcamera-devel] [PATCH 1/2] android: cameraDevice: Factorize\n\tthe code of validating camera3_capture_request","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"On Fri, Apr 2, 2021 at 1:04 AM Jacopo Mondi wrote:\n>\n> Hi Hiro,\n> On Fri, Apr 02, 2021 at 12:31:22AM +0900, Hirokazu Honda wrote:\n> > CameraDevice::processCaptureRequest() checks the validness of a\n> > provided camera3_capture_request. This factorizes the code in\n> > order to add more validation to the request later.\n> >\n> > Signed-off-by: Hirokazu Honda \n> > ---\n> > src/android/camera_device.cpp | 24 ++++++++++++++++--------\n> > 1 file changed, 16 insertions(+), 8 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index eb327978..48eb471d 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -256,6 +256,21 @@ void sortCamera3StreamConfigs(std::vector &unsortedConfigs,\n> > unsortedConfigs = sortedConfigs;\n> > }\n> >\n> > +bool isValidRequest(camera3_capture_request_t *camera3Request)\n> > +{\n> > + if (!camera3Request) {\n> > + LOG(HAL, Error) << \"No capture request provided\";\n> > + return false;\n> > + }\n> > +\n> > + if (!camera3Request->num_output_buffers) {\n> > + LOG(HAL, Error) << \"No output buffers provided\";\n> > + return -EINVAL;\n>\n> return false ?\n>\n\ndefinitely, yes.\nThanks for catching!\n\n> With this fixed\n> Reviewed-by: Jacopo Mondi \n>\n> Thanks\n> j\n>\n> > + }\n> > +\n> > + return true;\n> > +}\n> > +\n> > } /* namespace */\n> >\n> > /*\n> > @@ -1785,15 +1800,8 @@ int CameraDevice::processControls(Camera3RequestDescriptor *descriptor)\n> >\n> > int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)\n> > {\n> > - if (!camera3Request) {\n> > - LOG(HAL, Error) << \"No capture request provided\";\n> > - return -EINVAL;\n> > - }\n> > -\n> > - if (!camera3Request->num_output_buffers) {\n> > - LOG(HAL, Error) << \"No output buffers provided\";\n> > + if (isValidRequest(camera3Request))\n> > return -EINVAL;\n> > - }\n> >\n> > /* Start the camera if that's the first request we handle. */\n> > if (!running_) {\n> > --\n> > 2.31.0.291.g576ba9dcdaf-goog\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C99CC0DA4\n\tfor ;\n\tThu, 1 Apr 2021 16:11:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE07668791;\n\tThu, 1 Apr 2021 18:11:47 +0200 (CEST)","from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com\n\t[IPv6:2607:f8b0:4864:20::b31])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55136602D7\n\tfor ;\n\tThu, 1 Apr 2021 18:11:46 +0200 (CEST)","by mail-yb1-xb31.google.com with SMTP id m132so2347975ybf.2\n\tfor ;\n\tThu, 01 Apr 2021 09:11:46 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"BeEDusnY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=qReandT7pk5XTy4GrBqTDbUBANfHbYXJ1OGjqa98R2Q=;\n\tb=BeEDusnYkfo5PigA5+zsw/ChE4r+hUbELAYaB0XBp/t5tbOhN8pASfathnGSjkzK+L\n\tD6aPLtDTyw5t3PMdN3Ta35VhRqQtc4efitsDj8xJL9+w2I7TwTMQ0t2yCVbMKu7dLWXb\n\tKCLvvicIC8xyUR7oBNZxjh5T2ZXKmiannKiYc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=qReandT7pk5XTy4GrBqTDbUBANfHbYXJ1OGjqa98R2Q=;\n\tb=tVy3urDG39wpww4+kGQ4noN7zGg0kd1EQDSnswLjzQ9saZ/xZdPy0NuBJw31121PoL\n\tTQH4aV1XZNbW14RNtJ4vS9XxqI++Yz5jpDhsYBvBrln/G2vd3tPQSXeJlLsCeXuPC1WF\n\tLRPDvCcTLDutcclKkuWN8+LxoYAZu9EbVlyKPqd6N6Svx5BRrrm4ObE2K2jHrP0XCQQh\n\touQJwxOJlMZFRd9GLzjHlIKGPqo39PM5f9UKCpBrdKRTGSdAibFEIM8nd6NLb8hd8B2W\n\tHaQWdersmuR22oplzUVE+mamLi6V7cYJIBrABfasRG9M40pd9ozo6VDToUAaltFHildM\n\tANUQ==","X-Gm-Message-State":"AOAM530cUuFI1DfJoAJwNC0BTyUrAv2j45AsKXplDBa+ubt8qrSfPEMh\n\t/BhRREtoKI1usHcaFix+pcwkhy9rSHxmIDUKMkmMtkzKbHY=","X-Google-Smtp-Source":"ABdhPJzxTNdVfpMUEg0t9B3MGf/fO8KPUw0Vszj+klTR23Ele5LrOyUn1/uRFyIzzPz7YUtSpVB7f6BBtn7KChEPvK4=","X-Received":"by 2002:a25:ca07:: with SMTP id\n\ta7mr12415225ybg.455.1617293505334; \n\tThu, 01 Apr 2021 09:11:45 -0700 (PDT)","MIME-Version":"1.0","References":"<20210401153123.1217170-1-hiroh@chromium.org>\n\t<20210401160530.an4mdgmalsn3dwig@uno.localdomain>","In-Reply-To":"<20210401160530.an4mdgmalsn3dwig@uno.localdomain>","From":"Hirokazu Honda ","Date":"Fri, 2 Apr 2021 01:11:35 +0900","Message-ID":"","To":"Jacopo Mondi ","Subject":"Re: [libcamera-devel] [PATCH 1/2] android: cameraDevice: Factorize\n\tthe code of validating camera3_capture_request","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16090,"web_url":"https://patchwork.libcamera.org/comment/16090/","msgid":"<77b7d1fa-22ea-b8fd-e25e-debd66c9ec3e@ideasonboard.com>","date":"2021-04-01T22:28:01","subject":"Re: [libcamera-devel] [PATCH 1/2] android: cameraDevice: Factorize\n\tthe code of validating camera3_capture_request","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 01/04/2021 17:05, Jacopo Mondi wrote:\n> Hi Hiro,\n> On Fri, Apr 02, 2021 at 12:31:22AM +0900, Hirokazu Honda wrote:\n>> CameraDevice::processCaptureRequest() checks the validness of a\n>> provided camera3_capture_request. This factorizes the code in\n>> order to add more validation to the request later.\n>>\n>> Signed-off-by: Hirokazu Honda \n>> ---\n>> src/android/camera_device.cpp | 24 ++++++++++++++++--------\n>> 1 file changed, 16 insertions(+), 8 deletions(-)\n>>\n>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n>> index eb327978..48eb471d 100644\n>> --- a/src/android/camera_device.cpp\n>> +++ b/src/android/camera_device.cpp\n>> @@ -256,6 +256,21 @@ void sortCamera3StreamConfigs(std::vector &unsortedConfigs,\n>> \tunsortedConfigs = sortedConfigs;\n>> }\n>>\n>> +bool isValidRequest(camera3_capture_request_t *camera3Request)\n>> +{\n>> +\tif (!camera3Request) {\n>> +\t\tLOG(HAL, Error) << \"No capture request provided\";\n>> +\t\treturn false;\n>> +\t}\n>> +\n>> +\tif (!camera3Request->num_output_buffers) {\n>> +\t\tLOG(HAL, Error) << \"No output buffers provided\";\n>> +\t\treturn -EINVAL;\n> \n> return false ?\n> \n> With this fixed\n> Reviewed-by: Jacopo Mondi \n> \n\nWith that,\n\nReviewed-by: Kieran Bingham \n\n> Thanks\n> j\n> \n>> +\t}\n>> +\n>> +\treturn true;\n>> +}\n>> +\n>> } /* namespace */\n>>\n>> /*\n>> @@ -1785,15 +1800,8 @@ int CameraDevice::processControls(Camera3RequestDescriptor *descriptor)\n>>\n>> int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)\n>> {\n>> -\tif (!camera3Request) {\n>> -\t\tLOG(HAL, Error) << \"No capture request provided\";\n>> -\t\treturn -EINVAL;\n>> -\t}\n>> -\n>> -\tif (!camera3Request->num_output_buffers) {\n>> -\t\tLOG(HAL, Error) << \"No output buffers provided\";\n>> +\tif (isValidRequest(camera3Request))\n>> \t\treturn -EINVAL;\n>> -\t}\n>>\n>> \t/* Start the camera if that's the first request we handle. */\n>> \tif (!running_) {\n>> --\n>> 2.31.0.291.g576ba9dcdaf-goog\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3E249BD695\n\tfor ;\n\tThu, 1 Apr 2021 22:28:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D25A6051B;\n\tFri, 2 Apr 2021 00:28:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DCD4C6051B\n\tfor ;\n\tFri, 2 Apr 2021 00:28:05 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 39D4080E;\n\tFri, 2 Apr 2021 00:28:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Rx2FSgZR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1617316085;\n\tbh=KVc/vtrRaXcq0ojW8kjUQaoVfto1kmsOi3x2oKlXj2k=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=Rx2FSgZReYdSZO5UplRfdX8rwmnkBMjA2fqVzD70z9RyAKNaz6CLkTvTZA3/RwSg2\n\twcunOq3nEXZt8iGlgP4SYKsW07sa2BwEaxzGP7oMkkU1/KRQgZR5w5b3VnwfjEAmKC\n\tyEehBTFrabguNOgmtYBo6mjnC1K/DZm0yBJPH/i8=","To":"Jacopo Mondi , Hirokazu Honda ","References":"<20210401153123.1217170-1-hiroh@chromium.org>\n\t<20210401160530.an4mdgmalsn3dwig@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<77b7d1fa-22ea-b8fd-e25e-debd66c9ec3e@ideasonboard.com>","Date":"Thu, 1 Apr 2021 23:28:01 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210401160530.an4mdgmalsn3dwig@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/2] android: cameraDevice: Factorize\n\tthe code of validating camera3_capture_request","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]