{"id":11811,"url":"https://patchwork.libcamera.org/api/patches/11811/?format=json","web_url":"https://patchwork.libcamera.org/patch/11811/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210401101340.160590-6-paul.elder@ideasonboard.com>","date":"2021-04-01T10:13:37","name":"[libcamera-devel,RFC,5/8] android: camera_device: Set noise reduction values for FULL requirements","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"acf52783a2e15717ac39b8f4798e4ebb9caafa50","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11811/mbox/","series":[{"id":1878,"url":"https://patchwork.libcamera.org/api/series/1878/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1878","date":"2021-04-01T10:13:32","name":"android: First set of FULL fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/1878/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11811/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11811/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9B03C0DA4\n\tfor ;\n\tThu, 1 Apr 2021 10:14:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87F8A68788;\n\tThu, 1 Apr 2021 12:14:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 020D06877D\n\tfor ;\n\tThu, 1 Apr 2021 12:14:03 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A6E75F7;\n\tThu, 1 Apr 2021 12:14:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NQpiwFtQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1617272042;\n\tbh=dekIEvQ68+4wkIbN3NGFvrZmLdKcvY2JvRv5zx0mktc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NQpiwFtQcyq0/GorDD4Gif9iHR/EDkyW18MM0MrHd4m6E877Q6E0PfjmXSl9GfMz0\n\to+GE7fNOgfozp8IDXxEixSPQJ6Uee572UmtnvI0Al3eZVHzabEzfpff1g6MzXYoUo4\n\tW57EqN7d5FILzK1BYXcel5H6plWIzADJbS0T/1CM=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 1 Apr 2021 19:13:37 +0900","Message-Id":"<20210401101340.160590-6-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210401101340.160590-1-paul.elder@ideasonboard.com>","References":"<20210401101340.160590-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC PATCH 5/8] android: camera_device: Set noise\n\treduction values for FULL requirements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Set the appropriate values for noise reduction to satisfy the\nrequirements for hardware level FULL. These are:\n- OFF and FAST and HIGH_QUALITY must be supported\n- the preview template should have noise reduction set to FAST\n- the capture result metadata should have the noise reduction mode set\n to the same mode as what was in the request metadata\n\nThis, along with \"android: camera_device: Add separate template for\nstill capture\" and \"android: camera_device: Set proper frame duration\",\nallows the following CTS tests to pass:\n- android.hardware.camera2.cts.CameraDeviceTest#testCameraDevicePreviewTemplate\n- android.hardware.camera2.cts.CameraDeviceTest#testCameraDeviceRecordingTemplate\n- android.hardware.camera2.cts.CameraDeviceTest#testCameraDeviceStillTemplate\n- android.hardware.camera2.cts.CaptureRequestTest#testNoiseReductionModeControl\n- android.hardware.camera2.cts.CaptureRequestTest#testNoiseReductionModeControlFastFps\n\nSigned-off-by: Paul Elder \n---\n src/android/camera_device.cpp | 13 +++++++++++--\n 1 file changed, 11 insertions(+), 2 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 0dcfc880..fc432263 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1087,12 +1087,18 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t{\n \t\tstd::vector data;\n \t\tdata.reserve(5);\n+\t\t/*\n+\t\t * \\todo if this doesn't have OFF and FAST and HIGH_QUALITY\n+\t\t * then this camera does not support FULL\n+\t\t */\n \t\tconst auto &infoMap = controlsInfo.find(&controls::draft::NoiseReductionMode);\n \t\tif (infoMap != controlsInfo.end()) {\n \t\t\tfor (const auto &value : infoMap->second.values())\n \t\t\t\tdata.push_back(value.get());\n \t\t} else {\n \t\t\tdata.push_back(ANDROID_NOISE_REDUCTION_MODE_OFF);\n+\t\t\tdata.push_back(ANDROID_NOISE_REDUCTION_MODE_FAST);\n+\t\t\tdata.push_back(ANDROID_NOISE_REDUCTION_MODE_HIGH_QUALITY);\n \t\t}\n \t\tstaticMetadata_->addEntry(ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n \t\t\t\t\t data.data(), data.size());\n@@ -1431,7 +1437,8 @@ std::unique_ptr CameraDevice::requestTemplatePreview()\n \trequestTemplate->addEntry(ANDROID_STATISTICS_FACE_DETECT_MODE,\n \t\t\t\t &faceDetectMode, 1);\n \n-\tuint8_t noiseReduction = ANDROID_NOISE_REDUCTION_MODE_OFF;\n+\t/* \\todo FULL expects this to be FAST, not OFF*/\n+\tuint8_t noiseReduction = ANDROID_NOISE_REDUCTION_MODE_FAST;\n \trequestTemplate->addEntry(ANDROID_NOISE_REDUCTION_MODE,\n \t\t\t\t &noiseReduction, 1);\n \n@@ -2197,7 +2204,9 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor,\n \t\t\t\t &value, 1);\n \n \tvalue = ANDROID_NOISE_REDUCTION_MODE_OFF;\n-\tresultMetadata->addEntry(ANDROID_NOISE_REDUCTION_MODE, &value, 1);\n+\tfound = settings.getEntry(ANDROID_NOISE_REDUCTION_MODE, &entry);\n+\tresultMetadata->addEntry(ANDROID_NOISE_REDUCTION_MODE,\n+\t\t\t\t found ? entry.data.u8 : &value, 1);\n \n \t/*\n \t * \\todo Use sliding window average\n","prefixes":["libcamera-devel","RFC","5/8"]}