[{"id":1567,"web_url":"https://patchwork.libcamera.org/comment/1567/","msgid":"<09594189-293e-56d9-653d-b285d6bc17a9@ideasonboard.com>","date":"2019-05-09T09:30:41","subject":"Re: [libcamera-devel] [PATCH 4/5] test: v4l2_device: Reset media\n\tlinks and set a resolution","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 08/05/2019 17:58, Niklas Söderlund wrote:\n> When initializing the test reset any media links and set a know\n> resolutions. This is needed to put the device under test into known\n> state and not have the v4l2 device tests depend on that no one have\n> touched the device before the test is executed.\n> \n> The resolution is picked purely at random and could possibly be moved to\n> each test case if there is a need for different resolutions for a\n> specific one.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> test/v4l2_device/v4l2_device_test.cpp | 19 ++++++++++++++++++-\n> 1 file changed, 18 insertions(+), 1 deletion(-)\n> \n> diff --git a/test/v4l2_device/v4l2_device_test.cpp b/test/v4l2_device/v4l2_device_test.cpp\n> index ee5a8e009bef2a5e..5bd80a6c68d796b6 100644\n> --- a/test/v4l2_device/v4l2_device_test.cpp\n> +++ b/test/v4l2_device/v4l2_device_test.cpp\n> @@ -54,7 +54,24 @@ int V4L2DeviceTest::init()\n> \tif (!capture_)\n> \t\treturn TestFail;\n> \n> -\treturn capture_->open();\n> +\tmedia_->acquire();\n\nShould you check the return code of acquire?\n\nDoes it block using lockf() internally?\n\n> +\tif (media_->disableLinks())\n\nWhere do we recreate / re-enable the links?\n\nor does it reset to a sane default?\n\n> +\t\treturn TestFail;\n\nIs it an issue here that the media_ is not released? I now can't recall\nif the acquire/release is about locking globally using lockf() or if\nit's just a state machine state change.\n\nIf it must be released - perhaps we should do some sort of auto-lock\nrelease by using the destructor of a local object, so that it releases\nwhen it goes out of scope.\n\n> +\tmedia_->release();\n> +\n> +\tif (capture_->open())\n> +\t\treturn TestFail;\n> +\n> +\tV4L2DeviceFormat format = {};\n> +\tif (capture_->getFormat(&format))\n> +\t\treturn TestFail;\n> +\n> +\tformat.size.width = 640;\n> +\tformat.size.height = 480;\n> +\tif (capture_->setFormat(&format))\n> +\t\treturn TestFail;\n> +\n> +\treturn TestPass;\n> }\n> \n> void V4L2DeviceTest::cleanup()\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 975C160E50\n\tfor ;\n\tThu, 9 May 2019 11:30:44 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 30DF8529;\n\tThu, 9 May 2019 11:30:44 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1557394244;\n\tbh=9a20Ua7ibipBiE46mqnz6rnGCe7DeSgtF/1gYEM/8xs=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=oYbmO0n8q9VK1yDoGq3nSlNpkkns1a3PdqnR7O6lX3NqJvTIEmo1eS4nzyMWRWYs2\n\tZa65WYsnG4ar3H8rMgfsyeOp582Zu7xNwdXiPiYORE2LJSxxozKVK33RWp3D74s0+k\n\tGIxofRHzE22j4O6bPJ9DJV2vfSLIERznphv+vdRA=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190508165814.26201-1-niklas.soderlund@ragnatech.se>\n\t<20190508165814.26201-5-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<09594189-293e-56d9-653d-b285d6bc17a9@ideasonboard.com>","Date":"Thu, 9 May 2019 10:30:41 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.6.1","MIME-Version":"1.0","In-Reply-To":"<20190508165814.26201-5-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 4/5] test: v4l2_device: Reset media\n\tlinks and set a resolution","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 09 May 2019 09:30:44 -0000"}},{"id":1571,"web_url":"https://patchwork.libcamera.org/comment/1571/","msgid":"<20190511022731.GD12768@pendragon.ideasonboard.com>","date":"2019-05-11T02:27:31","subject":"Re: [libcamera-devel] [PATCH 4/5] test: v4l2_device: Reset media\n\tlinks and set a resolution","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Thu, May 09, 2019 at 10:30:41AM +0100, Kieran Bingham wrote:\n> On 08/05/2019 17:58, Niklas Söderlund wrote:\n> > When initializing the test reset any media links and set a know\n> > resolutions. This is needed to put the device under test into known\n> > state and not have the v4l2 device tests depend on that no one have\n> > touched the device before the test is executed.\n> > \n> > The resolution is picked purely at random and could possibly be moved to\n> > each test case if there is a need for different resolutions for a\n> > specific one.\n> > \n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > test/v4l2_device/v4l2_device_test.cpp | 19 ++++++++++++++++++-\n> > 1 file changed, 18 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/test/v4l2_device/v4l2_device_test.cpp b/test/v4l2_device/v4l2_device_test.cpp\n> > index ee5a8e009bef2a5e..5bd80a6c68d796b6 100644\n> > --- a/test/v4l2_device/v4l2_device_test.cpp\n> > +++ b/test/v4l2_device/v4l2_device_test.cpp\n> > @@ -54,7 +54,24 @@ int V4L2DeviceTest::init()\n> > \tif (!capture_)\n> > \t\treturn TestFail;\n> > \n> > -\treturn capture_->open();\n> > +\tmedia_->acquire();\n> \n> Should you check the return code of acquire?\n> \n> Does it block using lockf() internally?\n\nIt won't block, it will return an error, so I think it's a good idea to\ncheck for that.\n\n> > +\tif (media_->disableLinks())\n> \n> Where do we recreate / re-enable the links?\n> \n> or does it reset to a sane default?\n\nIt won't enable links, so any test depending on this would have to\nenable links manually.\n\n> > +\t\treturn TestFail;\n> \n> Is it an issue here that the media_ is not released? I now can't recall\n> if the acquire/release is about locking globally using lockf() or if\n> it's just a state machine state change.\n> \n> If it must be released - perhaps we should do some sort of auto-lock\n> release by using the destructor of a local object, so that it releases\n> when it goes out of scope.\n\nlockf() will not persist once the file descriptor is closed, so it\nshouldn't be a problem, but proper error handling is still a good idea.\n\nWith those issues fixed,\n\nReviewed-by: Laurent Pinchart \n\n> > +\tmedia_->release();\n> > +\n> > +\tif (capture_->open())\n> > +\t\treturn TestFail;\n> > +\n> > +\tV4L2DeviceFormat format = {};\n> > +\tif (capture_->getFormat(&format))\n> > +\t\treturn TestFail;\n> > +\n> > +\tformat.size.width = 640;\n> > +\tformat.size.height = 480;\n> > +\tif (capture_->setFormat(&format))\n> > +\t\treturn TestFail;\n> > +\n> > +\treturn TestPass;\n> > }\n> > \n> > void V4L2DeviceTest::cleanup()","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 81A5460E4D\n\tfor ;\n\tSat, 11 May 2019 04:27:48 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9AEB82DF;\n\tSat, 11 May 2019 04:27:47 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1557541667;\n\tbh=NYe0RvsqGYB4PsY0iW/at+LBwW/ha1ihVl5cFzSteF8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oyiLEP2d6NW0Or7/AIvo4a6uPUnAtMfZZ5wYFuEq47cRDF9TYhVG8yAs262DHbBWJ\n\tsa3wBbm0IId+2GF6HBd2y6vsYwigEqGIOUoQeEzlRB9LAD6hEpO2PzH1Dm5rtMuiDg\n\tAzVes1Pvv2l9tpFr/Om5/vx52jm/0bZPT8FPBTUc=","Date":"Sat, 11 May 2019 05:27:31 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Niklas =?utf-8?q?S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20190511022731.GD12768@pendragon.ideasonboard.com>","References":"<20190508165814.26201-1-niklas.soderlund@ragnatech.se>\n\t<20190508165814.26201-5-niklas.soderlund@ragnatech.se>\n\t<09594189-293e-56d9-653d-b285d6bc17a9@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<09594189-293e-56d9-653d-b285d6bc17a9@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 4/5] test: v4l2_device: Reset media\n\tlinks and set a resolution","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 11 May 2019 02:27:48 -0000"}},{"id":1580,"web_url":"https://patchwork.libcamera.org/comment/1580/","msgid":"<20190511110348.GJ28561@bigcity.dyn.berto.se>","date":"2019-05-11T11:03:48","subject":"Re: [libcamera-devel] [PATCH 4/5] test: v4l2_device: Reset media\n\tlinks and set a resolution","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran, Laurent,\n\nThanks for your feedback.\n\nOn 2019-05-11 05:27:31 +0300, Laurent Pinchart wrote:\n> Hello,\n> \n> On Thu, May 09, 2019 at 10:30:41AM +0100, Kieran Bingham wrote:\n> > On 08/05/2019 17:58, Niklas Söderlund wrote:\n> > > When initializing the test reset any media links and set a know\n> > > resolutions. This is needed to put the device under test into known\n> > > state and not have the v4l2 device tests depend on that no one have\n> > > touched the device before the test is executed.\n> > > \n> > > The resolution is picked purely at random and could possibly be moved to\n> > > each test case if there is a need for different resolutions for a\n> > > specific one.\n> > > \n> > > Signed-off-by: Niklas Söderlund \n> > > ---\n> > > test/v4l2_device/v4l2_device_test.cpp | 19 ++++++++++++++++++-\n> > > 1 file changed, 18 insertions(+), 1 deletion(-)\n> > > \n> > > diff --git a/test/v4l2_device/v4l2_device_test.cpp b/test/v4l2_device/v4l2_device_test.cpp\n> > > index ee5a8e009bef2a5e..5bd80a6c68d796b6 100644\n> > > --- a/test/v4l2_device/v4l2_device_test.cpp\n> > > +++ b/test/v4l2_device/v4l2_device_test.cpp\n> > > @@ -54,7 +54,24 @@ int V4L2DeviceTest::init()\n> > > \tif (!capture_)\n> > > \t\treturn TestFail;\n> > > \n> > > -\treturn capture_->open();\n> > > +\tmedia_->acquire();\n> > \n> > Should you check the return code of acquire?\n> > \n> > Does it block using lockf() internally?\n> \n> It won't block, it will return an error, so I think it's a good idea to\n> check for that.\n\nGood catch, I will add a check for the return code.\n\n> \n> > > +\tif (media_->disableLinks())\n> > \n> > Where do we recreate / re-enable the links?\n> > \n> > or does it reset to a sane default?\n> \n> It won't enable links, so any test depending on this would have to\n> enable links manually.\n\nYes, each test who inherits from the base would need to enable links if \nit depends on them being enabled.\n\n> \n> > > +\t\treturn TestFail;\n> > \n> > Is it an issue here that the media_ is not released? I now can't recall\n> > if the acquire/release is about locking globally using lockf() or if\n> > it's just a state machine state change.\n> > \n> > If it must be released - perhaps we should do some sort of auto-lock\n> > release by using the destructor of a local object, so that it releases\n> > when it goes out of scope.\n> \n> lockf() will not persist once the file descriptor is closed, so it\n> shouldn't be a problem, but proper error handling is still a good idea.\n\nI feel that handling the error here and call release() if we can't reset \nthe links is a bit overkill for a test case and reduces the readability \nof the code for little gain. I do however not feel strongly about this \nand will do so in the next version.\n\n> \n> With those issues fixed,\n> \n> Reviewed-by: Laurent Pinchart \n> \n> > > +\tmedia_->release();\n> > > +\n> > > +\tif (capture_->open())\n> > > +\t\treturn TestFail;\n> > > +\n> > > +\tV4L2DeviceFormat format = {};\n> > > +\tif (capture_->getFormat(&format))\n> > > +\t\treturn TestFail;\n> > > +\n> > > +\tformat.size.width = 640;\n> > > +\tformat.size.height = 480;\n> > > +\tif (capture_->setFormat(&format))\n> > > +\t\treturn TestFail;\n> > > +\n> > > +\treturn TestPass;\n> > > }\n> > > \n> > > void V4L2DeviceTest::cleanup()\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6CE7960E4F\n\tfor ;\n\tSat, 11 May 2019 13:03:50 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id e13so7127064ljl.11\n\tfor ;\n\tSat, 11 May 2019 04:03:50 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tj27sm2106807lfk.97.2019.05.11.04.03.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSat, 11 May 2019 04:03:48 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=zJd4zucCuzHyEOt7m7icHEhbQjdZ7aM4X5DJj8nrvTc=;\n\tb=TAFYq6ZL6ViDorsiaHgQk8SodncMBsTWmqCUsrYgGGUnVxSU37W415mfdpTix7kzMX\n\tIvcGMYJnYtsCwolqqPXXKZCJI3uHVhCOIjoWP64XgqvhHW6kGFp+o2dy5Wdt0IwrV4oz\n\toSC5zqrBCK6xo5gI6T6LQPztPrTkZTTGb4z113ID9aarVbngbB1ranuROw88Seg76eHG\n\tXbdLKE0CmhLhQp+w1tG3HvMv38Geimc+Gyh9NphCMR9ceSZ70SnHyQmaI2aOlHTKd8DE\n\t+zKfysU9udwMG9VN4yGndoFr6Ke6y50KPhZBKdkzcLwQ7Xg/vGRbUIoQP6FX0DsNEMcU\n\tjLoQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=zJd4zucCuzHyEOt7m7icHEhbQjdZ7aM4X5DJj8nrvTc=;\n\tb=TP0ERynZTCUB3sAAUa1mK9z1zlLr7SLONPWZDep496kITvQq70a2BOBjkSuB3Ww3yI\n\tdzJ/iRv9X6CVSJVCTYRlrhs9yl+y+CFKwPaHcxRQ7w7NpvI6aH+CCrjMlw7pbRYBXXX3\n\teBWHjmrGqaO03UTaEs6hQ6SptARKt8q5KzjyArSJyzIEuOvN5H1CJ+MKMqQQVbQjCETu\n\tYpSMKOSsc+GvfI79xrwx1QnoLi9CjGqhDAJLqqtg5kATxiRR9ZnTUAgP+pMUVYeiKq3R\n\tTp6rzTRyyLe1+33VFz/ALfk0G//HvGoGkwpZHTPUxUqoJZtnxhg1Ikt5aS0eTEloDZ8C\n\tjcWQ==","X-Gm-Message-State":"APjAAAU5IdanABPmL9M0L6RyvwYLXkVZ6XN5+sx36LF4lliMCuK8Noc5\n\tqOjpKfchP+cYjm30VX9luusUlUjjTxQ=","X-Google-Smtp-Source":"APXvYqz3hn2yN5SJpNySGj+Eps0X4vlXmbhmtiIfjLqAs3fa8ndd12rdQbpQyA6gixe9LnwOTHqGCw==","X-Received":"by 2002:a2e:206:: with SMTP id 6mr7707154ljc.59.1557572629874;\n\tSat, 11 May 2019 04:03:49 -0700 (PDT)","Date":"Sat, 11 May 2019 13:03:48 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20190511110348.GJ28561@bigcity.dyn.berto.se>","References":"<20190508165814.26201-1-niklas.soderlund@ragnatech.se>\n\t<20190508165814.26201-5-niklas.soderlund@ragnatech.se>\n\t<09594189-293e-56d9-653d-b285d6bc17a9@ideasonboard.com>\n\t<20190511022731.GD12768@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190511022731.GD12768@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH 4/5] test: v4l2_device: Reset media\n\tlinks and set a resolution","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 11 May 2019 11:03:50 -0000"}}]