[{"id":16107,"web_url":"https://patchwork.libcamera.org/comment/16107/","msgid":"","date":"2021-04-03T02:59:00","subject":"Re: [libcamera-devel] [PATCH v3 5/5] android: soraka: Add camera\n\tHAL configuration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Mar 30, 2021 at 04:21:13PM +0200, Jacopo Mondi wrote:\n> Add camera HAL configuration file for IPU3 Soraka.\n> \n> Reviewed-by: Laurent Pinchart \n> Reviewed-by: Hirokazu Honda \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/data/soraka/camera_hal.yaml | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n> create mode 100644 src/android/data/soraka/camera_hal.yaml\n> \n> diff --git a/src/android/data/soraka/camera_hal.yaml b/src/android/data/soraka/camera_hal.yaml\n> new file mode 100644\n> index 000000000000..605f3096b726\n> --- /dev/null\n> +++ b/src/android/data/soraka/camera_hal.yaml\n> @@ -0,0 +1,10 @@\n> +cameras:\n> + \"\\\\_SB_.PCI0.I2C4.CAM1\":\n> + model: ov5670\n\nI've just realized we don't use the model. Should we drop it, or do you\nenvision it being used in the future ?\n\n> + location: front\n> + rotation: 0\n> +\n> + \"\\\\_SB_.PCI0.I2C2.CAM0\":\n> + model: ov13858\n> + location: back\n> + rotation: 0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C5E7BD695\n\tfor ;\n\tSat, 3 Apr 2021 02:59:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12E5E68788;\n\tSat, 3 Apr 2021 04:59:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2CFC602D7\n\tfor ;\n\tSat, 3 Apr 2021 04:59:45 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 53B5F3D7;\n\tSat, 3 Apr 2021 04:59:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PBs25jXZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1617418785;\n\tbh=EIBfGFLszsiPLTZmC/j20KE/3YWqUBZRdGHsvGTdnk0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PBs25jXZCC2afkh5MrsmFWkkhsZg/t3YSCCk2f1UHaXz4oLtiEbYp4HOazJOZhERm\n\tuNb7WtBIUdKB/j14XixuyceF1IJ+18W/tiM/z84jZNWu7gjBeqpQD3FONP3nZ28d65\n\tK+V7bwaR6R+HkqV2p6pTMClGaHK9YEqhjM3EJePg=","Date":"Sat, 3 Apr 2021 05:59:00 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210330142113.37457-1-jacopo@jmondi.org>\n\t<20210330142113.37457-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210330142113.37457-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 5/5] android: soraka: Add camera\n\tHAL configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]