[{"id":16056,"web_url":"https://patchwork.libcamera.org/comment/16056/","msgid":"<20210330103334.7my5tuvhvt4hgq2e@basti-TUXEDO-Book-XA1510>","date":"2021-03-30T10:33:34","subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Fix typo in a\n\tcomment","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"Hey Naushir,\n\nThank you for the patch.\nJust out of curiosity so this assert makes sure that bayerRequeueCount\nwas not increased more than once during each loop cycle right? Because\notherwise this assert just checks the same condition that the if clause\nabove checks, right? Because every increase of the variable comes with a\npop from the queue.\n\nOn 30.03.2021 08:56, Naushir Patuck wrote:\n>s/embedded/bayer/\n>\n>Signed-off-by: Naushir Patuck \nReviewed-by: Sebastian Fricke \n\n>---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n>diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>index f22e286ed87a..2a917455500f 100644\n>--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>@@ -1802,7 +1802,7 @@ bool RPiCameraData::findMatchingBuffers(BayerFrame &bayerFrame, FrameBuffer *&em\n> \t\t\t * pending embedded data buffers.\n> \t\t\t */\n> \t\t\tif (bayerRequeueCount == unicam_[Unicam::Image].getBuffers().size()) {\n>-\t\t\t\t/* The embedded queue must be empty at this point! */\n>+\t\t\t\t/* The bayer queue must be empty at this point! */\n> \t\t\t\tASSERT(bayerQueue_.empty());\n>\n> \t\t\t\tLOG(RPI, Warning) << \"Flushing embedded data stream!\";\n>-- \n>2.25.1\n>\n>_______________________________________________\n>libcamera-devel mailing list\n>libcamera-devel@lists.libcamera.org\n>https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41FF4C0DA3\n\tfor ;\n\tTue, 30 Mar 2021 10:33:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B5A368781;\n\tTue, 30 Mar 2021 12:33:39 +0200 (CEST)","from mout01.posteo.de (mout01.posteo.de [185.67.36.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDFC7602D2\n\tfor ;\n\tTue, 30 Mar 2021 12:33:37 +0200 (CEST)","from submission (posteo.de [89.146.220.130]) \n\tby mout01.posteo.de (Postfix) with ESMTPS id 038A7160060\n\tfor ;\n\tTue, 30 Mar 2021 12:33:36 +0200 (CEST)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4F8m4v3ptPz9rxg;\n\tTue, 30 Mar 2021 12:33:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"eKkNV+8d\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1617100417; bh=b4rTrO2APXumm+sOzWW851rmL7OAZcOk/XQeKxFivzc=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=eKkNV+8dzdIAGOgyZKCURKCPI/jv3gNzz+LJMem+X0neQtmrY3TmgMRTCyc23Odgc\n\tPhFJE8bYlYtWW2GG4Qja4kJV53l74oKhN6DiX/MtieVG7eXkV43EUQDtlNWeSslRR9\n\tpyYbWpQzmSXOrdk0YrV2VaguDkgX8Y30O59VkEUWEr7rKIj/MD0t+230yaiq7Vj/mL\n\tz9RFciddTWVmL0YPzVHIDVI+ytiQujIKXFsrR47XkiW/vB2L1YuP8fqvEFYvRe4gqW\n\tsxUh3CXbUS/klVWeUMd6917VBOdPoRgwvQxdwzwiB+oaSkXGKIP/YU3Ad1sPfC0GDG\n\tntLIYT4v10AIQ==","Date":"Tue, 30 Mar 2021 12:33:34 +0200","From":"Sebastian Fricke ","To":"Naushir Patuck ","Message-ID":"<20210330103334.7my5tuvhvt4hgq2e@basti-TUXEDO-Book-XA1510>","References":"<20210330075626.996126-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210330075626.996126-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Fix typo in a\n\tcomment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16060,"web_url":"https://patchwork.libcamera.org/comment/16060/","msgid":"","date":"2021-03-30T10:52:41","subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Fix typo in a\n\tcomment","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Sebastian,\n\nOn Tue, 30 Mar 2021 at 11:33, Sebastian Fricke \nwrote:\n\n> Hey Naushir,\n>\n> Thank you for the patch.\n> Just out of curiosity so this assert makes sure that bayerRequeueCount\n> was not increased more than once during each loop cycle right? Because\n> otherwise this assert just checks the same condition that the if clause\n> above checks, right? Because every increase of the variable comes with a\n> pop from the queue.\n>\n\nConceptually, there are 2 queues, one for the buffers available to use. and\nanother for the buffers that have been filled up by the device. The assert\nhere\nis to ensure commonality between the two when all of the buffers have been\nrecycled back to the device. Hope that make sense :)\n\nRegards,\nNaush\n\n\n\n>\n> On 30.03.2021 08:56, Naushir Patuck wrote:\n> >s/embedded/bayer/\n> >\n> >Signed-off-by: Naushir Patuck \n> Reviewed-by: Sebastian Fricke \n>\n> >---\n> > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> >diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> >index f22e286ed87a..2a917455500f 100644\n> >--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> >+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> >@@ -1802,7 +1802,7 @@ bool RPiCameraData::findMatchingBuffers(BayerFrame\n> &bayerFrame, FrameBuffer *&em\n> > * pending embedded data buffers.\n> > */\n> > if (bayerRequeueCount ==\n> unicam_[Unicam::Image].getBuffers().size()) {\n> >- /* The embedded queue must be empty at\n> this point! */\n> >+ /* The bayer queue must be empty at this\n> point! */\n> > ASSERT(bayerQueue_.empty());\n> >\n> > LOG(RPI, Warning) << \"Flushing embedded\n> data stream!\";\n> >--\n> >2.25.1\n> >\n> >_______________________________________________\n> >libcamera-devel mailing list\n> >libcamera-devel@lists.libcamera.org\n> >https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17A45C0DA3\n\tfor ;\n\tTue, 30 Mar 2021 10:53:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 85EE3602DB;\n\tTue, 30 Mar 2021 12:53:00 +0200 (CEST)","from mail-lf1-x133.google.com (mail-lf1-x133.google.com\n\t[IPv6:2a00:1450:4864:20::133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 449F8602D2\n\tfor ;\n\tTue, 30 Mar 2021 12:52:58 +0200 (CEST)","by mail-lf1-x133.google.com with SMTP id n138so23119328lfa.3\n\tfor ;\n\tTue, 30 Mar 2021 03:52:58 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"FEN8eFYR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=qh+4t7PeVels9oWw9ZHWafGUIBmkv5xi/Yo0I1mif1w=;\n\tb=FEN8eFYRZmJF8JowybgbtRM9qdvsloVoh5HbM1DoADy/6br7y2hJ2E3Te4qJVJ6m+s\n\t6TJ/xfwSVMWb3IfHkfgDR66SwZb4ei9xDbWB1J/5czkeooqji80DEnnAYi3LxPAtgd0r\n\tPm/sPet7wW+OrhZm42RwOrjNoS3FNPAo0iASutDjcrHmJVm4We095wtQq97FXLuuao8L\n\tbr9vU3bxl+18uHyVqay6qnaoAzVlokd7JQrVrTzF2wNk63zXsnaTa5BmxfWOHhApYyKR\n\tzAa2qdWPeMqnkeCcnR6SdraZQEUh3DbmK6iD+CP8enC8BJak4hrLGwQUYqGAjGrPY8JX\n\tfrHg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=qh+4t7PeVels9oWw9ZHWafGUIBmkv5xi/Yo0I1mif1w=;\n\tb=nCraPNRjvdxl9BXL2UvRV3nbnn2jk5I1lNFtztCapvcNIThndu1o8aEc15J1g5HCGC\n\tSJE9nEFgzw12WMEBixBqDnqCUlPypJkEofx2FaY1NAJzImY+0dFtvRPo9nsKeMMyEJjZ\n\tJWNM+C0mbHbzKOhoGY4vaSHJU29zmOCgQ5CWeeOW3Brx3OT+1Eb8EndLHdcomabW35JP\n\tAQ9d99rC9zccILAJQdYZ1wYms6NvxoxASJJfTAv0037a8LFCeFDPHIOXZ0agIg8Uz/18\n\tyYiL0Vv8lnqrweni8y0IuMJj7UiQUG/Et+dCeY5364M9c5QxZz8i4yqzeefIFhGFGekW\n\tcvzw==","X-Gm-Message-State":"AOAM532cxG7/zoYF5abTIvlYaTUCP2XUMkxfZPPvZe08AdN60qBNbpD/\n\tjl/ttUZ1SxE6zkg0DydRVTt4CW/S3f8yzK8OU004/w==","X-Google-Smtp-Source":"ABdhPJxsLLNjIiiZ4/Zl7QYyKVlbKyreBHEE0piYZX8zql+KYZ9GJh45z2mowPMXscAW+6RCTFPiZEX2QROSM6YuUYE=","X-Received":"by 2002:a05:6512:3c84:: with SMTP id\n\th4mr1177127lfv.617.1617101577711; \n\tTue, 30 Mar 2021 03:52:57 -0700 (PDT)","MIME-Version":"1.0","References":"<20210330075626.996126-1-naush@raspberrypi.com>\n\t<20210330103334.7my5tuvhvt4hgq2e@basti-TUXEDO-Book-XA1510>","In-Reply-To":"<20210330103334.7my5tuvhvt4hgq2e@basti-TUXEDO-Book-XA1510>","From":"Naushir Patuck ","Date":"Tue, 30 Mar 2021 11:52:41 +0100","Message-ID":"","To":"Sebastian Fricke ","Subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Fix typo in a\n\tcomment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============3246288692356017042==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]