[{"id":16061,"web_url":"https://patchwork.libcamera.org/comment/16061/","msgid":"<9f1247f0-2949-a421-12b7-e5c544414318@ideasonboard.com>","date":"2021-03-30T18:48:52","subject":"Re: [libcamera-devel] [PATCH v4 1/2] android: CameraDevice: Add\n\tstop()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Hiro,\n\nOn 30/03/2021 06:46, Hirokazu Honda wrote:\n> This adds CameraDevice::stop(), which cleans up the member\n> variables of CameraDevice. It is called in CameraDevice::close()\n> and CameraDevice::configureStreams().\n> \n> Signed-off-by: Hirokazu Honda \n> ---\n> src/android/camera_device.cpp | 19 +++++++++++--------\n> src/android/camera_device.h | 2 ++\n> 2 files changed, 13 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index ae693664..14299429 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -657,11 +657,18 @@ int CameraDevice::open(const hw_module_t *hardwareModule)\n> \n> void CameraDevice::close()\n> {\n> -\tstreams_.clear();\n\nHere CameraDevice::close() no longer clears the stream_, and it's not\nadded anywhere else.\n\nIs this intentional?\n\nIt seems like a functional change which is not mentioned by the commit\nmessage and stands out a bit.\n\nIs it handled automatically elsewhere already?\n\n\n> +\tstop();\n> +\n> +\tcamera_->release();\n> +}\n> +\n> +void CameraDevice::stop()\n> +{\n> +\tif (!running_)\n> +\t\treturn;\n> \n> \tworker_.stop();\n> \tcamera_->stop();\n> -\tcamera_->release();\n> \n> \trunning_ = false;\n> }\n> @@ -1545,12 +1552,8 @@ PixelFormat CameraDevice::toPixelFormat(int format) const\n> */\n> int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> {\n> -\t/* Before any configuration attempt, stop the camera if it's running. */\n> -\tif (running_) {\n> -\t\tworker_.stop();\n> -\t\tcamera_->stop();\n> -\t\trunning_ = false;\n> -\t}\n> +\t/* Before any configuration attempt, stop the camera. */\n> +\tstop();\n> \n> \t/*\n> \t * Generate an empty configuration, and construct a StreamConfiguration\n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index 11bdfec8..39cf95ad 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -85,6 +85,8 @@ private:\n> \t\tint androidFormat;\n> \t};\n> \n> +\tvoid stop();\n> +\n> \tint initializeStreamConfigurations();\n> \tstd::vector\n> \tgetYUVResolutions(libcamera::CameraConfiguration *cameraConfig,\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 00B4EC0DA4\n\tfor ;\n\tTue, 30 Mar 2021 18:48:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F8386877F;\n\tTue, 30 Mar 2021 20:48:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5669F602D2\n\tfor ;\n\tTue, 30 Mar 2021 20:48:56 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5AB38102;\n\tTue, 30 Mar 2021 20:48:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lgokgzcz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1617130135;\n\tbh=AEvHL8xa9/GY1a9c0tAUjRXY09RQkJWEQzk+vlbg7aw=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=lgokgzczE0KrHBs/iu9OBy/L6z06rKkakcsdx2oaq/KsM8rH9Rvvlfwh4/i/Pj1/T\n\tDtqaLUSSgQij4aX52RMEcEjv1QLEaXmhQNF0Z91bF+2AAxwcN2xpoVVzNkRgqCiWIa\n\twSvmNcrOYRY5f1YgAk+MnZQx2E+dCo4+XLjGpf08=","To":"Hirokazu Honda , libcamera-devel@lists.libcamera.org","References":"<20210330054642.387562-1-hiroh@chromium.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<9f1247f0-2949-a421-12b7-e5c544414318@ideasonboard.com>","Date":"Tue, 30 Mar 2021 19:48:52 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210330054642.387562-1-hiroh@chromium.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v4 1/2] android: CameraDevice: Add\n\tstop()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16066,"web_url":"https://patchwork.libcamera.org/comment/16066/","msgid":"","date":"2021-03-31T05:54:10","subject":"Re: [libcamera-devel] [PATCH v4 1/2] android: CameraDevice: Add\n\tstop()","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Kieran,\n\nOn Wed, Mar 31, 2021 at 3:48 AM Kieran Bingham\n wrote:\n>\n> Hi Hiro,\n>\n> On 30/03/2021 06:46, Hirokazu Honda wrote:\n> > This adds CameraDevice::stop(), which cleans up the member\n> > variables of CameraDevice. It is called in CameraDevice::close()\n> > and CameraDevice::configureStreams().\n> >\n> > Signed-off-by: Hirokazu Honda \n> > ---\n> > src/android/camera_device.cpp | 19 +++++++++++--------\n> > src/android/camera_device.h | 2 ++\n> > 2 files changed, 13 insertions(+), 8 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index ae693664..14299429 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -657,11 +657,18 @@ int CameraDevice::open(const hw_module_t *hardwareModule)\n> >\n> > void CameraDevice::close()\n> > {\n> > - streams_.clear();\n>\n> Here CameraDevice::close() no longer clears the stream_, and it's not\n> added anywhere else.\n>\n> Is this intentional?\n>\n> It seems like a functional change which is not mentioned by the commit\n> message and stands out a bit.\n>\n> Is it handled automatically elsewhere already?\n>\n\nThat's definitely my fault. I will add revert it on close() in the next patch.\nThanks for finding.\n\n>\n> > + stop();\n> > +\n> > + camera_->release();\n> > +}\n> > +\n> > +void CameraDevice::stop()\n> > +{\n> > + if (!running_)\n> > + return;\n> >\n> > worker_.stop();\n> > camera_->stop();\n> > - camera_->release();\n> >\n> > running_ = false;\n> > }\n> > @@ -1545,12 +1552,8 @@ PixelFormat CameraDevice::toPixelFormat(int format) const\n> > */\n> > int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> > {\n> > - /* Before any configuration attempt, stop the camera if it's running. */\n> > - if (running_) {\n> > - worker_.stop();\n> > - camera_->stop();\n> > - running_ = false;\n> > - }\n> > + /* Before any configuration attempt, stop the camera. */\n> > + stop();\n> >\n> > /*\n> > * Generate an empty configuration, and construct a StreamConfiguration\n> > diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> > index 11bdfec8..39cf95ad 100644\n> > --- a/src/android/camera_device.h\n> > +++ b/src/android/camera_device.h\n> > @@ -85,6 +85,8 @@ private:\n> > int androidFormat;\n> > };\n> >\n> > + void stop();\n> > +\n> > int initializeStreamConfigurations();\n> > std::vector\n> > getYUVResolutions(libcamera::CameraConfiguration *cameraConfig,\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2BAEBC0DA4\n\tfor ;\n\tWed, 31 Mar 2021 05:54:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 871536877F;\n\tWed, 31 Mar 2021 07:54:23 +0200 (CEST)","from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com\n\t[IPv6:2607:f8b0:4864:20::b2e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F613602DB\n\tfor ;\n\tWed, 31 Mar 2021 07:54:21 +0200 (CEST)","by mail-yb1-xb2e.google.com with SMTP id m132so19965117ybf.2\n\tfor ;\n\tTue, 30 Mar 2021 22:54:21 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Y4jeb9X8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=ry0H+PdLQcqiaKkQBsJMVBvqS+uf8Gd6fEMc1uvt+pU=;\n\tb=Y4jeb9X8jDC77EUekmgc+TaMBGJUPhekhz58xLZhUMOOfGZOzRqq8adRC0mns3bDRM\n\tPDJJjDxRPtwVOlVwrj5FIl3WWJLCFi6wMZIj4x6jkhZoawr1VIbzPNL5YQZl6ndB9K3G\n\tDhg2yn4LFw3ALPXHrfgVVjgyKV9qN7qyywpSs=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=ry0H+PdLQcqiaKkQBsJMVBvqS+uf8Gd6fEMc1uvt+pU=;\n\tb=gDnN9Mw51tLOXCsSd8q+gx7sw6uoQibe4d6l7KW75o9j+6KwoHgoGoj8kmdHE+8ccb\n\tRcPjftVq9XWfTZNHgktU2y14nZhJIPofhe5daZepnzq7Q8EHO94n9IQvL7LjlsdGIbI0\n\twSAxSvzJovVg5al9fC9EJiWB+mEDIHz/Bos6lDd5FBMicbwsZA9DqzS16FjBwfbaicbx\n\tzPFC+vhKkREs/04AeG5vaXFiTfkuZ8An9bRIacV1VVoMY4HtgBVhr4bM94KG4hyVOY+L\n\t9NGTR/aAd/TkA2FpAQHQKYwzJsXpQ7XkXr0MvN7GirOvoz07azD1IOhdGGweoOG+B+gB\n\twkUA==","X-Gm-Message-State":"AOAM5332UaAAjNvZ/Yk9yvr1+QptjEPQosHmQrfroixOduu1+P2Msg8V\n\txU0UcBzHfcwAXbi2mFbdr4bqvsExcRZnkiqCr4/suR4qgiI=","X-Google-Smtp-Source":"ABdhPJzEx5nHRbw1UIO9i5Ui2OrixIMn3dXpq7eO2A1zsULKOrBYB9z8KG0CJsYfO6HgZHdDpk7P91eMv3JO7yBLVNE=","X-Received":"by 2002:a25:c905:: with SMTP id z5mr2398245ybf.461.1617170060415;\n\tTue, 30 Mar 2021 22:54:20 -0700 (PDT)","MIME-Version":"1.0","References":"<20210330054642.387562-1-hiroh@chromium.org>\n\t<9f1247f0-2949-a421-12b7-e5c544414318@ideasonboard.com>","In-Reply-To":"<9f1247f0-2949-a421-12b7-e5c544414318@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Wed, 31 Mar 2021 14:54:10 +0900","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [PATCH v4 1/2] android: CameraDevice: Add\n\tstop()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]