{"id":11783,"url":"https://patchwork.libcamera.org/api/patches/11783/?format=json","web_url":"https://patchwork.libcamera.org/patch/11783/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210330052521.381550-4-hiroh@chromium.org>","date":"2021-03-30T05:25:20","name":"[libcamera-devel,v3,3/4] android: CameraDevice: Log rotation variables in camera3_stream","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"aa8aab5fcc7f325c563518dd01cbfafdc457b27c","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11783/mbox/","series":[{"id":1866,"url":"https://patchwork.libcamera.org/api/series/1866/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1866","date":"2021-03-30T05:25:17","name":"Regard crop_rotate_scale_degrees in configuration","version":3,"mbox":"https://patchwork.libcamera.org/series/1866/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11783/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11783/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6FBAC32F0\n\tfor ;\n\tTue, 30 Mar 2021 05:25:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5155568787;\n\tTue, 30 Mar 2021 07:25:36 +0200 (CEST)","from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com\n\t[IPv6:2607:f8b0:4864:20::52d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99C696877F\n\tfor ;\n\tTue, 30 Mar 2021 07:25:33 +0200 (CEST)","by mail-pg1-x52d.google.com with SMTP id k8so1726694pgf.4\n\tfor ;\n\tMon, 29 Mar 2021 22:25:33 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:c112:2822:484f:486])\n\tby smtp.gmail.com with ESMTPSA id\n\tu79sm19726006pfc.207.2021.03.29.22.25.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 29 Mar 2021 22:25:31 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"LK5P1HNp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=uzJ5NBH/VKVvgZ8hs4XPVTW2Cjo7mcmmi+r7ZDRXFN0=;\n\tb=LK5P1HNpip8OSedLYC0P9HDPjNUtzP0fvriZvlC5DHFYws8MATbiAARkQAlNF/arMp\n\tmcGSdaLF+V4RUNu5GaPid533toK7Wu3bmskrG4w/bRJYfOHYD0vvZ6s/Dx6lBhsV31pm\n\tWb/tjsCuHIe8cInYmYw3gsc0fIG9aOq2N6lQM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=uzJ5NBH/VKVvgZ8hs4XPVTW2Cjo7mcmmi+r7ZDRXFN0=;\n\tb=eVdzpDoEQMhJEsh39KGJBkd1HywnJE3U8UbC4ej/qSjGdcqOLgurnoVtNBYRPt0BEl\n\tCBQufjVAr6VGWDqGsxtEtW8i0SZGWNfkY5JDlXpUb1K7xmadI9dBwhrKrCZaCVWB04lr\n\tPpxy9tSEvo3q0Y2nKurv28CvAE1a13/vADLJeQeucysWE3a0NYHt/SOiF7budplRuNph\n\teISHYKEji9aff7u1TSSxibV3xTtp5YeBsyb/xzfWsMZpSvUc2YRi5FM61f76WOLhzOXx\n\tdPMDWJKxZx0+l7GGXb0/lZzH+nyqRm1Y+apO+EXiwORHHCCrb2K2/JVTZBFpuPDGZOae\n\tNUUQ==","X-Gm-Message-State":"AOAM531Q4AMJGiVfSNl37mGgpxLYxJ32YKs0dO/PAvzQr3ZQeMdOcgDj\n\tmgjrc7cpdqnpy0dWBfT7vxtPfrFChu+ekQ==","X-Google-Smtp-Source":"ABdhPJzppM1fI2BVHtW1BNXp8kbW+OYbgSE3d2NDSmKxquGWYv7tqSFUvBOE2kqbmSy3j1YgNJuW+g==","X-Received":"by 2002:a63:d449:: with SMTP id\n\ti9mr26133523pgj.227.1617081932056; \n\tMon, 29 Mar 2021 22:25:32 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 30 Mar 2021 14:25:20 +0900","Message-Id":"<20210330052521.381550-4-hiroh@chromium.org>","X-Mailer":"git-send-email 2.31.0.291.g576ba9dcdaf-goog","In-Reply-To":"<20210330052521.381550-1-hiroh@chromium.org>","References":"<20210330052521.381550-1-hiroh@chromium.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 3/4] android: CameraDevice: Log\n\trotation variables in camera3_stream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"|rotation| and |crop_rotate_scale_degrees| are important info of\na configuration. They should be logged.\n\nSigned-off-by: Hirokazu Honda \nReviewed-by: Jacopo Mondi \nReviewed-by: Laurent Pinchart \n---\n src/android/camera_device.cpp | 20 ++++++++++++++++++++\n 1 file changed, 20 insertions(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex f88e94bc..e0eaa3b5 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -256,6 +256,21 @@ void sortCamera3StreamConfigs(std::vector &unsortedConfigs,\n \tunsortedConfigs = sortedConfigs;\n }\n \n+const char *rotationToString(int rotation)\n+{\n+\tswitch (rotation) {\n+\tcase CAMERA3_STREAM_ROTATION_0:\n+\t\treturn \"0\";\n+\tcase CAMERA3_STREAM_ROTATION_90:\n+\t\treturn \"90\";\n+\tcase CAMERA3_STREAM_ROTATION_180:\n+\t\treturn \"180\";\n+\tcase CAMERA3_STREAM_ROTATION_270:\n+\t\treturn \"270\";\n+\t}\n+\treturn \"INVALID\";\n+}\n+\n #if defined(CHROMEOS)\n /*\n * Check whether the crop_rotate_scale_degrees values for all streams in\n@@ -1632,6 +1647,11 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \t\t\t << \", width: \" << stream->width\n \t\t\t << \", height: \" << stream->height\n \t\t\t << \", format: \" << utils::hex(stream->format)\n+\t\t\t << \", rotation: \" << rotationToString(stream->rotation)\n+#if defined(CHROMEOS)\n+\t\t\t << \", crop_rotate_scale_degrees: \"\n+\t\t\t << rotationToString(stream->crop_rotate_scale_degrees)\n+#endif\n \t\t\t << \" (\" << format.toString() << \")\";\n \n \t\tif (!format.isValid())\n","prefixes":["libcamera-devel","v3","3/4"]}