[{"id":1569,"web_url":"https://patchwork.libcamera.org/comment/1569/","msgid":"<20190511014546.GB12768@pendragon.ideasonboard.com>","date":"2019-05-11T01:45:46","subject":"Re: [libcamera-devel] [PATCH 1/5] test: v4l2_device: Order class\n\tsections","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Wed, May 08, 2019 at 06:58:10PM +0200, Niklas Söderlund wrote:\n> Order the sections of a class public, protected and private. There is no\n> functional change only restructuring of existing code to align with the\n> style of other tests.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/v4l2_device/buffer_sharing.cpp | 16 ++++++++--------\n> 1 file changed, 8 insertions(+), 8 deletions(-)\n> \n> diff --git a/test/v4l2_device/buffer_sharing.cpp b/test/v4l2_device/buffer_sharing.cpp\n> index 45b07fc4905b826e..09695239ee4b9e80 100644\n> --- a/test/v4l2_device/buffer_sharing.cpp\n> +++ b/test/v4l2_device/buffer_sharing.cpp\n> @@ -27,14 +27,6 @@ public:\n> \t{\n> \t}\n> \n> -private:\n> -\tconst unsigned int bufferCount = 4;\n> -\n> -\tV4L2Device *output_;\n> -\n> -\tunsigned int framesCaptured_;\n> -\tunsigned int framesOutput_;\n> -\n> protected:\n> \tint init()\n> \t{\n> @@ -182,6 +174,14 @@ protected:\n> \n> \t\tV4L2DeviceTest::cleanup();\n> \t}\n> +\n> +private:\n> +\tconst unsigned int bufferCount = 4;\n> +\n> +\tV4L2Device *output_;\n> +\n> +\tunsigned int framesCaptured_;\n> +\tunsigned int framesOutput_;\n> };\n> \n> TEST_REGISTER(BufferSharingTest);\n> -- \n> 2.21.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4D0E60E4D\n\tfor ;\n\tSat, 11 May 2019 03:46:10 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 245A32DF;\n\tSat, 11 May 2019 03:46:10 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1557539170;\n\tbh=2eAMF2jUTkmczhwa0w2ZsDbg/XfQ1qwHt1Smgrk1fJQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=j/pymSC4W4Og/rB/Kxa0IPYVpVwXeZJH+B2G4A6stujK7FNejpo0RN8gMptfbLS7H\n\tJB8koR+Z+IFLFuyxb8n3fckfpVdPbeSfZPkOqxxJisBDMl5OCkQdx8/rp62Ipbo6Hj\n\tqPBhs/Xg6c5V9dU3CVb3rtX3Gn8tZUZ3mzq2FqMg=","Date":"Sat, 11 May 2019 04:45:46 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190511014546.GB12768@pendragon.ideasonboard.com>","References":"<20190508165814.26201-1-niklas.soderlund@ragnatech.se>\n\t<20190508165814.26201-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190508165814.26201-2-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/5] test: v4l2_device: Order class\n\tsections","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 11 May 2019 01:46:11 -0000"}}]