[{"id":16034,"web_url":"https://patchwork.libcamera.org/comment/16034/","msgid":"","date":"2021-03-30T00:14:16","subject":"Re: [libcamera-devel] [PATCH v2 6/6] android: soraka: Add camera\n\tHAL configuration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Mar 29, 2021 at 05:28:07PM +0200, Jacopo Mondi wrote:\n> Add camera HAL configuration file for IPU3 Soraka.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/data/soraka/camera_hal.yaml | 13 +++++++++++++\n> 1 file changed, 13 insertions(+)\n> create mode 100644 src/android/data/soraka/camera_hal.yaml\n> \n> diff --git a/src/android/data/soraka/camera_hal.yaml b/src/android/data/soraka/camera_hal.yaml\n> new file mode 100644\n> index 000000000000..59d1cdedb2c8\n> --- /dev/null\n> +++ b/src/android/data/soraka/camera_hal.yaml\n> @@ -0,0 +1,13 @@\n> +manufacturer: Google\n> +model: Soraka\n> +\n> +cameras:\n> + \"\\\\_SB_.PCI0.I2C4.CAM1\":\n> + model: \"ov5670\"\n\nNo need for quotes for model and location, same below.\n\n> + location: \"front\"\n> + rotation: 0\n> +\n> + \"\\\\_SB_.PCI0.I2C2.CAM0\":\n> + model: \"ov13858\"\n> + location: \"back\"\n> + rotation: 0\n\nI'm sure we'll bikeshed lots of topics, including the name of the\nconfiguration file, and possibly the option of storing data for multiple\ndevices in a single file, but that's for later.\n\nReviewed-by: Laurent Pinchart ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C154AC32F0\n\tfor ;\n\tTue, 30 Mar 2021 00:15:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 218C568782;\n\tTue, 30 Mar 2021 02:15:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ECFF4602D7\n\tfor ;\n\tTue, 30 Mar 2021 02:15:00 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 522EF102;\n\tTue, 30 Mar 2021 02:15:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mmRNzIbp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1617063300;\n\tbh=Pz7C069MMDiSTzHprT2R8O4sDqgoImoxxU6JFtnzHMY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mmRNzIbproM+rLUVvl6epp7Sa1mnI/a8fq8rX3ad8jGB9vX9Q0xERTSEBDVdtVIdE\n\tbyY2/VW2ptGrjTmeW0vydWOAro+8fzRCLTbSK0nCg6VrO9kfeCx01mm25eFJVN5Uxn\n\tufav8Tl11QASNaNIg1xYe0LtgkKWeywgT+ByT2eE=","Date":"Tue, 30 Mar 2021 03:14:16 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210329152807.28331-1-jacopo@jmondi.org>\n\t<20210329152807.28331-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210329152807.28331-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 6/6] android: soraka: Add camera\n\tHAL configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16043,"web_url":"https://patchwork.libcamera.org/comment/16043/","msgid":"","date":"2021-03-30T03:30:45","subject":"Re: [libcamera-devel] [PATCH v2 6/6] android: soraka: Add camera\n\tHAL configuration","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Jacopo. Thanks for the patch.\n\nOn Tue, Mar 30, 2021 at 9:15 AM Laurent Pinchart\n wrote:\n>\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Mon, Mar 29, 2021 at 05:28:07PM +0200, Jacopo Mondi wrote:\n> > Add camera HAL configuration file for IPU3 Soraka.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/android/data/soraka/camera_hal.yaml | 13 +++++++++++++\n> > 1 file changed, 13 insertions(+)\n> > create mode 100644 src/android/data/soraka/camera_hal.yaml\n> >\n> > diff --git a/src/android/data/soraka/camera_hal.yaml b/src/android/data/soraka/camera_hal.yaml\n> > new file mode 100644\n> > index 000000000000..59d1cdedb2c8\n> > --- /dev/null\n> > +++ b/src/android/data/soraka/camera_hal.yaml\n> > @@ -0,0 +1,13 @@\n> > +manufacturer: Google\n> > +model: Soraka\n> > +\n> > +cameras:\n> > + \"\\\\_SB_.PCI0.I2C4.CAM1\":\n> > + model: \"ov5670\"\n>\n> No need for quotes for model and location, same below.\n>\n> > + location: \"front\"\n> > + rotation: 0\n> > +\n> > + \"\\\\_SB_.PCI0.I2C2.CAM0\":\n> > + model: \"ov13858\"\n> > + location: \"back\"\n> > + rotation: 0\n>\n> I'm sure we'll bikeshed lots of topics, including the name of the\n> configuration file, and possibly the option of storing data for multiple\n> devices in a single file, but that's for later.\n>\n> Reviewed-by: Laurent Pinchart \n>\n\nReviewed-by: Hirokazu Honda \n\n> --\n> Regards,\n>\n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E0FA4C32F0\n\tfor ;\n\tTue, 30 Mar 2021 03:31:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 422BF68786;\n\tTue, 30 Mar 2021 05:31:01 +0200 (CEST)","from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n\t[IPv6:2a00:1450:4864:20::632])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6CD71602D7\n\tfor ;\n\tTue, 30 Mar 2021 05:30:59 +0200 (CEST)","by mail-ej1-x632.google.com with SMTP id a7so22585786ejs.3\n\tfor ;\n\tMon, 29 Mar 2021 20:30:59 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"cIZUeqJ5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=tmdd9hdo5c2aBhS0w+fUgIZRkWlCg6IwLg1KPYD8BfY=;\n\tb=cIZUeqJ5xNKDeCytrGiTQ8vq++f6ChYLfpKRJbkXQP9cm5ten+XU7aVw8Ky/KciGIz\n\tqIUSpHRD7C+P1D2ogXm1eGySOm80vYlIoB/XL0AlSiItXdohcI3QxGBRvim3wPyqVni+\n\tkUo4a0EEGiYrYKEjp++bHo8B4Jlzf7LQDmoxw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=tmdd9hdo5c2aBhS0w+fUgIZRkWlCg6IwLg1KPYD8BfY=;\n\tb=UXkahgYzwwQD2PiGoqgnMszhE0ssLWuJwa1OrsgY9aKpId2L+RuRKBXiqfXKPzTa5I\n\t3ZM8bGhHpNDpsEh9/+shby6hFVe8USyEKZx+D43PHTOaZAX0PC2cWSPnernJidQYcw38\n\tp1bHoSPHZN5lXjIlvjka2zYQIbhUBHFt7DWbQZDbpMZfX3OqdvUIOYBokINOhXP2AxYH\n\t36tDHWDY6FF0SVBabtA7OgqMSJkXlLDX2QWePSiaUil6fHnG40uh41bDfR1blLgFYWoZ\n\tlgT7ZD+dOJ1CfXgCEoOdVCTarY499QQJtpTg8c8hkhQPKlzrifh2Q/qoKsyHO/TtLTUD\n\tE0RQ==","X-Gm-Message-State":"AOAM532TVhM7ZMdc90PZjYOizGjE0UTt36K4iKvybU2LwPImU5va4Szr\n\t/nAt+gx+/UoBWdvS4T/hIsEIYEBRqTbtVOx/Aps7GA==","X-Google-Smtp-Source":"ABdhPJyOTTw1d66d+guIo55khb5S9IhN4dJLBq96avCsMjVVdmx+oa1Ygj+C1hqpGdtufqvrCGAzgJeRhahWaAWoyAs=","X-Received":"by 2002:a17:906:4747:: with SMTP id\n\tj7mr30902417ejs.221.1617075058969; \n\tMon, 29 Mar 2021 20:30:58 -0700 (PDT)","MIME-Version":"1.0","References":"<20210329152807.28331-1-jacopo@jmondi.org>\n\t<20210329152807.28331-6-jacopo@jmondi.org>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Tue, 30 Mar 2021 12:30:45 +0900","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v2 6/6] android: soraka: Add camera\n\tHAL configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]