[{"id":16035,"web_url":"https://patchwork.libcamera.org/comment/16035/","msgid":"","date":"2021-03-30T00:15:03","subject":"Re: [libcamera-devel] [PATCH v2 4/6] android: camera_hal_manager:\n\tUse CameraHalConfig","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Mar 29, 2021 at 05:28:05PM +0200, Jacopo Mondi wrote:\n> Store the HAL configuration in the camera manager.\n> \n> Reviewed-by: Niklas Söderlund \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_hal_manager.cpp | 6 +++++-\n> src/android/camera_hal_manager.h | 3 +++\n> 2 files changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\n> index bf3fcda75237..f79789b5bfb8 100644\n> --- a/src/android/camera_hal_manager.cpp\n> +++ b/src/android/camera_hal_manager.cpp\n> @@ -39,13 +39,17 @@ CameraHalManager::~CameraHalManager() = default;\n> \n> int CameraHalManager::init()\n> {\n> +\tint ret = halConfig_.open();\n> +\tif (ret)\n> +\t\treturn ret;\n> +\n> \tcameraManager_ = std::make_unique();\n> \n> \t/* Support camera hotplug. */\n> \tcameraManager_->cameraAdded.connect(this, &CameraHalManager::cameraAdded);\n> \tcameraManager_->cameraRemoved.connect(this, &CameraHalManager::cameraRemoved);\n> \n> -\tint ret = cameraManager_->start();\n> +\tret = cameraManager_->start();\n> \tif (ret) {\n> \t\tLOG(HAL, Error) << \"Failed to start camera manager: \"\n> \t\t\t\t<< strerror(-ret);\n> diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h\n> index d9bf27989965..af1581da6579 100644\n> --- a/src/android/camera_hal_manager.h\n> +++ b/src/android/camera_hal_manager.h\n> @@ -19,6 +19,8 @@\n> \n> #include \n> \n> +#include \"camera_hal_config.h\"\n> +\n> class CameraDevice;\n> \n> class CameraHalManager\n> @@ -50,6 +52,7 @@ private:\n> \tCameraDevice *cameraDeviceFromHalId(unsigned int id);\n> \n> \tstd::unique_ptr cameraManager_;\n> +\tCameraHalConfig halConfig_;\n> \n> \tconst camera_module_callbacks_t *callbacks_;\n> \tstd::vector> cameras_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D6F7C32F0\n\tfor ;\n\tTue, 30 Mar 2021 00:15:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CEA1A68782;\n\tTue, 30 Mar 2021 02:15:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7147E602D7\n\tfor ;\n\tTue, 30 Mar 2021 02:15:48 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ADB6E102;\n\tTue, 30 Mar 2021 02:15:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iqbTeHOe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1617063348;\n\tbh=PnH2ZrU7iYcAyBO6UpO79Pxzn/e8qRAmme251iKqczg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=iqbTeHOee5ri3sZyGnOQMDahGkcREcJMEW0e3vPwd9wkfFu/gwQEW6hoOqjTuSzeA\n\tjT3QKBmnsm9iwTTYEDl5gCHBedCy/NxwbYn9Rh6JKk52xyW9fFcuI44p0r+zplVn7N\n\tQIbDhXU8lUF/vsh0HfzV/DE9nenuJ3ozY2aJ5u/Y=","Date":"Tue, 30 Mar 2021 03:15:03 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210329152807.28331-1-jacopo@jmondi.org>\n\t<20210329152807.28331-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210329152807.28331-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 4/6] android: camera_hal_manager:\n\tUse CameraHalConfig","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16039,"web_url":"https://patchwork.libcamera.org/comment/16039/","msgid":"","date":"2021-03-30T02:14:50","subject":"Re: [libcamera-devel] [PATCH v2 4/6] android: camera_hal_manager:\n\tUse CameraHalConfig","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi, Jacopo, thanks for the patch.\n\nOn Tue, Mar 30, 2021 at 9:15 AM Laurent Pinchart\n wrote:\n>\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Mon, Mar 29, 2021 at 05:28:05PM +0200, Jacopo Mondi wrote:\n> > Store the HAL configuration in the camera manager.\n> >\n> > Reviewed-by: Niklas Söderlund \n> > Signed-off-by: Jacopo Mondi \n>\n> Reviewed-by: Laurent Pinchart \n>\n\nReviewed-by: Hirokazu Honda \n\n> > ---\n> > src/android/camera_hal_manager.cpp | 6 +++++-\n> > src/android/camera_hal_manager.h | 3 +++\n> > 2 files changed, 8 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\n> > index bf3fcda75237..f79789b5bfb8 100644\n> > --- a/src/android/camera_hal_manager.cpp\n> > +++ b/src/android/camera_hal_manager.cpp\n> > @@ -39,13 +39,17 @@ CameraHalManager::~CameraHalManager() = default;\n> >\n> > int CameraHalManager::init()\n> > {\n> > + int ret = halConfig_.open();\n> > + if (ret)\n> > + return ret;\n> > +\n> > cameraManager_ = std::make_unique();\n> >\n> > /* Support camera hotplug. */\n> > cameraManager_->cameraAdded.connect(this, &CameraHalManager::cameraAdded);\n> > cameraManager_->cameraRemoved.connect(this, &CameraHalManager::cameraRemoved);\n> >\n> > - int ret = cameraManager_->start();\n> > + ret = cameraManager_->start();\n> > if (ret) {\n> > LOG(HAL, Error) << \"Failed to start camera manager: \"\n> > << strerror(-ret);\n> > diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h\n> > index d9bf27989965..af1581da6579 100644\n> > --- a/src/android/camera_hal_manager.h\n> > +++ b/src/android/camera_hal_manager.h\n> > @@ -19,6 +19,8 @@\n> >\n> > #include \n> >\n> > +#include \"camera_hal_config.h\"\n> > +\n> > class CameraDevice;\n> >\n> > class CameraHalManager\n> > @@ -50,6 +52,7 @@ private:\n> > CameraDevice *cameraDeviceFromHalId(unsigned int id);\n> >\n> > std::unique_ptr cameraManager_;\n> > + CameraHalConfig halConfig_;\n> >\n> > const camera_module_callbacks_t *callbacks_;\n> > std::vector> cameras_;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BF5BEC32F0\n\tfor ;\n\tTue, 30 Mar 2021 02:15:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4F9168782;\n\tTue, 30 Mar 2021 04:15:04 +0200 (CEST)","from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com\n\t[IPv6:2a00:1450:4864:20::52f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BCFD602D7\n\tfor ;\n\tTue, 30 Mar 2021 04:15:03 +0200 (CEST)","by mail-ed1-x52f.google.com with SMTP id dm8so16363618edb.2\n\tfor ;\n\tMon, 29 Mar 2021 19:15:03 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"M9gBdj7m\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=o0Q022Sl5XP6/b46tsAHTYC87thQWCv4cUwv+R6sHRU=;\n\tb=M9gBdj7mI0k1rVWDMrJOV5/Vj/7n3WBT71R/CWQZk1MJ6h3b78R8V32OyLkdGXtUSq\n\tSbfOZWVXJT0vAXTX/+bC+9kiBlC7cH6BADRO7Vit3j14zcFuV6Kf6ru1jeIwiozddp8u\n\tl1q3DIeznVnsYa64mdt2ELUZnwImbtsuOoGkA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=o0Q022Sl5XP6/b46tsAHTYC87thQWCv4cUwv+R6sHRU=;\n\tb=OdaSDYDPxYtymLa5tRMgbNH+zpyY/LOCGrXtQ3pO4VxQMSRjM4Jr07Rf0Kz9UWfKPw\n\touF4J5hkhi06e9aDQ9qjg3RB5qRDrFQ2eeNLJx2OUbkNzmQUhCQCyqomE0o/PXmGJT0H\n\tBdSFCmqAhHIOaSc2KpnK68wNDLD/DL+OHJI9TmsnmBaBseurGqknkRAdakW8tfQdGELT\n\t++J1FX0Yv53UFLM24PwKENN75bXMIGeICuheuT4pnj/BJ46flvQkvablkNwAALLwU+/X\n\tAbN5tm0iKfLCLINuQH6z8OWFgx1CLhTBALeGrmqXCvNpkzIUI364neWQniZ5XOtRAZAi\n\tIRxQ==","X-Gm-Message-State":"AOAM532yEa/BiDw6eUzuiCogQLc0LrvAE/a7uQ59iiw8e7QD6x3YpMBC\n\tFKWm7pdHW3UYPhVpQY4ZO3AkiUCfTLBwtdPRWZnoJw==","X-Google-Smtp-Source":"ABdhPJzwNxfu/seeiARZL8hNOcSF0EfuXHhhLU/t5iAqP5ZVgysGq7tKKLZtimWsqVYqzhSS+nFxQKIy/ICqCUkDYOc=","X-Received":"by 2002:aa7:c7da:: with SMTP id\n\to26mr31694736eds.244.1617070503019; \n\tMon, 29 Mar 2021 19:15:03 -0700 (PDT)","MIME-Version":"1.0","References":"<20210329152807.28331-1-jacopo@jmondi.org>\n\t<20210329152807.28331-4-jacopo@jmondi.org>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Tue, 30 Mar 2021 11:14:50 +0900","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v2 4/6] android: camera_hal_manager:\n\tUse CameraHalConfig","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]