[{"id":16010,"web_url":"https://patchwork.libcamera.org/comment/16010/","msgid":"<20210329092203.uuqzk4obms5mggqr@uno.localdomain>","date":"2021-03-29T09:22:03","subject":"Re: [libcamera-devel] [PATCH v2 1/3] libcamera: PipelineHandler:\n\tMake queueRequest() void function","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Hiro,\n\nOn Mon, Mar 29, 2021 at 06:15:50PM +0900, Hirokazu Honda wrote:\n> PipelineHandler::queueRequest() is asynchronously invoked in\n> Camera::queueRequest(). Therefore the return value of\n> PipelineHandler::queueRequest() is useless. This changes the\n> function to a void function.\n>\n> Signed-off-by: Hirokazu Honda \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> include/libcamera/internal/pipeline_handler.h | 2 +-\n> src/libcamera/camera.cpp | 6 ++++--\n> src/libcamera/pipeline_handler.cpp | 6 +-----\n> 3 files changed, 6 insertions(+), 8 deletions(-)\n>\n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index 6aca0b46..093b94c6 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -79,7 +79,7 @@ public:\n> \tvirtual int start(Camera *camera, const ControlList *controls) = 0;\n> \tvirtual void stop(Camera *camera) = 0;\n>\n> -\tint queueRequest(Request *request);\n> +\tvoid queueRequest(Request *request);\n>\n> \tbool completeBuffer(Request *request, FrameBuffer *buffer);\n> \tvoid completeRequest(Request *request);\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 84edbb8f..2611c701 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -996,8 +996,10 @@ int Camera::queueRequest(Request *request)\n> \t\t}\n> \t}\n>\n> -\treturn d->pipe_->invokeMethod(&PipelineHandler::queueRequest,\n> -\t\t\t\t ConnectionTypeQueued, request);\n> +\td->pipe_->invokeMethod(&PipelineHandler::queueRequest,\n> +\t\t\t ConnectionTypeQueued, request);\n> +\n> +\treturn 0;\n> }\n>\n> /**\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index d22991d3..eba00ed3 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -371,10 +371,8 @@ const ControlList &PipelineHandler::properties(const Camera *camera) const\n> * signalled by the pipeline handler using the completeRequest() method.\n> *\n> * \\context This function is called from the CameraManager thread.\n> - *\n> - * \\return 0 on success or a negative error code otherwise\n> */\n> -int PipelineHandler::queueRequest(Request *request)\n> +void PipelineHandler::queueRequest(Request *request)\n> {\n> \tLIBCAMERA_TRACEPOINT(request_queue, request);\n>\n> @@ -385,8 +383,6 @@ int PipelineHandler::queueRequest(Request *request)\n> \tint ret = queueRequestDevice(camera, request);\n> \tif (ret)\n> \t\tdata->queuedRequests_.remove(request);\n> -\n> -\treturn ret;\n> }\n>\n> /**\n> --\n> 2.31.0.291.g576ba9dcdaf-goog\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D48B1C32EF\n\tfor ;\n\tMon, 29 Mar 2021 09:21:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3956968783;\n\tMon, 29 Mar 2021 11:21:29 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D7D66877E\n\tfor ;\n\tMon, 29 Mar 2021 11:21:28 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 01E7C20000C;\n\tMon, 29 Mar 2021 09:21:27 +0000 (UTC)"],"Date":"Mon, 29 Mar 2021 11:22:03 +0200","From":"Jacopo Mondi ","To":"Hirokazu Honda ","Message-ID":"<20210329092203.uuqzk4obms5mggqr@uno.localdomain>","References":"<20210329091552.157208-1-hiroh@chromium.org>\n\t<20210329091552.157208-2-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210329091552.157208-2-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] libcamera: PipelineHandler:\n\tMake queueRequest() void function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16100,"web_url":"https://patchwork.libcamera.org/comment/16100/","msgid":"","date":"2021-04-03T01:09:08","subject":"Re: [libcamera-devel] [PATCH v2 1/3] libcamera: PipelineHandler:\n\tMake queueRequest() void function","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch.\n\nOn Mon, Mar 29, 2021 at 06:15:50PM +0900, Hirokazu Honda wrote:\n> PipelineHandler::queueRequest() is asynchronously invoked in\n> Camera::queueRequest(). Therefore the return value of\n> PipelineHandler::queueRequest() is useless. This changes the\n> function to a void function.\n> \n> Signed-off-by: Hirokazu Honda \n> Reviewed-by: Laurent Pinchart \n\nI'll apply this already as it doesn't require the rest of the series.\n\n> ---\n> include/libcamera/internal/pipeline_handler.h | 2 +-\n> src/libcamera/camera.cpp | 6 ++++--\n> src/libcamera/pipeline_handler.cpp | 6 +-----\n> 3 files changed, 6 insertions(+), 8 deletions(-)\n> \n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index 6aca0b46..093b94c6 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -79,7 +79,7 @@ public:\n> \tvirtual int start(Camera *camera, const ControlList *controls) = 0;\n> \tvirtual void stop(Camera *camera) = 0;\n> \n> -\tint queueRequest(Request *request);\n> +\tvoid queueRequest(Request *request);\n> \n> \tbool completeBuffer(Request *request, FrameBuffer *buffer);\n> \tvoid completeRequest(Request *request);\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 84edbb8f..2611c701 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -996,8 +996,10 @@ int Camera::queueRequest(Request *request)\n> \t\t}\n> \t}\n> \n> -\treturn d->pipe_->invokeMethod(&PipelineHandler::queueRequest,\n> -\t\t\t\t ConnectionTypeQueued, request);\n> +\td->pipe_->invokeMethod(&PipelineHandler::queueRequest,\n> +\t\t\t ConnectionTypeQueued, request);\n> +\n> +\treturn 0;\n> }\n> \n> /**\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index d22991d3..eba00ed3 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -371,10 +371,8 @@ const ControlList &PipelineHandler::properties(const Camera *camera) const\n> * signalled by the pipeline handler using the completeRequest() method.\n> *\n> * \\context This function is called from the CameraManager thread.\n> - *\n> - * \\return 0 on success or a negative error code otherwise\n> */\n> -int PipelineHandler::queueRequest(Request *request)\n> +void PipelineHandler::queueRequest(Request *request)\n> {\n> \tLIBCAMERA_TRACEPOINT(request_queue, request);\n> \n> @@ -385,8 +383,6 @@ int PipelineHandler::queueRequest(Request *request)\n> \tint ret = queueRequestDevice(camera, request);\n> \tif (ret)\n> \t\tdata->queuedRequests_.remove(request);\n> -\n> -\treturn ret;\n> }\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3D90C0DA3\n\tfor ;\n\tSat, 3 Apr 2021 01:09:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F638602CF;\n\tSat, 3 Apr 2021 03:09:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC2A6602CF\n\tfor ;\n\tSat, 3 Apr 2021 03:09:53 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3C1543D7;\n\tSat, 3 Apr 2021 03:09:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TxQXm45j\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1617412193;\n\tbh=rssK2UJxTsU3GVKy4WYUwcmDcr5fD23gKlC2i4jnmOU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TxQXm45jqTyWxn9MJxE71aE2nB3d6zV2/zRQQvUlES+e9u/+246TB9o49DoOXFeaW\n\t7hwXw/IJxMY6Qi8zaJsNNbeN5GUNwn/XuuXxB13OECwU7YhqNrbK6+svVNYVouFV5n\n\tjqManLhm298Y4P/UpGRKRtMnyzimbM7VY9EZS3hM=","Date":"Sat, 3 Apr 2021 04:09:08 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210329091552.157208-1-hiroh@chromium.org>\n\t<20210329091552.157208-2-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210329091552.157208-2-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] libcamera: PipelineHandler:\n\tMake queueRequest() void function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]