[{"id":16005,"web_url":"https://patchwork.libcamera.org/comment/16005/","msgid":"<20210329081601.GC2475@pyrite.rasen.tech>","date":"2021-03-29T08:16:01","subject":"Re: [libcamera-devel] [PATCH]\n\t/src/libcamera/pipeline/raspberrypi/rpi_stream.h: modify the head\n\tfile","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hello Siyuan,\n\nThe patch title doesn't contribute any useful information. What about\nthe header are you modifying? You only have 75 characters, so you need\nto be concise.\n\nAlso the prefix in this case can just be raspberrypi:. So an example of\nan appropriate patch title would be:\n\nraspberrypi: rpi_stream: include the proper ipa_interface header\n\nThere of course may be other acceptable variations.\n\nOn Mon, Mar 29, 2021 at 03:47:22PM +0800, Siyuan Fan wrote:\n> From: Fan Siyuan \n\nThis is only needed if the sender is different from the committer.\n\nYou also need a changelog here. A paragraph (or a sentence for a patch\nthis small) to describe why you are making what kind of change.\n\n> Signed-off-by: Fan Siyuan \n> ---\n> src/libcamera/pipeline/raspberrypi/rpi_stream.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/rpi_stream.h b/src/libcamera/pipeline/raspberrypi/rpi_stream.h\n> index f1ac715f..0f002212 100644\n> --- a/src/libcamera/pipeline/raspberrypi/rpi_stream.h\n> +++ b/src/libcamera/pipeline/raspberrypi/rpi_stream.h\n> @@ -13,7 +13,7 @@\n> #include \n> \n> #include \n> -#include \n> +#include \n\nThere is documentation on this, but it's still under review so it can\nonly be found on the mailing list [1].\n\nThe interface (including data structures and functions) between the\npipeline handler and the IPA is customizable, in mojom files under\ninclude/libcamera/ipa/. For example, the raspberrypi IPA interface is\ndefined in include/libcamera/ipa/raspberrypi.mojom. At compile time,\nthis mojom file is processed and the IPA interface header is generated\n(a few other files are generated as well). For raspberrypi, the\ngenerated IPA interface header is raspberrypi_ipa_interface.h, which\nwill be generated in $BUILD_DIR/include/libcamera/ipa/. This header\nincludes the definition of the custom data structures and the\nIPAInterface specification, according to the definition in the mojom\nfile. rpi_stream.h uses ipa::RPi::MaskID, which is defined in\nraspberrypi.mojom, and will be present in raspberrypi_ipa_interface.h,\nso rpi_stream.h needs to include raspberrypi_ipa_interface.h, not\nipa_interface.h.\n\nSorry for this being so mysterious. That's why I wanted to document\nit...\n\n[1] https://patchwork.libcamera.org/patch/11526/#patch\n\n\nPaul\n\n> #include \n> \n> #include \"libcamera/internal/v4l2_videodevice.h\"\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E337C32EF\n\tfor ;\n\tMon, 29 Mar 2021 08:16:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C95C68783;\n\tMon, 29 Mar 2021 10:16:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6ACCD6877E\n\tfor ;\n\tMon, 29 Mar 2021 10:16:09 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F0F7931A;\n\tMon, 29 Mar 2021 10:16:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ew4hT8Q6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1617005769;\n\tbh=XR9G7C+h46S7WuWZ3xN9cjuJ4DwFrmm39C1UkSCjQug=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ew4hT8Q6K/wAyk9immJnTBM5HJ9DWx1D1lQCFIOzwr9UJq4EQepUP56aROcP4+DLN\n\tBNvvYb3HzY1u2HEqducUw4ZlDEGVllI2+jV5JcyX2vNkFwra+z1AWAhkYEjF4Qf2g7\n\taPVxZ+01v9DwdssTThOzzV3tMaakqJ140wPjnEJg=","Date":"Mon, 29 Mar 2021 17:16:01 +0900","From":"paul.elder@ideasonboard.com","To":"Siyuan Fan ","Message-ID":"<20210329081601.GC2475@pyrite.rasen.tech>","References":"","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH]\n\t/src/libcamera/pipeline/raspberrypi/rpi_stream.h: modify the head\n\tfile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]