[{"id":15986,"web_url":"https://patchwork.libcamera.org/comment/15986/","msgid":"","date":"2021-03-29T04:39:48","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: PipelineHandler: Make\n\tqueueRequest() void function","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch.\n\nOn Mon, Mar 29, 2021 at 09:27:13AM +0900, Hirokazu Honda wrote:\n> PipelineHandler::queueRequest() is asynchronously invoked in\n> Camera::queueRequest(). Therefore the return value of\n> PipelineHandler::queueRequest() is useless. This changes the\n> function to a void function.\n> \n> Signed-off-by: Hirokazu Honda \n> ---\n> include/libcamera/internal/pipeline_handler.h | 2 +-\n> src/libcamera/camera.cpp | 6 ++++--\n> src/libcamera/pipeline_handler.cpp | 4 +---\n> 3 files changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index 6aca0b46..093b94c6 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -79,7 +79,7 @@ public:\n> \tvirtual int start(Camera *camera, const ControlList *controls) = 0;\n> \tvirtual void stop(Camera *camera) = 0;\n> \n> -\tint queueRequest(Request *request);\n> +\tvoid queueRequest(Request *request);\n> \n> \tbool completeBuffer(Request *request, FrameBuffer *buffer);\n> \tvoid completeRequest(Request *request);\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 84edbb8f..2611c701 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -996,8 +996,10 @@ int Camera::queueRequest(Request *request)\n> \t\t}\n> \t}\n> \n> -\treturn d->pipe_->invokeMethod(&PipelineHandler::queueRequest,\n> -\t\t\t\t ConnectionTypeQueued, request);\n> +\td->pipe_->invokeMethod(&PipelineHandler::queueRequest,\n> +\t\t\t ConnectionTypeQueued, request);\n> +\n> +\treturn 0;\n> }\n> \n> /**\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index d22991d3..05b807d6 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -374,7 +374,7 @@ const ControlList &PipelineHandler::properties(const Camera *camera) const\n> *\n> * \\return 0 on success or a negative error code otherwise\n\nNot anymore :-) You can just drop this line.\n\nReviewed-by: Laurent Pinchart \n\n> */\n> -int PipelineHandler::queueRequest(Request *request)\n> +void PipelineHandler::queueRequest(Request *request)\n> {\n> \tLIBCAMERA_TRACEPOINT(request_queue, request);\n> \n> @@ -385,8 +385,6 @@ int PipelineHandler::queueRequest(Request *request)\n> \tint ret = queueRequestDevice(camera, request);\n> \tif (ret)\n> \t\tdata->queuedRequests_.remove(request);\n> -\n> -\treturn ret;\n> }\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53642C32EF\n\tfor ;\n\tMon, 29 Mar 2021 04:40:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 890CB6877D;\n\tMon, 29 Mar 2021 06:40:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 187E4602D2\n\tfor ;\n\tMon, 29 Mar 2021 06:40:32 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9673A102;\n\tMon, 29 Mar 2021 06:40:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"H5jMzgMe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616992831;\n\tbh=uB8Ht5cvcwMNWjA9H56nBEka7i4I7rPoDbFnMU5ia0c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=H5jMzgMeLfNmw6NKZ0vd+LRIBTTbl9NPykIU6X23fNAEDSxJRTAn/tY4ZSHfyE15u\n\t9+u/4dKaV+ey7mtv6/5QmzN4hvYj1FSvxGTzuXIs5LJTe7t3Byqe8W+UTicxxJaNWA\n\tWMn/tiDvJfa1L+DtQV3UM1MdgnWXbnaWpgwD6TS4=","Date":"Mon, 29 Mar 2021 07:39:48 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210329002715.74403-1-hiroh@chromium.org>\n\t<20210329002715.74403-2-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210329002715.74403-2-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: PipelineHandler: Make\n\tqueueRequest() void function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]