[{"id":1568,"web_url":"https://patchwork.libcamera.org/comment/1568/","msgid":"<283e740e-6c80-f491-6c48-acf54aa7b2a5@ideasonboard.com>","date":"2019-05-09T10:00:24","subject":"Re: [libcamera-devel] [PATCH v2 10/11] libcamera: pipeline_handler:\n\tAdd functions to lock a whole pipeline","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 08/05/2019 16:18, Niklas Söderlund wrote:\n> Add lock() and unlock() which backed by the MediaDevice implementation\n\n'which are backed'\n\n> can will lock all media devices claimed by a pipeline handler instance.\n\nand will lock\n\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/include/pipeline_handler.h | 3 ++\n> src/libcamera/pipeline_handler.cpp | 38 ++++++++++++++++++++++++\n> 2 files changed, 41 insertions(+)\n> \n> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> index 4c13496246c2251c..019c8f4751a8c2b2 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -57,6 +57,9 @@ public:\n> \tMediaDevice *tryAcquire(DeviceEnumerator *enumerator,\n> \t\t\t\tconst DeviceMatch &dm);\n> \n> +\tbool lock();\n> +\tvoid unlock();\n> +\n> \tvirtual CameraConfiguration\n> \tstreamConfiguration(Camera *camera, const std::vector &usages) = 0;\n> \tvirtual int configureStreams(Camera *camera, const CameraConfiguration &config) = 0;\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 8f50ef51f0c23301..6aa6c6ede49beb12 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -182,6 +182,44 @@ out:\n> \treturn media.get();\n> }\n> \n> +/**\n> + * \\brief Lock all media devices acquired by the pipeline\n> + *\n> + * This method shall not be called from a pipeline handler implementation\n> + * directly, as the Camera handles this on the behalf of the specified\n> + * implementation.\n> + *\n> + * \\return True if the devices could be locked, false otherwise\n> + * \\sa unlock()\n> + * \\sa MediaDevice::lock()\n> + */\n> +bool PipelineHandler::lock()\n> +{\n> +\tfor (std::shared_ptr media : mediaDevices_) {\n\nfor (auto media : mediaDevices_) { ?\n\n\n> +\t\tif (!media->lock()) {\n> +\t\t\tunlock();\n> +\t\t\treturn false;\n> +\t\t}\n> +\t}\n> +\n> +\treturn true;\n> +}\n> +\n> +/**\n> + * \\brief Unlock all media devices acquired by the pipeline\n> + *\n> + * This method shall not be called from a pipeline handler implementation\n> + * directly, as the Camera handles this on the behalf of the specified\n> + * implementation.\n> + *\n> + * \\sa lock()\n> + */\n> +void PipelineHandler::unlock()\n> +{\n> +\tfor (std::shared_ptr media : mediaDevices_)\n\nauto ?\n\n> +\t\tmedia->unlock();\n> +}\n> +\n> /**\n> * \\fn PipelineHandler::streamConfiguration()\n> * \\brief Retrieve a group of stream configurations for a specified camera\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BD0860E51\n\tfor ;\n\tThu, 9 May 2019 12:00:27 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E82302B6;\n\tThu, 9 May 2019 12:00:26 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1557396027;\n\tbh=1Jm8HXgFRGk+8l3diS7rRGvno37Dbuo/xLuL+bh1NpY=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=J2DfKMHq9d+UbdxpytvEtzguArRhScUj75P4lL/jd3TKCL4Vi3XVrS4/GMInR2PkT\n\tWeFeaDM0fXO0lgAT2pywItAUt/VwS7RmvNRKwqYA5SbbWnv5qhORo4lgwqQZVg7LcE\n\tUb6sHJ/PbHxtaNGPfToET0Gu4znGq8cd8Nu1UjKc=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190508151831.12274-1-niklas.soderlund@ragnatech.se>\n\t<20190508151831.12274-11-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<283e740e-6c80-f491-6c48-acf54aa7b2a5@ideasonboard.com>","Date":"Thu, 9 May 2019 11:00:24 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.6.1","MIME-Version":"1.0","In-Reply-To":"<20190508151831.12274-11-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v2 10/11] libcamera: pipeline_handler:\n\tAdd functions to lock a whole pipeline","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 09 May 2019 10:00:27 -0000"}},{"id":1578,"web_url":"https://patchwork.libcamera.org/comment/1578/","msgid":"<20190511091326.GH28561@bigcity.dyn.berto.se>","date":"2019-05-11T09:13:27","subject":"Re: [libcamera-devel] [PATCH v2 10/11] libcamera: pipeline_handler:\n\tAdd functions to lock a whole pipeline","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your feedback.\n\nOn 2019-05-09 11:00:24 +0100, Kieran Bingham wrote:\n> Hi Niklas,\n> \n> On 08/05/2019 16:18, Niklas Söderlund wrote:\n> > Add lock() and unlock() which backed by the MediaDevice implementation\n> \n> 'which are backed'\n> \n> > can will lock all media devices claimed by a pipeline handler instance.\n> \n> and will lock\n> \n> > \n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/libcamera/include/pipeline_handler.h | 3 ++\n> > src/libcamera/pipeline_handler.cpp | 38 ++++++++++++++++++++++++\n> > 2 files changed, 41 insertions(+)\n> > \n> > diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> > index 4c13496246c2251c..019c8f4751a8c2b2 100644\n> > --- a/src/libcamera/include/pipeline_handler.h\n> > +++ b/src/libcamera/include/pipeline_handler.h\n> > @@ -57,6 +57,9 @@ public:\n> > \tMediaDevice *tryAcquire(DeviceEnumerator *enumerator,\n> > \t\t\t\tconst DeviceMatch &dm);\n> > \n> > +\tbool lock();\n> > +\tvoid unlock();\n> > +\n> > \tvirtual CameraConfiguration\n> > \tstreamConfiguration(Camera *camera, const std::vector &usages) = 0;\n> > \tvirtual int configureStreams(Camera *camera, const CameraConfiguration &config) = 0;\n> > diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> > index 8f50ef51f0c23301..6aa6c6ede49beb12 100644\n> > --- a/src/libcamera/pipeline_handler.cpp\n> > +++ b/src/libcamera/pipeline_handler.cpp\n> > @@ -182,6 +182,44 @@ out:\n> > \treturn media.get();\n> > }\n> > \n> > +/**\n> > + * \\brief Lock all media devices acquired by the pipeline\n> > + *\n> > + * This method shall not be called from a pipeline handler implementation\n> > + * directly, as the Camera handles this on the behalf of the specified\n> > + * implementation.\n> > + *\n> > + * \\return True if the devices could be locked, false otherwise\n> > + * \\sa unlock()\n> > + * \\sa MediaDevice::lock()\n> > + */\n> > +bool PipelineHandler::lock()\n> > +{\n> > +\tfor (std::shared_ptr media : mediaDevices_) {\n> \n> for (auto media : mediaDevices_) { ?\n\nI think we should try to only use auto when the loop variable is an \niterator, so I would prefer to keep it as is. Looking at it again it \nshould probably be a reference, will make it as such for next version.\n\n for (std::shared_ptr &media : mediaDevices_) {\n\n> \n> \n> > +\t\tif (!media->lock()) {\n> > +\t\t\tunlock();\n> > +\t\t\treturn false;\n> > +\t\t}\n> > +\t}\n> > +\n> > +\treturn true;\n> > +}\n> > +\n> > +/**\n> > + * \\brief Unlock all media devices acquired by the pipeline\n> > + *\n> > + * This method shall not be called from a pipeline handler implementation\n> > + * directly, as the Camera handles this on the behalf of the specified\n> > + * implementation.\n> > + *\n> > + * \\sa lock()\n> > + */\n> > +void PipelineHandler::unlock()\n> > +{\n> > +\tfor (std::shared_ptr media : mediaDevices_)\n> \n> auto ?\n> \n> > +\t\tmedia->unlock();\n> > +}\n> > +\n> > /**\n> > * \\fn PipelineHandler::streamConfiguration()\n> > * \\brief Retrieve a group of stream configurations for a specified camera\n> > \n> \n> -- \n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F8CC60E4E\n\tfor ;\n\tSat, 11 May 2019 11:13:29 +0200 (CEST)","by mail-lf1-x143.google.com with SMTP id x132so5797100lfd.0\n\tfor ;\n\tSat, 11 May 2019 02:13:29 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\ty7sm2059798ljj.34.2019.05.11.02.13.27\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSat, 11 May 2019 02:13:27 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=4T2zc5rb0pWx734BKSuQLLdkst/kMyDvK8FNNvJ01HU=;\n\tb=bZO6k6dt7JtlI4ZpdfHY68AvFRLb18LwA+F++sSdCCQWzZk35DOL0w/hq8dS/KV7z6\n\t3mTE+moLfpXFTL30/ZPfU3+SzuLGhaIVarrfXuM450Wg5uiuKj4e5bfk492QKUNnT4D2\n\tX7XUrbRv6LJTr5u7DNNpPyy4K8b9eUb49PNdYw4RClJcUWqRufCIqN7wMvrY0CAKOebV\n\t0Saz0j0LzOOZSYUwHhJqU5xkY6WiPmUErl9Sh3McoCVTIWi7lfQ//vEpLpg3tSslugMz\n\tXbG48zzyppPCGYbJt1RPt4WIwVgHWnKrn/5kzYMFn5AXGL4JjwS2Zn6APUw4S7BPquLw\n\tgJ7w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=4T2zc5rb0pWx734BKSuQLLdkst/kMyDvK8FNNvJ01HU=;\n\tb=GrO/DZsnEZ7zG44ByZgkrKaCHGRWTyU/B+/a7nwio6ns8n0lMuyNeNf2Ky+LoNfVXK\n\tj12Lm4iCmnzizAzlN0R5i4V+heeFhNzDAGEpPoPuAivWdDpyEEpSMSMt7jt+Z/2T9Ftl\n\tJwmaQ0dZzKjyIrJe2V4ppevKc7DgKHxdFxp1RsQq+Fw3tP3xVyXJvku5zqrGpW+7hIWX\n\tp8y5K6rIB2BTxGSCvNuAYAbCtAEKJEB2Rfen3GsFUOu0sGK3vEPsP6sldHdlQqB49OSi\n\tOx72hiwHGdwLUfaMr4AXS8EDDkV1umG80h9p0rOp1N/0duSDU/m3zuLQW5e/8jmD3oPF\n\tEg8w==","X-Gm-Message-State":"APjAAAVYEkomo3O5zH8BKRauleA02qisTGlSXvChJWQP0XCS1a6fIF+p\n\thJQup/+vssOGwXuhVol2wqxbr7Z53F8=","X-Google-Smtp-Source":"APXvYqzNyTAbhpFwDot6ldyM8Olex3nXY00pZJelk6K5b7eaw0NDlUGTAHSJHRGwQStgPo1ih3Dzkg==","X-Received":"by 2002:ac2:528f:: with SMTP id q15mr7877841lfm.37.1557566008645;\n\tSat, 11 May 2019 02:13:28 -0700 (PDT)","Date":"Sat, 11 May 2019 11:13:27 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190511091326.GH28561@bigcity.dyn.berto.se>","References":"<20190508151831.12274-1-niklas.soderlund@ragnatech.se>\n\t<20190508151831.12274-11-niklas.soderlund@ragnatech.se>\n\t<283e740e-6c80-f491-6c48-acf54aa7b2a5@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<283e740e-6c80-f491-6c48-acf54aa7b2a5@ideasonboard.com>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH v2 10/11] libcamera: pipeline_handler:\n\tAdd functions to lock a whole pipeline","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 11 May 2019 09:13:29 -0000"}}]