[{"id":15985,"web_url":"https://patchwork.libcamera.org/comment/15985/","msgid":"","date":"2021-03-29T04:32:42","subject":"Re: [libcamera-devel] [PATCH v2 3/3] android: CameraDevice: Deny\n\tnon ROTATION_0 stream configuration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch.\n\nOn Mon, Mar 29, 2021 at 07:45:28AM +0900, Hirokazu Honda wrote:\n> Libcamera doesn't handle crop_rotate_scale_degrees. Therefore,\n\ns/Libcamera/libcamera/\n\n> if it is requested, that is, crop_rotate_scale_degrees is not\n> CAMERA3_STREAM_ROTATION_0, the configuration should fail.\n> \n> Signed-off-by: Hirokazu Honda \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index d3368b19..11c0f35a 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1647,6 +1647,13 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t\tif (!format.isValid())\n> \t\t\treturn -EINVAL;\n> \n> +\t\t/* \\todo Support rotation. */\n> +\t\tif (stream->rotation != CAMERA3_STREAM_ROTATION_0 ||\n> +\t\t stream->crop_rotate_scale_degrees != CAMERA3_STREAM_ROTATION_0) {\n> +\t\t\tLOG(HAL, Error) << \"Rotation is not supported\";\n> +\t\t\treturn -EINVAL;\n> +\t\t}\n> +\n> \t\t/* Defer handling of MJPEG streams until all others are known. */\n> \t\tif (stream->format == HAL_PIXEL_FORMAT_BLOB) {\n> \t\t\tif (jpegStream) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D43FEC32EA\n\tfor ;\n\tMon, 29 Mar 2021 04:33:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9331C6877D;\n\tMon, 29 Mar 2021 06:33:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E2BB602D2\n\tfor ;\n\tMon, 29 Mar 2021 06:33:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3881E31A;\n\tMon, 29 Mar 2021 06:33:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kGExJZLJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616992406;\n\tbh=vQYW8iO+zNM/z18ao0aDnyW+eL1ME+oegdHGiaY2V/k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kGExJZLJ3Pv2xQiwmxNscwMdTcTpvEKF17a4n2MDfFBGBlOMuMeyMPjXdG3DJxaHa\n\tXViBZ3zPkaBiOINy/sPw0PkD96pRrLZh3NTolVesE0YSHNzgfjni02GMStcwKnWGDw\n\t6EsbY4kTmFpPcx8wbNCv7ae7mJPJsWOBEJNXIL7I=","Date":"Mon, 29 Mar 2021 07:32:42 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210328224528.55468-1-hiroh@chromium.org>\n\t<20210328224528.55468-4-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210328224528.55468-4-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v2 3/3] android: CameraDevice: Deny\n\tnon ROTATION_0 stream configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16004,"web_url":"https://patchwork.libcamera.org/comment/16004/","msgid":"<20210329080343.xorthzkf6xwqymgv@uno.localdomain>","date":"2021-03-29T08:03:43","subject":"Re: [libcamera-devel] [PATCH v2 3/3] android: CameraDevice: Deny\n\tnon ROTATION_0 stream configuration","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Hiro\n\nOn Mon, Mar 29, 2021 at 07:45:28AM +0900, Hirokazu Honda wrote:\n> Libcamera doesn't handle crop_rotate_scale_degrees. Therefore,\n> if it is requested, that is, crop_rotate_scale_degrees is not\n> CAMERA3_STREAM_ROTATION_0, the configuration should fail.\n>\n> Signed-off-by: Hirokazu Honda \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/camera_device.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index d3368b19..11c0f35a 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1647,6 +1647,13 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t\tif (!format.isValid())\n> \t\t\treturn -EINVAL;\n>\n> +\t\t/* \\todo Support rotation. */\n> +\t\tif (stream->rotation != CAMERA3_STREAM_ROTATION_0 ||\n> +\t\t stream->crop_rotate_scale_degrees != CAMERA3_STREAM_ROTATION_0) {\n> +\t\t\tLOG(HAL, Error) << \"Rotation is not supported\";\n> +\t\t\treturn -EINVAL;\n> +\t\t}\n> +\n> \t\t/* Defer handling of MJPEG streams until all others are known. */\n> \t\tif (stream->format == HAL_PIXEL_FORMAT_BLOB) {\n> \t\t\tif (jpegStream) {\n> --\n> 2.31.0.291.g576ba9dcdaf-goog\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C4897C32EA\n\tfor ;\n\tMon, 29 Mar 2021 08:03:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0534C68783;\n\tMon, 29 Mar 2021 10:03:09 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54B526877E\n\tfor ;\n\tMon, 29 Mar 2021 10:03:08 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id CDD42E0003;\n\tMon, 29 Mar 2021 08:03:07 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Mon, 29 Mar 2021 10:03:43 +0200","From":"Jacopo Mondi ","To":"Hirokazu Honda ","Message-ID":"<20210329080343.xorthzkf6xwqymgv@uno.localdomain>","References":"<20210328224528.55468-1-hiroh@chromium.org>\n\t<20210328224528.55468-4-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210328224528.55468-4-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v2 3/3] android: CameraDevice: Deny\n\tnon ROTATION_0 stream configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]