[{"id":15980,"web_url":"https://patchwork.libcamera.org/comment/15980/","msgid":"<20210329033727.t2g4f5fdhwjxkfcz@basti-TUXEDO-Book-XA1510>","date":"2021-03-29T03:37:27","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix typo","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"Hey Laurent,\n\nOn 28.03.2021 23:09, Laurent Pinchart wrote:\n>Fix a simply typo.\n>\n\nReviewed-by: Sebastian Fricke \n\n>Signed-off-by: Laurent Pinchart \n>---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n>diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>index a8edf906220b..382e4b894a1c 100644\n>--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n>+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>@@ -869,7 +869,7 @@ bool PipelineHandlerIPU3::match(DeviceEnumerator *enumerator)\n> int PipelineHandlerIPU3::initControls(IPU3CameraData *data)\n> {\n> \t/*\n>-\t * \\todo The constrols intialized here depend on sensor configuration\n>+\t * \\todo The controls intialized here depend on sensor configuration\n> \t * and their limits should be updated once the configuration gets\n> \t * changed.\n> \t *\n>-- \n>Regards,\n>\n>Laurent Pinchart\n>\n>_______________________________________________\n>libcamera-devel mailing list\n>libcamera-devel@lists.libcamera.org\n>https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A772FC32EA\n\tfor ;\n\tMon, 29 Mar 2021 03:37:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ECC486877D;\n\tMon, 29 Mar 2021 05:37:29 +0200 (CEST)","from mout01.posteo.de (mout01.posteo.de [185.67.36.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97D77602D2\n\tfor ;\n\tMon, 29 Mar 2021 05:37:28 +0200 (CEST)","from submission (posteo.de [89.146.220.130]) \n\tby mout01.posteo.de (Postfix) with ESMTPS id 1C9AD16005C\n\tfor ;\n\tMon, 29 Mar 2021 05:37:28 +0200 (CEST)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4F7yvC5KmPz6tmD;\n\tMon, 29 Mar 2021 05:37:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"dFkDewQo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1616989048; bh=3ahvohXPisz1YL2IcyyGrwigxwVflN9rGbHMtGvGGZ8=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=dFkDewQoa0W59grVNcvcCLa9dfRfWtqg/57XS/EN6N3JTgf6++sqeEZxd4ESAcmdU\n\tqOBBICwGw2DfkDZXIKNN9RpR3pvl45fDaU0VBsVWiHVy0EIB+WEt7q6hW8GdFGQeNy\n\tt2pGu4Ir2FZgTOrOY+/mvWH7xVwdvSh6/0hQoSEDs6CvlqFUpjoa4ismqDY9l4DOnO\n\t0HVPM4FtW82QV7mmlv1nUi7ZtvP8GOuryL80TBniQswTQK9N2e2XJ/58M+ZCaZGJK/\n\ttWQEXlzp8lV/gdUkdMlBx5sKYmEMa0XYBFbUURdIhnOwtJPbVzX8KyTCCx5Pn7XaMk\n\t/cGh0B75WSDxQ==","Date":"Mon, 29 Mar 2021 05:37:27 +0200","From":"Sebastian Fricke ","To":"Laurent Pinchart ","Message-ID":"<20210329033727.t2g4f5fdhwjxkfcz@basti-TUXEDO-Book-XA1510>","References":"<20210328200913.15726-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210328200913.15726-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix typo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15981,"web_url":"https://patchwork.libcamera.org/comment/15981/","msgid":"<0c0ffdc6-e8d8-57af-e01c-c565ae7c5eb8@ideasonboard.com>","date":"2021-03-29T03:57:37","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix typo","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 3/29/21 1:39 AM, Laurent Pinchart wrote:\n> Fix a simply typo.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index a8edf906220b..382e4b894a1c 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -869,7 +869,7 @@ bool PipelineHandlerIPU3::match(DeviceEnumerator *enumerator)\n> int PipelineHandlerIPU3::initControls(IPU3CameraData *data)\n> {\n> \t/*\n> -\t * \\todo The constrols intialized here depend on sensor configuration\n> +\t * \\todo The controls intialized here depend on sensor configuration\nOne more typo in the same line\ns/intialized/initialized\n\nAfter addressing that;\n\nReviewed-by: Umang Jain \n\nThanks!\n\n\n> \t * and their limits should be updated once the configuration gets\n> \t * changed.\n> \t *","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D056C32EF\n\tfor ;\n\tMon, 29 Mar 2021 03:57:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D41F56877D;\n\tMon, 29 Mar 2021 05:57:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD9E9602D2\n\tfor ;\n\tMon, 29 Mar 2021 05:57:42 +0200 (CEST)","from localhost.localdomain (unknown [103.238.109.24])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C21C331A;\n\tMon, 29 Mar 2021 05:57:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kEWI0ndT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616990262;\n\tbh=003navMy6jGr9n+mV8C149AtjzP5upc8j1fsB7g5sec=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=kEWI0ndTmbKxcwGadmzmbNQCVd6f0i9Cd2wJG0ydCaqWgCbCFPy4IIsexLSlx1l1s\n\t8WNAA1243w5+cw0JR+9OXvQxmcU3mElhbp4Ha8LSu0tSPIrl6dIiWCAH7aHiHOVnjf\n\tmQ8A584veFHbiK/dztKvdiiXe91xddfqv6tsUTLM=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210328200913.15726-1-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<0c0ffdc6-e8d8-57af-e01c-c565ae7c5eb8@ideasonboard.com>","Date":"Mon, 29 Mar 2021 09:27:37 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.11.0","MIME-Version":"1.0","In-Reply-To":"<20210328200913.15726-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix typo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]