[{"id":15971,"web_url":"https://patchwork.libcamera.org/comment/15971/","msgid":"","date":"2021-03-28T20:10:17","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Fix typo and\n\timprove wording","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Sebastian,\n\nThank you for the patch.\n\nOn Sun, Mar 28, 2021 at 07:03:03PM +0200, Sebastian Fricke wrote:\n> s/Return the validated limits out though metadata./\n> Return the validated limits via metadata./\n> \n> Signed-off-by: Sebastian Fricke \n> ---\n> It is probably debatable, if we should remove that comment completely,\n> as the code is quite self explanatory. But it might help.\n\nI'll let Naush and David decide what they like best, and they apply the\npatch.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index ed2d9a54..dad6395f 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -1066,7 +1066,7 @@ void IPARPi::applyFrameDurations(double minFrameDuration, double maxFrameDuratio\n> \t\t\t\t minSensorFrameDuration, maxSensorFrameDuration);\n> \tmaxFrameDuration_ = std::max(maxFrameDuration_, minFrameDuration_);\n> \n> -\t/* Return the validated limits out though metadata. */\n> +\t/* Return the validated limits via metadata. */\n> \tlibcameraMetadata_.set(controls::FrameDurations,\n> \t\t\t { static_cast(minFrameDuration_),\n> \t\t\t\t static_cast(maxFrameDuration_) });","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C1A9C32EA\n\tfor ;\n\tSun, 28 Mar 2021 20:11:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB4E46877F;\n\tSun, 28 Mar 2021 22:11:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4AE266084F\n\tfor ;\n\tSun, 28 Mar 2021 22:11:01 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DDC13323;\n\tSun, 28 Mar 2021 22:11:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mD9xlLbf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616962261;\n\tbh=2W1QLKOnY9av1RrolprF1d04kooRetHmHyld76qXm7o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mD9xlLbfW1o8ARslMV3/drmoWcnxOGkV61uwzWk4Tv5BZa/8XZHOJ+2XfT2HmUfny\n\t7E2qXWIhpBeMfQbYjBjL1hPotJSdSVClymi5B1n7nn6BMzhhYYS+op3+blD1MR7tnR\n\tiWkCz1BRFTMZjbwsYFtsbXS2s8EPGNwGEwYRC0OY=","Date":"Sun, 28 Mar 2021 23:10:17 +0300","From":"Laurent Pinchart ","To":"Sebastian Fricke ","Message-ID":"","References":"<20210328170302.36104-1-sebastian.fricke@posteo.net>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210328170302.36104-1-sebastian.fricke@posteo.net>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Fix typo and\n\timprove wording","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16000,"web_url":"https://patchwork.libcamera.org/comment/16000/","msgid":"","date":"2021-03-29T06:59:46","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Fix typo and\n\timprove wording","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Sebastian,\n\nThank you for your patch.\n\nOn Sun, 28 Mar 2021 at 18:03, Sebastian Fricke \nwrote:\n\n> s/Return the validated limits out though metadata./\n> Return the validated limits via metadata./\n>\n> Signed-off-by: Sebastian Fricke \n>\n---\n> It is probably debatable, if we should remove that comment completely,\n> as the code is quite self explanatory. But it might help.\n> ---\n>\n\nI see no harm in keeping the comment.\nReviewed-by: Naushir Patuck \n\n\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp\n> b/src/ipa/raspberrypi/raspberrypi.cpp\n> index ed2d9a54..dad6395f 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -1066,7 +1066,7 @@ void IPARPi::applyFrameDurations(double\n> minFrameDuration, double maxFrameDuratio\n> minSensorFrameDuration,\n> maxSensorFrameDuration);\n> maxFrameDuration_ = std::max(maxFrameDuration_, minFrameDuration_);\n>\n> - /* Return the validated limits out though metadata. */\n> + /* Return the validated limits via metadata. */\n> libcameraMetadata_.set(controls::FrameDurations,\n> { static_cast(minFrameDuration_),\n> static_cast(maxFrameDuration_)\n> });\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D6AAAC32EA\n\tfor ;\n\tMon, 29 Mar 2021 07:00:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E38568784;\n\tMon, 29 Mar 2021 09:00:07 +0200 (CEST)","from mail-lf1-x134.google.com (mail-lf1-x134.google.com\n\t[IPv6:2a00:1450:4864:20::134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2BB7C6877D\n\tfor ;\n\tMon, 29 Mar 2021 09:00:05 +0200 (CEST)","by mail-lf1-x134.google.com with SMTP id g8so16822894lfv.12\n\tfor ;\n\tMon, 29 Mar 2021 00:00:05 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"NYXBxjiJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Oh0NgksQ0oxPQKvgKgxWiDCAPuRewDjj/hx9JDOoIOc=;\n\tb=NYXBxjiJacFHhJvSPYHGrQaT0OIj6FFAJ8ouGomXgy7t1cxMuIgxQYaBtVLJXOVXZS\n\t5CRrZEKNzEjg7ugmKp02w6KdKXZmlwWHe563um+UxmCAzLNd1OExH3B6AFDb+cPM9yzT\n\tkHMlyO79HBSJylr0Dx3XfKo2sv2bf8u0omZv2Lf3T99OZbtyyjWqtlXfwo6K2YsF3aor\n\tOqzvK5VtHiTtiqwKIRo3/XFul5IHQqw2x9xTvm7qAVz0xnJXDC+VxwUD0Z63j/P4dctj\n\tJ51izBiq737j8w+V5wP78+mqbTIW8JlGLubcPJGPYo+xaE/XjFmgggSucDa7Nd3uX/fD\n\tuUAg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Oh0NgksQ0oxPQKvgKgxWiDCAPuRewDjj/hx9JDOoIOc=;\n\tb=CFm9/ejCbvegmQ8E0mV7J7PNdYVH+QBLvw9upEBkIf5FoQUcVSdl+aXFI4h6YmoG2p\n\tV0GhCEXuupRMwrfm+NuddFhuCoFqd958mjArxwNZyPL0UFe4ym8UKVA5aRR9jW9O0gJe\n\tH19s/GqLBb5GnDhPxdIqA14CuiGJqO2dfvH5ejlSgUW/NsGE2OcG4rQAbZerXWvQE6I2\n\tGR7yLRhiKwHUQp+zo6lseaR70gjHZQzVlgSYMzyAQEuW87NMe40aJcGGZ4M0S8RF4ERl\n\tpdnferVaJpeKl9eCyhEKcE4iarycXp1Nst+otHdCrQgFFHtywlkMwEC6W9z306zYqZKn\n\tX5sw==","X-Gm-Message-State":"AOAM531gtVcy7QZvwEvK//7rFghJ98Nuv0ci72oL8JKlvn/SaHUPWGL4\n\tDp+fye1AqzQWCz0JHvO5v8I9Umxq5/44l9OUvqS16g==","X-Google-Smtp-Source":"ABdhPJyT3ZDTOtYa4q6zqIPMZ0QYn9Zpq+0n4gicqOWKw3PmbyjvXLLg4zQt90CV65F5kx6FJ9tsj5fALvxirAtULGI=","X-Received":"by 2002:ac2:4205:: with SMTP id\n\ty5mr15406289lfh.375.1617001204629; \n\tMon, 29 Mar 2021 00:00:04 -0700 (PDT)","MIME-Version":"1.0","References":"<20210328170302.36104-1-sebastian.fricke@posteo.net>","In-Reply-To":"<20210328170302.36104-1-sebastian.fricke@posteo.net>","From":"Naushir Patuck ","Date":"Mon, 29 Mar 2021 06:59:46 +0000","Message-ID":"","To":"Sebastian Fricke ","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Fix typo and\n\timprove wording","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============7293030778308007746==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]