[{"id":15965,"web_url":"https://patchwork.libcamera.org/comment/15965/","msgid":"","date":"2021-03-28T16:50:17","subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Remove unused\n\tgetFormat call","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Sebastian,\n\nThank you for the patch.\n\nOn Sun, Mar 28, 2021 at 04:27:12PM +0200, Sebastian Fricke wrote:\n> The comment states, that we get the device format to pass it to the IPA,\n> but the variable `sensorFormat` is not used again after it's assignment.\n> Remove it, together with the comment.\n\nLooks like this unused variable has been there from the very first\nversion of the RPi pipeline handler.\n\nReviewed-by: Laurent Pinchart \n\nI don't think there's any risk of a side effect here, but I'll let David\nor Naush comment before applying the patch.\n\n> Signed-off-by: Sebastian Fricke \n> ---\n> Tested on Raspberry Pi 4 with IMX219 without issues.\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ---\n> 1 file changed, 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 378a5227..f22e286e 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1238,9 +1238,6 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config)\n> \tstd::map entityControls;\n> \tipa::RPi::IPAConfig ipaConfig;\n> \n> -\t/* Get the device format to pass to the IPA. */\n> -\tV4L2DeviceFormat sensorFormat;\n> -\tunicam_[Unicam::Image].dev()->getFormat(&sensorFormat);\n> \t/* Inform IPA of stream configuration and sensor controls. */\n> \tunsigned int i = 0;\n> \tfor (auto const &stream : isp_) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4569AC32ED\n\tfor ;\n\tSun, 28 Mar 2021 16:51:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F8BB6877F;\n\tSun, 28 Mar 2021 18:51:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 74DBA6084F\n\tfor ;\n\tSun, 28 Mar 2021 18:51:01 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E1722436;\n\tSun, 28 Mar 2021 18:51:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tYMRDwHu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616950261;\n\tbh=H7jUr9cAR9H8m1zDPYehVvEETz2u1KE4mgBICz1h/8I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tYMRDwHusDqSTWVyNhE0RBSpEdW3yq2WzubxPZ9Ytl+uOshVyP3hVkC02TgivpJgb\n\to634p40iAx2TeAzWpnr4MIwjoKGEKXUWVZKFbyHyMVnT9Gobi5hgcCIHiBmUyKHIEI\n\twkEafUu4cSdtD0sa3spqAXDqbhyHxZA1YcpQijUQ=","Date":"Sun, 28 Mar 2021 19:50:17 +0300","From":"Laurent Pinchart ","To":"Sebastian Fricke ","Message-ID":"","References":"<20210328142711.29702-1-sebastian.fricke@posteo.net>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210328142711.29702-1-sebastian.fricke@posteo.net>","Subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Remove unused\n\tgetFormat call","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15999,"web_url":"https://patchwork.libcamera.org/comment/15999/","msgid":"","date":"2021-03-29T06:57:25","subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Remove unused\n\tgetFormat call","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Sebastian,\n\nThank you for your patch.\n\nOn Sun, 28 Mar 2021 at 15:27, Sebastian Fricke \nwrote:\n\n> The comment states, that we get the device format to pass it to the IPA,\n> but the variable `sensorFormat` is not used again after it's assignment.\n> Remove it, together with the comment.\n>\n> Signed-off-by: Sebastian Fricke \n>\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> Tested on Raspberry Pi 4 with IMX219 without issues.\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ---\n> 1 file changed, 3 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 378a5227..f22e286e 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1238,9 +1238,6 @@ int RPiCameraData::configureIPA(const\n> CameraConfiguration *config)\n> std::map entityControls;\n> ipa::RPi::IPAConfig ipaConfig;\n>\n> - /* Get the device format to pass to the IPA. */\n> - V4L2DeviceFormat sensorFormat;\n> - unicam_[Unicam::Image].dev()->getFormat(&sensorFormat);\n> /* Inform IPA of stream configuration and sensor controls. */\n> unsigned int i = 0;\n> for (auto const &stream : isp_) {\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8789C32EA\n\tfor ;\n\tMon, 29 Mar 2021 06:57:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8893C6877D;\n\tMon, 29 Mar 2021 08:57:46 +0200 (CEST)","from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com\n\t[IPv6:2a00:1450:4864:20::12d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE93D602D2\n\tfor ;\n\tMon, 29 Mar 2021 08:57:44 +0200 (CEST)","by mail-lf1-x12d.google.com with SMTP id 75so16868010lfa.2\n\tfor ;\n\tSun, 28 Mar 2021 23:57:44 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"nllxwVuT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=i29v+AK/9qoXTdcQRQUgx0NEowIfzjLNpEIt0ZkIUjg=;\n\tb=nllxwVuTd5KlG4m5E8hG+HBT9FvfLJDFWWANxOHQVA+0nAHCJYrcezYvrERXPYH5Kr\n\tU4rcsXVQbDFXtvXVNrWnKpqhQDS7e+bz+0/MuZ6To4/ilGJa5gYj6ICPQ+ryyDpmwiWb\n\t2LBpRkDP8x9BkGck44pdktPghyU6emqhLi+QFOLmzNpcLEjbtEUFL1lDEw1cvKynOokF\n\tvA+yLYkXwHHWmATeS64FSa+VVU3dGbAGvAYtggKXg6uE0O/9QgQEEe634hXhRDWp+IpE\n\thTWSQnLHdPXmn7LULZxwAn8CBha5kFnvzHKmNvgfseTTvn3KOYO0bAdPGEicxws0LFc5\n\tMoSA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=i29v+AK/9qoXTdcQRQUgx0NEowIfzjLNpEIt0ZkIUjg=;\n\tb=f4IHvahfbyZEXMNcTRvbP/xkH7Pe5s75HIBTf0vx1+Pp2XUCqzusRN9FQdZscsoQGl\n\t8RbcrQT0AN1qFrwaPnJ0/+ObICUZpysbhC7BIpJDBn5byW4B7DLbyjEZE3BeV2jGn0+y\n\tKAkV1kdv25sbThg5ZU3cI6FjhteeFjUUQtDNY2LsAehtjnJhiRWOO4behux9x3s20C1I\n\tesVrQpEwD4O+fAnX2XNzWb1zFBSeQv8B2TDsEFSACEd6f0EEIOC3X57iOJtB+KRFMtss\n\tMgtGUzuKOOWX077tRCQqKQgs6NmI0lpx+AqLdx01glOO8Z/oMz5ermyDrA5qwJwl5ylz\n\t4jgg==","X-Gm-Message-State":"AOAM532bYfCwfeZMg3ZUBvay7VRk46tWIvPbMNIYfcnyY5BC1iNq2eBd\n\tnoXmdTy6Sc405gJDB8ytY7uYfb1Ypp66LFW7eohmtw==","X-Google-Smtp-Source":"ABdhPJxpLS3ACxPBcyBQzXUVdsUc8e5Ay/ZvdlbIxL3tLpY81RP2Et8H8gIocb304jlY86EdXZYJ5hYEk6DODRNldoM=","X-Received":"by 2002:a05:6512:3226:: with SMTP id\n\tf6mr14976393lfe.171.1617001064025; \n\tSun, 28 Mar 2021 23:57:44 -0700 (PDT)","MIME-Version":"1.0","References":"<20210328142711.29702-1-sebastian.fricke@posteo.net>","In-Reply-To":"<20210328142711.29702-1-sebastian.fricke@posteo.net>","From":"Naushir Patuck ","Date":"Mon, 29 Mar 2021 06:57:25 +0000","Message-ID":"","To":"Sebastian Fricke ","Subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Remove unused\n\tgetFormat call","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============4922026145792828023==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]