[{"id":15966,"web_url":"https://patchwork.libcamera.org/comment/15966/","msgid":"","date":"2021-03-28T16:50:48","subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberryPi: Fix typo in\n\tcomment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Sebastian,\n\nThank you for the patch.\n\nOn Sun, Mar 28, 2021 at 02:59:07PM +0200, Sebastian Fricke wrote:\n> s/Will need to/We'll need to/\n> \n> Signed-off-by: Sebastian Fricke \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 2cac802c..378a5227 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1141,7 +1141,7 @@ int PipelineHandlerRPi::prepareBuffers(Camera *camera)\n> \n> \t/*\n> \t * Decide how many internal buffers to allocate. For now, simply look\n> -\t * at how many external buffers will be provided. Will need to improve\n> +\t * at how many external buffers will be provided. We'll need to improve\n> \t * this logic. However, we really must have all streams allocate the same\n> \t * number of buffers to simplify error handling in queueRequestDevice().\n> \t */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36274C32ED\n\tfor ;\n\tSun, 28 Mar 2021 16:51:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E573B6877F;\n\tSun, 28 Mar 2021 18:51:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 20AB96084F\n\tfor ;\n\tSun, 28 Mar 2021 18:51:32 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AAEA1436;\n\tSun, 28 Mar 2021 18:51:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"j44EBYKU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616950291;\n\tbh=0aYKFSw8c94cpt3cA/ttb/oUsKuoo424H7IqDh0HA10=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=j44EBYKU6V6K3sJnr6slnunDjtm/hM7ltyXmtc7dSABnYhDNyM+WytdZIvlCntFDj\n\tDKieSDSI/WnOU+k6p6pWGjNzZ0kIf5/da/nyu5rX47Jj/x/7CccfcNqDcdTo13Tng3\n\t1/ttaTmesrjGa8cLaTQrF55YwNcsL/0r7/6KytkQ=","Date":"Sun, 28 Mar 2021 19:50:48 +0300","From":"Laurent Pinchart ","To":"Sebastian Fricke ","Message-ID":"","References":"<20210328125906.25461-1-sebastian.fricke@posteo.net>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210328125906.25461-1-sebastian.fricke@posteo.net>","Subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberryPi: Fix typo in\n\tcomment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15998,"web_url":"https://patchwork.libcamera.org/comment/15998/","msgid":"","date":"2021-03-29T06:56:35","subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberryPi: Fix typo in\n\tcomment","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Sebastian,\n\nThank you for your patch.\n\nOn Sun, 28 Mar 2021 at 13:59, Sebastian Fricke \nwrote:\n\n> s/Will need to/We'll need to/\n>\n> Signed-off-by: Sebastian Fricke \n>\n\ns/raspberryPi/raspberrypi/\nApart from that:\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 2cac802c..378a5227 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1141,7 +1141,7 @@ int PipelineHandlerRPi::prepareBuffers(Camera\n> *camera)\n>\n> /*\n> * Decide how many internal buffers to allocate. For now, simply\n> look\n> - * at how many external buffers will be provided. Will need to\n> improve\n> + * at how many external buffers will be provided. We'll need to\n> improve\n> * this logic. However, we really must have all streams allocate\n> the same\n> * number of buffers to simplify error handling in\n> queueRequestDevice().\n> */\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5186CC32EA\n\tfor ;\n\tMon, 29 Mar 2021 06:56:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A46766877D;\n\tMon, 29 Mar 2021 08:56:56 +0200 (CEST)","from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com\n\t[IPv6:2a00:1450:4864:20::22e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A167A602D2\n\tfor ;\n\tMon, 29 Mar 2021 08:56:54 +0200 (CEST)","by mail-lj1-x22e.google.com with SMTP id f26so14657932ljp.8\n\tfor ;\n\tSun, 28 Mar 2021 23:56:54 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"C6+cCU1T\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=bxKzG2+xGTCdumXRRNOnDtpOuFuNYw+hq6xeitOJ4DI=;\n\tb=C6+cCU1T9xw6pOkjXsYXjitvtCxsXiNgsXcKBFs62YGgFvnIYB9nRj8EdyrA8momba\n\ts8SuNdukp7pdfO/4QIeZ+1ZEVnrU4b9L7zos/zYafzFHlmKuDVv2iX3bhRyKQY9dVhe1\n\tsfqwIEFnji29Bze8vbidXq3ongCtR8Ecp2VtzfxIHILLWlvnoHPiX2f3/jx27RM/8NKS\n\tZo+tEA6ouTZeDW8CpkuzbNJK1G4nfPm6gM7AThbj5JzNcSAohHKCI7xrK30uY6HLSay2\n\t2jytnUg4PqFB0yE/2XJAfDeLZeww4WzCu+H5s0zXf5gxSAmyTlO/IxT3fhqLTIyL8Ybn\n\tQB8Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=bxKzG2+xGTCdumXRRNOnDtpOuFuNYw+hq6xeitOJ4DI=;\n\tb=gYLXAytSgl1fSxQEKGpCfFCEPNaNRCjvJd+GxQKE/Yle+I8sC4bOFp643QfL49bs/+\n\tgW1K3nmCFTPASH/AdvOf2PNqSjhmtbG2B0kCVikc1wEWvEj4Ew0Zqt1OiWj+/0sEKmE6\n\t/BJE6py+vip1UbWmGV9fKKOvJ1zuXxpf1vkUgeomrqU3l8gtBEiRBm8n0ZflCwpW+K3c\n\tDJdprQ2hAGGBzRvs3q7neWwiFpaQuznUUsmEz4H40HLiFaoTvrHLMTx4X7RoFgyq/Lml\n\tBNU+5mmAkDhTg7CBcjnAgKhjICWsck7zjw26/J3vmv7Oksf8u/XrVsvCiaS7ybRewmdc\n\tlU6A==","X-Gm-Message-State":"AOAM533wyROcGV/0Cr5MdeKlc81L8q70Lx6ReohdNV4OTZo3l0aC7VqE\n\tvqaCeg2+dFuLw+6tJ/TFq5A68d6tV0pUAt4jpzxDSw==","X-Google-Smtp-Source":"ABdhPJwa7xBHokfGmeoWEZn6c38RfRgaHHSl1C3FY9slHgWLZHw/x0h6+x2GESxdd5/WLxXyuz2RlYotahY5Vr0w4Yo=","X-Received":"by 2002:a2e:89d4:: with SMTP id\n\tc20mr17391529ljk.169.1617001013904; \n\tSun, 28 Mar 2021 23:56:53 -0700 (PDT)","MIME-Version":"1.0","References":"<20210328125906.25461-1-sebastian.fricke@posteo.net>","In-Reply-To":"<20210328125906.25461-1-sebastian.fricke@posteo.net>","From":"Naushir Patuck ","Date":"Mon, 29 Mar 2021 06:56:35 +0000","Message-ID":"","To":"Sebastian Fricke ","Subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberryPi: Fix typo in\n\tcomment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============3020627324367939711==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]