[{"id":15967,"web_url":"https://patchwork.libcamera.org/comment/15967/","msgid":"","date":"2021-03-28T16:51:27","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrrypi: Remove duplicate\n\tcomment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Sebastian,\n\nThank you for the patch.\n\nOn Sun, Mar 28, 2021 at 09:59:54AM +0200, Sebastian Fricke wrote:\n> The exact same comment is used two times within 5 lines.\n> Remove one of them as it is redundant.\n> \n> Signed-off-by: Sebastian Fricke \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 1c928b72..ed2d9a54 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -208,7 +208,6 @@ void IPARPi::start(const ControlList &controls, ipa::RPi::StartConfig *startConf\n> \tagcStatus.shutter_time = 0.0;\n> \tagcStatus.analogue_gain = 0.0;\n> \n> -\t/* SwitchMode may supply updated exposure/gain values to use. */\n> \tmetadata.Get(\"agc.status\", agcStatus);\n> \tif (agcStatus.shutter_time != 0.0 && agcStatus.analogue_gain != 0.0) {\n> \t\tControlList ctrls(sensorCtrls_);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AEBF7C32ED\n\tfor ;\n\tSun, 28 Mar 2021 16:52:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C9C16877F;\n\tSun, 28 Mar 2021 18:52:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C209C6084F\n\tfor ;\n\tSun, 28 Mar 2021 18:52:11 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 57137436;\n\tSun, 28 Mar 2021 18:52:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KbvncAjq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616950331;\n\tbh=fwnCS2NxMBMM4glc1DEnqDg9PyOCDIwXugtL3PpfkcI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KbvncAjqHVipTpSmvP43uy7al1stVIJ/G8ZHzBQSiMPM4BeC8Qfr8UGW94VbuNDmw\n\tPdVHdLwc1VIFvtDlYO1f5wfOD1TB18MCEV1Br4T1kpvc6Tp7PHbW1B65xve1x6ybMH\n\tILo1fOGhrA+fcAQQkabIQB7taAukM2Et1IyHBZRI=","Date":"Sun, 28 Mar 2021 19:51:27 +0300","From":"Laurent Pinchart ","To":"Sebastian Fricke ","Message-ID":"","References":"<20210328075954.13182-1-sebastian.fricke@posteo.net>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210328075954.13182-1-sebastian.fricke@posteo.net>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrrypi: Remove duplicate\n\tcomment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15972,"web_url":"https://patchwork.libcamera.org/comment/15972/","msgid":"<0f84d052-2f0a-4083-727f-1a07fac6bb83@ideasonboard.com>","date":"2021-03-28T21:04:30","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrrypi: Remove duplicate\n\tcomment","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Sebastian,\n\nOn 28/03/2021 18:51, Laurent Pinchart wrote:\n> Hi Sebastian,\n> \n> Thank you for the patch.\n> \n> On Sun, Mar 28, 2021 at 09:59:54AM +0200, Sebastian Fricke wrote:\n>> The exact same comment is used two times within 5 lines.\n>> Remove one of them as it is redundant.\n>>\n>> Signed-off-by: Sebastian Fricke \n> \n> Reviewed-by: Laurent Pinchart \n\nThere is a typo in the commit title (too much r's :-)).\nOtherwise:\nReviewed-by: Jean-Michel Hautbois \n\n>> ---\n>> src/ipa/raspberrypi/raspberrypi.cpp | 1 -\n>> 1 file changed, 1 deletion(-)\n>>\n>> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n>> index 1c928b72..ed2d9a54 100644\n>> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n>> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n>> @@ -208,7 +208,6 @@ void IPARPi::start(const ControlList &controls, ipa::RPi::StartConfig *startConf\n>> \tagcStatus.shutter_time = 0.0;\n>> \tagcStatus.analogue_gain = 0.0;\n>> \n>> -\t/* SwitchMode may supply updated exposure/gain values to use. */\n>> \tmetadata.Get(\"agc.status\", agcStatus);\n>> \tif (agcStatus.shutter_time != 0.0 && agcStatus.analogue_gain != 0.0) {\n>> \t\tControlList ctrls(sensorCtrls_);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A206C32EA\n\tfor ;\n\tSun, 28 Mar 2021 21:04:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87D116877C;\n\tSun, 28 Mar 2021 23:04:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D5976084F\n\tfor ;\n\tSun, 28 Mar 2021 23:04:31 +0200 (CEST)","from [IPv6:2a01:e0a:169:7140:20b:b94b:3cde:d33f] (unknown\n\t[IPv6:2a01:e0a:169:7140:20b:b94b:3cde:d33f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B6F0C323;\n\tSun, 28 Mar 2021 23:04:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WcI60g20\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616965470;\n\tbh=4hs42n3hrdvMG0owrjLT3ZgNGkIT1jt4UUlPBcMLBfY=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=WcI60g20FPrLyqZsPtStQt3rjfGOVaZ4skPZ8xNN3Wj5Uv6Vuigp15w/zyiM1V38C\n\tHd/2I1cb0seIjEbCZ/zTo0AWS80BNPDIiWaIirLHda4Nd0OHRMCn1AIr+Kd8uX3QBk\n\tZz2T5VFtlSJR9mdblFlaiOPDLH9g4NB+hzw2I7hY=","To":"Laurent Pinchart ,\n\tSebastian Fricke ","References":"<20210328075954.13182-1-sebastian.fricke@posteo.net>\n\t","From":"Jean-Michel Hautbois ","Message-ID":"<0f84d052-2f0a-4083-727f-1a07fac6bb83@ideasonboard.com>","Date":"Sun, 28 Mar 2021 23:04:30 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrrypi: Remove duplicate\n\tcomment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15979,"web_url":"https://patchwork.libcamera.org/comment/15979/","msgid":"<20210329033418.aj2ar6de5zayeocd@basti-TUXEDO-Book-XA1510>","date":"2021-03-29T03:34:18","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrrypi: Remove duplicate\n\tcomment","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"Hey Jean-Michel,\n\nOn 28.03.2021 23:04, Jean-Michel Hautbois wrote:\n>Hi Sebastian,\n>\n>On 28/03/2021 18:51, Laurent Pinchart wrote:\n>> Hi Sebastian,\n>>\n>> Thank you for the patch.\n>>\n>> On Sun, Mar 28, 2021 at 09:59:54AM +0200, Sebastian Fricke wrote:\n>>> The exact same comment is used two times within 5 lines.\n>>> Remove one of them as it is redundant.\n>>>\n>>> Signed-off-by: Sebastian Fricke \n>>\n>> Reviewed-by: Laurent Pinchart \n>\n>There is a typo in the commit title (too much r's :-)).\n>Otherwise:\n>Reviewed-by: Jean-Michel Hautbois \n\nWoops fixing a typo with a typo ;)\nThank you for notifying.\n\nGreetings,\nSebastian\n\n>\n>>> ---\n>>> src/ipa/raspberrypi/raspberrypi.cpp | 1 -\n>>> 1 file changed, 1 deletion(-)\n>>>\n>>> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n>>> index 1c928b72..ed2d9a54 100644\n>>> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n>>> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n>>> @@ -208,7 +208,6 @@ void IPARPi::start(const ControlList &controls, ipa::RPi::StartConfig *startConf\n>>> \tagcStatus.shutter_time = 0.0;\n>>> \tagcStatus.analogue_gain = 0.0;\n>>>\n>>> -\t/* SwitchMode may supply updated exposure/gain values to use. */\n>>> \tmetadata.Get(\"agc.status\", agcStatus);\n>>> \tif (agcStatus.shutter_time != 0.0 && agcStatus.analogue_gain != 0.0) {\n>>> \t\tControlList ctrls(sensorCtrls_);\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A565DC32EF\n\tfor ;\n\tMon, 29 Mar 2021 03:34:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E416E6877D;\n\tMon, 29 Mar 2021 05:34:21 +0200 (CEST)","from mout01.posteo.de (mout01.posteo.de [185.67.36.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A9CE602D2\n\tfor ;\n\tMon, 29 Mar 2021 05:34:20 +0200 (CEST)","from submission (posteo.de [89.146.220.130]) \n\tby mout01.posteo.de (Postfix) with ESMTPS id CD22D16005C\n\tfor ;\n\tMon, 29 Mar 2021 05:34:19 +0200 (CEST)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4F7yqb2fMTz6tmG;\n\tMon, 29 Mar 2021 05:34:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"XJ0sitCb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1616988859; bh=YWtHcb4tXqytnnX3QCxfZqvvt6HLAD7Cfv6j5r/MlHg=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=XJ0sitCbwEgKTCOGViPsnBYbYBtBRJeMx387Z0eBiR+xEna2sUS3c+uVHluJAeP6n\n\t/8R530xQvbc0BoM+DSsep140SrMX+oOHp1rjWDzDHBm98ccIrSNBqh4lYXNsfxRTw8\n\tC2JVzVa2NmbfP6YVOBvSB8sA4GvhqvilG+aCUlEbby0+TmVV5DTe7Xj4T7ILbEwtyf\n\tDfyn7Lrp2G/iHaN4vfQCpCgHPpZQpCPSpdV6JcZrBGu9tS1Jq8d5HDGzPYlATx8CXg\n\tKqvvQQp7+EYR3irTvlx233aPrlEX8pACj+e6CtF6tDV13Li16+KEYXisiFb6JjaP/b\n\tf0tWabtw7adJg==","Date":"Mon, 29 Mar 2021 05:34:18 +0200","From":"Sebastian Fricke ","To":"Jean-Michel Hautbois ","Message-ID":"<20210329033418.aj2ar6de5zayeocd@basti-TUXEDO-Book-XA1510>","References":"<20210328075954.13182-1-sebastian.fricke@posteo.net>\n\t\n\t<0f84d052-2f0a-4083-727f-1a07fac6bb83@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<0f84d052-2f0a-4083-727f-1a07fac6bb83@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrrypi: Remove duplicate\n\tcomment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]