{"id":11736,"url":"https://patchwork.libcamera.org/api/patches/11736/?format=json","web_url":"https://patchwork.libcamera.org/patch/11736/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210327100812.17483-1-sebastian.fricke@posteo.net>","date":"2021-03-27T10:08:13","name":"[libcamera-devel,v2] ipa: rkisp1: Do not set controls during configure","commit_ref":"1456efe7d51a3a0c6b57db4310f75b2a08ab1756","pull_url":null,"state":"accepted","archived":false,"hash":"dcece091af0f104373d1e75a792e20b304c9fa9b","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/?format=json","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11736/mbox/","series":[{"id":1845,"url":"https://patchwork.libcamera.org/api/series/1845/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1845","date":"2021-03-27T10:08:13","name":"[libcamera-devel,v2] ipa: rkisp1: Do not set controls during configure","version":2,"mbox":"https://patchwork.libcamera.org/series/1845/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11736/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11736/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 846A7C32ED\n\tfor ;\n\tSat, 27 Mar 2021 10:09:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA41F68D6E;\n\tSat, 27 Mar 2021 11:09:02 +0100 (CET)","from mout01.posteo.de (mout01.posteo.de [185.67.36.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A630068D58\n\tfor ;\n\tSat, 27 Mar 2021 11:09:00 +0100 (CET)","from submission (posteo.de [89.146.220.130]) \n\tby mout01.posteo.de (Postfix) with ESMTPS id 1E227160061\n\tfor ;\n\tSat, 27 Mar 2021 11:09:00 +0100 (CET)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4F6vgv2qwKz6tmb;\n\tSat, 27 Mar 2021 11:08:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"TiqklGix\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1616839740; bh=SEP7eHUjTW4tYsXEcfZ7452VWAa8X9UgHrO8ddTpg9k=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=TiqklGixishbrEbJmxopDcvZv63XO1B+FPn/C4f5gKQ6oo1vuNhrgDVp1wp5oqKJW\n\te9yK1p3rMOngpFgGMFBEg6B3hRQbg9RV/pBZiufyvnpfcjHQctGsmGdLTCLX5Xqmd/\n\tJwipVwwALCkB3eMjeeSL5XwCWpkNuIkvCG46POlboWD8wlbJ8bmmMovacvxE6C3nYm\n\tIi1pOtCuRj5zvB4WEyIggIsVarzmn7debj9Go7e5FJHb8aRpq0vDq9/KABoW0YI8GU\n\tA32XNudtzb95vjdALGR89H0oK6RSc2r2k7QxRtbyPnIQWPS+/NJqbaKayeE9453meR\n\tvpCcSqdxWBUMA==","From":"Sebastian Fricke ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 27 Mar 2021 11:08:13 +0100","Message-Id":"<20210327100812.17483-1-sebastian.fricke@posteo.net>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2] ipa: rkisp1: Do not set controls\n\tduring configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Do not send events back to the pipeline handler, while the IPA thread\nhas not been started.\n\nIf information needs to be returned from configure it should be returned\ndirectly.\n\nMove the initial call to setControls() out of configure() and into the\nstart() method which is called after the IPA running_ state is updated.\n\nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \nReviewed-by: Paul Elder \nSigned-off-by: Sebastian Fricke \n---\nChanges since v1:\n- Fix whitespace issues (thanks to Laurent)\n- Correct commit description (thanks to Paul)\n---\n src/ipa/rkisp1/rkisp1.cpp | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex d2a10bb9..8a57b080 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -32,7 +32,7 @@ class IPARkISP1 : public ipa::rkisp1::IPARkISP1Interface\n {\n public:\n \tint init(unsigned int hwRevision) override;\n-\tint start() override { return 0; }\n+\tint start() override;\n \tvoid stop() override {}\n \n \tint configure(const CameraSensorInfo &info,\n@@ -80,6 +80,13 @@ int IPARkISP1::init(unsigned int hwRevision)\n \treturn 0;\n }\n \n+int IPARkISP1::start()\n+{\n+\tsetControls(0);\n+\n+\treturn 0;\n+}\n+\n /**\n * \\todo The RkISP1 pipeline currently provides an empty CameraSensorInfo\n * if the connected sensor does not provide enough information to properly\n@@ -121,7 +128,6 @@ int IPARkISP1::configure([[maybe_unused]] const CameraSensorInfo &info,\n \t\t<< \"Exposure: \" << minExposure_ << \"-\" << maxExposure_\n \t\t<< \" Gain: \" << minGain_ << \"-\" << maxGain_;\n \n-\tsetControls(0);\n \treturn 0;\n }\n \n","prefixes":["libcamera-devel","v2"]}