[{"id":15921,"web_url":"https://patchwork.libcamera.org/comment/15921/","msgid":"","date":"2021-03-26T02:42:20","subject":"Re: [libcamera-devel] [PATCH v3 09/11] libcamera: camera: Assert\n\tpipelines complete all requests","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Mar 25, 2021 at 01:42:29PM +0000, Kieran Bingham wrote:\n> When the camera manager calls stop on a pipeline, it is expected that\n> the pipeline handler guarantees all requests are returned back to the\n> application before the camera has stopped.\n> \n> Ensure that this guarantee is met by providing an accessor on the\n> pipeline handler to validate that all pending requests are removed.\n> \n> Signed-off-by: Kieran Bingham \n> \n> ---\n> Note:\n> \n> I wanted to make PipelineHandler::active() a const function, but then\n> I'm unable to call it through invokeMethod(). Does invokeMethod support\n> calling const functions? Or did I do something obviously wrong?\n\nWhat's the compilation error ?\n\n> ---\n> include/libcamera/internal/pipeline_handler.h | 1 +\n> src/libcamera/camera.cpp | 3 +++\n> src/libcamera/pipeline_handler.cpp | 17 +++++++++++++++++\n> 3 files changed, 21 insertions(+)\n> \n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index 9bdda8f3b799..1410a06ebabe 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -80,6 +80,7 @@ public:\n> \n> \tvirtual int start(Camera *camera, const ControlList *controls) = 0;\n> \tvirtual void stop(Camera *camera) = 0;\n> +\tbool active(const Camera *camera);\n> \n> \tint queueRequest(Request *request);\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 7f7956ba732f..99b01633ff5f 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -1086,6 +1086,9 @@ int Camera::stop()\n> \td->pipe_->invokeMethod(&PipelineHandler::stop, ConnectionTypeBlocking,\n> \t\t\t this);\n> \n> +\tASSERT(!d->pipe_->invokeMethod(&PipelineHandler::active,\n> +\t\t\t\t ConnectionTypeBlocking, this));\n> +\n\nAs the pipeline handler has stopped, there should be no race, can we\ncall\n\n\tASSERT(!d->pipe_->active());\n\ndirectly ? That would also solve your const problem :-)\n\n> \td->setState(Private::CameraConfigured);\n> \n> \treturn 0;\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index e3d4975d9ffd..c1ea4374b445 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -357,6 +357,23 @@ const ControlList &PipelineHandler::properties(const Camera *camera) const\n> * \\context This function is called from the CameraManager thread.\n> */\n> \n> +/**\n> + * \\brief Determine if the camera has any requests pending\n> + * \\param[in] camera The camera to check\n> + *\n> + * This method determines if there are any requests queued to the pipeline\n> + * awaiting processing.\n> + *\n> + * \\context This function is called from the CameraManager thread.\n> + *\n\nThis would need to be updated.\n\n> + * \\return True if there are pending requests, or false otherwise\n> + */\n> +bool PipelineHandler::active(const Camera *camera)\n> +{\n> +\tconst CameraData *data = cameraData(camera);\n> +\treturn !data->queuedRequests_.empty();\n> +}\n> +\n> /**\n> * \\fn PipelineHandler::queueRequest()\n> * \\brief Queue a request","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E889DBDC66\n\tfor ;\n\tFri, 26 Mar 2021 02:43:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D93E6084F;\n\tFri, 26 Mar 2021 03:43:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E172602E3\n\tfor ;\n\tFri, 26 Mar 2021 03:43:03 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 10C87443;\n\tFri, 26 Mar 2021 03:43:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tHSIw0Ls\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616726583;\n\tbh=/w4YgQ0a9M36HslwUteHc2pgfp4NoPCsgeOaW6B/deE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tHSIw0LsxpSAoV2z+9RV1vGiH1zM4aNRPHly00HX/nDbmGpkJ11fm+55vF0yiMkJm\n\toYt5VvV6Ngxuuoilgwe8vxbWKntbFWg5zTLIwKpo+AETfJ0lqFifYAX7WJiPfJXzFY\n\twC0QZfEtWMDhOWPWwoyhZUWCfX+K0v1Jbt2p+9Uk=","Date":"Fri, 26 Mar 2021 04:42:20 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210325134231.1400051-1-kieran.bingham@ideasonboard.com>\n\t<20210325134231.1400051-12-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210325134231.1400051-12-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 09/11] libcamera: camera: Assert\n\tpipelines complete all requests","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15956,"web_url":"https://patchwork.libcamera.org/comment/15956/","msgid":"<4ef8d292-318c-98a5-2593-188ba24a9d22@ideasonboard.com>","date":"2021-03-26T16:02:38","subject":"Re: [libcamera-devel] [PATCH v3 09/11] libcamera: camera: Assert\n\tpipelines complete all requests","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 26/03/2021 02:42, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Thu, Mar 25, 2021 at 01:42:29PM +0000, Kieran Bingham wrote:\n>> When the camera manager calls stop on a pipeline, it is expected that\n>> the pipeline handler guarantees all requests are returned back to the\n>> application before the camera has stopped.\n>>\n>> Ensure that this guarantee is met by providing an accessor on the\n>> pipeline handler to validate that all pending requests are removed.\n>>\n>> Signed-off-by: Kieran Bingham \n>>\n>> ---\n>> Note:\n>>\n>> I wanted to make PipelineHandler::active() a const function, but then\n>> I'm unable to call it through invokeMethod(). Does invokeMethod support\n>> calling const functions? Or did I do something obviously wrong?\n> \n> What's the compilation error ?\n\nWith the following diff:\n\n+++ b/include/libcamera/internal/pipeline_handler.h\n- bool active(const Camera *camera);\n+ bool active(const Camera *camera) const;\n\n+++ b/src/libcamera/pipeline_handler.cpp\n-bool PipelineHandler::active(const Camera *camera)\n+bool PipelineHandler::active(const Camera *camera) const\n\n\nI get:\n\n> In file included from ../src/libcamera/camera.cpp:18:\n> ../src/libcamera/camera.cpp: In member function ‘int libcamera::Camera::stop()’:\n> ../src/libcamera/camera.cpp:1087:40: error: no matching function for call to ‘libcamera::PipelineHandler::invokeMethod(bool (libcamera::PipelineHandler::*)(const libcamera::Camera*) const, libcamera::ConnectionType, libcamera::Camera*)’\n> 1087 | ConnectionTypeBlocking, this));\n> | ^\n> ../include/libcamera/internal/log.h:125:8: note: in definition of macro ‘ASSERT’\n> 125 | if (!(condition)) \\\n> | ^~~~~~~~~\n> In file included from ../include/libcamera/camera.h:17,\n> from ../src/libcamera/camera.cpp:8:\n> ../include/libcamera/object.h:36:4: note: candidate: ‘template::value>* > R libcamera::Object::invokeMethod(R (T::*)(FuncArgs ...), libcamera::ConnectionType, Args ...)’\n> 36 | R invokeMethod(R (T::*func)(FuncArgs...), ConnectionType type,\n> | ^~~~~~~~~~~~\n> ../include/libcamera/object.h:36:4: note: template argument deduction/substitution failed:\n> In file included from ../src/libcamera/camera.cpp:18:\n> ../src/libcamera/camera.cpp:1087:40: note: types ‘R (T::)(FuncArgs ...)’ and ‘bool (libcamera::PipelineHandler::)(const libcamera::Camera*) const’ have incompatible cv-qualifiers\n> 1087 | ConnectionTypeBlocking, this));\n> | ^\n> ../include/libcamera/internal/log.h:125:8: note: in definition of macro ‘ASSERT’\n> 125 | if (!(condition)) \\\n> | ^~~~~~~~~\n> [11/107] Compiling C++ object src/libcamera/libcamera.so.p/meson-generated_.._proxy_raspberrypi_ipa_proxy.cpp.o\n> ninja: build stopped: subcommand failed.\n> make: *** [Makefile:51: libcamera] Error 1\n\n\n\nBut I don't really care, as I like your suggestion below:\n\n\n\n> \n>> ---\n>> include/libcamera/internal/pipeline_handler.h | 1 +\n>> src/libcamera/camera.cpp | 3 +++\n>> src/libcamera/pipeline_handler.cpp | 17 +++++++++++++++++\n>> 3 files changed, 21 insertions(+)\n>>\n>> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n>> index 9bdda8f3b799..1410a06ebabe 100644\n>> --- a/include/libcamera/internal/pipeline_handler.h\n>> +++ b/include/libcamera/internal/pipeline_handler.h\n>> @@ -80,6 +80,7 @@ public:\n>> \n>> \tvirtual int start(Camera *camera, const ControlList *controls) = 0;\n>> \tvirtual void stop(Camera *camera) = 0;\n>> +\tbool active(const Camera *camera);\n>> \n>> \tint queueRequest(Request *request);\n>> \n>> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n>> index 7f7956ba732f..99b01633ff5f 100644\n>> --- a/src/libcamera/camera.cpp\n>> +++ b/src/libcamera/camera.cpp\n>> @@ -1086,6 +1086,9 @@ int Camera::stop()\n>> \td->pipe_->invokeMethod(&PipelineHandler::stop, ConnectionTypeBlocking,\n>> \t\t\t this);\n>> \n>> +\tASSERT(!d->pipe_->invokeMethod(&PipelineHandler::active,\n>> +\t\t\t\t ConnectionTypeBlocking, this));\n>> +\n> \n> As the pipeline handler has stopped, there should be no race, can we\n> call\n> \n> \tASSERT(!d->pipe_->active());\n> \n> directly ? That would also solve your const problem :-)\n\nWell, then that's even better!\n\n\n> \n>> \td->setState(Private::CameraConfigured);\n>> \n>> \treturn 0;\n>> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n>> index e3d4975d9ffd..c1ea4374b445 100644\n>> --- a/src/libcamera/pipeline_handler.cpp\n>> +++ b/src/libcamera/pipeline_handler.cpp\n>> @@ -357,6 +357,23 @@ const ControlList &PipelineHandler::properties(const Camera *camera) const\n>> * \\context This function is called from the CameraManager thread.\n>> */\n>> \n>> +/**\n>> + * \\brief Determine if the camera has any requests pending\n>> + * \\param[in] camera The camera to check\n>> + *\n>> + * This method determines if there are any requests queued to the pipeline\n>> + * awaiting processing.\n>> + *\n>> + * \\context This function is called from the CameraManager thread.\n>> + *\n> \n> This would need to be updated.\n\nCertainly.\n\n\n> \n>> + * \\return True if there are pending requests, or false otherwise\n>> + */\n>> +bool PipelineHandler::active(const Camera *camera)\n>> +{\n>> +\tconst CameraData *data = cameraData(camera);\n>> +\treturn !data->queuedRequests_.empty();\n>> +}\n>> +\n>> /**\n>> * \\fn PipelineHandler::queueRequest()\n>> * \\brief Queue a request\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93C64C32EB\n\tfor ;\n\tFri, 26 Mar 2021 16:02:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E365D68D73;\n\tFri, 26 Mar 2021 17:02:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 70C2D68D58\n\tfor ;\n\tFri, 26 Mar 2021 17:02:41 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DF57D443;\n\tFri, 26 Mar 2021 17:02:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lX+UsFDE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616774561;\n\tbh=CnJ+sR3QY2BeO5GvGEACaXe/a9D5JoBy5PhQCcMzrOc=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=lX+UsFDExr/h4jthisT3VV43sDnK15ZWZsVhr/fIUrUqlW1MnXDLQ2H0SNlmUWVBw\n\tdEtKKonXwrOwjEJlQj2pryDHy6SgoMRo4ryHcNv9M9ZhlrrqUwB1lhQ7BzHMOrkQxL\n\t9fVBiVWlXCEsQ0CcskJaRYxcISQqJPew7x3XVTP8=","To":"Laurent Pinchart ","References":"<20210325134231.1400051-1-kieran.bingham@ideasonboard.com>\n\t<20210325134231.1400051-12-kieran.bingham@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<4ef8d292-318c-98a5-2593-188ba24a9d22@ideasonboard.com>","Date":"Fri, 26 Mar 2021 16:02:38 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v3 09/11] libcamera: camera: Assert\n\tpipelines complete all requests","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]