[{"id":15917,"web_url":"https://patchwork.libcamera.org/comment/15917/","msgid":"","date":"2021-03-26T02:10:42","subject":"Re: [libcamera-devel] [PATCH v3 06/11] libcamera: camera: Validate\n\trequests are completed in Running state","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Mar 25, 2021 at 01:42:26PM +0000, Kieran Bingham wrote:\n> All requests must have completed before the Camera has fully stopped.\n> \n> Requests completing when the camera is not running represent an internal\n> pipeline handler bug.\n> \n> Trap this event with a fatal error.\n> \n> Reviewed-by: Niklas Söderlund \n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/camera.cpp | 11 +++++++++--\n> 1 file changed, 9 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 84edbb8f494d..b86bff4745b2 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -1062,11 +1062,11 @@ int Camera::stop()\n> \n> \tLOG(Camera, Debug) << \"Stopping capture\";\n> \n> -\td->setState(Private::CameraConfigured);\n> -\n> \td->pipe_->invokeMethod(&PipelineHandler::stop, ConnectionTypeBlocking,\n> \t\t\t this);\n> \n> +\td->setState(Private::CameraConfigured);\n> +\n> \treturn 0;\n> }\n> \n> @@ -1079,6 +1079,13 @@ int Camera::stop()\n> */\n> void Camera::requestComplete(Request *request)\n> {\n> +\tPrivate *const d = LIBCAMERA_D_PTR();\n> +\n> +\t/* Disconnected cameras are still able to complete requests. */\n> +\tint ret = d->isAccessAllowed(Private::CameraRunning);\n> +\tif (ret < 0 && ret != -ENODEV)\n\nWould this work too ?\n\n\tif (d->isAccessAllowed(Private::CameraRunning, true) < 0)\n\nReviewed-by: Laurent Pinchart \n\n> +\t\tLOG(Camera, Fatal) << \"Trying to complete a request when stopped\";\n> +\n> \trequestCompleted.emit(request);\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 91505BDC66\n\tfor ;\n\tFri, 26 Mar 2021 02:11:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D7A106084F;\n\tFri, 26 Mar 2021 03:11:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BB3A602E3\n\tfor ;\n\tFri, 26 Mar 2021 03:11:26 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A518FB6F;\n\tFri, 26 Mar 2021 03:11:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"F7mR+Z6z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616724685;\n\tbh=oVKpMXhrc3x4NXLSfGB3ybSXRgka7jzD41NPHuXAGRA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=F7mR+Z6zxSqr26u4e2i+ONiT7/DBOL1oqthBMssYecvwErsQvlgpdTaVMM1TnfvNl\n\tkmTelkh5bVMnsU9LdeRDZ6saqfGLHh9GZPp+7I4GVCw3E8AFliyxnl3xIma+qmrCjd\n\taBo+szpT70SqwARwNRG48LWV8GG6TDBTXhuS4SSk=","Date":"Fri, 26 Mar 2021 04:10:42 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210325134231.1400051-1-kieran.bingham@ideasonboard.com>\n\t<20210325134231.1400051-9-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210325134231.1400051-9-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 06/11] libcamera: camera: Validate\n\trequests are completed in Running state","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15950,"web_url":"https://patchwork.libcamera.org/comment/15950/","msgid":"<6e810bdb-d402-843b-844c-bee073a9696d@ideasonboard.com>","date":"2021-03-26T15:18:00","subject":"Re: [libcamera-devel] [PATCH v3 06/11] libcamera: camera: Validate\n\trequests are completed in Running state","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 26/03/2021 02:10, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Thu, Mar 25, 2021 at 01:42:26PM +0000, Kieran Bingham wrote:\n>> All requests must have completed before the Camera has fully stopped.\n>>\n>> Requests completing when the camera is not running represent an internal\n>> pipeline handler bug.\n>>\n>> Trap this event with a fatal error.\n>>\n>> Reviewed-by: Niklas Söderlund \n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/libcamera/camera.cpp | 11 +++++++++--\n>> 1 file changed, 9 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n>> index 84edbb8f494d..b86bff4745b2 100644\n>> --- a/src/libcamera/camera.cpp\n>> +++ b/src/libcamera/camera.cpp\n>> @@ -1062,11 +1062,11 @@ int Camera::stop()\n>> \n>> \tLOG(Camera, Debug) << \"Stopping capture\";\n>> \n>> -\td->setState(Private::CameraConfigured);\n>> -\n>> \td->pipe_->invokeMethod(&PipelineHandler::stop, ConnectionTypeBlocking,\n>> \t\t\t this);\n>> \n>> +\td->setState(Private::CameraConfigured);\n>> +\n>> \treturn 0;\n>> }\n>> \n>> @@ -1079,6 +1079,13 @@ int Camera::stop()\n>> */\n>> void Camera::requestComplete(Request *request)\n>> {\n>> +\tPrivate *const d = LIBCAMERA_D_PTR();\n>> +\n>> +\t/* Disconnected cameras are still able to complete requests. */\n>> +\tint ret = d->isAccessAllowed(Private::CameraRunning);\n>> +\tif (ret < 0 && ret != -ENODEV)\n> \n> Would this work too ?\n> \n> \tif (d->isAccessAllowed(Private::CameraRunning, true) < 0)\n> \n\nOh, I'd missed that there was an allowDisconnected parameter to\nisAccessAllowed.\n\nYes, that's better.\n\n\n> Reviewed-by: Laurent Pinchart \n> \n>> +\t\tLOG(Camera, Fatal) << \"Trying to complete a request when stopped\";\n>> +\n>> \trequestCompleted.emit(request);\n>> }\n>> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A396C32EA\n\tfor ;\n\tFri, 26 Mar 2021 15:18:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1511D68D6A;\n\tFri, 26 Mar 2021 16:18:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7440F602D7\n\tfor ;\n\tFri, 26 Mar 2021 16:18:04 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D7AD443;\n\tFri, 26 Mar 2021 16:18:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"b2PC6dm2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616771883;\n\tbh=ogtOq4Da4QKjX9Q5af+HfdU8r7kqKzI6HcvO5oCl0PQ=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=b2PC6dm2gDLw0WXbM1eqXes9Tsoo8zit3EEi/4IHvgPrU2BiGpnD9rSZEE5oQa94j\n\tOMynnw1zhrs9kTbpWfImBDmEPac4cQGk5sVqSQ8DJXWZRwO2g0yPXmtuaeH5urgoft\n\t6AP1ecPERmcVK8W6LWOea7vYG0gaBorvYvquTHVA=","To":"Laurent Pinchart ","References":"<20210325134231.1400051-1-kieran.bingham@ideasonboard.com>\n\t<20210325134231.1400051-9-kieran.bingham@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<6e810bdb-d402-843b-844c-bee073a9696d@ideasonboard.com>","Date":"Fri, 26 Mar 2021 15:18:00 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v3 06/11] libcamera: camera: Validate\n\trequests are completed in Running state","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]