[{"id":15899,"web_url":"https://patchwork.libcamera.org/comment/15899/","msgid":"<20210325105234.g623yapntuypqipl@uno.localdomain>","date":"2021-03-25T10:52:34","subject":"Re: [libcamera-devel] [PATCH 3/3] android: CameraDevice: Deny non\n\tROTATION_0 stream configuration","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Hiro\n\nOn Thu, Mar 25, 2021 at 02:19:31PM +0900, Hirokazu Honda wrote:\n> Libcamera doesn't handle crop_rotate_scale_degrees. Therefore,\n> if it is requested, that is, crop_rotate_scale_degrees is not\n> CAMERA3_STREAM_ROTATION_0, the configuration should fail.\n\nWe also do not handle rotation != 0\nShould you rule that out as well ?\n>\n> Signed-off-by: Hirokazu Honda \n> ---\n> src/android/camera_device.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index d24b0b23..3aab643d 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1657,6 +1657,13 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t\tif (!format.isValid())\n> \t\t\treturn -EINVAL;\n>\n> +\t\t/* \\todo Support crop_rotate_scale_degrees. */\n> +\t\tif (stream->crop_rotate_scale_degrees != CAMERA3_STREAM_ROTATION_0) {\n> +\t\t\tLOG(HAL, Error)\n> +\t\t\t\t<< \"crop_rotate_scale_degrees is not supported\";\n> +\t\t\treturn -EINVAL;\n> +\t\t}\n> +\n> \t\t/* Defer handling of MJPEG streams until all others are known. */\n> \t\tif (stream->format == HAL_PIXEL_FORMAT_BLOB) {\n> \t\t\tif (jpegStream) {\n> --\n> 2.31.0.291.g576ba9dcdaf-goog\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D73FFC32E9\n\tfor ;\n\tThu, 25 Mar 2021 10:52:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F1AB68D6E;\n\tThu, 25 Mar 2021 11:52:02 +0100 (CET)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACD5268D58\n\tfor ;\n\tThu, 25 Mar 2021 11:52:01 +0100 (CET)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 30A911C0013;\n\tThu, 25 Mar 2021 10:52:00 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","Date":"Thu, 25 Mar 2021 11:52:34 +0100","From":"Jacopo Mondi ","To":"Hirokazu Honda ","Message-ID":"<20210325105234.g623yapntuypqipl@uno.localdomain>","References":"<20210325051931.3748204-1-hiroh@chromium.org>\n\t<20210325051931.3748204-4-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210325051931.3748204-4-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH 3/3] android: CameraDevice: Deny non\n\tROTATION_0 stream configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15978,"web_url":"https://patchwork.libcamera.org/comment/15978/","msgid":"","date":"2021-03-28T22:43:36","subject":"Re: [libcamera-devel] [PATCH 3/3] android: CameraDevice: Deny non\n\tROTATION_0 stream configuration","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Jacopo, thanks for reviewing.\n\nOn Thu, Mar 25, 2021 at 7:52 PM Jacopo Mondi wrote:\n>\n> Hi Hiro\n>\n> On Thu, Mar 25, 2021 at 02:19:31PM +0900, Hirokazu Honda wrote:\n> > Libcamera doesn't handle crop_rotate_scale_degrees. Therefore,\n> > if it is requested, that is, crop_rotate_scale_degrees is not\n> > CAMERA3_STREAM_ROTATION_0, the configuration should fail.\n>\n> We also do not handle rotation != 0\n> Should you rule that out as well ?\n\nWell, as this is undocumented, rotation should not be filled as we\nhave crop_rotate_scale_degrees.\nBut checking it should be harmless. Added.\n\nBest Regards,\n-Hiro\n\n> >\n> > Signed-off-by: Hirokazu Honda \n> > ---\n> > src/android/camera_device.cpp | 7 +++++++\n> > 1 file changed, 7 insertions(+)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index d24b0b23..3aab643d 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -1657,6 +1657,13 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> > if (!format.isValid())\n> > return -EINVAL;\n> >\n> > + /* \\todo Support crop_rotate_scale_degrees. */\n> > + if (stream->crop_rotate_scale_degrees != CAMERA3_STREAM_ROTATION_0) {\n> > + LOG(HAL, Error)\n> > + << \"crop_rotate_scale_degrees is not supported\";\n> > + return -EINVAL;\n> > + }\n> > +\n> > /* Defer handling of MJPEG streams until all others are known. */\n> > if (stream->format == HAL_PIXEL_FORMAT_BLOB) {\n> > if (jpegStream) {\n> > --\n> > 2.31.0.291.g576ba9dcdaf-goog\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97C21C32ED\n\tfor ;\n\tSun, 28 Mar 2021 22:43:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C2C2D6877F;\n\tMon, 29 Mar 2021 00:43:48 +0200 (CEST)","from mail-ej1-x634.google.com (mail-ej1-x634.google.com\n\t[IPv6:2a00:1450:4864:20::634])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 21A98602D7\n\tfor ;\n\tMon, 29 Mar 2021 00:43:47 +0200 (CEST)","by mail-ej1-x634.google.com with SMTP id ap14so3435852ejc.0\n\tfor ;\n\tSun, 28 Mar 2021 15:43:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"iMHbReNi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=nZevU5gnW/UaSTZV70qTYCss8K/NIOxwE83ojQxLjDA=;\n\tb=iMHbReNiIjLtLjW96nBXFNKYpp7nBnNmY4rpxFxS/tA576fMl7xonSRkWGzkNoBp18\n\tzRaOY1Ot88nOMPw2cnxXJy3UHc4awuHqPp+1YMVgrowVqvOxKstbEIVW8N0dXKsozve8\n\tCkG9pQX7MSqcQpgWMevvkA2RPJ7SiVBqPpTss=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=nZevU5gnW/UaSTZV70qTYCss8K/NIOxwE83ojQxLjDA=;\n\tb=laUBOgtdbul5G8LCiwbfOZJ9owT/gJ4W9l4doM93mWC8j+KAn3r/aV/CX64gXGQyCL\n\t8aUlo4530LGLAxOVTIqaOqdcEp2NX5GJqU2vi8u+bS8VFZzK4i6y5HJPDKBugqyq9Qjk\n\tpi627Dl7rPZS8vsVWDuOFBzlIbBa7mETG8ry36358tzR142AToxwg7BRdbgWUrr3siWW\n\tnWARoJNnqKnON9lvvaWeYcPUtO51c5xPAqgAfqI9Xi5nQT/uXYT2jBzKhFkBj1IF0HjW\n\tV3Lsk4ZukCWrMB/DYTg0D3TQ6OT1Bt2QDI07uHfK8YWcRn87Hik87NBLmt7yTe7UYDka\n\t9LTA==","X-Gm-Message-State":"AOAM533woHfPBS6NGa1cwHXzeW9RwFukjuIu6QKw9/K1KFQ1a63hSBVq\n\t8mEQF0gd1MUrbUt03qNrBfPK9j3HAI/XqS3iXE1IzQ==","X-Google-Smtp-Source":"ABdhPJyLaC992mD72njBBYJdyMWD5GPlQx57u/tkWRKfzODsp7zlveLudol42LUwXbFdNM95VhyHF0gyR0LALZ3SO/s=","X-Received":"by 2002:a17:906:701:: with SMTP id\n\ty1mr692686ejb.243.1616971426709; \n\tSun, 28 Mar 2021 15:43:46 -0700 (PDT)","MIME-Version":"1.0","References":"<20210325051931.3748204-1-hiroh@chromium.org>\n\t<20210325051931.3748204-4-hiroh@chromium.org>\n\t<20210325105234.g623yapntuypqipl@uno.localdomain>","In-Reply-To":"<20210325105234.g623yapntuypqipl@uno.localdomain>","From":"Hirokazu Honda ","Date":"Mon, 29 Mar 2021 07:43:36 +0900","Message-ID":"","To":"Jacopo Mondi ","Subject":"Re: [libcamera-devel] [PATCH 3/3] android: CameraDevice: Deny non\n\tROTATION_0 stream configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]