{"id":11704,"url":"https://patchwork.libcamera.org/api/patches/11704/?format=json","web_url":"https://patchwork.libcamera.org/patch/11704/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210325051931.3748204-3-hiroh@chromium.org>","date":"2021-03-25T05:19:30","name":"[libcamera-devel,2/3] android: CameraDevice: Log rotation variables in camera3_stream","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"86affd874ab6eeae7f6a669e9b3194746b3557ba","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11704/mbox/","series":[{"id":1830,"url":"https://patchwork.libcamera.org/api/series/1830/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1830","date":"2021-03-25T05:19:28","name":"Regard crop_rotate_scale_degrees in configuration","version":1,"mbox":"https://patchwork.libcamera.org/series/1830/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11704/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11704/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2EBEDC32E9\n\tfor ;\n\tThu, 25 Mar 2021 05:19:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E1ABA68D6C;\n\tThu, 25 Mar 2021 06:19:46 +0100 (CET)","from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com\n\t[IPv6:2607:f8b0:4864:20::1034])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DCF1602D7\n\tfor ;\n\tThu, 25 Mar 2021 06:19:44 +0100 (CET)","by mail-pj1-x1034.google.com with SMTP id\n\til9-20020a17090b1649b0290114bcb0d6c2so2247319pjb.0\n\tfor ;\n\tWed, 24 Mar 2021 22:19:44 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:7c07:24cd:c637:7fab])\n\tby smtp.gmail.com with ESMTPSA id\n\tfs9sm3999250pjb.40.2021.03.24.22.19.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 24 Mar 2021 22:19:42 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"R//9ZwEF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=PZPYhm58v8yg1n+/LPY7yqvGtfUspXKfM7MF2dvZ+yk=;\n\tb=R//9ZwEFacpRU+rzkMKmGzfu3nLag7hsqnA60s651fI7jZ2RdmWDQrSirg3jSp1oIv\n\tmSiP9pqDqrl1HdcLLcBhBOwzAPeSVHcqW/UlTxnv6ub5JTkAkGewOZXzokjqxUB6mQeY\n\t4qSI2NVaCfQ+nd9EVtoZ7nbq4jacNFArC5+T8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=PZPYhm58v8yg1n+/LPY7yqvGtfUspXKfM7MF2dvZ+yk=;\n\tb=QwQ4rpia80g5dgyJ+Shf/P3uSYcvmey+FjXYe4lyZuuY2ENJsfgTRt39UyP6Tlm2XX\n\tNQrtPzGHxIXqRqA0gbsnBnJufD0zQsDfNsQuHhop9MGa2K+7E/+6A/RaIxM1rdF6jypd\n\tZJqpAtAgnVzDL8sz9IeTEDV19rdqstvb8TRVgr+zXZGznDeeYkpwriRYBZ7ejSx+Fvnr\n\trRB2mB0CW+L36iWRBXTlt2qhGHd4VCMHekGWVpdsvasDZZl8IiNj0WBhvyIQL15D0x8V\n\t8wgcLk9fVSp/1VzwYIl/EGqbfmJSgHBEQR60tayEdOCT+0UIpQhDcBoLQrsmCG89kxWJ\n\tsaqA==","X-Gm-Message-State":"AOAM532LZZWFH6P8J0Z4dj+FgG8pmtLGfr1JsJND8MWx1Q59KejxI2vD\n\tZ9IodNIw+uH4cuzqPaHjym0pKQF+dNOuow==","X-Google-Smtp-Source":"ABdhPJxhlLUn+Lhn8U1zCPA/tvd9E5ghVDK8MOSIKtDQjJVYocLCSLGpVzu+WDEZeA83dVZS1FxwZA==","X-Received":"by 2002:a17:90b:38f:: with SMTP id\n\tga15mr6993422pjb.149.1616649583035; \n\tWed, 24 Mar 2021 22:19:43 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 25 Mar 2021 14:19:30 +0900","Message-Id":"<20210325051931.3748204-3-hiroh@chromium.org>","X-Mailer":"git-send-email 2.31.0.291.g576ba9dcdaf-goog","In-Reply-To":"<20210325051931.3748204-1-hiroh@chromium.org>","References":"<20210325051931.3748204-1-hiroh@chromium.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 2/3] android: CameraDevice: Log rotation\n\tvariables in camera3_stream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"|rotation| and |crop_rotate_scale_degrees| are important info of\na configuration. They should be logged.\n\nSigned-off-by: Hirokazu Honda \n---\n src/android/camera_device.cpp | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)\n\n--\n2.31.0.291.g576ba9dcdaf-goog","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 1414bfef..d24b0b23 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -256,6 +256,20 @@ void sortCamera3StreamConfigs(std::vector &unsortedConfigs,\n \tunsortedConfigs = sortedConfigs;\n }\n\n+const char *rotationToString(int rotation)\n+{\n+\tswitch (rotation) {\n+\tcase CAMERA3_STREAM_ROTATION_0:\n+\t\treturn \"ROTATION_0\";\n+\tcase CAMERA3_STREAM_ROTATION_90:\n+\t\treturn \"ROTATION_90\";\n+\tcase CAMERA3_STREAM_ROTATION_180:\n+\t\treturn \"ROTATION_180\";\n+\tcase CAMERA3_STREAM_ROTATION_270:\n+\t\treturn \"ROTATION_270\";\n+\t}\n+\treturn \"ROTATION_INVALID\";\n+}\n /*\n * verifyCropRotateScaleDegrees returns where |crop_rotate_scale_degrees| in\n * all camera3_stream in stream_list are valid.\n@@ -1635,6 +1649,9 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \t\t\t << \", width: \" << stream->width\n \t\t\t << \", height: \" << stream->height\n \t\t\t << \", format: \" << utils::hex(stream->format)\n+\t\t\t << \", rotation: \" << rotationToString(stream->rotation)\n+\t\t\t << \", crop_rotate_scale_degrees: \"\n+\t\t\t << rotationToString(stream->crop_rotate_scale_degrees)\n \t\t\t << \" (\" << format.toString() << \")\";\n\n \t\tif (!format.isValid())\n","prefixes":["libcamera-devel","2/3"]}